reactos/dll/shellext/netshell
Whindmar Saksit ea60890961
[NETSHELL][SHELL32] Make NetShell PIDL format more Windows compatible (#7183)
- The PIDL format needs to be Windows compatible so that wlanwiz can get the connection GUID.
- SHELL32::ILIsEqual cannot deem PIDL formats it does not understand as invalid.
- DefView must ask the folder when comparing PIDLs.
2024-08-08 22:00:03 +02:00
..
lang [NETSHELL] Improve portuguese (pt-PT) translation (#7120) 2024-07-18 18:13:27 +02:00
res [NETSHELL] Register folder attributes as SFGAO_FOLDER, not SFGAO_CANDELETE (#5880) 2023-11-04 17:40:22 +03:00
CMakeLists.txt [CMAKE] Get rid of add_compile_flags_language macro 2020-10-20 21:44:54 +02:00
connectmanager.cpp [NETSHELL] Return error if disconnection failed 2022-09-26 23:33:57 +02:00
connectmanager.h [NETSHELL] Use STDMETHOD macro and keyword override (#6568) 2024-03-02 21:38:52 +09:00
enumlist.cpp [NETSHELL][SHELL32] Make NetShell PIDL format more Windows compatible (#7183) 2024-08-08 22:00:03 +02:00
lanconnectui.cpp [NETSHELL] Double click on component should open properties (#6008) 2023-11-20 21:48:18 +09:00
lanconnectui.h [NETSHELL] Use STDMETHOD macro and keyword override (#6568) 2024-03-02 21:38:52 +09:00
lanstatusui.cpp [NETSHELL] Repair "Network Connection 'State' does nothing" CORE-18844 2023-02-19 18:44:51 +01:00
lanstatusui.h [NETSHELL] Use STDMETHOD macro and keyword override (#6568) 2024-03-02 21:38:52 +09:00
netshell.cpp [NETSHELL] Use ATL 2018-11-18 14:01:54 +02:00
netshell.rc [TRANSLATION] Add Hong Kong Chinese (zh-HK) translation - Part 1 (#3941) 2021-12-30 00:40:57 +03:00
netshell.spec
precomp.h [NETSHELL][SHELL32] Make NetShell PIDL format more Windows compatible (#7183) 2024-08-08 22:00:03 +02:00
README [FORMATTING] Remove trailing whitespace. Addendum to 34593d93. 2021-09-13 03:52:22 +02:00
resource.h [NETSHELL] Fix Network Tray icon activity indication (#4669) 2022-09-09 23:51:51 +02:00
setup.cpp [NETSHELL] Improvements to the network setup (1/x) 2019-06-17 01:18:05 +02:00
shfldr_netconnect.cpp [NETSHELL][SHELL32] Make NetShell PIDL format more Windows compatible (#7183) 2024-08-08 22:00:03 +02:00
shfldr_netconnect.h [NETSHELL] Use STDMETHOD macro and keyword override (#6568) 2024-03-02 21:38:52 +09:00

=== Introduction ===

The netshell library is responsible for managing network connections. The user interface is accessed
by opening the control panel and selecting the "Network Connections" folder.
The netshell library provides COM interfaces to enumerate available network adapters, network protocols, network clients and network transports
and receive detailed information about them. However, it cannot configure these components. For configuration, look in the netcfgx documentation
(Hint: INetCfg)

=== Interface ===

The user interface is exposed by implementing the IShellFolder interface as required by explorer
namespace extension. The code is currently placed in shfldr_netconnect.c

The enumeration of the available network connections is performed by the IShellFolder::EnumObjects
(ISF_NetConnect_fnEnumObjects). It uses the INetConnectionManager interface implemented by netshell
in connectmanager.c to enumerate all available network connections.

The context menu of network connection items is populated by the IContextMenu::QueryContextMenu
(ISF_NetConnect_IContextMenu3_QueryContextMenu) which is obtained by IShellFolder::GetUIObjectOf. The actions are performed by the
IContextMenu::InvokeCommand function (ISF_NetConnect_IContextMenu3_InvokeCommand). At the moment
the actions "Status" / "Properties" are implemented.

=== Status Dialog & Notification Area ===

The status dialog is implemented by IOleCommandTarget interface(CLSID_ConnectionTray). This interface manages all status dialogs
for all available dialogs. The interface is implemented as a singleton to avoid multiple notification icons
appearing in the Notification area of the explorer. Every time the IShellFolder object is created (ISF_NetConnect_Constructor),
it creates a reference to IOleCommandTarget interface and calls its IOleCommandTarget::Exec function with CGID_ShellServiceObject.
This causes IOleCommandTarget interface to enumerate all available network connections, check if they should be shown (NCCF_SHOW_ICON flag set
in the NETCON_PROPERTIES dwCharacter), and add them to notification area with Shell_NotifyIcon. For that purpose a hidden window is created (dialog
procedure is LANStatusDlg) which receives WM_SHOWSTATUSDLG msg when it shall show display the status dialog.

When a user wants to display the status dialog by clicking on the context menu of network connection item, the IShellFolder sends the NetCfgInstanceId of
the selected network connection to IOleCommandTarget::Exec function. The function then looks up the specified notification item and then sends
the WM_SHOWSTATUSDLG msg to specific window.

=== Network Connections Property Dialog ===

The network connections property dialog is implemented by the INetConnectionPropertyUi2 interface. The class id is obtained by calling
INetConnection::GetUiObjectClassId of the current selected network connection. After obtaining the interface by calling CoCreateInstance, the
selected network connection is stored as reference by calling INetConnectionPropertyUi::SetConnection. The next step is to call
INetConnectionPropertyUi::AddPages to add custom property pages to the property sheet set. If the function succeeds, the caller can then invoke
PropertySheetW function to display the properties.
	Note: If the context doesn't match, i.e. the INetConnectionPropertyUi2 cannot work together
		with current INetConnection, then it should fail INetConnectionPropertyUi::AddPages
	Note: The function ShowNetConnectionProperties in shlfdr_netconnect.c shows how to invoke the Network Connections Property Dialog

The enumeration of network components (protocols, client, transport) is done by using the INetCfg api). Initialization is performed in InitializeLANPropertiesUIDlg
function. When a user accepts changes, it calls INetCfg::Apply or when it aborts the changes INetCfg::Cancel.

=== Known Issues ===
* Status changes of an adapter are not automatically updated because the information is cached
* There seems to be an icon problem which makes icon blink in the status dialog

=== Testing in windows ===

Unfortunately in windows the CLSID_ConnectionManager class is implemented in the netman
service and netshell contains the rpc proxy stubs for it. This means that until we are able to
reimplement these stubs alongside all its unimplemented interfaces and objects, we can't replace
the system netshell with ours (INetConnectionManager and IEnumNetConnection are only the tip
of the iceberg).
However it is perfectly fine if one copies our netshell in a different folder and change the
registry settings to make it handle CLSID_ConnectionFolder, CLSID_LanConnectionUi and CLSID_ConnectionTray.
When doing so there are actually two options about how to test. One is leaving #define USE_CUSTOM_CONMGR 1
as is and the other is setting is to 0. What this does is that when 0, the connections will be enumerated
in the shell folder and the tray using the system's INetConnectionManager (which resides in the system's
netman service and is accessible through the system's netshell.dll). This allows us to implement and
test our three components against the correct implementation of INetConnectionManager.
The other option is setting USE_CUSTOM_CONMGR to 1 which will make the shell folder and the tray
enumerate connections with our connection manager effectively testing it in windows as well.