Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-03-01 03:45:16 +00:00
Code Issues Projects Releases Packages Wiki Activity
reactos/modules/rostests
History
Joachim Henze 3780e42ff9 [0.4.15][NTOS:SE][NDK][KMTESTS:SE] Fix 'kmtest_.exe SeQueryInfoToken' (#5308) 
This backport fixes 'kmtest_.exe SeQueryInfoToken'
on all testers: VBox x86, KVM x86, WHS x86, Win2003_x64.
And according to Thomas description may also prevent a buffer overrun when executing that formerly broken test.
Afterwards all 76 tests of this suite do complete on all those builders.
Before the patch only 74 of those tests succeeded, 2 failed.

The fix is a squashed backport of the following 6 commits from Thomas Faber:
0.4.16-dev-11-g 44bdafa17e [KMTESTS:SE] Fix failing tests (#5308)
0.4.16-dev-10-g bf6af0f52e [NTOS:SE] Mark output parameters as such (#5308)
0.4.16-dev-9-g 156053cafd [NDK] Match AUX_ACCESS_DATA definition with publicly available version. - if you allocated only sizeof(AUX_ACCESS_DATA), the test would crash with a 4 byte buffer overflow. (#5308)
0.4.16-dev-8-g ff410211e9 [KMTESTS:SE] Don't modify internal data structure, this might cause buffer overrun (#5308)
0.4.16-dev-7-g 206df96bc4 [KMTESTS:SE] Correctly allocate PrivilegeSet buffers (#5308)
0.4.16-dev-6-g 64a6bd4c3e [KMTESTS:SE] Avoid use of uninitialized pool and hardcoded offsets (#5308)

WHS x86 before-and-after-state, the after-test had a few fixes from Timos unrelated PR7343 inside unfortunately:
https://reactos.org/testman/compare.php?ids=97640,97871
(This is added to prove the test being wrong)

I tested it also successfully on my local 2k3sp2 x86 with the releases/0.4.15 afterstate, built with RosBEWin2.2.2 GCC8.4.0dbg x86.

Win2003_x64 0.4.16-dev-11-g44bdafa at 2024-09-12 15:19 (after-state):
https://reactos.org/testman/compare.php?ids=97791

0.4.16-dev-5-g2913ef5 vs. 0.4.16-dev-11-g44bdafa vs. 0.4.16-dev-23-g53b304e:
VBox x86 https://reactos.org/testman/compare.php?ids=97795,97806,97877

0.4.16-dev-5-g2913ef5 vs. 0.4.16-dev-20-g144a8b5 vs. 0.4.16-dev-21-g2af6fd4:
KVM x86 https://reactos.org/testman/compare.php?ids=97793,97855,97856

Since we do touch the NTOS and NDK here the fix is not guaranteed to be side-effect-free,
but since we are so early in the RC-phase, I dared to pick it, especially since the alternative would have
been to disable the test altogether in the releases/0.4.15 which would have been a pity, if we can also have it all green everywhere.
2024-09-15 14:09:29 +02:00
..
apitests [USER32_APITEST] Improve RedrawWindow API test by testing flags (#7160) 2024-09-01 14:32:43 +03:00
dibtests
drivers
dxtest
kmtests [0.4.15][NTOS:SE][NDK][KMTESTS:SE] Fix 'kmtest_.exe SeQueryInfoToken' (#5308) 2024-09-15 14:09:29 +02:00
regtests
rosautotest [ROSAUTOTEST][MC] Add Romanian (ro-RO) translation to message table (#5429) 2023-07-13 19:48:55 +03:00
testdata
tests [DXHALTEST] Correct some typos (#5737) 2023-12-17 15:56:39 +03:00
unittests [INTEROP_UNITTEST] Add interoperability tests for localized strings (#7129) 2024-09-01 15:22:29 +03:00
win32 [MYEVENTPROVIDER_DLL][MC] Update MyEventProvider.mc (#5929) 2023-11-08 11:18:07 +00:00
winetests [0.4.15][WINETESTS] Exclude 2 tests: mshmtl:htmldoc, urlmon:protocol ROSTESTS-358 2024-09-14 23:34:38 +02:00
CMakeLists.txt [SETUPLIB][ROSTESTS] Move setuplib unittests to rostests directory. 2024-07-31 13:46:00 +02:00
COPYING
readme.txt

readme.txt 

====================
ReactOS Tests
====================

This directory contains various tests for ReactOS.
Make sure you also have a copy of the rest of the ReactOS
source before you attempt to build anything in this module.
It is to be placed under "modules" subdirectory of a trunk checkout.
The module requires to be enabled during the "configure" process.

To include the module in your build folder, run the configure script with the flags -DENABLE_ROSTESTS=1

# For Windows users

    configure.cmd -DENABLE_ROSTESTS=1

# For UNIX users

    ./configure.sh -DENABLE_ROSTESTS=1