Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-28 19:32:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

[0.4.15][WINETESTS] Exclude 2 tests: mshmtl:htmldoc, urlmon:protocol ROSTESTS-358

Browse source 
I am really no fan of disabling tests, even when they are broken,
but in these cases they are really not worth of suffering the pain, and rerunning the bots all the time.

Those tests do have random failures and timeouts, and are accessing external web-resources
of the Wine test-infratructure, which are not always accessible.
I do disable them, because they very often make the testruns run extremely long.
"Inspired by" 0.4.15-dev-367-g d424a0e088 urlmon_winetest:url skipped due to frequent hang on Test KVM

This following links do reflect the BEFORE-STATE:

The "urlmon:protocol" test does even crash on the WHS x86 testbot, see:
https://reactos.org/testman/compare.php?ids=97640

0.4.14-release-123-gcc9c2ba:
VBox https://reactos.org/testman/compare.php?ids=97825  KVM https://reactos.org/testman/compare.php?ids=97826 (both timed out at urlmon:url)

0.4.15-2-g94cae27:
VBox https://reactos.org/testman/compare.php?ids=97837  KVM https://reactos.org/testman/compare.php?ids=97838

Yes, even older branches might also be affected, but I will only exclude them for now on releases/0.4.14 and releases/0.4.15
because only on those I do regularly run the testbots still.
This commit is contained in:
Joachim Henze 2024-09-14 23:34:38 +02:00
parent 94cae279fa
commit 5f1fcb59e5
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/rostests/winetests/mshtml/htmldoc.c
View file

@ -8556,6 +8556,12 @@ static void test_ServiceProvider(void)
START_TEST(htmldoc)
{
if (!winetest_interactive)
{
win_skip("Skipping mshtml:htmldoc due to hang ROSTESTS-358\n");
return;
}
CoInitialize(NULL);
if(!check_ie()) {

6
modules/rostests/winetests/urlmon/protocol.c
View file

@ -4255,6 +4255,12 @@ START_TEST(protocol)
{
HMODULE hurlmon;
if (!winetest_interactive)
{
win_skip("Skipping urlmon:protocol due to hang ROSTESTS-358\n"); // FIXME: It crashes even on WHS testbot https://reactos.org/testman/compare.php?ids=97640
return;
}
hurlmon = GetModuleHandleA("urlmon.dll");
pCoInternetGetSession = (void*) GetProcAddress(hurlmon, "CoInternetGetSession");
pReleaseBindInfo = (void*) GetProcAddress(hurlmon, "ReleaseBindInfo");