Serge Gautherie
ed9f0dca14
[USBPORT] USBPORT_InvalidateEndpointHandler(): Properly enumerate endpoints
2019-09-29 13:39:12 +03:00
Thomas Faber
6ec38aa942
[HDAUDBUS] Build a device instance ID from Codec & node number. CORE-13702
2019-09-27 21:29:41 +02:00
Thomas Faber
4c6cc29bb8
[HDAUDBUS] Fix timeouts for hardware register operations. CORE-15874
...
Most needed to be multiplied by 10 to match Haiku's behavior.
In one case, the broken timeout was offset by a higher number of loop
iterations, which is now restored.
This should fix failures on real hardware that result in the
"unable to exit reset" print, and avoid a possible subsequent Pnp
manager crash.
Compare with the following (both snooze and KeStallExecutionProcessor use microseconds):
ff38df48cf/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp (L466)ff38df48cf/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp (L357)ff38df48cf/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp (L978)
2019-09-26 10:27:31 +02:00
Serge Gautherie
085528c31a
[MOUNTMGR] HasDriveLetter(): Simplify code by using a for() loop
2019-09-22 10:25:09 +02:00
Pierre Schweitzer
20b4f0a231
[FLOPPY] Implement IOCTL_MOUNTDEV_QUERY_DEVICE_NAME
2019-09-14 10:48:19 +02:00
Pierre Schweitzer
bf6215c601
[MOUNTMGR] Properly enumerate pending IRPs on cleanup
...
CORE-16370
2019-09-14 09:41:47 +02:00
Pierre Schweitzer
0a5f86d44a
[MOUNTMGR] Fix MountState usage in MountMgrTargetDeviceNotification
...
CORE-13882
2019-09-13 20:08:39 +02:00
Pierre Schweitzer
5c678a76a6
[MOUNTMGR] Fix broken check
...
Only mark volume mounted if it's not waiting for unloading
CORE-13882
2019-09-13 20:08:39 +02:00
Timo Kreuzer
a71a6531ef
[UNIATA] Fix uniata on x64
2019-09-08 10:39:01 +02:00
Thomas Faber
5d4f13f625
[ACPICA] Update to version 20190816. CORE-16368
2019-09-08 07:46:53 +02:00
Pierre Schweitzer
7ff3658f10
[BTRFS] Reenable the MountMgr thread
...
Now that IOCTL_MOUNTMGR_QUERY_POINTS and IOCTL_MOUNTMGR_CHANGE_NOTIFY have
been fixed, the thread no longer eats 100% CPU nor prevent ReactOS shutdown
2019-09-07 23:28:58 +02:00
Pierre Schweitzer
d904ee19c5
[MOUNTMGR] Properly return EpicNumber in MountMgrChangeNotify
2019-09-07 23:07:54 +02:00
Serge Gautherie
400eb23a64
[BTRFS] Revert "Allow driver to start at first stage when no hive is present."
...
Not needed anymore.
This reverts commit 80e11516b1
2019-09-07 19:58:03 +02:00
Serge Gautherie
e08dc30569
[BTRFS] Revert "Leak the root stream file object on mount."
...
Not needed anymore.
This reverts commit c13ccc92f6
2019-09-07 19:58:03 +02:00
Pierre Schweitzer
6e3c0d360b
[BTRFS] bool must be 1-sized
...
CORE-16366
2019-09-06 08:56:26 +02:00
Serge Gautherie
b45f27cf2e
[MOUNTMGR] Remove a leftover UNREFERENCED_PARAMETER()
...
Addendum to 77657c22c9
2019-09-06 08:34:14 +02:00
Pierre Schweitzer
ff19ce934b
[MOUNTMGR] Don't overrun output buffer in QueryPointsFromMemory
2019-09-06 08:30:18 +02:00
Pierre Schweitzer
26a31b160a
[MOUNTMGR] Fix QueryPointsFromSymbolicLinkName and make it working
...
Select the current stack location for output buffer
And set output size so that buffer gets properly copied to caller
2019-09-06 08:28:36 +02:00
Pierre Schweitzer
d592e00dfa
[MOUNTMGR] Fix QueryPointsFromMemory and make it working
...
Select the current stack location for output buffer
And set output size so that buffer gets properly copied to caller
2019-09-05 08:36:19 +02:00
Pierre Schweitzer
70d29ec423
[MOUNTMGR] Properly validate input buffer size
...
This avoids IOCTL_MOUNTMGR_QUERY_POINTS always failing
2019-09-05 08:36:19 +02:00
Pierre Schweitzer
77657c22c9
[MOUNTMGR] Fix global symbolic link creations
...
They were wrongly pointing to the original target once rewritten
instead of pointing to the proper target: the device.
This notably fixes opening the MountMgr device from user
mode (to perform IOCTL calls, for instance), and might
also fix various bugs dealing with global namespaces.
This might have some various effects in ReactOS~.
2019-09-05 08:36:19 +02:00
Pierre Schweitzer
dcd463ba98
[BTRFS] Fix fileinfo.c build
2019-09-02 22:17:17 +02:00
Pierre Schweitzer
021e25f249
[BTRFS] Fix create.c build
2019-09-02 22:02:45 +02:00
Pierre Schweitzer
fe0a6c9be4
[BTRFS] Fix dirctl.c build
2019-09-02 21:48:54 +02:00
Pierre Schweitzer
318da0c18c
[BTRFS] Upgrade to 1.4
...
CORE-16354
2019-09-02 08:19:48 +02:00
Stanislav Motylkov
053bf17e8b
[BOOTVID] Refactor font data from i386 and arm bootdata.c ( #1891 )
2019-09-01 23:01:40 +02:00
Victor Perevertkin
88cf5b0a3c
[USB] Enable *_new usb stack
2019-08-20 01:34:58 +03:00
Victor Perevertkin
fc14c095f5
[USBPORT] Fix endless loop, occasionally happened on real hardware
2019-08-20 01:30:52 +03:00
Hermès Bélusca-Maïto
4016225269
[FFS] Silence some only-informative KdPrints.
2019-08-18 15:26:23 +02:00
Victor Martinez
d60acd88cb
[UDFS] Avoid freeing Vcb when it couldn't have been allocated in UDFPnpSurpriseRemove()
...
CORE-11203
2019-08-17 16:49:11 +03:00
Victor Martinez
e5e4362b6d
[UDFS] Fix NewCFBName leakage in UDFFirstOpenFile()
...
CORE-11098
2019-08-17 16:49:11 +03:00
Victor Martinez
b64865fbdf
[UDFS] Fix accessing an already freed pointer in UDFMarkAllocatedAsNotXXX()
...
CORE-11182
2019-08-17 16:49:11 +03:00
Victor Martinez
4805f0cd73
[UDFS] Don't access OldInIcb after being freed
...
CORE-11199
2019-08-17 16:49:11 +03:00
Victor Martinez
d97e49091d
[UDFS] Fix uninitialized variable
...
CORE-11216
2019-08-17 15:43:24 +03:00
Victor Perevertkin
90b8646790
[USBOHCI_NEW] Fix unused variable
2019-08-16 20:37:11 +03:00
Stanislav Motylkov
2a8fc2b411
[USBOHCI_NEW] Refactor OHCI_AbortTransfer function
...
- Added SAL annotation
- Simplified local variables
- Replace counterintuitive `do {} while ()` loops with nice `for` loops
- Get rid of goto and its label, it can be simply avoided
2019-08-16 19:08:04 +02:00
Sylvain Deverre
4d3df0da50
[NTFS] Correctly find attributes stored in another file record in MFT (and referenced in data stream)
2019-08-16 11:08:29 +02:00
Serge Gautherie
68bcc2df7c
[NDIS] Enforce '#if DBG' around MiniDisplayPacket[2]()
...
Also add 'static' on MiniDisplayPacket2().
2019-08-15 21:08:10 +02:00
Timo Kreuzer
0e8392beea
[TDI] Improve spec file
2019-08-15 18:04:57 +02:00
Timo Kreuzer
58588b76e2
[REACTOS] Fix MSVC printf format warnings
2019-08-15 15:24:12 +02:00
Hermès Bélusca-Maïto
d7d13b3226
[PROCESSR] Employ usual casing for CurrentControlSet key.
2019-08-10 19:15:38 +02:00
Oleg Dubinskiy
47303268e1
[USBAUDIO] Fix compilation issues
2019-08-03 14:55:57 +02:00
Hermès Bélusca-Maïto
b6135732d4
[DLLs] Fix .spec files regarding OLE-specific exports.
...
- Do not use hardcoded ordinals, add missing '-private'.
Except for MSXML3, OLE32 and RSAENH, see commit bff824b2
2019-07-28 16:26:22 +02:00
Timo Kreuzer
08c6d21e1f
[REACTOS] Fix warning C4146: unary minus operator applied to unsigned type, result still unsigned
2019-07-27 11:21:28 +02:00
Timo Kreuzer
791b1ad7bd
[FASTFAT] Copy an entire field, instead of half-copying it with RtlCopyMemory
...
Fixes GCC 8 warning:
sdk/include/crt/mingw32/intrin_x86.h:76:12: error: 'memmove' offset [21, 40] from the object at 'DirContext' is out of the bounds of referenced subobject 'Attrib' with type 'unsigned char' at offset 19 [-Werror=array-bounds]
return memmove(dest, source, num);
^~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-20 13:56:18 +02:00
Thomas Faber
aa46da57d4
[ACPICA] Update to version 20190703. CORE-16202
2019-07-20 08:47:50 +02:00
Timo Kreuzer
ad60726288
[ACPICA] Fix MSVC x64 build
...
See CORE-16082
2019-07-14 11:35:50 +02:00
Thomas Faber
d9f9cb247c
[PCI] The INIT section must be uppercase.
2019-07-07 08:18:12 +02:00
Serge Gautherie
4253ba71fc
[FLOPPY_NEW] Fix MSVC builds
2019-07-06 09:39:03 +02:00
Thomas Faber
76e00fab7e
[PORTCLS] Zero memory in operator new. CORE-16157
...
Fixes a regression from 99fa38809f
2019-07-05 17:31:46 +02:00
Serge Gautherie
6d238e4513
[FASTFAT_NEW] Fix MSVC builds
...
CORE-14879
2019-07-04 21:16:12 +02:00
Timo Kreuzer
9590cd15f4
[FASTFAT] Fix use after free when volume is unmounted
2019-06-30 13:57:14 +02:00
Eric Kohl
545692e89e
[STORPORT] Improvements to the device enumerator code.
...
- Create PDO for the device
- Send a SCSIOP_INQUIRY command to the new PDO
- Delete the PDO if the inquiry command failed
2019-06-27 23:28:41 +02:00
Victor Perevertkin
e831f8530b
[USBSTOR] Do not print device descriptor by default.
...
Add SrbGetCdb macro
2019-06-25 19:04:20 +03:00
Victor Perevertkin
10260f40d9
[USBOHCI_NEW] Rename counter-intuitive field of Transfer Descriptor
2019-06-25 15:14:21 +03:00
Victor Perevertkin
9004e64b57
[USBOHCI_NEW] Zero out the transfer descriptor right after allocation.
...
Cleaned up transfer routines and added some more docs.
2019-06-25 15:03:26 +03:00
Victor Perevertkin
3fe397818a
[USBOHCI_NEW] Simplify the MapTransferToTD routine and add some docs
2019-06-25 13:02:35 +03:00
Thomas Faber
3fb5ca3bee
[UNIATA] Update to version 0.47a. CORE-15930
2019-06-25 09:26:09 +02:00
Thomas Faber
2e21126cb0
[ACPICA] Update to version 20190509. CORE-16138
2019-06-25 09:26:07 +02:00
Timo Kreuzer
dc0cd07d21
[CMIDRIVER] Try to fix build 3
2019-06-25 09:11:01 +02:00
Hermès Bélusca-Maïto
306bcd9d73
[BLUE] Initialize the console with a default font for codepage 437.
2019-06-25 02:32:09 +02:00
Timo Kreuzer
aad4096475
[CMIDRIVER] Try to fix build 2
2019-06-25 00:54:00 +02:00
Timo Kreuzer
a14b509974
[CMIDRIVER] Try to fix build
2019-06-25 00:26:08 +02:00
Timo Kreuzer
99fa38809f
[STDUNK][PORTCLS][CMIDriver] Fix issue with operator new/delete
...
Fix for MSVC warning "C2323: 'operator new': non-member operator new or delete functions may not be declared static or in a namespace other than the global namespace."
See https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-what-s-new-2003-through-2015?view=vs-2019 section "Overloaded operator new and operator delete"
2019-06-24 21:17:00 +02:00
Hermès Bélusca-Maïto
ede3fddad7
[BOOTVID] Diverse enhancements.
...
- Import cmdcnst.h and vga.h headers from the 'vga_new' VGA Miniport Driver,
that contain definitions related to VGA registers as well as command-stream
functionality.
- Replace a bunch of hardcoded values by their corresponding defintions.
- Replace "Captain-Obvious" comments in VgaIsPresent() with actual
explanations from the corresponding function in 'vga_new'.
- Simplify the VgaInterpretCmdStream() function, based on the
corresponding one from 'vga_new'.
- Use concise comments in the 'AT_Initialization' command stream definition.
- Import the 'VGA_640x480' initialization command stream from 'vga_new'
and use it as the full VGA initialization stream whenever the HAL
does not handle the VGA display (HalResetDisplay() returning FALSE).
Otherwise we just use the 'AT_Initialization' command stream that
performs minimal initialization.
- Remove unused AT_Initialization and other declarations from ARM build.
2019-06-23 23:59:48 +02:00
Hermès Bélusca-Maïto
8f04a09e74
[BOOTVID] Fixes for VgaIsPresent() and VidInitialize().
...
- VgaIsPresent(): Re-select the memory mode register before playing
around with the sequencer flag. Otherwise the VGA may not be detected
correctly from time to time.
- VidInitialize(): Simplify the initialization loop, reset AddressSpace
to its "default" value of 1 when calling HalFindBusAddressTranslation()
on 'NullAddress'.
2019-06-23 03:07:19 +02:00
Hermès Bélusca-Maïto
025cfb108b
[BOOTVID] Simplify the code by introducing and using IO port helper macros.
...
- Move around two header includes.
- Remove a redundant assignment in VgaInterpretCmdStream().
2019-06-23 02:59:43 +02:00
Bișoc George
42ce8519b6
[FASTFAT][FLTMGR][NTOS] Do not explicitly call ObfDereferenceObject() ( #1636 )
...
"Most code should not directly call the platform-specific ObfDereferenceObject() function but use the ObDereferenceObject() macro instead."
CORE-16081
2019-06-22 16:20:58 +02:00
Benjamin Aerni
939b25a15a
[I8042PRT] Add Latitude E6400 to the hack list ( #1665 )
...
Let it make grow, grow, grow... !!
2019-06-16 23:00:53 +02:00
Victor Perevertkin
1552434940
[NTFS] Do not print debug message for every function call by default
2019-06-15 19:24:27 +03:00
Pierre Schweitzer
95848cb538
[BTRFS] Fix MSVC build
...
CORE-16111
2019-06-11 12:50:49 +02:00
Pierre Schweitzer
92543df9e1
[BTRFS] Fix MSVC build
...
CORE-16111
2019-06-11 12:43:43 +02:00
Pierre Schweitzer
f381137c89
[BTRFS] Upgrade to 1.3
...
CORE-16111
2019-06-11 12:35:19 +02:00
Victor Perevertkin
da1b08e842
[USBSTOR] Properly handle IRP_MN_QUERY_DEVICE_RELATIONS(BusRelations) for FDO.
...
This fixes Driver Verifier warnings
2019-06-11 04:39:43 +03:00
Victor Perevertkin
04409942d6
[USBSTOR] Register dumb IRP_MJ_SYSTEM_CONTROL handler.
...
This satisfies Driver Verifier
2019-06-11 04:39:43 +03:00
Victor Perevertkin
126abaf88f
[USBSTOR] Improve handling of IRP_MN_QUERY_DEVICE_TEXT for PDOs
...
CORE-15883
2019-06-11 04:39:43 +03:00
Victor Perevertkin
40b25634ff
[USBSTOR] Do not leak fields of DeviceExtensions upon device removal
2019-06-11 04:39:43 +03:00
Victor Perevertkin
fa530aee92
[DISK] Disable IsFloppyDevice check.
...
It wrongly marks USB flash drives as a floppy device
2019-06-11 04:39:43 +03:00
Victor Perevertkin
b7de5870e6
[USBSTOR] Weaken the type checks of a device.
...
This adds usb-cdrom support to usbstor.sys
2019-06-11 04:39:43 +03:00
Victor Perevertkin
7bb93db372
[USBSTOR] Refactor device reset and pipe reset code.
...
Return correct status codes from completion routines.
Reject requests while the device is being reset
2019-06-11 04:39:43 +03:00
Victor Perevertkin
aaa90f6986
[USBSTOR] Do not try to retry a failed request
...
for all cases except receiving a USBD_STATUS_STALL_PID status.
This decision should be made by higher-level driver (and classpnp drivers do it)
2019-06-11 04:39:43 +03:00
Victor Perevertkin
c7ed299aaa
[USBSTOR] Issue a SCSI Request Sense after receiving
...
a CSW with failed status. CORE-15884
Based on Vadim Galyant's patches to usbstor
2019-06-11 04:39:43 +03:00
Victor Perevertkin
5046f1b3fa
[USBSTOR] Keep CBW and CSW inside an IRP context.
...
Remove obsolete fields from the IRP context structure.
2019-06-11 04:39:43 +03:00
Victor Perevertkin
c452f7dab4
[USBSTOR] Refactor request issue code.
...
Pipe handle selection now made more correctly.
Simplified an MDL allocation for a request.
2019-06-11 04:39:43 +03:00
Victor Perevertkin
84f78cb0d7
[USBSTOR] Better handle CBW/CSW transfer errors
...
and set SrbStatus correctly.
2019-06-11 04:39:43 +03:00
Victor Perevertkin
3faf5efd49
[USBSTOR] Better validate SCSI IRPs.
...
Patch by Vadim Galyant
2019-06-11 04:39:43 +03:00
Victor Perevertkin
f3fd12b9be
[USBSTOR] Rework the routines for sending internal SCSI requests.
...
Now for each request SenseBuffer is correctly set
and 3 attempts are made to be sure the STALL state is cleared and
the error is in something else.
Remove the usage of UFI_INQUIRY_DATA structure in favor of "standard"
INQUIRYDATA structure from scsi.h
Based in Vadim Galyant's patches to usbstor
2019-06-11 04:39:43 +03:00
Victor Perevertkin
ed6724cd7e
[USBSTOR] Do not create a new Irp for USB requests - use the original one
...
from higher-level driver instead.
Refactored CSWCompletionRoutine for correct handling different CSW
statuses, more work to be done here.
2019-06-11 04:39:43 +03:00
Victor Perevertkin
b4c03399ba
[USBSTOR] Do not attempt additional processing of SCSI requests.
...
Now the driver sends all requests transparently.
Inspired by Vadim Galyant's patches to usbstor
2019-06-11 04:39:43 +03:00
Victor Perevertkin
d17d15ab6c
[FORMATTING][USBSTOR] Remove Captain Obvious and line-wasting comments.
...
Now the driver conforms with our current Coding Style.
No functional changes
2019-06-11 04:39:43 +03:00
Hermès Bélusca-Maïto
6fb3dcd312
[FASTFAT] Adjust the 'UnCleanCount', followng commit 9c3c0d12.
2019-06-09 19:05:24 +02:00
Hermès Bélusca-Maïto
4b6abeb352
[FASTFAT] Minor cleanup of the main header file.
2019-06-09 17:56:06 +02:00
Serge Gautherie
38db074491
Misc addendum to CORE-14271 ( #1529 )
...
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.
Also, add a FIXME.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RegisterClipboardFormatA/W() a bit
No functional change.
* [UDFS] Simplify SeSinglePrivilegeCheck() return value check
No functional change.
Addendum to
CORE-14271
2019-06-04 16:56:33 +02:00
Eric Kohl
be88574f59
[STORPORT] Detect attached devices
2019-06-02 23:30:02 +02:00
Eric Kohl
631db82058
[STORPORT] Fix resource list size calculation
2019-06-02 14:24:35 +02:00
Timo Kreuzer
2944d29969
[REISERFS] Convert a tab to spaces
...
Fixes GCC 8 warning:
drivers/filesystems/reiserfs/src/memory.c:874:5: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if (Mcb->RfsdFcb)
^~
drivers/filesystems/reiserfs/src/memory.c:877:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
if (RfsdLoadInode(Vcb, &(Mcb->Key), &RfsdIno)) {
^~
2019-05-27 13:22:40 +02:00
Timo Kreuzer
81bdf4e360
[CRT] Add missing posix error codes
...
These are required by latest mingw-w64 stl and we are mixing this with our crt headers.
Define _CRT_NO_POSIX_ERROR_CODES in all modules that define their own constants.
2019-05-27 13:22:40 +02:00
Hervé Poussineau
9a6eb70ff9
[HIDCLASS] Implement IRP_MJ_WRITE
2019-05-14 14:37:22 +02:00
Pierre Schweitzer
883b1f31ac
[BTRFS] Upgrade to 1.2.1
...
CORE-16004
2019-05-11 11:20:02 +02:00
Hervé Poussineau
2d5a230810
[MOUHID] Correctly detect tablet devices
...
Some mice give a logical min/logical max which is the maximum move
that they can provide. Those were wrongly detected as absolute mice,
and mouse pointer was mostly stuck at the upper left corner of the
screen.
2019-05-10 11:35:01 +02:00
Hervé Poussineau
2978d4b61b
[HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library
...
Interface between both is not anymore the HidParser_* functions, but
the HidP_* functions and the AllocFunction/FreeFunction/DebugFunctions/
ZeroFunction/CopyFunction.
2019-05-02 20:06:47 +02:00
Hervé Poussineau
bef39dd62e
[SERIAL] Immediately complete read IRP if all requested bytes have been found in circular buffer
...
Previously, we had to wait to receive another byte to finish the first IRP.
2019-05-02 20:06:47 +02:00
Hervé Poussineau
ebd39aa266
[I8042PRT] Do not assert on unknown IOCTL
2019-05-02 20:06:47 +02:00
Hervé Poussineau
501116b68f
[HIDCLASS] Implement IOCTL_HID_GET_FEATURE/IOCTL_HID_SET_FEATURE
2019-04-19 22:46:03 +02:00
Thomas Faber
a7634b8e1d
[USBHUB_NEW] Support NULL HubExtension in USBH_PdoRemoveDevice.
...
Device removal can happen multiple times for PDOs.
2019-04-14 15:32:18 +02:00
Thomas Faber
477cf902e4
[USBHUB_NEW] Fix inverted check in USBH_RestoreDevice.
...
This allows re-enabling a disabled device.
2019-04-14 15:32:16 +02:00
Thomas Faber
46b0f6d9de
[USBCCGP] Allow unconfiguring the device in USBCCGP_PDOSelectConfiguration.
...
Fixes device removal for USB audio devices.
2019-04-14 15:32:14 +02:00
Thomas Faber
528fc589c0
[USBCCGP] Do not try to unconfigure a device that is not configured.
...
Fixes handling failed IRP_MN_START_DEVICE.
2019-04-14 15:32:12 +02:00
Victor Perevertkin
5f4cf8a716
[USBHID] Do not assert if the device was unplugged during an operation.
2019-04-08 12:05:17 +03:00
Hervé Poussineau
902b86eecf
[UDFS] Fix macros to support 'bit' being a complex expression
...
This is for example used in udf_info/mount.cpp:
UDFSetUsedBits(new_bm, i & ~(d-1), d);
2019-04-07 19:28:18 +02:00
Hervé Poussineau
5f69f99ce2
[UDFS] Keep same includes/defines on x64 as on other architectures
2019-04-07 19:28:18 +02:00
Hervé Poussineau
33cf2c44c5
[MUP] Use _SEH2_AbnormalTermination() instead of _abnormal_termination()
...
We're already using SEH2 macros, so also use SEH2 functions
2019-04-07 19:28:18 +02:00
Hervé Poussineau
4c1cbd2b53
[EXT2] Add __REACTOS__ check around changes done in 76910c358f
2019-04-07 18:32:29 +02:00
Thomas Faber
89a587169b
[ACPICA] Update to version 20190405. CORE-15926
2019-04-07 10:59:52 +02:00
Jérôme Gardou
23373acbb9
[CMAKE] Use modules instead of shared libraries
...
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.
On my system, this reduces the configure-time by a factor of two.
2019-04-06 17:43:38 +02:00
Pierre Schweitzer
2a104321ee
[UDFS] Fix an integer overflow leading to a buffer overrun
...
Spotted by GCC7
2019-04-04 15:08:21 +02:00
Alexandr A. Telyatnikov
6d5a81013c
[UNIATA] Fix for uninitialized Lun pointer
...
This fixes crash on Intel AHCI init. CORE-15886
2019-04-02 18:02:07 +02:00
Timo Kreuzer
c334c17d69
[UDFS] Fix 64 bit issues
2019-04-02 10:53:23 +02:00
Hervé Poussineau
12c70fb4cf
[UDFS] Really use 'logical or' when meant to
...
'binary or' was also working, but it is less clear.
2019-04-01 11:38:32 +02:00
Hervé Poussineau
76910c358f
[EXT2] Correctly zero memory before using it
2019-04-01 11:38:32 +02:00
Thomas Faber
ba1fb9ace9
[ACPICA] Update to version 20190329. CORE-15900
2019-03-30 14:57:35 +01:00
Maxim Smirnov
5570cde271
[NULL] Use correct device characteristics value for the null device
2019-03-28 22:46:04 +01:00
Thomas Faber
b546130731
[UNIATA] Update to version 0.47. CORE-15870
2019-03-24 14:48:32 +01:00
Thomas Faber
526fc76cac
[SERIAL] Do not return NTSTATUS from an interrupt routine.
2019-03-24 09:25:17 +01:00
Thomas Faber
b91cf860cd
[UNIATA] Update to version 46e8. CORE-15843
2019-03-14 13:16:43 +01:00
Thomas Faber
48870fe35e
[UNIATA] Remove an unnecessary ROS-diff.
2019-03-14 13:16:41 +01:00
Thomas Faber
fc9d5d2f55
[USBUHCI_NEW] Fix an infinite loop.
2019-03-11 08:54:03 +01:00
Thomas Faber
026a12fe39
[USBPORT] Implement interface setting in USBPORT_OpenInterface.
2019-03-11 08:54:01 +01:00
Thomas Faber
ac20ab031c
[USBPORT] Correctly handle alternate settings returned from USBPORT_ParseConfigurationDescriptor.
...
The last parameter of USBPORT_ParseConfigurationDescriptor is a pointer
to a boolean indicating whether any alternate interface settings were
found for the specified interface.
Interpreting it as an alternate setting value, as we did before,
would always override the alternate setting to '1' (if any alternate
descriptors were present), therefore selecting the wrong interface
setting, and possibly causing a buffer overflow on the InterfaceList's
Pipes array.
Found by Special Pool.
2019-03-11 08:53:55 +01:00
Thomas Faber
36c1cb0910
[USBPORT] Correctly find interface descriptor in USBPORT_ParseConfigurationDescriptor
...
There can be other descriptors between the config descriptor and the
first interface descriptor, so we specifically need to check for
the interface descriptor type and skip anything before that.
We also need to guard against bLength == 0, which would cause an
infinite loop, instead of doing a second bDescriptorType check.
2019-03-11 08:53:53 +01:00
Thomas Faber
1946f6bb25
[USBPORT] Acquire EndpointSpinLock in addition to MiniportSpinLock in USBPORT_ReopenPipe.
2019-03-11 08:53:52 +01:00
Thomas Faber
e47240fb37
[USBPORT] Release StateChangeSpinLock before acquiring MiniportSpinLock.
...
Found by Driver Verifier.
2019-03-11 08:53:50 +01:00
Thomas Faber
267f5633ee
[USBPORT] Leave IRP status untouched for unhandled interfaces.
...
Found by Driver Verifier.
2019-03-11 08:53:49 +01:00
Thomas Faber
12a66769fc
[USBPORT] Don't change the status of IRP_MJ_SYSTEM_CONTROL requests.
...
Found by Driver Verifier.
2019-03-11 08:53:47 +01:00
Thomas Faber
e10e6a85fb
[USBHUB_NEW] Don't leak IRP_MJ_SYSTEM_CONTROL requests.
...
Found by Driver Verifier.
2019-03-11 08:53:45 +01:00
Pierre Schweitzer
4e07b3b9f9
[AFD] Don't reallocate buffers if windows sizes didn't change
2019-03-10 12:27:30 +01:00
Timo Kreuzer
f5f6ea2965
[REACTOS] Fix 64 bit issues
2019-03-04 21:58:42 +01:00
Timo Kreuzer
403fec1b27
[SACDRV] Fix CHECK_PARAMETER_WITH_STATUS error handling macro
2019-03-04 21:58:42 +01:00
Timo Kreuzer
05f4951b8c
[CDROM_NEW] Fix SLIST_ENTRY vs SINGLE_LIST_ENTRY issues
2019-03-04 21:58:42 +01:00
Timo Kreuzer
dfd876a96b
[CLASSPNP] Fix SLIST_ENTRY vs SINGLE_LIST_ENTRY issues
2019-03-04 21:58:42 +01:00
Thomas Faber
1001e6089f
[HDAUDBUS] Wait until the correct number of responses was received. CORE-15465
...
We previously only gave the device a hard-coded amount of time to respond,
which could lead to interpreting the contents of uninitialized memory as
a response. This would lead to an unreasonably large number of audio function
groups being detected.
A KSEMAPHORE mirrors what Haiku uses here, though it may not be the optimal
synchronization primitive for this case under Windows.
2019-02-28 10:27:06 +01:00
Thomas Faber
8530ae9950
[HDAUDBUS] Handle responses in a DPC instead of the ISR.
2019-02-28 10:06:18 +01:00
Thomas Faber
a7431880bd
[HDAUDBUS] Fix a DPRINT.
2019-02-28 10:05:53 +01:00
Thomas Faber
1f76fb738a
[HDAUDBUS] Prevent overflow of the AudioGroups array. CORE-14153 CORE-15465
...
This protects against crashing in case of faulty/malicious hardware,
but also works around a bug in HDA_SendVerbs that causes it to return
invalid data, thereby suggesting more groups than are actually present.
2019-02-27 11:04:23 +01:00
Thomas Faber
a8414f665b
[HDAUDBUS] Implement HDA_Unload. Stub HDA_Power and HDA_SystemControl.
2019-02-26 09:58:53 +01:00
Thomas Faber
25b22131ca
[HDAUDBUS] Correctly mask register values.
...
See https://github.com/haiku/haiku/blob/master/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp
and https://github.com/haiku/haiku/blob/master/src/add-ons/kernel/drivers/audio/hda/driver.h#L118-L140
This fixes various device reset failures and probably other issues.
2019-02-26 09:51:48 +01:00
Thomas Faber
584baf79d9
[HDAUDBUS] Implement PDO removal. CORE-14617
2019-02-26 09:51:38 +01:00
Thomas Faber
c8c0fc8d64
[HDAUDBUS] Implement FDO removal. CORE-14617
2019-02-26 09:51:21 +01:00
Thomas Faber
b05e5b0340
[HDAUDBUS] Use IoForwardIrpSynchronously instead of HDA_SyncForwardIrp.
2019-02-26 09:50:50 +01:00
Thomas Faber
789cfd3ddc
[HDAUDBUS] Forward FDO requests instead of completing them.
2019-02-26 09:20:47 +01:00
