Commit graph

74536 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
f55ded91a4
[SHIMGVW] Fix cursor (#1471)
Fix the cursor of shimgvw.dll. CORE-15219
2019-04-05 16:52:11 +09:00
Katayama Hirofumi MZ
6388b91a4d
[CRT][USER32] fix wsprintf additional argument (%*s) (#1470)
Reduce wsprintf function failures ("%*s"). CORE-13955
2019-04-05 16:33:18 +09:00
Katayama Hirofumi MZ
2fd3a8f1b5
[KERNEL32_APITEST] Follow up of #1466 (#1469)
Skip tests if the current codepage is not Japanese. CORE-15920
2019-04-05 13:04:15 +09:00
Katayama Hirofumi MZ
eb8d1d929f
[KERNEL32_APITEST] Japanese calendar testcase (#1466)
Add Japanese calendar-related tests. CORE-15920
2019-04-05 09:06:41 +09:00
Katayama Hirofumi MZ
d04b4e65d6
[SHELL32] Implement Explorer background image (Retrial of #801) (#1463)
IconArea_Image, IconArea_Text and IconArea_TextBackground values in desktop.ini in a folder will be supported. It denies network paths. CORE-5516
2019-04-05 07:59:35 +09:00
Katayama Hirofumi MZ
466dbc5929
[BOOTDATA] Japanese calendar-related registry info (#1468)
Add registry info about Japanese calendar. CORE-15920
2019-04-05 07:21:00 +09:00
Eric Kohl
a8dea717f2 [MC] Add spanisch, polish, romanian, turkish, chinese and taiwanese messages to the file by duplicating the english ones and translate messages that will be used by the NET ACCOUNTS command.
Translators, please check the translations.
2019-04-04 23:53:35 +02:00
Pierre Schweitzer
2a104321ee [UDFS] Fix an integer overflow leading to a buffer overrun
Spotted by GCC7
2019-04-04 15:08:21 +02:00
Katayama Hirofumi MZ
8bf795ff76
[GDI32_APITEST] Add LPtoDP testcase (#1462)
ROSTESTS-320
2019-04-04 10:44:52 +09:00
Katayama Hirofumi MZ
2c48ab4c0e
[ROSTESTS][GDI32_APITEST] Follow up of #1459 (#1460)
ROSTESTS-319
2019-04-04 05:25:02 +09:00
Mark Jansen
d71712e909
[SYSSETUP] Ask for common controls v6 when using v6 features 2019-04-03 19:44:27 +02:00
Mark Jansen
bae083355d
[SYSSETUP] Add a missing break 2019-04-03 19:44:16 +02:00
Katayama Hirofumi MZ
e157a5fe1c
[GDI32_APITEST] Improve DPtoLP testcase (#1459)
ROSTESTS-319
2019-04-03 22:48:42 +09:00
Katayama Hirofumi MZ
234a78e09f
[ROSTESTS][GDI32_APITEST] Follow up of #1457 (#1458)
Thanks, @SergeGautherie.
2019-04-03 20:42:21 +09:00
Katayama Hirofumi MZ
f65a62ea5b
[ROSTESTS][GDI32_APITEST] Refactor testcases (#1457)
[ROSTESTS][GDI32_APITEST] Refactor testcases
2019-04-03 17:22:21 +09:00
Maxim Smirnov
39c0fd5722 [SHELL32] Fix version info in the file dialog 2019-04-03 00:51:24 +02:00
Alexandr A. Telyatnikov
6d5a81013c [UNIATA] Fix for uninitialized Lun pointer
This fixes crash on Intel AHCI init. CORE-15886
2019-04-02 18:02:07 +02:00
Julien Schueller
23d0aead53 [KERNEL32] Fix typo in kernel32.spec (#1453) 2019-04-02 15:48:41 +02:00
Katayama Hirofumi MZ
635534005b
[WIN32SS][FONT] Fix font coordinate conversion CORE-15907 (#1452)
[WIN32SS][FONT] Fix font bounding box mapping for viewport CORE-15907
2019-04-02 22:39:26 +09:00
Timo Kreuzer
c334c17d69 [UDFS] Fix 64 bit issues 2019-04-02 10:53:23 +02:00
Timo Kreuzer
be97da34ac [NETAPI32] Fix NetUserEnum to work on x64
The previous implementation used the resume_handle parameter to return a pointer to the active enumeration context, but resume_handle is a DWORD. To support 64 bit pointers, the enumeration context is inserted into a global linked list and given a unique 32 bit value as identifier for later lookup.
The way the function is implemented, leaking a data structure while the MSDN description does not indicate that, seems a little questionable in general, but that is something that I leave to the original author to investigate.
2019-04-02 01:45:51 +02:00
Timo Kreuzer
61e35141e8 [SETUPAPI] Use ClassInstallReserved field instead of Reserved to store a pointer.
The Reserved field is ULONG and we need ULONG_PTR. ClassInstallReserved was unused so far. I have no idea whether this is correct, but it cannot be more incorrect than what we had.
2019-04-01 22:20:39 +02:00
Hervé Poussineau
0c4d21a5a1 Revert "[DXG] Define GUIDs only once", to fix MSVC build
This reverts commit 3a78dd4b31.
2019-04-01 18:00:59 +02:00
Hervé Poussineau
ef3ded6b97 [CMAKE] Enable -fno-aggressive-loop-optimizations only for GCC 4.8(+)
Previously, it was also enabled for GCC > 4.7, ie for example for GCC 4.7.1
2019-04-01 17:32:07 +02:00
Hervé Poussineau
2f46ab2104 [RAPPS] Fix compilation
DPA_Search() function requires 6 parameters, not 4!
2019-04-01 11:38:32 +02:00
Hervé Poussineau
6cc607bac2 [SETUPAPI] SetupDiGetDeviceInfoListClass: fix buffer overflow (and return correct results) 2019-04-01 11:38:32 +02:00
Hervé Poussineau
faa938e9dc [USERENV] Initialize variable before using it 2019-04-01 11:38:32 +02:00
Hervé Poussineau
6a1c78b37b [GLU32] Prevent a warning when comparing 'this' against 0 2019-04-01 11:38:32 +02:00
Hervé Poussineau
3a78dd4b31 [DXG] Define GUIDs only once 2019-04-01 11:38:32 +02:00
Hervé Poussineau
12c70fb4cf [UDFS] Really use 'logical or' when meant to
'binary or' was also working, but it is less clear.
2019-04-01 11:38:32 +02:00
Hervé Poussineau
76910c358f [EXT2] Correctly zero memory before using it 2019-04-01 11:38:32 +02:00
Hervé Poussineau
c8719ee865 [CRT] Correctly share get_ioinfo()/release_ioinfo() functions between code units
This fixes the following compiler errors:

../sdk/lib/crt/stdio/stat64.c:7:13: error: inline function 'release_ioinfo' declared but never defined [-Werror]
 inline void release_ioinfo(ioinfo *info);
             ^~~~~~~~~~~~~~
../sdk/lib/crt/stdio/stat64.c:6:16: error: inline function 'get_ioinfo' declared but never defined [-Werror]
 inline ioinfo* get_ioinfo(int fd);
                ^~~~~~~~~~
../sdk/lib/crt/stdio/file.c:186:5: error: 'init_ioinfo_cs' is static but used in inline function 'get_ioinfo' which is not static [-Werror]
     init_ioinfo_cs(ret);
     ^~~~~~~~~~~~~~
../sdk/lib/crt/stdio/file.c:183:19: error: 'get_ioinfo_nolock' is static but used in inline function 'get_ioinfo' which is not static [-Werror]
     ioinfo *ret = get_ioinfo_nolock(fd);
2019-04-01 11:38:32 +02:00
Hervé Poussineau
c3e2a54789 [SDK] Fix compilation error
../sdk/include/reactos/rosctrls.h:283:59: error: no matching function for call to 'CToolbar<TItemData>::SendMessageW(int, HWND__*&, int)'
         return SendMessageW(TB_SETTOOLTIPS, hWndTooltip, 0);
../sdk/include/psdk/winuser.h:5543:21: note: candidate: LRESULT ATL::CWindow::SendMessageW(UINT, WPARAM, LPARAM) <near match>
../sdk/include/psdk/winuser.h:5543:21: note:   conversion of argument 2 would be ill-formed
2019-04-01 11:38:32 +02:00
Hervé Poussineau
a15160cd45 [FREELDR] Prevent a warning in Xbox memory initialization 2019-04-01 11:38:32 +02:00
Hervé Poussineau
95671c25ec [CMAKE] Add -fno-aggressive-loop-optimizations flag
ReactOS/Windows headers contain lots of structures whose last field is
fieldName[ANYSIZE] or fieldName[1].
Starting with GCC 4.8, gcc considers that accessing items [2], [3], ...
are undefined operation, and may optimize those accesses by removing them!

Add flag -fno-aggressive-loop-optimizations to prevent this unwanted behaviour.
2019-04-01 11:38:32 +02:00
Hervé Poussineau
6668178cff [PSDK] Remove throw specifiers, deprecated in C++11 2019-04-01 11:38:32 +02:00
Bartosz Brachaczek
d256ff6006
[NTOSKRNL] Do not try to access OldBackTracking[-1]
It can be triggered by the existing "F<", "FILE.TXT" case in the tests.

CORE-15902
2019-04-01 08:28:00 +02:00
Bartosz Brachaczek
695e00fbbd
[NTOSKRNL] Unify buffer size calculation in FsRtlIs{Name,Dbcs}InExpression
It better captures the intent now in FsRtlIsNameInExpressionPrivate and
fixes a slight overallotion by 4 bytes in FsRtlIsDbcsInExpression.

While at it, use the ANSI_DOS_DOT macro in the Dbcs version.

CORE-15902
2019-04-01 08:27:59 +02:00
Hermès Bélusca-Maïto
6eadbfb7e7
[TRANSLATION][USERINIT] Update Bulgarian translation.
Fixed the "installation failed" displayed error string.
Based on a patch by contributor 'WindowxDeveloper'.
2019-03-31 23:18:29 +02:00
WindowxDeveloper
5577e8fbe8
[TRANSLATION][RUNONCE] Add Bulgarian translation. 2019-03-31 23:05:32 +02:00
WindowxDeveloper
e78aa82d0a
[TRANSLATION][WINLOGON] Improve Bulgarian translation. 2019-03-31 22:58:14 +02:00
WindowxDeveloper
6bcf552011
[TRANSLATION][SERVICES] Add Bulgarian translation. 2019-03-31 22:54:33 +02:00
Joann Mõndresku
6c9f1a8c26
[THEMES] Add artwork for Lunar.
Added original artwork for the new Lunar theme.
2019-03-31 22:13:24 +02:00
Adam Słaboń
8946920109
[THEMES] Add new ReactOS theme - Lunar. By Adam Słaboń and Joann Mõndresku.
Reuse some Lautus assets, adjust the theme configuration and include it in the build process.
2019-03-31 22:13:15 +02:00
jimtabor
2f5c0ee0a9 [NtGdi] Fix assert with Winamp
Fixes CORE-10774.

Reference:
Alexandre Julliard : Ignore empty rectangles in ExtCreateRegion.
8ac61c5a1e
2019-03-31 13:31:59 -05:00
Bișoc George
bd5fb32b79 [COVERITY][SPOOLSS] Fix a resource leak
Unload the library pointed by hWinspool when the function fails.

CID 1401149
2019-03-31 20:09:42 +02:00
Baruch Rutman
d5b4570d23 [RAPPS] Add themes category
Add category string to the rest of rc files

Update README
2019-03-31 20:08:25 +02:00
Raul Tambre
3592ca6545
[CONFIGURE] Add VS 16.0 support. 2019-03-31 20:02:56 +02:00
Raul Tambre
989667f0c2
[CONFIGURE] Simplify Visual Studio generator selection.
CMake >3.2 supports specifying the architecture through the -A parameter,
allowing the logic to be simplified.
Specifying the architecture like this is also required since Visual Studio 2019.
2019-03-31 20:02:55 +02:00
Bartosz Brachaczek
e9b438bfaa
[NTOSKRNL] Addendum to 21d2c70: properly start DOS_START loop
Fixes last failing test.

CORE-15902
2019-03-31 19:35:25 +02:00