Commit graph

67897 commits

Author SHA1 Message Date
Kamil Hornicek ca4c2640e7 [WIN32K]
- Don't try to delete the pattern bitmap in UserInitialize.
- Set the correct owner before deleting the update region in co_UserFreeWindow.
- Fixes some "Trying to delete global object" debug prints.

svn path=/trunk/; revision=73855
2017-02-20 10:10:37 +00:00
Giannis Adamopoulos ef483f95f7 [blackshade.msstyles] -Add a skeleton for a theme based on a mockup by David Quintana
svn path=/trunk/; revision=73854
2017-02-19 20:40:45 +00:00
Eric Kohl b96144bbbd [COMCTL32]
Update a tool buttons tooltip rectangle when the button gets hidden.
Patch will be sent upstream!
CORE-12667 #resolve

svn path=/trunk/; revision=73853
2017-02-19 20:39:11 +00:00
Eric Kohl 5b17f6949b [DEVMGR]
- NEVER EVER use single line if statements!!!!
- Fix indentation and coding style.

svn path=/trunk/; revision=73852
2017-02-19 19:40:04 +00:00
Eric Kohl bb85fef52f [DEVMGR]
Hide "HTREE\ROOT\0" from the device tree.
CORE-12670 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=73851
2017-02-19 19:13:41 +00:00
Eric Kohl dd588d8bb2 [DEVMGR]
Select a treeview item on a right click.

svn path=/trunk/; revision=73850
2017-02-19 18:31:52 +00:00
Thomas Faber f78f7b3f31 [MSAFD][WS2_32]
- Properly return error codes from WSPConnect
CORE-12787 #resolve

svn path=/trunk/; revision=73849
2017-02-19 17:50:34 +00:00
Pierre Schweitzer 3499311e18 [EVENTVWR]
Don't attempt to free random address

CID 1401231

svn path=/trunk/; revision=73848
2017-02-19 17:24:13 +00:00
Giannis Adamopoulos 3df13bc41a [UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric id to GetSysColor. CORE-11086
svn path=/trunk/; revision=73847
2017-02-19 16:32:44 +00:00
Eric Kohl 27c1e20f13 [ACPI]
Generate a proper device id string for processor devices.

svn path=/trunk/; revision=73846
2017-02-19 15:13:49 +00:00
Pierre Schweitzer 7fb841c839 [SHELL32]
For the input string, WideCharToMultiByte takes a char count and not a buffer size.

CID 1401096, 1401088

svn path=/trunk/; revision=73845
2017-02-19 13:22:02 +00:00
Pierre Schweitzer e78b6c5179 [SHELL32]
Don't attempt to dereference a pointer after having freed it

CID 1401297

svn path=/trunk/; revision=73844
2017-02-19 13:00:12 +00:00
Pierre Schweitzer 23733b7867 [WS2_32]
Remove duplicated if

CID 1400935

svn path=/trunk/; revision=73843
2017-02-19 12:52:14 +00:00
Pierre Schweitzer f772b72e3e [DNSAPI]
Properly check for domain name being set

CID 1401070

svn path=/trunk/; revision=73842
2017-02-19 12:42:08 +00:00
Thomas Faber e4bf71987b [WSHTCPIP]
- Fix incorrect sizeof in SHIoctl_GetInterfaceList. CID 1401188

svn path=/trunk/; revision=73841
2017-02-19 12:21:06 +00:00
Thomas Faber 8b8c1c7e5a [WS2_32]
- Fix ridiculous over-casting

svn path=/trunk/; revision=73840
2017-02-19 12:05:48 +00:00
Thomas Faber c60757b725 [WS2_32]
- Fix wrong ServLength in getnameinfo, again, since it got lost in the ws2_32_new work. CID 716150
CORE-11214

svn path=/trunk/; revision=73839
2017-02-19 11:44:18 +00:00
Giannis Adamopoulos 64c9bc0eba [UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776
svn path=/trunk/; revision=73838
2017-02-19 11:41:23 +00:00
Pierre Schweitzer c7a2132d63 [DNSAPI]
Properly check for domain name being set

CID 1401080

svn path=/trunk/; revision=73837
2017-02-19 11:34:00 +00:00
Pierre Schweitzer 3a8d6379b1 [FASTFAT]
Avoid uninit variable usage.

CID 1401257, 1401259

svn path=/trunk/; revision=73836
2017-02-19 11:22:21 +00:00
Thomas Faber 0ba77df60d [LOCALMON]
- Avoid a potential double free in InitializePrintMonitor2. CID 1401299
- Avoid a use after free in LocalmonClosePort. CID 1401298

svn path=/trunk/; revision=73835
2017-02-19 10:31:37 +00:00
Giannis Adamopoulos cf3310e4e9 [UXTHEME] -The code to draw the classic style borders was copied from win32k, so imitate what it does and restore two bits that got removed in the copy. CORE-9667
svn path=/trunk/; revision=73834
2017-02-19 10:23:26 +00:00
Giannis Adamopoulos 8e371f8e7f [SHELL32] -Try to fix themes when opening the control panel applet from the control panel.
svn path=/trunk/; revision=73833
2017-02-19 09:10:03 +00:00
Mark Jansen 099a790594 [KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek. CID 1322124 CORE-12784 #resolve #comment Thanks!
svn path=/trunk/; revision=73832
2017-02-18 22:54:31 +00:00
Pierre Schweitzer 590c4dcc8c [FASTFAT]
Get rid of the ENTRY_DELETED2, ENTRY_VOLUME2 and ENTRY_END2 macros.

svn path=/trunk/; revision=73831
2017-02-18 21:37:56 +00:00
Pierre Schweitzer 1dc27a26be [FASTFAT]
Modify ReadVolumeLabel() so that it is able to read the volume label, even without using the VCB, the root FCB, Cc, the universe.
This is important, because in case of device verifying, you cannot rely on these elements anylonger, but you need to read the label.
A readme has been attached to the function, to indicate how to call it (I wish I could have put more asserts!). It's ugly, I know.

This allows fixing a FIXME in VfatVerify(): we can also check the volume label for FATX volumes.
The FIXME comment was misleading: MS FastFAT doesn't make any checksum or whatever of FAT root. Let's not do it.

svn path=/trunk/; revision=73830
2017-02-18 21:24:31 +00:00
Pierre Schweitzer 9c5c0b479a [FASTFAT]
Move ReadVolumeLabel() to fsctl.c close to functions that need it

svn path=/trunk/; revision=73829
2017-02-18 18:35:48 +00:00
Giannis Adamopoulos 9a213745ca [DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case is that it is not a pointer and another case that it is a pointer to a struct. What I'm sure of is that as it is now the position of the string in the binary affects the behavior of ApplyTheme. Thankfully 0 works great on windows.
svn path=/trunk/; revision=73828
2017-02-18 18:14:32 +00:00
Thomas Faber e4b71d31f9 [KMTESTS:MM]
- Add some stricter checks and improved error handling in NtCreateSection_user

svn path=/trunk/; revision=73827
2017-02-18 14:22:44 +00:00
Thomas Faber 8056edf828 [USBSTOR]
- Fix a broken assert (yes, calling NTOHL is wrong, ContiguousLogicBlocksByte0 is the MSB). CID 701077

svn path=/trunk/; revision=73826
2017-02-18 11:47:40 +00:00
Mark Jansen 29631b02e2 [GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ. CORE-6621
svn path=/trunk/; revision=73825
2017-02-18 11:25:31 +00:00
Thomas Faber 5d76039958 [PSDK]
- Fix KsFilterFactoryGetDevice
CORE-11794

svn path=/trunk/; revision=73824
2017-02-18 09:30:59 +00:00
Kamil Hornicek 67e4aa500e [SHELL32]
- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).

svn path=/trunk/; revision=73823
2017-02-17 23:39:39 +00:00
Pierre Schweitzer 1f58ae3a5d [FASTFAT]
Generalize the usage of functions pointers for FatX vs Fat specific code (direntry).
This should also help speeding up FastFAT.

svn path=/trunk/; revision=73822
2017-02-17 22:25:03 +00:00
Pierre Schweitzer 41f23cace3 [FASTFAT]
In the FCB, get rid of the FCB_IS_FATX_ENTRY flag. It makes no sense to have it on each and every file as the VCB already has such flag

svn path=/trunk/; revision=73821
2017-02-17 21:24:12 +00:00
Pierre Schweitzer 36bd380f3a [FASTFAT]
Fix a typo brought in r73819

svn path=/trunk/; revision=73820
2017-02-17 18:06:38 +00:00
Pierre Schweitzer 92922765ac [FASTFAT]
More FastFAT cleanup.
Except a light performances boost due to useless checks removal in read/write and to some functions inlining

More to follow...

svn path=/trunk/; revision=73819
2017-02-17 17:58:18 +00:00
Giannis Adamopoulos 2667ff688f [SHELL32] -Expand the name of the cpl file because CreateActCtx needs a full path.
svn path=/trunk/; revision=73818
2017-02-17 17:23:17 +00:00
Mark Jansen b742e89b01 [DBGHELP] Add experimental rsym support. CORE-12773
svn path=/trunk/; revision=73817
2017-02-17 16:18:15 +00:00
Mark Jansen e2c97e602f [DBGHELP_APITEST] Add tests for pdb and rsym parsing. CORE-12773
svn path=/trunk/; revision=73816
2017-02-17 16:15:49 +00:00
Mark Jansen 17a622f506 [SDK][KERNEL32] Add defines for PEB.AppCompatFlags CORE-12768 #resolve
svn path=/trunk/; revision=73815
2017-02-17 16:12:19 +00:00
Thomas Faber eb5ff5ce18 [LIBTIFF]
- Fix GCC non-PCH build
CORE-12775

svn path=/trunk/; revision=73814
2017-02-17 13:58:26 +00:00
Thomas Faber 34d6ad7853 [LIBTIFF]
- Update to version 4.0.7
CORE-12775 #resolve

svn path=/trunk/; revision=73813
2017-02-17 13:43:05 +00:00
Kamil Hornicek 7db2f3af0f [WIN32K]
- The pattern bitmap can get deleted during the GDI cleanup for process before the brush itself.
- Gets rid of some of those pesky "GreDeleteObject: Trying to delete invalid object" debug prints.

svn path=/trunk/; revision=73812
2017-02-17 13:13:36 +00:00
Thomas Faber 61d91cd9e8 [LIBTIFF]
- Use the official libtiff 4.0.3 def file to determine exported functions (instead of exporting everything in GCC builds, nothing in MSVC builds)
- Remove unused ROS-diffs
CORE-6898 CORE-12275

svn path=/trunk/; revision=73811
2017-02-17 13:05:50 +00:00
Kamil Hornicek 238c9ac8e2 [PING]
- Addendum to r73626. Convert the print specifiers too so that ping doesn't only output the old specifiers themselves.

svn path=/trunk/; revision=73810
2017-02-17 12:30:14 +00:00
Thomas Faber ea55caa53a [WINDOWSCODECS]
- Fix some MSVC-specific definitions

svn path=/trunk/; revision=73809
2017-02-17 12:17:20 +00:00
Pierre Schweitzer 990af47b16 [FASTFAT]
Thomas->happiness++;

svn path=/trunk/; revision=73808
2017-02-17 11:38:05 +00:00
Pierre Schweitzer 57ec8a7319 [FASTFAT]
Fix a few ugly things.
Both Thomas & cppcheck should be happier now!

svn path=/trunk/; revision=73807
2017-02-17 11:08:38 +00:00
Giannis Adamopoulos c607de714c [WIN32k]
-Fix a couple of cases where we use the versioned class atom instead of the non versioned one.

[USER32]
- Add support for versioned classes in RegisterClassExWOWW, GetClassInfoExW, GetClassInfoExA, UnregisterClassA, UnregisterClassW, and User32CreateWindowEx
- Make ClassNameToVersion return the name of the versioned class and the library name that implements it while preserving a hack that lets user32 know which classes are registered by comctl32 (this is needed because the default activation context doesn't contain the non versioned classes yet).
- Make VersionRegisterClass to load the specified library and make it register its classes which is used when the class is not registered yet but its manifest is active.

svn path=/trunk/; revision=73806
2017-02-17 11:07:14 +00:00