Commit graph

1150 commits

Author SHA1 Message Date
Eric Kohl c47ad98ff7 [SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List. 2019-06-06 19:12:44 +02:00
Eric Kohl adc9bd48b7 [SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr. 2019-06-06 19:08:43 +02:00
Hermès Bélusca-Maïto fdfef818ef
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559)
CORE-11711
2019-06-06 17:07:38 +02:00
Serge Gautherie 1f8250f700
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. (#1559) 2019-06-06 17:06:52 +02:00
Serge Gautherie addfb61d8b [NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615) 2019-06-06 01:49:18 +02:00
Serge Gautherie 46259092f9 [ADVAPI32:REG] Remove some useless casts (#1614) 2019-06-05 18:37:07 +02:00
Serge Gautherie 38db074491 Misc addendum to CORE-14271 (#1529)
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check

RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.

No functional change.

Addendum to
CORE-14271

* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check

RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.

Also, add a FIXME.

No functional change.

Addendum to
CORE-14271

* [USER32] Simplify RegisterClipboardFormatA/W() a bit

No functional change.

* [UDFS] Simplify SeSinglePrivilegeCheck() return value check

No functional change.

Addendum to
CORE-14271
2019-06-04 16:56:33 +02:00
Joachim Henze bc3eed68ca [MSHTML] Fake Success in HTMLDocument_put_bgColor()
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error 8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123

Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
2019-06-01 22:53:16 +02:00
Eric Kohl adceb3807e [NETAPI32] Implement parts of NetGetDCName and declare some parameters optional. 2019-05-29 15:35:55 +02:00
Eric Kohl 968bdeddf3 [NETAPI32] Implement NetpAllocWStrFromStr(), NetpAllocWStrFromAnsiStr() (not public, but useful) and NetpAllocWStrFromWStr(). 2019-05-29 12:59:44 +02:00
Katayama Hirofumi MZ 9a39315d46
[SYSSETUP] Set registry hostname in WriteComputerSettings (#1589)
Based on @Doug-Lyons's patch. CORE-16067
2019-05-29 19:59:40 +09:00
Timo Kreuzer 801ec51a91 [BROWSEUI] Fix indentation
Fixes GCC 8 warning:
dll/win32/browseui/explorerband.cpp:1332:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
                 if (!SUCCEEDED(hr) || !pParent.p)
                 ^~
dll/win32/browseui/explorerband.cpp:1335:21: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
                     hr = pParent->SetNameOf(0, pidlChild, dispInfo->item.pszText, SHGDN_INFOLDER, &pidlNew);
                     ^~
2019-05-27 13:22:40 +02:00
Timo Kreuzer 207a0f520e [MSHTML] Convert tabs to spaces
Fixes GCC 8 warning:
dll/win32/mshtml/script.c:844:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
    if(!new_buf)
    ^~
dll/win32/mshtml/script.c:846:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
             This->size <<= 1;
             ^~~~
2019-05-27 13:22:40 +02:00
Timo Kreuzer 089d59bc6c [RSAENH] Use StringCbPrintfA instead of sprintf
Fixes GCC 8 warning:
dll/win32/rsaenh/rsaenh.c:161:23: error: '%s' directive writing up to 259 bytes into a region of size 235 [-Werror=format-overflow=]
 #define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:161:23: note: in definition of macro 'RSAENH_REGKEY'
 #define RSAENH_REGKEY "Software\\Wine\\Crypto\\RSA\\%s"
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dll/win32/rsaenh/rsaenh.c:1107:5: note: 'sprintf' output between 26 and 285 bytes into a destination of size 260
     sprintf(szRSABase, RSAENH_REGKEY, pKeyContainer->szName);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-05-27 13:22:40 +02:00
Timo Kreuzer 81bdf4e360 [CRT] Add missing posix error codes
These are required by latest mingw-w64 stl and we are mixing this with our crt headers.
Define _CRT_NO_POSIX_ERROR_CODES in all modules that define their own constants.
2019-05-27 13:22:40 +02:00
Katayama Hirofumi MZ 2db0e159a4
[KERNEL32] Fix SetComputerNameExW (#1583)
Based on @Doug-Lyons's patch. CORE-16058
2019-05-27 16:18:38 +09:00
Jose Carlos Jesus 7f5e960e32
[TRANSLATIONS] Update/Add Portuguese translations.
Translations for: reactos/setup, usetup, syssetup, netshell, shell32.
2019-05-26 21:19:31 +02:00
Jose Carlos Jesus 73d7fd1415
[TRANSLATIONS] Update/Add Portuguese translations. (#1564)
Translations for: deskadp, deskmon, reactos/setup, usetup, syssetup.

Co-Authored-By: Bișoc George <fraizeraust99@gmail.com>
2019-05-19 17:04:47 +02:00
Pierre Schweitzer ea7aca8bdd
[KERNEL32] Drop unused line breaks 2019-05-08 18:34:28 +02:00
Pierre Schweitzer 204bfa8574
[KERNEL32] Misc. fixes to DefineDosDeviceW
- Add support for LUIDDeviceMapsEnabled;
- Broadcast proper message in case of device removal;
- Use less memory for strings management;
- Make code a bit cleaner.
2019-05-05 18:33:15 +02:00
Pierre Schweitzer 5d20d512be
[KERNEL32] Rewrite QueryDosDeviceW to handle global and local MS-DOS namespaces
It also comes with a small performance boost: instead of performing object
queries one after another, we query them all at once.
2019-05-05 14:18:09 +02:00
Pierre Schweitzer 8d128aa441
[KERNEL32] Reduce QueryDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.
2019-05-05 10:17:16 +02:00
Pierre Schweitzer 1ed7f27466
[KERNEL32] Reduce DefineDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
2019-05-05 10:17:16 +02:00
Eric Kohl 5164c852e8 [POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState. 2019-05-02 20:39:58 +02:00
Hervé Poussineau 7033ab18df [HID] Use hidparser static library for HidP_* functions
hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys

At the same time, this permis implementation of some HidP_* functions.
2019-05-02 20:06:47 +02:00
Katayama Hirofumi MZ dcaaf3e7af
[COMDLG32] Fix treatment of wrong filename extension (#1545)
Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270
2019-05-02 22:48:01 +09:00
Hermès Bélusca-Maïto 77d234b049
[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989 2019-04-29 22:51:35 +02:00
Serge Gautherie cf48f8bf8a [REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
No functional change otherwise.
2019-04-28 21:19:42 +02:00
Katayama Hirofumi MZ 2da24f7274 [COMDLG32] Follow up of #1514 CORE-7114 Don't load asterisk extension 2019-04-28 08:44:52 +09:00
Hermès Bélusca-Maïto 0e3a043526
[KERNEL32] Add an (incomplete) pre-implementation for SetThreadStackGuarantee(). (#803)
This should remove some of the "SetThreadStackGuarantee(): stub" messages in some simple cases.
2019-04-27 18:41:50 +02:00
Katayama Hirofumi MZ 6a7d8112c3
[COMDLG32] Save open/save location by extension (#1514)
Use the proper open/save initial folder for comdlg32.GetOpenFileName and comdlg32.GetSaveFileName. CORE-7114
2019-04-27 23:02:34 +09:00
Andrew Cook 716613cddc [CMAKE] Use new policies for CMP0005 and CMP0018 (#1481)
* [CMAKE] Fix for CMP0018
The new behaviour lets us explicitly disabling position independent code, avoiding the need to change undocumented variables

* LINK_DEPENDS is semicolon separated

* [CMAKE] Fix for CMP0005
it seems impossible to have cmake correct escape PROXY_CLSID_IS so move it to the header
2019-04-27 11:33:37 +02:00
Jared Smudde 7e18b6d0eb
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522)
CORE-13516, CORE-13518
2019-04-24 04:28:05 +02:00
Jared Smudde bf431dd278
[MPR] Implement the function WNetDisconnectDialog(). (#1522)
CORE-13516, CORE-13518
2019-04-24 04:28:01 +02:00
Hermès Bélusca-Maïto 62823a08ce
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry. 2019-04-24 03:41:41 +02:00
Hermès Bélusca-Maïto 0416c598f8
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem(). 2019-04-24 03:36:27 +02:00
Katayama Hirofumi MZ 8e60c2efee
[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518)
Correctly create cache about ".lnk" and handling in the member functions.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-04-24 03:28:17 +02:00
Mark Jansen 774f497721
[SYSSETUP] Fix a broken DPRINT
Thanks to Thomas for spotting it.
2019-04-22 16:24:59 +02:00
Eric Kohl eabae983e0 [POWRPROF] EnumPwrSchemes: Fix callback string lengths
The callback routine should get the real lengths of the name and description strings in bytes instead of the buffer sizes in characters. This fixes buffer overflows in powercfg.cpl.
2019-04-22 00:44:47 +02:00
Eric Kohl afca8367ea [KERNEL32] GetSystemPowerStatus(): Set the BATTERY_FLAG_CRITICAL flag if the battery life gets lower than 5 percent. 2019-04-19 22:30:46 +02:00
Eric Kohl 333eb16f30 [KERNEL32] GetSystemPowerStatus(): Fix coding style. No code changes! 2019-04-19 22:28:11 +02:00
Andreas Maier 0263151f3c
[DBGHELP] SymFromAddr: Handle 2 or more symbols at the same address correct.
There could be more then 2 symbols at the same addr.
Adjust function to handle that case correct.
2019-04-19 21:09:45 +02:00
Andreas Maier b2bcd8afdd
[DBGHELP] Set LastError for SymGetModuleBase-calls to ERROR_MOD_NOT_FOUND.
Correct last error in module_find_by_addr.
2019-04-19 21:09:45 +02:00
Andreas Maier 6175044aed
[DBGHELP] set correct values in symt_fill_sym_info (SYMBOL_INFO).
* symtype: set to SymPdb not SymCv (may be for old pdb-files pre VS 6.0)
* flags: return SYMFLAG_PUBLIC_CODE for SymTagPublicSymbol if its a function.
* flags: do not return SYMFLAG_FUNCTION for SymTagFuncion.
2019-04-19 21:09:45 +02:00
Andreas Maier 9466a005e9
[DBGHELP] Add SYMFLAG_- and SYMTYPE_-defines. 2019-04-19 21:09:44 +02:00
Andreas Maier e3447d02c1
[DBGHELP] use correct record in codeview_snarf_public.
Use public_vx iststead of data_vx for public symbols.
2019-04-19 21:09:44 +02:00
Andreas Maier 183294a12e
[DBGHELP] search for debugfiles in modulepath too.
Debug symbols (like PDB, ...) could not be found if the direcory of
the module and application differs. Applying this patch they will
be found.
Dbghelp searches the module path too. (See MS docs).
2019-04-19 21:09:38 +02:00
Mark Jansen 9f00854bad
[MSGINA] Disable exceptions in atl when compiling without exceptions 2019-04-18 19:21:38 +02:00
Mark Jansen f5731a41f8
[SHELL32] Use the same definitions for shell32 and it's static libs 2019-04-18 19:21:37 +02:00
Mark Jansen 9824a0154e
[ATL] Retire atlnew 2019-04-18 19:21:37 +02:00