- Fix FormatMessage flags sanitization.
- Use "LANG_USER_DEFAULT" instead of MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT) (these are the same, but one is shorter than the other).
- In case LookupAccountSidW fails to retrieve the user name of an associated SID, use ConvertSidToStringSidW to get the SID string directly and display it, instead of claiming there is no associated user for a given event.
- In addition to display (in the status bar) the number of events in the selected log, display the number of events actually listed. This can be useful when events filtering will be completely implemented, and it can be also useful for detecting possible corrupted logs where the number of enumerable events is different (less) than the total number of events in the log...
==> To translators: please update the translations!
CORE-11637
svn path=/trunk/; revision=73043
- Reorganize the header inclusions; add a PCH.
- Transform the event details dialog into a control that can be embedded:
* in a resizable dialog,
* or in a pane below the window listing the events.
CORE-11637
svn path=/trunk/; revision=72079
- Use helper functions for doing the filtering on the events (idea by Mark Jansen).
- Fix the states of menu items, depending on which event log/item (log file/filter; event item...) is currently selected.
- Correctly empty the event items list & cache whenever an event log/filter is closed (and avoid a crash when all logs/filters are closed and someone attempts to open an event item), during concurrent accesses. I use a reference count and AddRef/Release helpers.
- Get rid of the annoying log loading popup, and use instead the loading message displayed in the events listview as well as a progress-bar in the status bar.
CORE-11637
svn path=/trunk/; revision=71989
Commit "Part 1" of my Improvements for the Event Log Viewer. See CORE-11637 description for more details (too long to stay there).
svn path=/trunk/; revision=71958
- Display 3 different "types" of logs in the tree: "system logs": Application, Security, System, that are the minimal set of standard logs present on NT systems; "application logs": all the other logs, that are available to the event log service (both "system" and "application" logs are registered in the registry, under the "EventLog" service key). Finally comes the "user logs" that consists in all the log files that are manually opened by the user inthe event log viewer.
- Use 'PEVENTLOGRECORD' instead of 'EVENTLOGRECORD *'.
- Don't hardcode the buffer length values in the size parameters used in the GetEventUserName function.
- Merge both GetDisplayNameFile and GetDisplayNameID helpers into a single GetDisplayNameFileAndID function, since the former two were always called in tandem.
- Forbid editing the labels of the tree root nodes "system"/"application"/"user" logs.
- Splitter bar: set the cursor only when it is on the bar, not when it is above the status bar...
- Resize the status bar only in WM_SIZE events.
- Remove few dead code.
svn path=/trunk/; revision=71867
- Change the closed-folder icon, by Jared Smudde :)
- Add "open" and "log settings" menu items. Implementation will be done later.
svn path=/trunk/; revision=71850
- Use a tree to list the available system logs (and in the future, the manually opened logs within the viewer).
- Allow the user to resize the treeview/listview.
- Use the standard shell about-box dialog to display the "About..." notice + copyright.
- Improve the Event Log Viewer icon, and add new ones (folders + eventlog file).
svn path=/trunk/; revision=71836
- Remove a unused header.
- Start (re)working on the functions that retrieve strings associated to event categories and messages.
- Just display the event category number if we are unable to retrieve its associated string.
- If we cannot retrieve the event source for formatting purposes, use a default string and append the event strings to it.
- Fix some problems related to the usage of 'lpComputerName': this global variable stores the computer name on which the Event Viewer is running (or connected to) and view the available logs. Don't overwrite it with computer names from the events.
- Modify some localized strings in the resource files. Translators, please review/fix translations!
svn path=/trunk/; revision=71670
- Set window parent for different MessageBox calls.
- Add a notice in ShowStatusMessageThread concerning a potential bug.
- Rename strings "Save Protocol" into "Save Event Log"; adjust translations in this regard.
svn path=/trunk/; revision=71377
- Fix a typo in the "loading, wait" dialog.
- Use a RichEdit control for the detailed event description text, so that we can have for free clickable URLs.
- Use "Courier New" as the font for the event data text, so that we can have finer grained control over the font size...
svn path=/trunk/; revision=71376
- Fix the window styles of the edit boxes in the event details dialog.
- Refactor some parts of the code to reduce the level of code indentation.
- Replace malloc/free by their Win32 counterparts HeapAlloc/HeapFree.
- When caching the full contents of a given event log, don't load at this point the event text/data. Only load those when opening the event details dialog.
svn path=/trunk/; revision=71368
Update the Event Detail Dialog to better match XP/2K3
Patch by Lee Schroeder.
I updated the remaining dialogs.
Translators: Please check the dialogs!
CORE_8904 #resolve
svn path=/trunk/; revision=65628
Do not hardcode event logs, but retrieve them from the registry.
Patch by Ricardo Hanke.
CORE-8458 #resolve #comment Committed, thanks!
svn path=/trunk/; revision=63930
* when displaying message boxes, set the parent to the main window/details dialog instead of using NULL.
*add a function for showing the last Win32 error and replace two message boxes with a call to it.
*add the ability to save event logs to a file.
*add the ability to clear event logs.
*In QueryEventMessages(), assign lpSourceLogName and lpComputerName after the call to OpenEventLog, not before.
Patch by Ricardo Hanke
CORE-7863 #comment Comitted in r63525, thanks
svn path=/trunk/; revision=63525
* Change some of the LTEXT controls to EDITTEXT in IDD_EVENTDETAILDIALOG to better match the ones in Windows XP/2003.
* Change the height for the Bytes and Word Radio Buttons so the two controls are not overlapping IDC_EVENTDATAEDIT.
* By Lee Schroeder.
CORE-7842 #resolve #comment Committed in 61936. Thanks !
svn path=/trunk/; revision=61936
- brasilian portugeese translation by Matheus Macabu (bug no. 7079);
[AHK]
- add scripts for including AHK tests into Reactos\Bin;
svn path=/trunk/; revision=56697