Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ:
https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functional limitation in ReactOS.
Fixes regressions CORE-17020 and CORE-12203 that were once introduced
by SVN r72320 == git 297e33f228
during COMCTL32 WineSync 1.9.16 CORE-11866
Fix picked from 0.4.15-dev-191-g 295ba62820
This fixes
CORE-16775 Shutdown dialog is not destroyed in Limbo x86 PC Emulator
CORE-16697 [MSGINA] Improve logo-related display (japanese and chinese)
CORE-16775 was a regression introduced by 0.4.12-dev-731-g f9d29319a6
by porting back:
0.4.14-dev-1354-g 28e277b65f (#2518) CORE-16775
0.4.14-dev-1353-g a5a426f867 (#2508) CORE-16775
0.4.14-dev-999-g 61c8d3432c (#2360) CORE-16697
0.4.14-dev-998-g 623dd26cce (#2352) CORE-16697
Thanks to Jim Tabor, Mark Jansen & Thomas Faber
By squashed backmerge of the following commits:
--------------
[NTUSER] Fix Strings and Format to Hooks
Allocate heap instead of data segment to be used for callbacks on user side.
Move and correct initial hook call out setup. Use it in more than one hook call.
This fixes issues with strings out of alignment and use of kernel pointers.
See CORE-13907 and CORE-16769. KsStudio still needs retested.
Small wow update.
cherry picked from commit 0.4.14-dev-1287-g
568b6d0558
--------------
[RTL] Introduce RtlpImageNtHeader,
which implements the required functionality.
ntdll and ntoskrnl now have a wrapper for this, with SEH.
This protects the function against malformed / bad images,
whilst still being able to use the code in freeldr et al.
Idea from Thomas.
CORE-14857
cherry picked from commit 0.4.14-dev-1255-g
177ae91bf6
--------------
[WIN32SS] Form Sanity to Hook Callbacks
Fix WH_CALLWNDPROC/RET data to user hook calls. See CORE-13019 and CORE-13907.
cherry picked from commit 0.4.14-dev-1241-g
915a5764a9
--------------
[USER32] Fix null return.
See CORE-16769.
cherry picked from commit 0.4.14-dev-1240-g
d8add40e89
Missed a file. See CORE-14439.
cherry picked from commit 0.4.14-dev-1210-g
78098f99e0
[0.4.13][EXPLORER|SHELL3232] Fix CORE-14439 part 1 of 2
Prevent ros from halting when Miranda IM 0.10.21 snap-to-border-feature is used.
Fix SHAppBarMessage (not perfect) by adapting wine code. See CORE-14439.
More work is required. Kept the original code for reference.
Example : SetWindowPos should be called via Post Message.
Code commit is to wake up other developers.
cherry picked from commit 0.4.14-dev-1209-g
10d1afea18
CP_UTF8 validation was not strict. 5- or 6-byte length sequences are invalid in RFC 3629 UTF-8. CORE-16468
- Fix MultiByteToWideChar(CP_UTF8, ...) by making check strict.
This will definitely fix regression CORE-16678 which was introduced or unhidden by
0.4.13-dev-927-g
e85664a3d8
and was also reported to bring ros a bit closer towards displaying japanese in ros Notepad with MS Gothic,
but I am not sure, whether it is enough for that already when backported on its own.
cherry picked from commit 0.4.14-dev-193-g
a63678c9a9
Fixes symptom "MSVCPP2017 setup crash due to missing export"
The issue very likely got introduced by
0.4.13-dev-986-g
029b8f2cf9
because our loader exports stuff from neweer Windows versions
since then in case an executables manifest states compatibility.
Original commit message from patches author William Kent:
Stub GetCurrentPackageId() (#1942)
* [KERNEL32] Add stub implementation for GetCurrentPackageId() function
This Windows 8+ function is called by WiX bundles (EXE-based installers) upon exit, if the export is present. If it is a stub in the spec, they will crash, even if they are coded to be compatible with Windows XP/ReactOS.
Also add GetCurrentPackageId() forwarder to apiset.
cherry picked from commit 0.4.14-dev-482-g
192926ee02
Fixes symptom
"Adobe Flash player online setup fails downloading itself"
by porting back
0.4.14-dev-560-g
5bd6580fc6
and 0.4.14-dev-716-g
4bf76a659e
and additionally updating README.WINE
Testbots LGTM:
https://reactos.org/testman/compare.php?ids=70898,71103 VBox
https://reactos.org/testman/compare.php?ids=70899,71104 KVM
Thanks to Matthias Basler, Amine Khaldi, Victor Perevertkin.
recent ros releases that were affected by this bug:
0.4.7, 0.4.8, 0.4.12
recent ros releases that were NOT affected by this bug:
- 0.4.6, 0.4.9, 0.4.10, 0.4.11 (thanks to revert)
- 0.4.13, and presumably 0.4.14 (thanks to the proper fix)
Symptom "Far Manager 3.0 Build 5200 can not load NetBox.dll"
due to uncaught exception when accessing GetSystemTimePreciseAsFileTime().
The symptom started to show with 0.4.13-dev-986-g
029b8f2cf9
as LDR exposes more Vista+ stuff since then.
The fix is a selective backmerge of master PR-1963
I doubt it helps for CORE-5007 (as it was stated in master),
that ticket most likely got fixed beforehand already.
But I already tested: Delay-loading fixes CORE-15795,
which was unhidden by 0.4.12-dev-632-g
d93e516747
The fix by delay loading was cherry picked from commit
0.4.14-dev-475-g
82b758974f
It's not just a workaround, Windows delay-loads like that as well.
Thomas believes this specific delay-load will not trigger
the LD bug CORE-6504 within our gcc toolchain.
Thanks for help of Mark Jansen, Thomas Faber and Fabian Maurer.
Many Thanks to patches author JIRA user 'I_Kill_Bugs',
but also to Doug Lyons and Fabian Maurer.
Unhidden by SVN r75735 == git 0.4.7-dev-168-g
6af37fd54e
cherry-picked from 0.4.14-dev-312-g
b931f643e3
of a search result again.
The feature regressed by 0.4.13-dev-1133-g
a3ee648d8b
I chose the shorter solution of Brock Mammen instead
of the patch of Doug Lyons from PR1960.
Still many thanks to Doug Lyons for his encouragement
in creating a fix as well and performing
regression-testing.
cherry picked from commit 0.4.14-dev-39-g
cd2a274ef7
Shell Find Improvement to make Search Item general by adding asterisks
before and after before search and show sub-directories in find listing. CORE-16152
cherry picked from commit 0.4.14-dev-9-g
b6b7bda443
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.
Like in last releases.
Add localization for the file description of both XML and XSL file formats.
Please check for copypasta errors!
CORE-16390
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147
But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.
I committed the same workaround already into 0.4.12-RC-30-g
9513c9bf12
CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de714c
CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476074
This fixes a strange toggle-back-effect in 'Zeckensacks Glide Wrapper 0.84c'
by importing Wine commit
9dbe886e3f
Thanks to patches author Akihiro Sagawa <sagawa.aki@gmail.com>
