Stanislav Motylkov
3eb4f4d450
[THEMES][LUNAR] Fix line endings problem
2021-11-17 14:12:02 +03:00
Nikki Next
577fb37a8a
[THEMES][LUNAR] Add Russian translation ( #4100 )
2021-11-17 13:58:56 +03:00
Dmitry Borisov
84fabd819d
[ISAPNP] Add support for NEC PC-98 series
2021-11-17 13:56:29 +03:00
George Bișoc
f909e8762d
[NTOS:SE] Validate the SID lengths when capturing them
...
SIDs are variadic by nature which means their lengths can vary in a given amount of time and certain factors that allow for this happen. This also especially can lead to issues when capturing SIDs and attributes because SeCaptureSidAndAttributesArray might end up overwriting the buffer during the time it's been called.
Therefore when we're copying the SIDs, validate their lengths. In addition to that, update the documentation header accordingly and add some debug prints in code.
2021-11-16 10:55:44 +01:00
Thomas Faber
4601d94801
[DBGHELP] Fix default search path handling. CORE-17073
...
* Allow NULL search path in SymSetSearchPath
* Use . instead of concrete current directory
* Use _NT_ALT_SYMBOL_PATH variable
* Add some tests
2021-11-15 20:14:34 -05:00
Mark Jansen
ab7b004d51
[FONTEXT] Fix font installation
2021-11-15 20:02:14 +01:00
Mark Jansen
54c09f856c
[FONTEXT] Simplify HIDA usage
2021-11-15 20:02:14 +01:00
Mark Jansen
fa0f5cc4be
[SHELL32] Simplify HIDA usage
2021-11-15 20:02:14 +01:00
Mark Jansen
eb0c005c1b
[SENDMAIL] Simplify HIDA usage
2021-11-15 20:02:13 +01:00
Mark Jansen
eba16dc9e9
[MYDOCS] Simplify HIDA usage
2021-11-15 20:02:13 +01:00
Mark Jansen
e5ea6041c9
[SHELL32][SHELL32_APITEST] Add SHGetAttributesFromDataObject
2021-11-15 20:02:13 +01:00
Mark Jansen
1f44552d36
[DRWTSN32] Implement arm context reading
...
CORE-17605 CORE-17604
2021-11-15 19:57:35 +01:00
Joachim Henze
f028ca5b08
[WIN32K] Fix a weird control character in dibobj.c CreateDIBPalette() CORE-17848
2021-11-15 03:05:20 +01:00
Thomas Faber
68c9ac2a82
[RICHED20_WINETEST] Re-enable crashing test. CORE-16799
2021-11-14 20:22:34 -05:00
Thomas Faber
be38a2ca4e
[SETUP] Register riched20.dll's type library during setup. CORE-16799
...
This is a bit of a hack -- I'm not sure how Windows deals with this.
2021-11-14 20:22:05 -05:00
Thomas Faber
c8b6abab80
[RICHED20] Decorate thiscall functions as such. ROSTESTS-375 CORE-17021
2021-11-14 12:54:01 -05:00
Thomas Faber
e8b79e89eb
[NTOS:PS] Fix copypasta in NtQueryInformationJobObject. CID 1441354
2021-11-13 21:23:40 -05:00
Thomas Faber
34f2b7830d
[NTOS:IO] Correctly deal with exceptions when handling FileFsDriverPathInformation. CID 1476847
2021-11-13 21:23:39 -05:00
Thomas Faber
a74ff5be17
[NTOS:IO] Don't call IopCompleteRequest with uninitialized context values. CID 716761
...
NormalContext and NormalRoutine are just for good measure, but
SystemArgument2 is actually used by the function.
And yes, this appears to be a bug in Win 2003.
2021-11-13 21:23:39 -05:00
Thomas Faber
8254585be5
[NTOS:EX] Assert some AcquireResource return values. CID 1321882
2021-11-13 21:23:39 -05:00
Thomas Faber
aa9a098196
[NTOS:EX] Correctly handle OOM in NtFindAtom. CID 1237072
2021-11-13 21:23:36 -05:00
Thomas Faber
7be3e798d5
[BOOTDATA] Include VMXNET3 driver in optional.
2021-11-13 13:34:50 -05:00
Doug Lyons
252a7530d0
[CRT] Do Not lock ioinfo when spawning functions ( #4099 ) CORE-15176
...
This fixes CORE-15176 'Gimp 2.6.11 hangs when opening a file'.
It regressed by 0.4.9-dev-446-g bffd8201d0
I do intend to port this fix back.
2021-11-11 18:30:43 +01:00
Mark Jansen
0ae3805375
[COMCTL32] Fix crash on SB_GETPARTS
...
wParam (num_parts) is allowed to be bigger than the actual amount of parts
CORE-17842
2021-11-10 17:29:35 +01:00
George Bișoc
39003dd408
[ADVAPI32] Properly implement CreateRestrictedToken
...
Instead of duplicating the token and masquerade it as if the token was filtered (which is a big hack), properly implement CreateRestrictedToken function by calling NtFilterToken which it'll create a restricted token for us.
2021-11-07 14:22:20 +01:00
George Bișoc
aaa2094208
[KMTESTS:SE] Implement SeFilterToken testcase
2021-11-07 14:14:19 +01:00
George Bișoc
6fe1b387c6
[NTDLL_APITEST] Implement NtFilterToken testcase
2021-11-07 14:14:18 +01:00
George Bișoc
53db5377e2
[NTOS:SE] Implement token filtering
...
This implements the support of token filtering within the kernel, where the kernel can create restricted tokens of regular ones on demand by the caller. The implementation can be accessed thorough a NT syscall, NtFilterToken, and a kernel mode routine, SeFilterToken.
2021-11-07 14:14:18 +01:00
George Bișoc
a15e2472b8
[SDK][NDK][XDK] Add the privilege flags needed for token filtering
...
These are needed for CreateRestrictedToken, NtFilterToken and SeFilterToken respectively. See the link down below for more information.
https://docs.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-createrestrictedtoken
2021-11-07 14:14:18 +01:00
George Bișoc
d0b6b10868
[SDK][NDK] Declare the NtFilterToken syscall prototype
2021-11-07 14:14:14 +01:00
Hervé Poussineau
b39ae9f32b
[HALX86] Implement HalBuildScatterGatherList
...
Make HalGetScatterGatherList a wrapper around it.
2021-11-07 14:07:57 +01:00
Hervé Poussineau
eb283043d5
[HALX86] Partly implement HalCalculateScatterGatherListSize
2021-11-07 14:07:55 +01:00
George Bișoc
05d52aba2b
[NTOS:SE] Partially revert 0129de2
...
The continue statements do not server any useful purpose in these loops so they're basically pointless. These have been introduced by mistake so my bad.
2021-11-05 10:13:45 +01:00
Serge Gautherie
8110a66b08
[NTOS:MM] MI_IS_*(): Improve documentation
...
Intel 64 and IA-32 Architectures Software Developer’s Manual
version 075 (June 2021)
2021-11-04 23:20:21 +03:00
Serge Gautherie
94b8095ba2
[NTOS:KE] KiTrap0EHandler(): Use MI_IS_WRITE_ACCESS()
2021-11-04 23:20:21 +03:00
George Bișoc
0129de218b
[NTOS:SE] Mark the token as no longer belonging to admin group upon effective duplication
...
A scenario where it happens that an access token belongs to an administrators group but it's disabled (that is, SeAliasAdminsSid has no attributes or it doesn't have SE_GROUP_ENABLED turn ON), the function removes this group from the token but still has TOKEN_HAS_ADMIN_GROUP flag which can lead to erratic behavior across the kernel and security modules -- implying that the token still belongs to administrators group.
This is an oversight from my part.
2021-11-04 09:30:00 +01:00
Doug Lyons
17ec81eab8
[SHELL32] Enable OpenWith to handle "NoOpenWith" and "NoStartPage" registry keys ( #4043 )
...
- Add registry handling of two keys to COpenWithMenu.cpp
- Add code to stop OpenWith from using registry entries that should be excluded
- Stop logspam when right-click menu testing for OpenWith is done
CORE-17816
2021-11-03 03:16:47 +03:00
Hervé Poussineau
22d1e7a4e4
[NTOS:IO] Create non volatile registry keys for root devices (as for other devices)
2021-11-01 18:16:25 +01:00
Hervé Poussineau
9967d9aa4c
[NTOS:IO] Do not crash when calling IopLegacyResourceAllocation with NULL ResourceRequirements
2021-11-01 18:16:25 +01:00
Hervé Poussineau
88839d9726
[HALX86] Stub-implement scatter/gather DMA operations
...
These are required when we ask for a DMA_ADAPTER version 2.
2021-11-01 18:16:25 +01:00
Katayama Hirofumi MZ
3d78601f39
[WIN32SS][NTUSER] Implement NtUserDestroyInputContext ( #4063 )
...
CORE-11700
2021-11-01 15:20:42 +09:00
Mark Jansen
e3402aca65
[ATL][ATL_APITEST] Add test for CPath +small fixes
2021-10-30 22:47:57 +02:00
Hervé Poussineau
06fc9c43ed
[PARTMGR] Mark partitions as removable if device is removable
...
CORE-17392
2021-10-30 08:47:38 +02:00
Thomas Faber
3a323c3de0
[WIN32K] Fix uninitialized bResult in IntExtTextOutW.
...
Powered by clang-cl.
2021-10-29 22:06:49 -04:00
Thomas Faber
4bc95812fd
[WIN32K] Mark default as unreachable.
...
Powered by clang-cl.
2021-10-29 22:06:49 -04:00
Thomas Faber
3235e35dee
[WIN32K] Remove unnecessary if in NtUserGetGUIThreadInfo.
...
This condition is already checked above.
Powered by clang-cl.
2021-10-29 22:06:49 -04:00
Thomas Faber
42657493ef
[WIN32K] Fix uninitialized hNewMenu use in MENU_DoNextMenu.
...
See also: Wine's implementation.
Powered by clang-cl.
2021-10-29 22:06:46 -04:00
Efe Itietie
0e75fc9240
[NETSTAT] Fix coverity #1477187 "Double free" ( #4069 )
...
Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in b695971c
.
Remove the second tcpTable free and fix coverity #1477187 . CORE-17831
2021-10-28 17:26:09 +03:00
Thomas Faber
f4ccc518e3
[CODEOWNERS] Don't automatically add me to apitests and CMake PRs.
...
Still feel free to request my review explicitly if desired.
2021-10-27 19:27:33 -04:00
Thomas Faber
fb3e2c7c8b
[USBUHCI] Fix always-false HcFlavor checks.
...
Powered by clang-cl.
2021-10-27 19:27:33 -04:00