Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-01-15 18:43:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOS:EX] Correctly handle OOM in NtFindAtom. CID 1237072

Browse source
This commit is contained in:
Thomas Faber 2021-10-27 22:51:15 -04:00
parent 7be3e798d5
commit aa9a098196
No known key found for this signature in database
GPG key ID: 076E7C3D44720826
1 changed files with 13 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
ntoskrnl/ex/atom.c
View file

@ -249,7 +249,7 @@ NtFindAtom(IN PWSTR AtomName,
PRTL_ATOM_TABLE AtomTable = ExpGetGlobalAtomTable();
NTSTATUS Status;
KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
LPWSTR CapturedName = NULL;
_SEH2_VOLATILE LPWSTR CapturedName;
ULONG CapturedSize;
RTL_ATOM SafeAtom;
PAGED_CODE();
@ -283,20 +283,12 @@ NtFindAtom(IN PWSTR AtomName,
/* Allocate an aligned buffer + the null char */
CapturedSize = ((AtomNameLength + sizeof(WCHAR)) &~
(sizeof(WCHAR) -1));
CapturedName = ExAllocatePoolWithTag(PagedPool,
CapturedSize,
TAG_ATOM);
if (!CapturedName)
{
/* Fail the call */
Status = STATUS_INSUFFICIENT_RESOURCES;
}
else
{
/* Copy the name and null-terminate it */
RtlCopyMemory(CapturedName, AtomName, AtomNameLength);
CapturedName[AtomNameLength / sizeof(WCHAR)] = UNICODE_NULL;
}
CapturedName = ExAllocatePoolWithQuotaTag(PagedPool,
CapturedSize,
TAG_ATOM);
/* Copy the name and null-terminate it */
RtlCopyMemory(CapturedName, AtomName, AtomNameLength);
CapturedName[AtomNameLength / sizeof(WCHAR)] = UNICODE_NULL;
/* Probe the atom too */
if (Atom) ProbeForWriteUshort(Atom);
@ -304,6 +296,11 @@ NtFindAtom(IN PWSTR AtomName,
}
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
{
if (CapturedName != AtomName)
{
ExFreePoolWithTag(CapturedName, TAG_ATOM);
}
/* Return the exception code */
_SEH2_YIELD(return _SEH2_GetExceptionCode());
}
@ -314,7 +311,7 @@ NtFindAtom(IN PWSTR AtomName,
Status = RtlLookupAtomInAtomTable(AtomTable, CapturedName, &SafeAtom);
if (NT_SUCCESS(Status) && (Atom))
{
/* Success and caller wants the atom back.. .enter SEH */
/* Success and caller wants the atom back... enter SEH */
_SEH2_TRY
{
/* Return the atom */