Commit graph

9 commits

Author SHA1 Message Date
Joachim Henze 2d9dabac60 [0.4.7][SHELL32] Fix a directory handle leak when browsing folders
A bit of history: in SVN r71528 == git
4322caeede
I tried to fix our explorer often
crashing while browsing directories. It was linked to the fact
that a notification result may arrive while the notification
structure had already been deleted.

The fix for this was actually broken and was leading to a double
leak: the notification structure was leaked. But also the handle
to the directory that had been browsed!
This means that the directory couldn't be modified anymore as
a leaked handle to it was still open.

Actually, when notifications are cancel, the kernel properly
calls the notification routine, but with a specific error code.
So the correct fix is to stop handling that notification when
we receive this error code. This is the correct fix with no leaks.

This commit is a complete r71528 revert with the appropriate fix.

CORE-10941
CORE-12843

cherry picked from commit 0.4.9-dev-144-g
da8a41b97b

Joachim Henze: I suspect that this patch will introduce
CORE-15703 but I think it's an improvement even if it would.
2020-10-06 16:24:44 +02:00
Joachim Henze b638ba6426 [0.4.7][SHELL32] Fix item order in Folder Options (#415)
This fixes regression CORE-14393 for russian ros setups.

regression was introduced by SVN 75534 == git 0.4.7-dev-54-g
959a179f58

fix cherry picked from commit 0.4.9-dev-141-g
1f4c636453
2020-10-03 21:50:32 +02:00
Giannis Adamopoulos 2e469036b3 [0.4.7] cherry-pick [SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives like C: CORE-13925
(cherry picked from commit 78b78d6e73)
2017-11-14 20:08:00 +01:00
Giannis Adamopoulos 276f77a3a3 [0.4.7] cherry-pick [SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years ago and was properly reported 3 days ago). CORE-13925
(cherry picked from commit dd4af77703)
2017-11-14 20:07:53 +01:00
Thomas Faber cf3e1d4e19 [0.4.7] Revert r73436 to avoid trouble with VirtualBox Guest Additions. CORE-13172 CORE-12700 CORE-12765 2017-10-29 14:41:08 +01:00
Giannis Adamopoulos d310df0dd2 [SHELL32] CDefView: Fix a leak of an HMENU. This fix is thanks to Joachim Henze who found the bug and quickly found the guilty revision. CORE-13911 2017-10-26 21:39:32 +03:00
Adam Słaboń 9c790dfc3b Polish translation update (#29)
* Polish translation update
2017-10-10 12:14:38 +02:00
Colin Finck 950c86fb4c Fix remaining text file line endings in the tree. (#18)
Based on https://stackoverflow.com/a/1511273

Also enforce CRLF for all *.xml files in our tree, because they are distributed with ReactOS.
2017-10-06 15:00:36 +02:00
Colin Finck c2c66aff7d Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00