Commit graph

61 commits

Author SHA1 Message Date
Joachim Henze 008d15fe9c [0.4.7][COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147

But greatly eliminates perceived flickering when hovering
with the mouse over buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de7

CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476

The comctl32 part of the fix was picked from 0.4.13-dev-1194-g
a40331b0f4
-------------------
The Win32SS part is just to fix compilation when USE_VERSIONED_CLASSES is not defined
and was picked from 0.4.9-dev-679-g
083c3d992b
2020-10-31 20:26:08 +01:00
Joachim Henze 2d9dabac60 [0.4.7][SHELL32] Fix a directory handle leak when browsing folders
A bit of history: in SVN r71528 == git
4322caeede
I tried to fix our explorer often
crashing while browsing directories. It was linked to the fact
that a notification result may arrive while the notification
structure had already been deleted.

The fix for this was actually broken and was leading to a double
leak: the notification structure was leaked. But also the handle
to the directory that had been browsed!
This means that the directory couldn't be modified anymore as
a leaked handle to it was still open.

Actually, when notifications are cancel, the kernel properly
calls the notification routine, but with a specific error code.
So the correct fix is to stop handling that notification when
we receive this error code. This is the correct fix with no leaks.

This commit is a complete r71528 revert with the appropriate fix.

CORE-10941
CORE-12843

cherry picked from commit 0.4.9-dev-144-g
da8a41b97b

Joachim Henze: I suspect that this patch will introduce
CORE-15703 but I think it's an improvement even if it would.
2020-10-06 16:24:44 +02:00
Joachim Henze 25515885f3 [0.4.7][GDIPLUS] Fix a regression painting gradient CORE-15479
patch is import of Wine commit 0937186f7d15fed60f77fa2014d650f4d0b6b20b
by Nikolay Sivov

regression was introduced by SVN r75872 == git 0.4.7-dev-344-g
c6f32e4a5f

fix cherry picked from 0.4.12-dev-360-g
daadcc6141
2020-10-03 23:24:06 +02:00
Joachim Henze b638ba6426 [0.4.7][SHELL32] Fix item order in Folder Options (#415)
This fixes regression CORE-14393 for russian ros setups.

regression was introduced by SVN 75534 == git 0.4.7-dev-54-g
959a179f58

fix cherry picked from commit 0.4.9-dev-141-g
1f4c636453
2020-10-03 21:50:32 +02:00
Joachim Henze be84e3f4e5 [0.4.7][SETUPAPI] Apply fix for CORE-12616 PR-408
This fixes a regression introduced in SVN r73442 == git
7e9b3d61c0
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.

This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.

I ported this fix from 0.4.8-RC-22-g
dba2f743c5
which is what we used successfully from 0.4.8rls-0.4.10rls
but does NOT reflect the latest additions yet to restore
lastError that were added by Pierre in
0.4.11-dev-643-g
8236bb8f38
but even without that few additional lines the patch did
100% what it promised: fixing CORE-12616
2020-10-02 19:37:03 +02:00
Joachim Henze ca2308d54c [0.4.7][RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75895 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.

The regression was introduced by SVN r75896 == 0.4.7-dev-368-g
ec29185ee5

fix cherry picked from 0.4.11-dev-634-g
ad34c91d1c
2020-10-02 16:56:49 +02:00
Joachim Henze 5eb70f85e6 [0.4.7][OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608
Looks better and reduces memory consumption.

The regression was introduced by SVN r75890 == 0.4.7-dev-362-g
7634613083

Fix cherry picked from 0.4.9-dev-877-g
6d5aae4865
2020-10-02 12:54:09 +02:00
Joachim Henze 5de8d5c559 [0.4.7][DHCPSVC/IPHLPAPI] Fix 2 memory leaks CORE-14353
that are triggered repeatedly when just idling on
the desktop and therefore will lure ros into
inevitable BSOD after some days.

fix cherry picked from 0.4.9-dev-52-g
87d3fdf99e

and 2nd fix cherry picked from 0.4.9-dev-50-g
182a31074f
2020-10-02 11:57:47 +02:00
Joachim Henze 45044a8371 [0.4.7][COMCTL32] use previous version of cursor files CORE-14144,
idc_divider.cur & idc_divideropen.cur,
justify their diff in comctl32/comctl32_ros.diff
2020-09-21 01:31:20 +02:00
Giannis Adamopoulos 2fda8374a2 [0.4.7] cherry-pick [COMCTL32] Button: Don't use a class brush. CORE-13445
(cherry picked from commit 34c563fa2a)
2017-11-17 17:11:08 +01:00
Giannis Adamopoulos 850c1d6b6d [0.4.7] cherry-pick [COMCTL32] Button: Draw the image list even when the button has the BS_ICON or the BS_BITMAP style. CORE-13170
(cherry picked from commit a98ff4d77c)
2017-11-14 20:08:13 +01:00
Giannis Adamopoulos 2534bc6542 [0.4.7] cherry-pick [COMCTL32] -Button: Implement drawing the image list with the BUTTON_IMAGELIST_ALIGN_CENTER parameter. This is enough to fix buttons with images created by Lazarus but only with themes. The non themed branch of the code is slightly more complex and will be fixed next. CORE-13170
(cherry picked from commit dea602cd70)
2017-11-14 20:08:05 +01:00
Giannis Adamopoulos 2e469036b3 [0.4.7] cherry-pick [SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives like C: CORE-13925
(cherry picked from commit 78b78d6e73)
2017-11-14 20:08:00 +01:00
Giannis Adamopoulos 276f77a3a3 [0.4.7] cherry-pick [SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years ago and was properly reported 3 days ago). CORE-13925
(cherry picked from commit dd4af77703)
2017-11-14 20:07:53 +01:00
Hermès Bélusca-Maïto 8b16304062
[0.4.7] Apply drawing issue fix for propsheets in comctl32, approved by Joachim Henze. See commit 11049bd (issue CORE-13929). 2017-11-03 00:16:15 +01:00
Thomas Faber cf3e1d4e19 [0.4.7] Revert r73436 to avoid trouble with VirtualBox Guest Additions. CORE-13172 CORE-12700 CORE-12765 2017-10-29 14:41:08 +01:00
Giannis Adamopoulos d310df0dd2 [SHELL32] CDefView: Fix a leak of an HMENU. This fix is thanks to Joachim Henze who found the bug and quickly found the guilty revision. CORE-13911 2017-10-26 21:39:32 +03:00
Pierre Schweitzer 0add5d0a79 [KERNEL32] Fix MSVC build 2017-10-23 17:25:19 +02:00
Pierre Schweitzer 34c39a1336 [KERNEL32] Implement NpGetUserNamep() 2017-10-23 17:09:21 +02:00
Pierre Schweitzer 19cef7806c [KERNEL32] Fix a FIXME in GetNamedPipeHandleStateW and stub a private function for a left unimplemented function 2017-10-23 14:36:18 +02:00
Pierre Schweitzer 3832f83a32 [KERNEL32] Check Basep8BitStringToDynamicUnicodeString() return and only call -W in case of success
CID 1419330
2017-10-23 13:39:44 +02:00
Pierre Schweitzer 19f1cd78c1 [KERNEL32] Check NtQueryInformationFile succeed before using its return. Also fix coding style
CID 512966
2017-10-23 12:36:43 +02:00
Giannis Adamopoulos 143c306006 [BROWSEUI] CBandSiteMenu: Use CSimpleArray and CComHeapPtr. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 3bfdbf3b2c [BROWSEUI] Improve CBandSiteBase::OnWinEvent to forward messages correctly to the child bands. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos bab9a54039 [BROWSEUI] Add a hack and abuse ISFB_STATE_QLINKSMODE to make the quick launch band to be aligned to left and show no text 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos ee3b732043 [BROWSEUI] CISFBand: Misc fixes
- Slightly improve the implementation of IShellFolderBand
- Show both folders and files in the toolbar
- Use the name of the folder shown as the name of the band
2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 37e6151b40 [BROWSEUI] CBandSiteMenu: Implement the Desktop, Quick Launch and New Toolbar menu items 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 0ed80264f9 [BROWSEUI] CBandSiteMenu: Fix two broken loops 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 3e812a66ff [BROWSEUI] Enable the menu items for the toolbars submenu of the CBandSiteMenu. Also add a new string which will be used in the next commit. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 8a52080dcc [BROWSEUI] Rename CISFBand_CreateInstance and add a CISFBand_CreateInstance macro that makes easy to switch between the system implementation or the local one. 2017-10-22 20:03:32 +03:00
Amine Khaldi fec16ab0c0 [MSI] Apply Wine commit fdac39f by Hans Leidekker: Pass correct length to GetDateFormatW. CORE-13902 2017-10-21 11:45:18 +01:00
Serge Gautherie ba507ba439 [SYSSETUP] [USERINIT] "sLanguage" relates to LOCALE_SABBREVLANGNAME actually, not LOCALE_SLANGUAGE. CORE-13128 #62 2017-10-17 13:59:18 +01:00
Giannis Adamopoulos f0f1e5ffdb [QCKLNCH] Remove qcklnch (#61)
- Move CIFSBand to the shellbars static lib which is linked to browseui and rshell.
- Move CQuickLaunchBand to rshell.
- Make nescessary adjustments so that they can both be registered and instantiated.
2017-10-16 23:56:34 +03:00
Pierre Schweitzer ed263291d1 [UBTRFS] Update to 1.0.1
CORE-13896
2017-10-16 20:30:24 +02:00
Pierre Schweitzer 5bfc68cc14 [KERNEL32] Fix buffer size for allocation in GetVolumeInformationW(). This fixes function failing with big enough buffer. 2017-10-15 10:43:49 +02:00
Pierre Schweitzer dc8bfeabcf [KERNEL32] Use proper size for allocating buffer in GetVolumeInformationA(). This was leading to allocate a too small buffer under certain conditions and to overrun it.
This fixes JRE7 setup.
This regression was brought in by r75969.

CORE-13888
2017-10-14 23:19:12 +02:00
Jared Smudde a8ad1702da [SYSSETUP] Change "Select the theme you prefer" to "Select the theme you prefer." to fit in with the other titles in second stage setup. 2017-10-11 13:22:24 +02:00
Stopkin Sergey 74cc91524a [GETUNAME] Update the Russian translation. #45 CORE-13222 2017-10-10 13:03:32 +01:00
Adam Słaboń 9c790dfc3b Polish translation update (#29)
* Polish translation update
2017-10-10 12:14:38 +02:00
Mark Jansen 4dafcc5ea2 [MSI] Fix a buffer overrun in build_default_format CORE-13881
Imported wine commit:
f517022: msi: Fix an invalid write in build_default_format (Valgrind).
2017-10-09 12:33:18 +01:00
Amine Khaldi 15786900c9 [MSI] Addendum to 71bffdc as I removed this unintentionally. 2017-10-09 12:32:09 +01:00
Hermès Bélusca-Maïto d260385023 [KERNEL32]: Add a .gitattributes file for the winnls resource files.
The .nls files in winnls are actual resource text files for kernel32 and not binary NLS files.
Therefore treat them as such.
2017-10-08 15:48:07 +02:00
Amine Khaldi e38cdd2f62 [MSCOREE] Fix build. 2017-10-08 14:28:58 +01:00
Amine Khaldi 7d346cbc73 [SHLWAPI] Highlight a difference and mark the module as synced with Wine Staging 2.16. CORE-13762 2017-10-08 12:09:52 +01:00
Amine Khaldi ea59f30f86 [WMVCORE] Sync with Wine Staging 2.16. CORE-13762
998fe04 wmvcore: Support IWMPacketSize2 interfaces in IWMReader.
0570cf9 wmvcore: Support IWMProfile3 interfaces in IWMReader.
98e94b2 wmvcore: Support IReferenceClock interfaces in IWMReader.
163aac1 wmvcore: Support IWMLanguageList interfaces in IWMReader.
b1702c4 wmvcore: Support IWMHeaderInfo/2/3 interfaces in IWMReader.
73f8066 wmvcore: Support IWMReaderPlaylistBurn interface in IWMReader.
b15c398 wmvcore: Support IWMReaderTimecode interface in IWMReader.
465feb7 wmvcore: Support IWMReaderTypeNegotiation interface in IWMReader.
437c667 wmvcore: Support IWMReaderStreamClock interface in IWMReader.
34b9b10 wmvcore: Support IWMReaderNetworkConfig1/2 interfaces in IWMReader.
94af027 wmvcore: Support IWMReaderAccelerator in IWMReader.
3f6b7c3 wmvcore: Add WMCheckURLScheme stub.
7381cec wmvcore: Implement WMCreateWriterPriv.
2017-10-08 11:49:33 +01:00
Amine Khaldi 71bffdcde9 [MSI] Sync with Wine Staging 2.16. CORE-13762
cb4c1dc msi: Always return MSIDBSTATE_ERROR when MsiGetDatabaseState is called from a custom action.
04d242d msi: Create dummy thread to initialize COM for custom actions.
52fbaeb msi: Add support for ActionText table.
700ebc8 msi: Return the correct values from dialogs.
a3dd99c msi: Return the current date and time.
4ccc82a msi: Use the Error table for more messages.
77e3d33 msi: Use MsiProcessMessage() to send error messages.
3ca2dfe msi: Avoid uninitialized pointer access on error path (Coverity).
d631714 msi: Add a trailing linefeed to a FIXME() trace.
39c2ff0 msi: Send the dialog created message in dialog_create().
14f865e msi: Don't queue a parent dialog to be shown in EndDialog.
8826584 msi: Process ShowDialog/EndDialog after all other control events.
44fb23d msi: Don't set _BrowseProperty.
b4c39f4 msi: Avoid a null pointer dereference.
51bd884 msi: Properly parse empty format strings.
16f0dff msi: Return the correct values from custom actions.
f348c7c msi: Rewrite dump_record().
f9c68df msi: Use the given record for INSTALLMESSAGE_ACTIONDATA.
c788ed85 msi: Provide the result of the last action.
1505912 msi: Allow setting NULL in MsiSetInteger().
f9f53fe msi: Correctly format the template field for MsiProcessMessage().
3033dae msi: Implement UI messages for dialogs.
5da9250 msi: Don't increment the refcount when creating dialogs.
48237e2 msi: Add a basic internal UI implementation.
39b841d msi: Fix a buffer overrun.
9032279 msi: Implement UI messages in MsiOpenPackage().
bcc4a04 msi: Implement INSTALLMESSAGE_INITIALIZE and INSTALLMESSAGE_TERMINATE.
a388906 msi: Send the correct UI messages upon calling MsiDoAction().
de5246a msi: Don't reimplement record formatting.
4e49ae3cc msi: Pass the given record to the callback.
df31a7c msi: Store string and record callback data separately.
cef6799 msi: Use an external UI record handler before a string handler.
2017-10-08 11:31:31 +01:00
Mark Jansen 48fe08654d [URLMON] Convert urlmon.inf to utf8 since git insists on fucking up utf16 files. 2017-10-07 23:43:57 +02:00
Hermès Bélusca-Maïto 66c2299bfe Fix encoding of some INF files (-> UTF-8 without BOM). 2017-10-07 22:21:22 +02:00
Mark Jansen da27e0026a [URLMON] Remove BOM from urlmon.inf 2017-10-07 22:11:41 +02:00
Amine Khaldi bd6e933ca5 [MSI] Group translations into the lang folder. 2017-10-07 12:41:53 +01:00