Jérôme Gardou
abcbd44641
[NTOS:MM] Fix passing section size to MiCreatePagingFileMap & fix maximum size check
...
Also return the right status instead of stupidly asserting when failing to allocate memory.
2020-12-14 18:22:18 +01:00
Jérôme Gardou
cb196d1e39
[APITESTS] Do not compile SEH tests in when using dummy PSEH
2020-12-14 18:22:07 +01:00
Jérôme Gardou
003ad0ec07
[PSDK] define __analysis_noreturn for clang static analyzer
2020-12-14 18:22:07 +01:00
Eric Kohl
f095ff418b
[SCSIPORT] Append the missing "SCSI <device type> Device" string to the device description
2020-12-13 16:24:58 +01:00
Eric Kohl
b71df06211
[INF] Include volume.inf in the build
2020-12-13 01:22:52 +01:00
Eric Kohl
fb500b884a
[INF] Add an inf file for the volume device class
2020-12-13 01:21:22 +01:00
Eric Kohl
afbff37d98
[STORPROP] Add missing property provider stubs
2020-12-12 16:42:15 +01:00
Eric Kohl
e64984cabb
[SCSIPORT] Trim the Device ID and the Device Description
...
- Extend CopyField to support a default character and trimming.
- Use CopyField instead of CopyFieldTruncate.
CORE-17396
2020-12-12 12:46:11 +01:00
Eric Kohl
8ba87f972d
[SCSIPORT] Fix the hardware IDs and remove the superfluous one
2020-12-10 23:25:06 +01:00
Eric Kohl
5099f24373
[SCSIPORT] Add the enumerator (SCSI) to the Compatible IDs
2020-12-09 23:58:12 +01:00
Jérôme Gardou
8631e75837
[NTOS:CC] Acquire the master lock after freeing the VACB in CcRosFlushDirtyPages
...
Fixes a random ASSERT
2020-12-09 18:06:42 +01:00
Jérôme Gardou
b089903520
[SCSIPORT] Addendum to 58ad5d9e02
2020-12-09 12:40:51 +01:00
Jérôme Gardou
58ad5d9e02
[SCSIPORT] Fix locking the device extension.
...
From MSDN:
It is an error to call KeReleaseSpinLockFromDpcLevel if the specified spin lock was acquired by calling KeAcquireSpinLock because the caller's original IRQL is not restored, which can cause deadlocks or fatal page faults.
2020-12-09 12:24:23 +01:00
Jérôme Gardou
484e959c29
[USER32] Properly save EBX in the wndproc wrapper
2020-12-09 10:00:35 +01:00
Jérôme Gardou
3d4cf8d2d8
[NTOS/FSRTL] Fix MCB tests
...
- Fix behaviour when adding or removing entries in the middle of an existing run
- Do not touch output parameters when failing, caller might rely on this.
2020-12-08 11:48:00 +01:00
Jérôme Gardou
b4debdcf4d
[KMTEST:FSRTL] Add more tests for MCB API
...
These were obtained through debug prints of fastfat_new in ReactOS.
2020-12-08 11:48:00 +01:00
Jérôme Gardou
7bbfde2b49
[KMTESTS] Add more tests for CcCopyRead
2020-12-08 11:48:00 +01:00
Jérôme Gardou
08cf040dd5
[KMTESTS] Add more tests for CcCopyWrite
2020-12-08 11:48:00 +01:00
Victor Perevertkin
016dc28793
[NTOS:CONFIG] Release the lock in a failure case in CmLoadKey
...
This is a workaround, the real issue is still not resolved
CORE-17263
2020-12-08 13:44:27 +03:00
Victor Perevertkin
da1f4ed6af
[SCSIPORT] Fix setting the "Driver" field in the DeviceMap\Scsi registry key
2020-12-08 01:32:15 +03:00
Eric Kohl
d9e20ae3fe
Implement the StorageCoInstaller and configure it for CD-ROM and Disk devices
...
This sets the friendly name for CD-ROM and Disk devices.
2020-12-07 23:17:29 +01:00
Hermès Bélusca-Maïto
3d980c4a2c
[NTOS:FSTUB] Addendum to 29615fee
and 8d2fe541: Further remove useless casts.
...
Also, fix the MBR checksum calculation (missing ~CheckSum + 1), to fix
the calculation in accordance with how MS calculates the MBR checksums
(and what we do as well in
https://github.com/reactos/reactos/blob/master/base/setup/lib/utils/partlist.c#L1581
https://github.com/reactos/reactos/blob/master/boot/freeldr/freeldr/arch/i386/hwdisk.c#L291
).
2020-12-07 22:52:42 +01:00
Hermès Bélusca-Maïto
fd053237cb
[NTOS:FSTUB] Minor formatting; put the PAGED_CODE() macros in evidence (instead of being lost in the declarations).
2020-12-07 22:51:15 +01:00
Victor Perevertkin
29615feeb6
[FSTUB] Fix bugs from 8d2fe54188
...
The buffer is now PUCHAR or PVOID everywhere
2020-12-07 19:50:51 +03:00
Victor Perevertkin
8d2fe54188
[FSTUB] Fix out of bounds access in IoReadDiskSignature
...
- Convert PARTITION_TABLE_OFFSET to the number of bytes instead of
(number of bytes) / 2. This avoids many confusing casts
- Use a cache aligned buffer for MBR
2020-12-07 14:43:34 +03:00
Jérôme Gardou
5d4ece342c
[CMAKE] Add a NO_REACTOS_BUILDNO option
...
This allows to not generate buildno.h and version.h after each commit and trigger the relinking of the complete module list
2020-12-07 11:32:37 +01:00
Hermès Bélusca-Maïto
7ae3d530db
[PSDK] Re-arrange DISK/DRIVE/PARTITION layout-related structures in ntdddisk.h and winioctl.h. Add few missing structures in winioctl.h.
2020-12-06 23:44:10 +01:00
Victor Perevertkin
39c48a4d91
[USBSTOR] Remove workarounds for old storage stack
2020-12-06 23:32:29 +03:00
Victor Perevertkin
aa05649902
[SETUPAPI] Do not use strlen on buffers which may possibly contain REG_MULTI_SZ
...
CORE-14187
2020-12-06 19:49:57 +03:00
Victor Perevertkin
ff13301eb2
[UMPNPMGR] Set the data type in all cases of PNP_GetDeviceRegProp
...
CORE-14187
2020-12-06 19:48:38 +03:00
Victor Perevertkin
2d6c6fa38d
[PARTMGR] Register a disk interface for disk PDO
...
CORE-14187
2020-12-06 19:47:15 +03:00
Timo Kreuzer
883ae6d93b
[RTL] Fix RtlImageDirectoryEntryToData to support both 32 and 64 bit images
2020-12-06 16:37:57 +01:00
Eric Kohl
cac7b003c0
Implement IRP_MN_QUERY_DEVICE_TEXT.DeviceTextLocationInformation
2020-12-06 12:42:50 +01:00
Victor Perevertkin
f722be93d5
[USBSTOR] Enable USB (ATAPI) cdroms
...
With the cdrom_new driver, they now work
CORE-16112
2020-12-06 02:08:32 +03:00
Victor Perevertkin
cbe88e287f
[USBSTOR][SCSIPORT] Use STORAGE_ADAPTER_DESCRIPTOR from WIN8
...
This way, these drivers are more compatible with classpnp and cdrom used
by ReactOS (and don't fire asserts)
2020-12-06 01:57:56 +03:00
Victor Perevertkin
139e8f5308
[BOOTDATA] Fix boot (addendum to dd56e065bc
)
...
- GenCdRom is actually required now to be in CDDB
- Forgot to add partmgr registry keys
CORE-6264
2020-12-06 01:55:20 +03:00
Victor Perevertkin
dd56e065bc
[REACTOS] Enable PnP storage stack
...
- Use PnP storage class drivers
- Make partmgr an upper filter driver for Disk class
- Fill upper filters in txtsetup and usetup/devinst
- Add cdrom driver to the critical device database
CORE-6264
2020-12-05 22:30:43 +03:00
Victor Perevertkin
fb155b4ea4
[SCSIPORT] Fix Sense request sending
...
- Pass all SRB flags which Windows scsiport passes
- Correctly reset the queue after completion
This fixes the bug when MS cdrom driver hangs after media ejection
2020-12-05 22:28:54 +03:00
Victor Perevertkin
a97c6e0aa9
[SCSIPORT] Make the driver PnP-aware
...
Basic functions are implemented in order to work in PnP stack,
only legacy (non-pnp) miniport drivers are supported.
Tested mostly with uniata
CORE-17132
2020-12-05 22:28:54 +03:00
Victor Perevertkin
582ca68696
[NTOS:PNP] Improve and refactor PnP notifications
...
- BUGFIX: do not call IoGetRelatedTargetDevice while guarded mutex is acquired
(the function issues an APC, but they are disabled inside a critical section)
- BUGFIX: only the beginning of a structure for GUID_PNP_CUSTOM_NOTIFICATION was copied and queued.
Just pass it as-is to a subscriber, without copying
- Don't convert event GUID to string, store and compare GUID struct itself
- Split IopNotifyPlugPlayNotification into 3 functions for each type of notification
(less stack usage and for future changes)
- Move initialization code for notifications into a separate routine
- Use separate lists and locks for every type of notification
- Put "TargetDeviceChange" notifications into their place inside DEVICE_NODE
2020-12-05 22:25:40 +03:00
Victor Perevertkin
e3198fb644
[NTOS:PNP] Check if APCs are enabled before waiting inside IopSynchronousCall
2020-12-05 22:25:39 +03:00
Victor Perevertkin
9eafb2971f
[NTOS:CONFIG] Comment out the assertion until fixed
...
CORE-17263
2020-12-05 22:17:08 +03:00
Victor Perevertkin
15a7b9dd2f
[CLASSPNP][CDROM_NEW][DISK_NEW] Fix clang build
...
CORE-17129
2020-12-05 22:15:29 +03:00
Victor Perevertkin
fe1b98fc36
[CLASSPNP] Fix amd64 build
...
CORE-17129
2020-12-05 22:15:10 +03:00
Victor Perevertkin
eb682bbfab
[DISK_NEW] Various small fixes
...
- Silence a (possibly wrong) assert in DiskShutdownFlush
- Fix build with GCC and MSVC amd64
CORE-17129
2020-12-05 22:14:50 +03:00
Mark Jansen
e1523dd28e
[NTDLL_APITEST] Add test showing that RtlImageDirectoryEntryToData works on 32-bit and 64-bit images
2020-12-05 17:03:24 +01:00
Victor Perevertkin
99f16dc8a7
[STORAHCI] Do not put the driver onto cd
...
Meanwhile, fix add_registry_inf usage (it is really a driver inf)
2020-12-05 18:06:42 +03:00
Victor Perevertkin
16e5ce8fb1
[CMAKE] Use C_STANDARD property instead of command line option
...
Addendum to 64211aa696
and 19779b3f96
2020-12-05 15:35:06 +03:00
Jérôme Gardou
0db79d4aa9
[NTOSKRNL:FSRTL] Fix memory corruption when pruning tunnel cache
2020-12-04 16:08:14 +01:00
Jérôme Gardou
3ec3e1a7f6
[BTRFS] Fix wrong condition check
2020-12-04 15:49:39 +01:00