Remove extra \r put by hand in some console output functions, so that we use there only \n.
But modify the ConWrite function so that, if we redirect output to something else than a console
(e.g. redirect to a file or to a serial console via ... > AUX), newline characters \n get converted
into \r\n automatically.
What you get, for instance, is: https://imageshack.com/a/img853/5834/l34.png
svn path=/trunk/; revision=59411
Fix the default input & output console modes. Now, you can use the command interpreter via serial port redirection, by:
1- Enabling a serial port on the machine on which ReactOS runs.
2- Launching:
cmd > AUX
at a command prompt.
svn path=/trunk/; revision=59405
Add a helper function which checks whether we are going to output text to a console handle or to a file handle.
Use it in ConWrite and in ConPrintfPaging.
svn path=/trunk/; revision=59401
- Remove erratic tabs in language files.
- Add the fact that one can use the "help" command with: "help command" to obtain help for "command".
svn path=/trunk/; revision=59391
And finally...
...
... fix whitespace, part 6/6 !!!! (convert tabs into 4-space indent).
Really, CMD is, together with win32k, the worst indented project I've ever seen.
You have lots of non-sensical extra newlines put in the middle of the code,
weird indentation made by a mix of tabs / spaces which take either 4 or 8 or even (!!)
2 spaces per indentation level; sometimes some guy mixed his space key with his tab key
to add a space between a word and another one; a mix of some sh*tty code styles (K&R and personal ones),
many many times no space between a logical keyword and the operand on which it applies, etc... etc...
I tried to put some sense in it, but I may have forgotten some insidious tabs somewhere...
svn path=/trunk/; revision=59389
- Fix MSVC version detection in configure.cmd
CORE-7337 #comment VS12 is not supported by CMake yet. With r59381, configure should at least give you a proper error message.
svn path=/trunk/; revision=59381
- Don't intentionally break on MSVC. I'm too lazy to change all of these to __REACTOS__, and it's a hack anyway...
CORE-7335
svn path=/trunk/; revision=59380
Correct some definitions (checked against official DDK). Fix also FSCTL_SET_SPARSE.
CORE-7333 #resolve #comment Fixed in revision r59376, thanks.
svn path=/trunk/; revision=59376
Fix extended and control characters handling in text-boxes. We don't show anymore strange characters when pressing on, e.g. up or down arrows anymore.
Also, fix uppercase 'o' character (which has the same scan code but is not an extended key, as the End key).
The culprit revision which introduced this bug is r58658.
CORE-7323 #resolve #comment The uppercase 'o' problem is fixed in revision r59373. Thanks for your report :)
svn path=/trunk/; revision=59373
Fix tree-view's image-list handle leakage when application quits.
Loosely based on a patch by Edijs Kolesnicovičs and Grégory Macário Harbs
NOTE: Always cleanup / destroy (or, try to) things in the reverse way they are created / initialized (i.e. in a symmetrical way). Therefore, destry the associated tree-view's image-list in the DestroyTreeView function, which is the opposite of CreateTreeView (which calls InitTreeViewImageLists). The same mechanism is already used by the list-view. For completeness, add a parameter to the DestroyTreeView function (a handle to a tree-view) so that we can pass to it the global tree-view's handle (see what's done in WM_DESTROY message handling in ChildWndProc).
CORE-6856 #resolve #comment Should be fixed in revision r59371. See the commit log for more details. Thanks :)
svn path=/trunk/; revision=59371
- Use UNICODE markers for characters (the L'.' symbol for example) (i.e. fix code originating from Wine).
- Accept NULL Path/FileName in RtlDosSearchPath_U (fixes some ntdll_apitest tests, see after).
Fixes for RtlGetFullPathName_Ustr:
==================================
- Rework RtlGetFullPathName_Ustr by "reusing" little parts of the code of our old RtlGetFullPathName_U coming from Wine (and then make RtlGetFullPathName_U call RtlGetFullPathName_Ustr instead).
- Include the get_full_path_helper code into RtlGetFullPathName_Ustr and NT'ify it, and fix it too:
* Fix skipping trailing path separators (slashes / backslashes) at the end of pathes.
* Zero-out the destination buffer
* Fix retrieving the "Short Name" (ie. the file name) out from the given full path name.
* Fix remaining UNC path handling (ie. correctly remove trailing points, spaces, in UNC paths).
They fix the following tests:
* kernel32:FindFiles (6 failures to full success)
* ntdll:RtlDosPathNameToNtPathName_U (4 failures to full success)
* ntdll:RtlDosSearchPath_U (6 failures to full success)
* ntdll:RtlGetFullPathName_U (8 failures down to 2 failures because we don't correctly NULLify the user buffer when trimming unneeded chars)
* ntdll:RtlGetFullPathName_UstrEx (6 failures down to 2 failures for the same reasons as the previous test)
To Do: Finish to NT'ify the code originated from Wine, fix NULLification of the user buffer (when trimming unneeded characters), and "clean" the code ie. remove extra DPRINTs and added FIXMEs and NOTEs comments.
svn path=/trunk/; revision=59366
Return STATUS_OBJECT_NAME_INVALID instead of STATUS_BAD_NETWORK_PATH, fixes some tests (kernel32:FindFiles in particular).
svn path=/trunk/; revision=59364
