Commit graph

70244 commits

Author SHA1 Message Date
Pierre Schweitzer
9f3c80193e
[FASTFAT] Don't mix FileNameInformation and FileNamesInformation (and support the later).
This commit fixes weird behavior in our FastFAT implementation. It was mixing two classes:
FileNameInformation and FileNamesInformation. It was handling FileNameInformation like
FileNamesInformation and was filling buffer with FILE_NAMES_INFORMATION structure instead
of FILE_NAME_INFORMATION structure (how many things did that break?!).
Also, it wasn't implementing the FileNamesInformation class at all. This is required by
ntdll_winetest:directory which doesn't expect it to fail and thus, attempts to read
never filled in memory.

This commit fixes the winetest crash, and may fix other weird FS behavior.

CORE-13367
2017-12-09 12:37:34 +01:00
Amine Khaldi
d086a431cb [SAMLIB] Use precomp.h in dllmain.c. 2017-12-09 12:32:34 +01:00
Mark Jansen
4ac511405f [SHELL32_APITEST] Add test for SHCreateFileExtractIconW
CORE-14082
2017-12-09 11:56:42 +01:00
Pierre Schweitzer
4fcaf92ec3
[KERNEL32] Silent a noisy DPRINT1 2017-12-09 11:54:18 +01:00
Katayama Hirofumi MZ
ea4daf8b68 [WIN32K] Fix NtGdiGetTextFaceW to report face name correctly (#173)
Initialize TEXTOBJ.FaceName member in TextIntRealizeFont and use it in NtGdiGetTextFaceW 
CORE-14071
2017-12-09 12:06:51 +02:00
Pierre Schweitzer
e95751ab78
[FASTFAT] Calculate more accurately buffer length in VfatGetAllInformation(). 2017-12-09 10:59:37 +01:00
Pierre Schweitzer
52f0726817
[FASTFAT] Allow partial returns on directory info query for first entry.
This mimics what MS FastFAT does and fixes (a bit) ntdll_winetest:directory.
It still crashes, but go farther.

CORE-13367
2017-12-09 10:58:19 +01:00
Amine Khaldi
e15874b491 [STOBJECT] Improve the existing PCH and make use of it. 2017-12-08 23:15:31 +01:00
Amine Khaldi
6429bfcd8f [CONSRV] Deduplicate GetScreenBufferSizeUnits(), SmallRectToRect() and ConsoleInput. Rename ConsoleList and InsertConsole(). #179 2017-12-08 23:04:48 +01:00
Pierre Schweitzer
9d91a2e8ce
[SERVICES] Fix querying the status of a registered but not started driver.
The current implementation was broken and some dead code was never called; always failing before.
This fix revives this dead code!
Extra fix: avoid derefencing potential null-ptr.
And also, as bonus, comment the function so that logic can be easily understood.

CORE-14062
2017-12-08 22:48:20 +01:00
Thomas Faber
81532227b6
[NTOS:MM] Implement and use MiAcquirePfnLockAtDpcLevel/MiReleasePfnLockFromDpcLevel. 2017-12-08 10:32:22 +01:00
Thomas Faber
da5949280c
[NTOS:MM] Use inline functions to acquire/release the PFN lock. 2017-12-08 10:32:08 +01:00
Serge Gautherie
a11841c939
[NTDLL_APITEST] Create Test_NtFreeVirtualMemory_Parameters(). CORE-13126
- Test 4th parameter ("ULONG FreeType") invalid values.
2017-12-08 09:47:44 +01:00
Thomas Faber
4aabe88288
[NTDLL_APITEST] Add license header for NtFreeVirtualMemory.c 2017-12-08 09:47:42 +01:00
James Tabor
c45a6e15bf [User32|IMM32] Fix a recursion crash in IMM. See CORE-14041.
Required a sync port from wine. This is a hack fix with Win32SS until
proper IMM support is added to Win32SS.
2017-12-07 21:14:21 -06:00
Amine Khaldi
9b349f958c [ADVAPI32_APITEST][NTDLL_APITEST][WINDOWSCODECS] Comment out some unused functions and types. Silences some clang-cl warnings. 2017-12-08 00:22:05 +01:00
Amine Khaldi
ccd5377851 [COMCTL32][FLTLIB][NETAPI32][SNDVOL32][STOBJECT][WBEMPROX] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-08 00:06:13 +01:00
Amine Khaldi
e83592920b [SHELL32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-07 23:54:22 +01:00
Amine Khaldi
7ed4c1dd03 [ADVAPI32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings. 2017-12-07 23:34:28 +01:00
Amine Khaldi
5633423086 [FREETYPE][PORTCLS][RPCSS][SPOOLSV][STLPORT][USETUP][WLANSVC] Silence some clang-cl warnings. 2017-12-07 23:26:59 +01:00
Amine Khaldi
9f85ef6712 [CMAKE/CLANG-CL] Don't pass /TP twice when we're dealing with a clang-cl c++ PCH. Pass -nostdinc instead of /X on clang-cl builds. 2017-12-07 23:22:48 +01:00
CNAmira
43e1d6f177 [TRANSLATION] Update Simplified Chinese translations. (#170)
- Add Simplified Chinese translation for EVENTCREATE.
- Update translations for 'dxdiag', 'fontview', 'magnify', 'mmc', 'rapps' and 'wordpad'.
Patch by Li Keqing.
2017-12-07 22:53:48 +01:00
Amine Khaldi
917b74b0dc [USER32] We're still using this one. Fixes build. 2017-12-07 22:37:40 +01:00
Giannis Adamopoulos
d163627319 [BROWSEUI] Move _ILIsDesktop to a shared header to avoid having 3 instances of it 2017-12-07 23:26:30 +02:00
Amine Khaldi
9443165625 [USER32] Remove unused debug channels. Silences some clang-cl warnings. 2017-12-07 22:25:30 +01:00
Hermès Bélusca-Maïto
49db8dc2a2
[CMD] Fix resource string (unrecognized escape sequence); addendum to 9a59558. 2017-12-07 22:08:54 +01:00
Amine Khaldi
00124d1b1a [CMAKE/CLANG-CL] Silence some clang-cl warnings in consistency with our gcc build. 2017-12-07 21:53:45 +01:00
Serge Gautherie
6fe9441d32
[NTDLL_APITEST] Allow the test to load on Windows XP. ROSTESTS-293 2017-12-07 09:54:53 +01:00
Ged Murphy
d73a72c21d
[SERVMAN] Fix return check on PropSheet_IsDialogMessage.
Should fix the regression introduced in the last commit.
CORE-14068
2017-12-06 22:08:46 +00:00
Luo Yufan
069546f5a4 Update Simplified Chinese translation. 2017-12-06 16:30:17 +01:00
Alexander Shaposhnikov
3ad4791796
[README] Update to 0.4.7 2017-12-06 11:23:49 +02:00
Pierre Schweitzer
c473b1a4d6
[NTOSKRNL] Only activate dumper in DBG builds 2017-12-05 23:28:04 +01:00
Pierre Schweitzer
149e1a2610
[NTOSKRNL] Add a non paged memory dumper in case of low memory situation.
Its purpose is to dump the non paged consumption, tag by tag,
to allow tracking potential faulting driver in case ReactOS starts lacking memory.
This will look like what !poolused outputs, even though it doesn't deal with paged pool.

Thanks to Thomas for his kind review and improvement suggestions.

CORE-14048
2017-12-05 23:19:11 +01:00
Ged Murphy
e36b89addb
[SERVMAN]
- Avoid a potential race whereby the current service selection can change before the propsheet thread starts up
- Cleanup the depends data, it doesn't need to be passed around the propsheet
2017-12-05 22:13:02 +00:00
Pierre Schweitzer
4296826c58
[VCDCLI] Add support for UDF/Joliet hidding.
By providing /u or /j switch on mount, the virtual CD-ROM class driver
will break the associated signatures on read so that FSDs cannot recognize them any longer.
2017-12-05 21:41:05 +01:00
Ged Murphy
ceb1e0b9ff
[Servman] Make the property sheets modeless so users can open multiple services at the same time (#166)
[SERVMAN]
- Make the property sheets modeless so users can open multiple services at the same time
- Untested in ros. In fact we have no code or tests cases to check that modeless property sheets work, so please raise a bug if you find any issues with the app.
- Dedicated to reactosfanboy
2017-12-05 12:25:14 +00:00
Stanislav Motylkov
df88fcf5cc [SHELL32_APITEST] SHParseDisplayName: More tests for relative paths 2017-12-05 10:48:37 +02:00
Stanislav Motylkov
53edadb8c0 [BROWSEUI] SHExplorerParseCmdLine: Improve relative path handling
CORE-12882, CORE-13847
2017-12-05 10:48:37 +02:00
Stanislav Motylkov
5dade73072 [BROWSEUI_APITEST] Improve tests for relative paths 2017-12-05 10:48:37 +02:00
Serge Gautherie
57aa1f1fc6
[SHELL32] shellpath.c: it is _WIN32_WINNT, not WIN32_WINNT. We even need to use __REACTOS__ instead here. CORE-12580 2017-12-03 21:52:37 +01:00
Amine Khaldi
b8309397b5 [AFD] Introduce and use pool tags. Thanks go to Arty for assisting me with this. CORE-14048 2017-12-03 21:52:15 +01:00
Stanislav Motylkov
a2cc76af84 [IPHLPAPI] Implement interface name resolving functions
Including:
- NhGetInterfaceNameFromDeviceGuid
- NhGetInterfaceNameFromGuid

CORE-13831, CORE-14033

Reference:
https://github.com/boundary/wireshark/blob/master/capture_win_ifnames.c#L275
2017-12-03 21:08:31 +01:00
Stanislav Motylkov
d6e0c422e1 [IPHLPAPI_APITEST] Add tests for interface resolving functions
CORE-13831, CORE-14033
2017-12-03 21:08:31 +01:00
Pierre Schweitzer
581f32b8c2
[VCDCLI] Implement a tool that allows managing vcdrom class driver.
It allows you managing virtual drives, mounting images, ejecting images, and so on.

It will load the driver when required.

It's less features complete that the MS GUI implementation.
I'll implement them later on, it can be quickly done.
What's missing: UDF/Joliet suppr and persistent mounts
2017-12-03 18:17:57 +01:00
Pierre Schweitzer
6906e184bb
[VCDROM] Implement the virtual CD-ROM class driver.
It was provided by MS as a separate package to download for Windows (up to 7).
That class driver allows creating virtual drives on which we can later mount ISOs images.
It's rather basic, but does the job.

To use it, you can use the GUI app from Microsoft (Virtual CD-ROM Control Panel)
or the vcdcli in CLI. We're compatible :-).

Note that it's not loaded at boot, you need to manually start it, to lower memory footprint.
Both applications will handle this for you.
2017-12-03 18:17:45 +01:00
Pierre Schweitzer
63d46228b8
[PSDK] Define the IOCTL_CDROM_EJECT_MEDIA IOCTL 2017-12-03 18:17:28 +01:00
Hermès Bélusca-Maïto
f79d268ea1
[CMD] Fix the del /s command, reported by Pablo De Napoli. CORE-10460
The command should delete files in the specified directory and all of its
sub-directories, using any file pattern specified.

For example, the command:

    del /S .\my_directory

should delete all the files inside my_directory and its sub-directories,
and as such should also detect that "my_directory" is indeed a directory,
while doing:

    del /S .\my_file

should of course detect that "my_file" is indeed a file pattern, and thus,
delete all "my_file" files from the current directory and its sub-directories.

The command:

    del /S some_directory\file_pattern

should delete "file_pattern" files from some_directory and its sub-directories.
2017-12-03 16:01:44 +01:00
Hermès Bélusca-Maïto
9a59558307
[CMD] Fix the presentation of some confirmation prompts. 2017-12-03 15:58:53 +01:00
Amine Khaldi
c39b0fc667 [USER32_APITEST] Add a PCH. 2017-12-02 22:18:06 +01:00
Amine Khaldi
283bbe7346 [NTDLL_APITEST] Add a PCH. 2017-12-02 22:15:04 +01:00