Commit graph

885 commits

Author SHA1 Message Date
Joachim Henze
9ab700eb9f [0.4.11][COMCTL32] Address regression CORE-14622
"Avira Antivir Personal 6.35.00.243" had issues painting its
setup wizard dialog with correct background color.
That part was a regression of SVN r74136 == git
b1b42795a9

and also did not draw its umbrella bmp, which did never work
in ros up to now afaik.

https://reactos.org/testman/compare.php?ids=69394,69478 VBOX
https://reactos.org/testman/compare.php?ids=69395,69479 KVM

Thanks to patches author Doug Lyons and HBelusca.

Wine has been reported to be affected by that bug as well:
https://bugs.winehq.org/show_bug.cgi?id=46636
Not sure whether our patch will be accepted by Wine,
to my naive eye this looks like an interim solution.

fix picked from commit 0.4.14-dev-107-g
f2f833c53c
2020-11-13 00:47:55 +01:00
Katayama Hirofumi MZ
c17c0326ff [0.4.11][SHELL32] Fix SHFileOperation Move operation (#1487)
Reduce failures of Move operation of shell32!SHFileOperation function. CORE-13450

And also fixes regression CORE-13176 "Drag and drop with multiple files is broken"
which regressed by SVN r74380 == git
fd91fe3337

fix picked from commit 0.4.12-dev-1080-g
c65156002c
2020-11-09 13:06:32 +01:00
Joachim Henze
6bdb308df1 [0.4.11][COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147

But greatly eliminates perceived flickering when hovering
with the mouse over buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de7

CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476

The comctl32 part of the fix was picked from 0.4.13-dev-1194-g
a40331b0f4
2020-10-31 20:16:05 +01:00
Joachim Henze
97ab52a4ce [0.4.11] Revert "[COMCTL32] button: Don't erase the area of the checkbox or the text."
This reverts last commit 0.4.11-RC-28-g
fc9e7ba7ea.

Okay, I changed my mind:
fc9e7ba7ea fixed the flickering for the text,
but would leave the flickering existant for the selection rectangle and also
for the checkmarks/radio-button-circle.
On its own it would only half-fix CORE-13278 therefore.
More problematic is that it would introduce a new regression CORE-15595.

I revert it because I do not want to transform 1 regression into 1,5regressions.
Test-results are easier to maintain with that conservative approach.
Seems we have to endure the flickering for another release :-(
2019-01-14 01:37:56 +01:00
Giannis Adamopoulos
fc9e7ba7ea [0.4.11] [COMCTL32] button: Don't erase the area of the checkbox or the text.
Attempt to fix the menace of the world, CORE-13278.
Note that this can also cause visual glitches for classic check boxes or
radio buttons.

This commit does not fix the flickering to 100%, but it does greatly reduce it.
I will watch out during release tests, whether anything is negatively impacted,
and if yes, I might withdraw the patch. Up to now I did not spot any problems.

cherry picked from commit 0.4.12-dev-347-g
75a80ec823
2019-01-13 19:11:41 +01:00
Joachim Henze
ff0886db4b [0.4.11] [GDIPLUS] Fix a regression painting gradient CORE-15479
patch is import of Wine commit 0937186f7d15fed60f77fa2014d650f4d0b6b20b
by Nikolay Sivov

cherry picked from commit 0.4.12-dev-360-g
daadcc6141
2019-01-13 17:24:21 +01:00
Mark Jansen
2522ec1b06 [0.4.11] [OLE32] Apply the proper Wine fix for CORE-14696
Don't free handles that are just copied in the inproc case.

This imports wine commit 25b136d40080a80c006b89e02708d2e248504a42,
by Huw Davies and Zebediah Figura

cherry picked from commit 0.4.12-dev-96-g
959994b67c
2018-12-17 22:25:15 +01:00
Joachim Henze
b93990e7fb [0.4.11] [SHELL32] Revert the sraboy workaround CORE-14696
This reverts the workaround of 0.4.11-RC-2-g
7e9c37c58f
Because we got a proper ole32-fix from Wine that I will apply in next commit.
2018-12-17 22:22:16 +01:00
Joachim Henze
231daa48f7 [0.4.11] [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again
CORE-15412

addendum to 0.4.10-dev-502-g
d559ca9c98

That copy-paste was done once intentionally to keep our imports similar to 2003.
It's worth reading the conversation in PR #748: Getequ seems to be ok with this.

The ideal solution most likely would be to instead *statically*
link against RegLoadMUIStringW() from advapi32_vista when WINNT=0x502.
For now the stuff runs again at least.
I left the func existing in advapi32_vista.dll.

cherry picked from commit 0.4.12-dev-99-g
6f8cb05cad
2018-12-17 22:06:17 +01:00
Joachim Henze
7fd1b51e8d [0.4.11] [BROWSEUI] Workaround regression CORE-15429 'unintended scrollbars'
Thanks to Doug Lyons for providing a temporary workaround quickly.
2018-12-17 20:11:12 +01:00
Katayama Hirofumi MZ
00a1f2214f [0.4.11] [SHELL32] 'Run' dialog box should accept URL (#1153)
Fix ShellExecCmdLine function. CORE-15455, CORE-11772
CORE-11772 mentioned it was a regression.

cherry picked from commit 0.4.12-dev-93-g
c94ca8128d
2018-12-17 18:59:50 +01:00
Joachim Henze
b906163dc1 [0.4.11] [COMCTL32] Fix regression CORE-14671 & CORE-14701
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).

Thanks to patches author Doug Lyons.

The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.

like in last release
(cherry picked from commit 9d758ae1cd)
2018-12-16 23:28:35 +01:00
Katayama Hirofumi MZ
29f9c0433f [0.4.11] [SHELL32] Fix 'Run' dialog crash (#1117)
CORE-15431 (2 of 2)
Running "%SYSTEMROOT%" sometimes crashed. This will fix it.
cherry picked from commit 0.4.12-dev-36-g
472787ffea
2018-12-16 20:35:13 +01:00
Katayama Hirofumi MZ
5aea1c7118 [0.4.11] [SHELL32] Enable environment variables in 'Run' dialog (#1111)
CORE-15431 (1 of 2)
cherry picked from commit 0.4.12-dev-19-g
06d717e3bc
2018-12-16 20:34:22 +01:00
Joachim Henze
a36ed7afc6 [0.4.11] [WINHTTP] Sledge-Hammer-Revert to SVN r75943 to fix regression CORE-13952
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 32.0.0.1 to download.
(I was able to watch a flash video in Opera 12.18 afterwards, before I was not)

same procedure as last releases
2018-12-09 19:14:38 +01:00
Joachim Henze
2fc468303c [0.4.11] [USP10] Apply unfinished patch to avoid CORE-14226
Thomas linked the patch in Wine Bug 44410
A very well-working patch, that I used to apply to every release since 0.4.8.
It avoids text rendering regressions in some setups like UltraISO
The bug is very wide-spread in unaddressed master.

like in last release
(cherry picked from commit 937c2615e6)
2018-12-09 18:30:30 +01:00
Joachim Henze
7e9c37c58f [0.4.11] [SHELL32] Avoid regression CORE-14696
"It was not longer possible to delete any file or folder via context menu"

By applying the workaround from Doug Lyons and sraboy, slightly adapted.
2018-12-09 18:02:29 +01:00
Eric Kohl
b9d4e2dae6 [USERENV] Move some functions around to make it look nicer. No code changes. 2018-12-08 16:41:17 +01:00
Pierre Schweitzer
e02f3356b1
[MPR] Sync with Wine Staging 3.17. CORE-15127 2018-12-08 11:42:23 +01:00
Pierre Schweitzer
bcad6700ec
[MPR] Import Wine commit: 773ff2e83b0547540639c6d4aeb9f817b621fb2f
Implement support for deleting persistent connections.
2018-12-06 22:44:43 +01:00
Pierre Schweitzer
3e8ec64489
[MPR] Import Wine commit: 23a232fce8899a24e76207518175235b7b0f00cd
Implement support for making connections persistent.
2018-12-06 22:42:46 +01:00
Luo Yufan
93ac724b47 [TRANSLATION] Update Simplified Chinese translation. (#1099)
Update Simplified Chinese translation for BROWSEUI, INETCPL and SYSDM.
2018-12-06 14:52:38 +01:00
Luo Yufan
39a478d17b [TRANSLATION] Update Simplified Chinese translation. (#1096) 2018-12-05 16:50:05 +01:00
Pierre Schweitzer
9c2a264d77
[MPR] Import Wine commit: 9988bb5e0729178b527052803d3ad670e5e0b46e
Implement remembered connection enumeration.

CORE-15310
2018-12-05 08:47:25 +01:00
Luo Yufan
07b120bd56 [TRANSLATION] Update Simplified Chinese translation. (#1094) 2018-12-04 17:13:39 +01:00
Eric Kohl
2037bab6c4 [SETUPAPI] GetDeviceInstanceKeyPath: Trying to open the hardware key opens the software key and vice versa. Fix it by swapping the code paths. 2018-12-03 22:03:38 +01:00
Mark Jansen
faddd38b36
[KERNEL32] Revert d897e27, which would re-initialized a list.
Spotted by Andrew Boyarshin.
2018-12-03 20:48:14 +01:00
Luo Yufan
6a506156a8 [MSGINA] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Luo Yufan
5066ee4606 [IEFRAME] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Luo Yufan
a9f634b5fe [SHELL32] Update Simplified Chinese translation. 2018-12-03 12:52:11 +01:00
Katayama Hirofumi MZ
cbd52e30d7
[SHELL32] Don't show taskbar button of Folder Options (#1091)
CORE-10481
2018-12-03 13:38:09 +09:00
Katayama Hirofumi MZ
c1eb420a91
careless s/E_FAIL/FALSE/ (#1089) 2018-12-03 05:43:21 +09:00
Katayama Hirofumi MZ
623b2e153e
[SHELL32] Follow up of #1085 (#1088)
CORE-10481
2018-12-03 05:38:36 +09:00
Katayama Hirofumi MZ
ecd51d99f4
[SHELL32] Don't show taskbar button of file property sheet (#1085)
CORE-10481
2018-12-03 04:25:46 +09:00
Eric Kohl
3f570f3369 [SETUPAPI] Implement SetupGetNonInteractiveMode() and SetupSetNonInteractiveMode(). 2018-12-02 14:10:25 +01:00
Pierre Schweitzer
81aa879c13
[IPHLPAPI] Implement GetOwnerModuleFromUdpEntry() 2018-12-01 14:49:38 +01:00
Joachim Henze
3050d93deb [BROWSEUI] Properly fix CORE-13003 "Explorer address bar display problem"
The patches author is Doug Lyons. Thank you very much!
The patch is an addendum to 0.4.9-dev-732-g
ea0cc1c783
2018-12-01 14:26:33 +01:00
Hermès Bélusca-Maïto
95deef460b
[XOLEHLP] Import xolehlp.dll from Wine(-Staging) 3.21.
Should help improving the situation of the Microsoft SQL Server 2005
Express Edition installer. CORE-15399
2018-11-30 21:49:28 +01:00
Pierre Schweitzer
226195d4f2
[IPHLPAPI] Don't assume first member of MIB tables is always DWORD-big
This fixes last bits of heap corruption when using UDP/TCP enumeration
functions.
2018-11-30 20:06:29 +01:00
Pierre Schweitzer
bf052e120b
[IPHLPAPI] Reduce code duplication and use a single function for TCP and UDP enumerations
Furthermore, memory was improperly allocated before (alignment issues) leading to heap
corruption under certain circumstances
2018-11-30 20:06:29 +01:00
Pierre Schweitzer
3d2d957f81
[IPHLPAPI] Implement GetOwnerModuleFromTcpEntry()
CORE-4792
2018-11-29 20:36:08 +01:00
Pierre Schweitzer
f87c88f6fe
[IPHLPAPI] Implement the *_TABLE_OWNER_MODULE_* in GetExtendedTcp/UdpTable() functions
This fixes CurrPorts in ReactOS. It now properly displays current connections along
with their creation time.

CORE-10134
2018-11-27 23:12:57 +01:00
Pierre Schweitzer
159f5b676a
[IPHLPAPI] Fix broken size computation leading to buffer overrun 2018-11-27 23:12:57 +01:00
Pierre Schweitzer
559297fe81
[IPHLPAPI] Implement getOwnerModUdpTable() and getOwnerModTcpTable()
These allow to enumerate UDP and TCP connections with module information
2018-11-27 23:12:56 +01:00
Pierre Schweitzer
7ce2f09a70
[SDK] Add AllocateAndGetTcp/UdpEx/2TableFromStack() functions family 2018-11-27 21:36:47 +01:00
Giannis Adamopoulos
1d55f459d6 [SHELL32] CFSDropTarget: Fix right click menu when shown over the tree view. CORE-11240 2018-11-27 12:58:08 +02:00
Giannis Adamopoulos
62c33fbf69 [BROWSEUI] CShellBrowser: Don't pass any parameters to Initialize. Let users use the BrowseObject method instead. 2018-11-27 10:33:57 +02:00
Pierre Schweitzer
6d6e371225
[IPHLPAPI] Start handling certain flags in GetAdaptersAddresses()
For now, we only support the most useful ones: IP_ADAPTER_DDNS_ENABLED,
IP_ADAPTER_REGISTER_ADAPTER_SUFFIX, IP_ADAPTER_DHCP_ENABLED
2018-11-26 22:43:43 +01:00
Eric Kohl
57d48a7f1c [NETAPI32] Implement DsGetDcNameA/W --> DsGetDcNameWithAccountA/W --> DsrGetDcNameEx2. 2018-11-25 23:24:21 +01:00
Pierre Schweitzer
1a964b5139
[IPHLPAPI] In GetAdaptersAddresses(), return friendly name if asked for 2018-11-25 18:04:13 +01:00