Commit graph

69129 commits

Author SHA1 Message Date
Shriraj Sawant 93a5cfc0ef [STOBJECT]
-Added new battery icons and hotplug icons, thanks to Pi_User5.
-Modified resources for the same.
-Modified CSysTray to support icon hiding feature.
-Modified hotplug.cpp by adding experimental enumeration to test icon behavior.
-Icon behavior successfully tested.
-Added code to eject device, works fine.
-Fixed a bug which didn't showed attached devices after reloading. (like after system restart or explorer restart.)
-Now at least pen-drives are safely removable. (Still experimental though, use at your own risk ;P)
-Tested in winxp vm, needs further testing.

svn path=/branches/GSoC_2017/shellext/; revision=75497
2017-08-06 16:33:27 +00:00
Shriraj Sawant b421d735af [STOBJECT]
-Added hotplug.cpp for handling removable devices notification icon.
-Modified CMakeLists.txt et al to plugin this hotplug to stobject.
-Added basic code to test the hotplug icon and integrate it with stobject.
-Tested in xpvm, needs further testing.

svn path=/branches/GSoC_2017/shellext/; revision=75431
2017-07-28 17:33:38 +00:00
Shriraj Sawant d13b13ec76 [STOBJECT]
-Fixed bugs related to strings and localization (needs further improvement).
-Fixed ContextMenu Position bug (for both power and volume).
-Now battery tooltip is as dynamic as its icon.

svn path=/branches/GSoC_2017/shellext/; revision=75405
2017-07-25 21:48:51 +00:00
Shriraj Sawant 287232ea2f [STOBJECT]
-Added support for battery enumeration.
-Now battery status is available.
-Added icons and resources respectively for battery levels.
-Now battery changes its icons dynamically as per its quantized levels.

svn path=/branches/GSoC_2017/shellext/; revision=75367
2017-07-17 19:43:53 +00:00
Shriraj Sawant e0959b80b1 [QCKLNCH]
-Fixed a memory leak issue.
-Apparently Tested in xpvm.
-Needs further testing.

svn path=/branches/GSoC_2017/shellext/; revision=75299
2017-07-07 16:38:37 +00:00
Shriraj Sawant bbf1ae346a [QCKLNCH]
-Apparently fixed some memory leaks. 
-Removed unnecessary methods.
-Fixed a checkmark bug. :p
-And thus finished any remaining issues of CR-122.

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Please raise any other issues which you feel needs correction. I am waiting... ;D

svn path=/branches/GSoC_2017/shellext/; revision=75298
2017-07-07 16:13:47 +00:00
Shriraj Sawant fe273d3531 [QCKLNCH]
-Removed CWindowImpl
-Added CWindow
-Used OnWinEvent() instead of subclassing
-Handled WM_COMMAND and WM_NOTIFY as needed
-Now along with buttons chevron menu is also working

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Thank you everyone for spending your time and giving a thorough review. :)

svn path=/branches/GSoC_2017/shellext/; revision=75297
2017-07-07 14:53:11 +00:00
Shriraj Sawant c8c4bcfa52 [QCKLNCH]
-Added en-US.rc
-Localized Menu resource.
-Added a string table and localized some strings.
-Major fixes like removing IDeskBar.
-Minor suggestions fixed.

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Thank you everyone for spending your time and giving a thorough review. :)

svn path=/branches/GSoC_2017/shellext/; revision=75276
2017-07-04 18:37:00 +00:00
Shriraj Sawant 180321d87a [QCKLNCH]
-Refactors and some code fixes (like CComHeapPtr, IID_PPV_ARG, _countof, etc.).
-Minor suggestions fixed.

CR-122 (https://code.reactos.org/cru/CR-122#details)

SelfNote: Should check if CComHeapPtr is overused! ;p

svn path=/branches/GSoC_2017/shellext/; revision=75272
2017-07-03 15:36:00 +00:00
Shriraj Sawant 26958e704b [QCKLNCH]
-Whitespace fixes
-Minor suggestions fixed.
-Minor refactors and some code fixes.

CR-122 (https://code.reactos.org/cru/CR-122#details)

svn path=/branches/GSoC_2017/shellext/; revision=75260
2017-07-01 20:22:13 +00:00
Shriraj Sawant 8a98b9a578 [QCKLNCH]
-Implemented IContextMenu::InvokeCommand()
-Modified IContextMenu::QueryContextMenu() to support CheckMenuItem()
-Minor code cleanup
-Now Quick Launch Supports the 'show text' and 'view' options.
-Tested on xpvm and ros explorer locally on win10, but needs some thorough testing

svn path=/branches/GSoC_2017/shellext/; revision=75257
2017-07-01 18:34:33 +00:00
Giannis Adamopoulos 9e52604cad * Sync up to trunk HEAD (r75230).
svn path=/branches/GSoC_2017/shellext/; revision=75232
2017-06-29 14:12:11 +00:00
Shriraj Sawant 5809f6ada6 [QCKLNCH]
-Created menu resource in qcklnch.rc
-Added resource.h to manage menu resources and all.
-Added IContextMenu.
-Implemented QueryContextMenu and stubbed other methods.
-Handled WM_RBUTTONUP for folder context menus.
-Minor code corrections.
-Tested working of some menu functions in winXP VM, though further testing is required.

svn path=/branches/GSoC_2017/shellext/; revision=75231
2017-06-29 12:23:13 +00:00
Giannis Adamopoulos 7d2398b6af [BROWSEUI] -CBandSite: Remove the Close item menu if the band is undeletable. Remove the Show caption menu item if the band doesn't have a caption. Implement showing or hiding the band caption.
svn path=/trunk/; revision=75230
2017-06-29 09:41:00 +00:00
Thomas Faber 10dc514582 [PSDK]
- Add USB_HUB_CHANGE and USB_HUB_STATUS_AND_CHANGE

svn path=/trunk/; revision=75229
2017-06-29 08:09:44 +00:00
Amine Khaldi dc50f1da19 [USBHUB_NEW] Bring-in the USB Hub driver created by Vadim Galyant. GitHub PR #29. As usual, I thank the code reviewers, especially Thomas for contributing most of the reviews, improvements and fix suggestions.
svn path=/trunk/; revision=75227
2017-06-28 23:23:01 +00:00
Hermès Bélusca-Maïto 922e006ea6 [BOOTDATA]: Sprinkle few FLG_ADDREG_NOCLOBBER (0x00000002) flags for registry keys/values that need to remain the same across ReactOS upgrades. This also includes the "Session Manager\DOS Devices" as well as the "Session Manager\Environment" values!
Also, fix the default LastKnownGood value to the 'Current'/'Default' one. These values should also not be touched across upgrades (well, they can be touched manually by the (u)setup program, but they must not when updating the registry in bulk).

svn path=/trunk/; revision=75225
2017-06-28 22:17:53 +00:00
Hermès Bélusca-Maïto b44faa47ed [CMLIB]: Addendum to r63495: Fix the CmpCopyKeyValueList() helper to make it what it is supposed to do: copy the list of values of a given key: this means, also copying the values themselves!!
For that aim I also introduce a CmpCopyValue() helper that allows copying the value data of a given registry value, taking into account whether the value is "small", normal or "big" (we don't support "big values" yet). This function allocates and copies the necessary hive cells corresponding to the given value. Only then, we add a new entry into the registry key value list that is grown dynamically.
Cleanup is performed in case of failure.
Now we can export registry sub-trees as registry hives, and successfully re-mount them in the registry.
CORE-13476 CORE-8259 CORE-10793

svn path=/trunk/; revision=75222
2017-06-28 00:04:13 +00:00
Hermès Bélusca-Maïto 60dedbf232 [CMLIB]: Adjust the old-style parameter annotations for two functions.
svn path=/trunk/; revision=75221
2017-06-27 23:46:17 +00:00
Mark Jansen c959a66fb5 [SHIMDBG] Add option to dump file properties.
svn path=/trunk/; revision=75218
2017-06-27 20:27:31 +00:00
Mark Jansen 5e0896e8ab [APPWIZ] Enable the 'Cancel' button while downloading. Patch by Jared Smudde and 'thc'. CORE-9629
svn path=/trunk/; revision=75217
2017-06-27 20:09:53 +00:00
Giannis Adamopoulos 9e4da13034 [BROWSEUI] -CBandSite: Implement the context menu of the rebar. It queries the IContextMenu if the band and appends to it a static menu part that can show or hide the title and close the toolbar. Showing or hiding the title isn't implemented yet.
svn path=/trunk/; revision=75216
2017-06-27 10:05:59 +00:00
Colin Finck 20bbfa5624 [PRINTING]
Fix all EnumPrintProcessorDatatypes API tests.

svn path=/trunk/; revision=75215
2017-06-27 07:25:04 +00:00
Eric Kohl 26d220be5e [IDL]
Prevent duplicate declaration of NTSTATUS.

svn path=/trunk/; revision=75214
2017-06-26 22:58:26 +00:00
Eric Kohl 64b471340a [IDL]
Prevent duplicate declaration of STRING and PSTRING.

svn path=/trunk/; revision=75213
2017-06-26 22:52:40 +00:00
Eric Kohl 4c3c7daba6 [NETAPI32]
- Add netlogon RPC binding code.
- Implement NetGetAnyDCName. This function calls its counterpart in the netlogon service.

svn path=/trunk/; revision=75212
2017-06-26 22:08:37 +00:00
Pierre Schweitzer 0706d8cb47 [FASTFAT]
- Stop passing DO, directly pass VCB
- Try to compute some unique value as internal ID for objects. As MS, return the LBO

CORE-13489

svn path=/trunk/; revision=75210
2017-06-26 18:10:43 +00:00
Colin Finck ef0ae276af [NETAPI32_APITEST]
Fix GCC build

svn path=/trunk/; revision=75209
2017-06-26 15:43:58 +00:00
Colin Finck e5654cce9f [NETAPI32_APITEST]
Add a simple API Test for netapi32.dll, only covering DsRoleGetPrimaryDomainInformation so far.
It succeeds in ReactOS, but outputs a heap error in the debug log. In real world applications, this later leads to a heap assertion failure.

svn path=/trunk/; revision=75208
2017-06-26 15:19:07 +00:00
Colin Finck 1525fa31fc [PRINTING]
- Create the actual generic handle in _LocalOpenPrinterHandle.
- Fix _RpcClosePrinter call.
- Enable many more tests in winspool_apitest, GetPrinterData.
- Bail out with ERROR_INVALID_PARAMETER for empty strings in _MakePrinterSubKey as well.
- Add the Name registry value for "Dummy Printer on LPT1" to make a test succeed.

This fixes many basic things.. which only got unnoticed, because Printing is only used in the form of API Tests so far.

CORE-13458
CORE-13459

svn path=/trunk/; revision=75207
2017-06-26 15:16:46 +00:00
Colin Finck 2bd66111fc [ADVAPI32_APITEST]
Fix copy-paste mistakes in messages.

svn path=/trunk/; revision=75206
2017-06-26 15:10:27 +00:00
Mark Jansen 54d38174b1 [APPHELP_APITEST] Add tests for SdbGetMatchingExe, to test matching on version resources. CORE-13284
svn path=/trunk/; revision=75205
2017-06-26 14:58:08 +00:00
Mark Jansen a04fdc1e99 Missing functions
svn path=/trunk/; revision=75204
2017-06-26 12:50:46 +00:00
Mark Jansen 9102288ea4 Missing include
svn path=/trunk/; revision=75203
2017-06-26 12:47:08 +00:00
Mark Jansen 2ef285e193 [SDK][XML2SDB] Simplify helper functions, output Exe matches + file attributes
svn path=/trunk/; revision=75202
2017-06-26 12:45:01 +00:00
Mark Jansen 5c59bd330a [APPHELP_APITEST:db] Fix the test for Win10, use WCHAR for data paths
svn path=/trunk/; revision=75201
2017-06-26 10:26:57 +00:00
Shriraj Sawant 8c802b5ece [QCKLNCH]
-Added CWindowImpl for proper subclassing.
-Now buttons are alive \0/.
-Code Cleanup.

svn path=/branches/GSoC_2017/shellext/; revision=75198
2017-06-25 20:20:27 +00:00
Eric Kohl 41af86fadd [IDL]
Add the Netlogon service interface definition.

svn path=/trunk/; revision=75197
2017-06-25 13:14:06 +00:00
Eric Kohl 31f03442d0 [NETAPI32]
Implement I_BrowserrDebugTrace and I_BrowserServerEnum. This functions calls their counterpart in the computer browser service.

svn path=/trunk/; revision=75196
2017-06-25 12:14:35 +00:00
Pierre Schweitzer 81eba8d3e7 [RXCE]
- Implemented RxCompleteSrvOpenKeyAssociation(), RxInitiateSrvOpenKeyAssociation(), RxProcessChangeBufferingStateRequests()
- Implemented RxFinalizeFcbTable(), RxFinalizeNetFobx(), RxFinalizeNetRoot(), RxFinalizeSrvCall(), RxFinalizeVNetRoot(), RxFreeObject(), RxpDestroySrvCall(), RxRemovePrefixTableEntry(), RxRemoveVirtualNetRootFromNetRoot(), RxScavengeRelatedFobxs(), RxTearDownBufferingManager(), RxUndoScavengerFinalizationMarking()
- Implemented RxPostToWorkerThread()
- Implemented RxFlushFcbInSystemCache(), RxPurgeFcb(), RxPurgeFcbInSystemCache()
- Stubbed RxOrphanSrvOpens(), RxpDiscardChangeBufferingStateRequests(), RxpDispatchChangeBufferingStateRequests(), RxpProcessChangeBufferingStateRequests()
- Continued implementation of RxDereference() so that it supports more objects than just SRV_CALL
- Reworked RxInsertWorkQueueItem() implementation so that it accepts any work item, and not just dispatch work items
- Finished implementation of RxTableLookupName() so that it properly returns a V_NET_ROOT on NET_ROOT match

Notable effects of this commit are:
- RXCE/RDBSS leak less memory; now objects without references are properly deleted from the system
- This means that stale objects are also deleted; this fixes CORE-13483 were same stale SRV_CALL was used again and again
- Because in prefix table NET_ROOT are correctly handled, it's now possible to mount several path from the same prefix; this fixes CORE-13482

CORE-8204
CORE-11327
CORE-13482
CORE-13483

svn path=/trunk/; revision=75195
2017-06-25 11:55:37 +00:00
Thomas Faber db0b0e9ee3 [USBPORT]
- Fix setting the direction in USBPORT_OpenPipe. Patch by Vadim Galyant.

svn path=/trunk/; revision=75194
2017-06-25 08:17:33 +00:00
Sebastian Gasiorek 9cb674f17f - update EDD_DIRECTDRAW_LOCAL, EDD_SURFACE and EDD_DIRECTDRAW_GLOBAL structures
- initial implementation of DxDdCreateD3DBuffer and DxDdCreateSurfaceObject CORE-4490

svn path=/trunk/; revision=75189
2017-06-24 22:24:04 +00:00
David Quintana 292f51e33a [NTOBJSHEX]
Fix registration.

svn path=/trunk/; revision=75188
2017-06-24 22:01:46 +00:00
Eric Kohl debf556003 [NETAPI32]
Implement NetBrowserStatisticsGet().

svn path=/trunk/; revision=75187
2017-06-24 21:47:27 +00:00
Eric Kohl 6317bb3ec2 [NETAPI32]
Move the functions NetGetDCName, NetGetAnyDCName and NetEnumerateTrustedDomains into a separate file for the Netlogon service interface code.

svn path=/trunk/; revision=75186
2017-06-24 16:42:21 +00:00
Pierre Schweitzer 33b1caea25 [DXG]
Fix GCC build

svn path=/trunk/; revision=75185
2017-06-24 16:22:24 +00:00
Eric Kohl c05ad4799c [NETAPI32]
Implement I_BrowserQueryOtherDomains, I_BrowserQueryStatistics and I_BrowserResetNetlogonState. This functions calls their counterpart in the computer browser service.


svn path=/trunk/; revision=75184
2017-06-24 14:59:14 +00:00
Sylvain Deverre 3e9107ceec [MMIXER] Cleanup mixer notifications opened by an application when it is closed.
CORE-10735 #comment Please retest.

svn path=/trunk/; revision=75183
2017-06-24 13:54:10 +00:00
Sebastian Gasiorek 1f993d692c [DXG] Initial implementation of DxDdLock and better stub for DxDdUnlock
svn path=/trunk/; revision=75182
2017-06-24 13:53:22 +00:00
Sebastian Gasiorek 355e52a599 [WIN32SS][NTDDRAW] Remove debug dump. Forgot about this.
svn path=/trunk/; revision=75181
2017-06-24 13:21:24 +00:00