Commit graph

71139 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 91b50f9ccb
[ADVAPI32] Take into account the service handler context when dispatching a control notification to a service. (Used e.g. by tcpsvcs.) 2018-02-26 00:36:57 +01:00
Hermès Bélusca-Maïto 635aabb011
[ADVAPI32] Use RPC types where needed. Comments cleanup. 2018-02-26 00:36:53 +01:00
Simon Dräger 82720432eb [TRANSLATION] Completed German translation in stobject (#401) 2018-02-25 23:36:05 +01:00
Simon Dräger ff23123615 [TRANSLATION] Minor German grammatical improvements 2018-02-25 17:26:43 +01:00
Hermès Bélusca-Maïto 5f4a4b35e6
[ADVAPI32_APITEST] Open services & SCM handles with correct access rights; improve a check order. 2018-02-25 16:11:00 +01:00
Alexander Shaposhnikov 509dd4e645
[CONTRIBUTING] Update .gitmessage
The template is made more clear and specific.
Added non-mandatory width hints.
2018-02-25 16:14:41 +02:00
Eric Kohl a0d412b77a [SC] Support the paramchange and netbind* control codes in the control command 2018-02-25 14:08:16 +01:00
Eric Kohl 9f0c54fcd3 [SC][SERVICES] Support SERVICE_CONTROL_PARAMCHANGE and SERVICE_CONTROL_NETBIND* control codes 2018-02-25 11:07:41 +01:00
Pierre Schweitzer 1986049a38
[CDFS_NEW] Sync with HEAD.
CORE-14315
2018-02-25 10:14:27 +01:00
Thomas Faber 6158207c31
[BOOTDATA] Do not include caroots.inf in registry.inf. CORE-12020
This splits registry.inf roughly in half, which massively reduces heap usage
in 1st stage. DPH and low-memory scenarios benefit from this.
2018-02-25 10:07:28 +01:00
Hermès Bélusca-Maïto c6d65fec69
[SERVICES] Use safe-string routines in some places, and do not hardcode buffer lengths. 2018-02-25 00:50:01 +01:00
Hermès Bélusca-Maïto 1aa359ec7f
[SERVICES] Send services shutdown notifications only if they accept them. 2018-02-25 00:49:58 +01:00
Hermès Bélusca-Maïto 6c097b4740
[SERVICES] Add french translation. 2018-02-25 00:49:55 +01:00
Simon Dräger fd3b6d8c09
[TRANSLATION] German syntax fix.
It is rather unusual to put a "then" after "If..", so removed that.
2018-02-24 23:32:31 +01:00
Harteex 23a6b69c4d [BOOTDATA] Fix path to temp folder for the Swedish locale (#381) 2018-02-24 23:08:55 +01:00
Pierre Schweitzer 62facb7a49
[NTOSKRNL] Implement ThreadHideFromDebugger in NtSetInformationThread() 2018-02-24 22:07:12 +01:00
Mark Jansen 2ffc684699
[ACLAYERS] Add WIN8 and WIN81 VersionLie shims 2018-02-24 19:33:56 +01:00
Mark Jansen 8e1f342990
[APPSHIM_APITEST] Add Win8 and Win81 versionlie tests 2018-02-24 19:33:50 +01:00
Mark Jansen 9b55e647fa
[ACPPAGE] Enable version lies until Win7 + some cleanup 2018-02-24 19:33:42 +01:00
Mark Jansen 0dd71438a4
[APPHELP] Set debug level in case of parse failure 2018-02-24 19:33:02 +01:00
Eric Kohl 4b8f53c9e9 [SERVMAN] Add an accelerator for the F5 (refresh) key
CORE-14389
2018-02-24 18:38:08 +01:00
Timo Kreuzer 6771bf55a0 [WIN32K] Get rid of some instances of the ugly RETURN() macro 2018-02-24 17:17:25 +01:00
Timo Kreuzer e688aab6b3 [FORMATTING] Fix indentation, no functional changes. 2018-02-24 17:17:25 +01:00
Pierre Schweitzer a3c58ca76f
[NTOSKRNL] Implement the support for reserve IRP in IO
The reserve IRP is an IRP which is allocated on system boot and kept during
the whole system life. Its purpose is to allow page reads in case of
low-memory situations where the system doesn't have enough memory left
to allocate an IRP to read from the page file (would be catastrophic situation).
2018-02-24 14:52:04 +01:00
Pierre Schweitzer 9ac2e9855a
[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters 2018-02-24 14:52:04 +01:00
Pierre Schweitzer 0fbdf31709
[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters 2018-02-24 14:52:04 +01:00
Thomas Faber af6c5806d5
[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerName in PathUnExpandEnvStrings) by Katayama Hirofumi MZ. CORE-13816 2018-02-24 14:18:29 +01:00
Thomas Faber 9ac94af436
[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handles) by Mark Jansen. 2018-02-24 14:18:15 +01:00
Thomas Faber a5a6c6419f
[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream. 2018-02-24 14:17:58 +01:00
Pierre Schweitzer 45964099f3
[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation 2018-02-24 13:36:26 +01:00
Pierre Schweitzer 227c4321c2
[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters 2018-02-24 13:36:26 +01:00
Eric Kohl 1dfbed9c3d [SERVICES][ADVAPI32] Fix the broken service stop sequence
services\database.c:
- Refactor ScmControlService() so that it can be used to send the dispatcher loop stop command.
- Separate the code to decrement the image run counter from the service image cleanup code.

services\rpcserver.c:
- RSetServiceStatus(): Stop the dispatcher loop when the image run counter is zero and remove the service image after that.

advapi32\service\sctrl.c:
- Do not terminate the service dispatcher loop when the last service is being stopped. Wait for an explicit dispatcher stop command (empty service name).

CORE-12413
2018-02-24 11:14:05 +01:00
Serge Gautherie b6c060ce04 [IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391) 2018-02-23 17:35:02 +00:00
Giannis Adamopoulos 5b38fed776 [SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
It seems that TBN_DELETINGBUTTON isn't called when the toolbar gets destroyed so the only way to avoid leaking the data is emptying it ourselves.
2018-02-23 12:27:48 +02:00
Mark Jansen 5f52a61e7d
[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.
CORE-14376
2018-02-22 23:25:57 +01:00
Serge Gautherie e8271c9a46 [KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks
Addendum to 22037684e4.

- Result: check "== FALSE" not "= TRUE".
- Report compared values, not different ones.

CORE-11819
2018-02-22 22:26:34 +01:00
Thomas Faber a2f77ee3fb
[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead. 2018-02-22 14:03:05 +01:00
Thomas Faber 56e2bf2f92
[NTOS:CC] Avoid some magic numbers. 2018-02-22 14:03:03 +01:00
Thomas Faber b8741e2bb3 [SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194 2018-02-22 11:53:34 +01:00
Thomas Faber 87d3fdf99e [DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353 2018-02-22 11:53:34 +01:00
Pierre Schweitzer 22037684e4
[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.
CORE-11819
2018-02-21 22:53:30 +01:00
Thomas Faber 182a31074f [IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353 2018-02-21 18:42:43 +01:00
Thomas Faber 4487284c17
[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298 2018-02-21 15:17:58 +01:00
Pierre Schweitzer 6ff94017e4
[VFATLIB] Fix FAT partitions formatting in a non clean fashion.
(So the fun begins)
In spite of what VFATLIB headers pretend, there's not magic in FAT boot sector.
The 3 first bytes are just the jump instruction (to the boot code). No jump, no boot.
Also, some (many?) FAT implementations rely on the jump code to help detecting that
a FAT volume is really a FAT volume. Like MS FastFAT. Or our own FAT recognizer in FS_REC.
The story is that, up to that commit, we zeroed the 3 first bytes; leading to broken
FAT volumes.
This got hidden in most cases by the fact that during setup, when we install boot
loader, we erase parts of the boot sector, including the jump instruction, making the
volume valid again. But that wouldn't fix secondary volumes where the boot loader isn't
installed.
And, also, imagine a scenario where you want to install ReactOS on a newly formatted volume
with MS FastFAT instead of our own implementation... That would simply not work to
the fact that the driver wouldn't recognize the fresh formatted volume!

(So the non fashion begins)
Fix this by putting a not that valid jump into the boot sector when formatting our
partitions. That way, our volume is always regarding a FAT view point. But, instead of
putting values that mean (nearly) nothing. We should also put a dummy bootloader
displaying the user and error message, as done by dosfstools.

(So the hope begins)
This opens the way for trying to install ReactOS with MS FastFAT (doesn't work yet).

CORE-11819
CORE-14362
2018-02-21 00:26:13 +01:00
Serge Gautherie e1bd79e3df [SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387) 2018-02-20 19:45:55 +01:00
Giannis Adamopoulos 3263303844 [SHELL32] CShellItem: Fix GetDisplayName and Compare
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.
2018-02-20 16:59:00 +02:00
Giannis Adamopoulos 9d7313273c [SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine
Fixes lots of tests.
2018-02-20 16:33:30 +02:00
Giannis Adamopoulos af97de39a2 [SHELL32] CShellItem: Fix return value of Compare method 2018-02-20 14:36:31 +02:00
Giannis Adamopoulos c361e475b4 [SHELL32] CDefaultContextMenu: Implement GetCommandString 2018-02-20 13:05:59 +02:00
Giannis Adamopoulos 7e48c20b3b [SHELL32] Fix a couple of tests 2018-02-20 11:48:40 +02:00