Commit graph

44810 commits

Author SHA1 Message Date
Jérôme Gardou 8be61c1a29 [GDI32_APITESTS]
- Test behaviour of SetDIBits for 1bpp bitmaps.
  - Add small test to GetPixel just to verify that SetDIBits doesn't say BS.

svn path=/trunk/; revision=50950
2011-03-02 01:15:10 +00:00
Jérôme Gardou 5e5532d3ef [WIN32K]
- in 1bpp bitmaps, 0 means white. Take that into in SetDIBits
  - fix a fixme in XLATEOBJ implementation
  - remove useless field from ROS_DCINFO
Fixes fox audio player GUI :-) Enjoy!

svn path=/trunk/; revision=50949
2011-03-02 00:15:57 +00:00
Jérôme Gardou c77754b87d [WIN32K]
- only lock DC if asked to in NtGdiSetDIBits.

svn path=/trunk/; revision=50948
2011-03-01 21:45:45 +00:00
Jérôme Gardou d5954abbf2 [[GDI32_APITEST]
- actually make a test, with == instead of =, relevant bits sets, good test value, etc.

svn path=/trunk/; revision=50947
2011-03-01 21:32:58 +00:00
Jérôme Gardou a5115608c9 [GDI32_APITEST]
- add a basic test for SetDIBits

svn path=/trunk/; revision=50946
2011-03-01 20:50:47 +00:00
Jérôme Gardou 1a7f618d3b [WIN32K]
- Dismiss alpha channel when creating a solid brush.
Finally fixes VLC icons and numerous winetests.

svn path=/trunk/; revision=50945
2011-03-01 14:44:53 +00:00
Timo Kreuzer 788c6760f7 [WIN32K]
Silence some DPRINTS

svn path=/trunk/; revision=50944
2011-03-01 13:27:19 +00:00
Timo Kreuzer a53926e3bf [USER32_APITEST]
Patch by Thomas Faber: some tests for GetMessage and PeekMessage

svn path=/trunk/; revision=50943
2011-03-01 12:05:39 +00:00
Timo Kreuzer dedaab13ab [WIN32K]
Do raster operation on 4 bytes instead of only 3. Fixes ...
maybe noone has noticed yet ;-)

svn path=/trunk/; revision=50942
2011-03-01 09:17:58 +00:00
Jérôme Gardou 1ea8829ec1 [WIN32K]
- Raster operations in user mode are on higher bytes, whereas they are on lower bytes for drivers. Try to clarify this situation.
  - Add sanity check about what was said previously.
  - Implement masking in EngBitBlt
  - Rewrite NtGdiMaskBlt accordingly
  - Realize the palette when selecting it into a device DC.
  - When applying raster operation, do so only on 24 bits, we don't support alpha channel in win32k
This fixes VLC pink icons, Timo's MaskBlt tests and probably a lot of other things.
[SHELL32]
  - Use correct (?) raster operations for drawing sjortcuts.
Also note that now NtGdiMaskBlt locks the device contexts : this should avoid some race conditions, such as icons drawn on top of windows and the like.
Win32k sucks less.
So does reactos.
Dedicated to Timo. Sleep well, mate.

svn path=/trunk/; revision=50941
2011-03-01 01:03:58 +00:00
Jérôme Gardou 56cfac043d [FORMATTING]
fix dibobj.c, to please pigglesworth

svn path=/trunk/; revision=50940
2011-02-28 23:46:02 +00:00
Jérôme Gardou 5896730829 [FORMATTING]
fix formatting. No code change

svn path=/trunk/; revision=50939
2011-02-28 23:29:36 +00:00
Timo Kreuzer 962c0688f5 [GDI32_APITEST]
Fix a bug

svn path=/trunk/; revision=50938
2011-02-28 20:04:10 +00:00
Timo Kreuzer e9b7bf6df2 [GDI32_APITEST]
More tests for MaskBlt

svn path=/trunk/; revision=50937
2011-02-28 18:01:12 +00:00
James Tabor edda07b8ac [Win32k|User32]
- Use User32 GetWindowRgnBox, still passing both wine msg SetWindowRgn and win winregion tests, see bug 5959.

svn path=/trunk/; revision=50936
2011-02-28 16:45:57 +00:00
Kamil Hornicek 9fb8200d9b [WIN32K]
Fix calculating of ScanLines and source point in NtGdiGetDIBitsInternal for top-down bitmaps to more closely mimic win xp behavior. (Timo - high five for your test app)
See issue #5524 for more details.

svn path=/trunk/; revision=50935
2011-02-28 12:47:01 +00:00
James Tabor c6182beb15 [Win32k|User32]
- Use User32 GetWindowRgnBox, still passing both wine msg SetWindowRgn and win winregion tests, see bug 5959.

svn path=/trunk/; revision=50934
2011-02-28 09:10:43 +00:00
James Tabor 823118e08a [Win32k|User32]
- Clarify the meaning and the use of 0, 1 and 2 for user window regions, wine never did. Noticing patches not corresponding in correctness and understanding, leaving potential crashes in the DCE code, which depend on these types.
- Patch based on Rafal Harabien patch, fixes wine msg SetWindowRgn test, see also bug 5959.

svn path=/trunk/; revision=50933
2011-02-28 06:31:44 +00:00
Timo Kreuzer efd76a4a9c [WIN32K]
addendum to r50928: 24 and 32bpp BI_RGB bitmaps are BGR

svn path=/trunk/; revision=50932
2011-02-28 00:48:19 +00:00
Timo Kreuzer 04e49a00e3 [GDI32]
Revert r50519 and r50519

svn path=/trunk/; revision=50931
2011-02-28 00:19:32 +00:00
Aleksey Bragin 62de69219a [SERVICES]
- Protect whole contents of ScmStartService() with a critical section instead of just a few parts of ScmStartUserModeService(). Seems to fix the comment #8 issue of bug #5924.

svn path=/trunk/; revision=50930
2011-02-27 23:07:04 +00:00
Timo Kreuzer 27b33c3045 [GDI32_APITEST]
More testcases for SelectObject and GetDIBits

svn path=/trunk/; revision=50929
2011-02-27 22:00:13 +00:00
Jérôme Gardou 5de8339cd1 [WIN32K]
- remove duplicate prototype
  - use RGB macro where possible
  - we create BGR palette for RGB DIB sections, let's do the other way around
  - simplify overcomplicated IntGetDIBColorTable
  - Add a first implementation of IntRealizePalette
No, it's not the VLC icons bugfix

svn path=/trunk/; revision=50928
2011-02-27 21:45:43 +00:00
Aleksey Bragin ccebf72731 [RTL/HEAP]
- A few comments, and a new structure definition (currently unused). Absolutely no changes to the actual code.

svn path=/trunk/; revision=50927
2011-02-27 19:36:46 +00:00
Eric Kohl a328e318a1 [SERVICES]
Protect the service start and sending of control packages by critical sections. This way, services will be started one by one and control packages will also be sent one by one.

Please test if this fixes bug #5924.

svn path=/trunk/; revision=50926
2011-02-27 19:25:14 +00:00
Aleksey Bragin 061ec721f9 - Promote service start failures from TRACE to ERR.
See issue #5924 for more details.

svn path=/trunk/; revision=50925
2011-02-27 19:09:45 +00:00
Timo Kreuzer 69d9838266 [NTOSKRNL]
Fix aborting of backtraces

svn path=/trunk/; revision=50924
2011-02-27 19:03:12 +00:00
Christoph von Wittich 5e0cafbbda [imagehlp]
-partial winesync

svn path=/trunk/; revision=50923
2011-02-27 18:49:27 +00:00
Christoph von Wittich 2f6bcbb66c [imagehlp_winetest]
-add imagehlp_winetest

svn path=/trunk/; revision=50922
2011-02-27 18:30:50 +00:00
Timo Kreuzer 736733be4d [WIN32K]
- mark surface as not selected in DC_vSelectSurface when its released from a DC
NtGdiSelectBitmap: 
- Don't allow selecting a bitmap into a dc that is already selected!
- Use DC_vSelectSurface instead of manually selecting
- set the DC size based on bitmap size

svn path=/trunk/; revision=50921
2011-02-27 17:51:37 +00:00
Timo Kreuzer 760940d0bd [WIN32K]
- In NtGdiGetDIBitsInternal use a shared lock for the bitmaps and provide background colors when initializing the XLATEOBJ. This fixes mono bitmaps passed to GetDIBits. (no it does not fix pink icons in VLC)
- In BuildDIBPalette don't handle 15bpp, its not valid. and 16 bpp is 555, this is documented in MSDN.

svn path=/trunk/; revision=50920
2011-02-27 17:38:18 +00:00
Timo Kreuzer eb7b3a6e70 Fix build
svn path=/trunk/; revision=50919
2011-02-27 17:31:54 +00:00
Timo Kreuzer 6c10c052af [GDI32]
In GetDIBits convert a BITMAPCOREHEADER to a BITMAPINFOHEADER before calling win32k, like done in other places. Convert it back after. This allows to simplify NtGdiGetDIBitsInternal (not done yet)

svn path=/trunk/; revision=50918
2011-02-27 17:20:02 +00:00
Timo Kreuzer 3a61fab955 [NTOSKRNL]
Fix a serious bug, where NtAllocateVirtualMemory could allocate memory user mode memory above MmHighestUserAddress up to MmSystemRangeStart - 1, which is a no-access area.

svn path=/trunk/; revision=50917
2011-02-27 15:16:00 +00:00
Eric Kohl d3b52209a4 [URLCACHE]
Do not initialize the URL-Cache for a system process.
Patch will be submitted to WINE.
See issue #5372 for more details.

svn path=/trunk/; revision=50916
2011-02-26 22:23:03 +00:00
Eric Kohl 66feb11cfe [SETUPAPI]
Rename functions according to the new naming scheme:
  CaptureAndConvertAnsiArg --> pSetupCaptureAndConvertAnsiArg
  CenterWindowRelativeToParent --> pSetupCenterWindowRelativeToParent
  ConcatenatePaths --> pSetupConcatenatePaths
  DuplicateString --> pSetupDuplicateString
  EnablePrivilege --> pSetupEnablePrivilege
  GetVersionInfoFromImage --> pSetupGetVersionInfoFromImage
  IsUserAdmin --> pSetupIsUserAdmin
  MultiByteToUnicode --> pSetupMultiByteToUnicode
  MyGetFileTitle --> pSetupGetFileTitle
  OpenAndMapForRead --> pSetupOpenAndMapForRead
  RegistryDelnode --> pSetupRegistryDelnode
  UnicodeToMultiByte --> pSetupUnicodeToMultiByte
  UnmapAndCloseFile --> pSetupUnmapAndCloseFile

svn path=/trunk/; revision=50915
2011-02-26 21:40:17 +00:00
Hervé Poussineau 38a3cf6ee4 [ntoskrnl] Fix compilation with _WINKD_=1
svn path=/trunk/; revision=50914
2011-02-26 20:00:08 +00:00
Pierre Schweitzer f154358da9 [KERNEL32]
Start unifying kernel32 Find* functions.
All calls end in same methods that are working only in unicode now.

Next step would be to unify stream & files using only one struct.

svn path=/trunk/; revision=50913
2011-02-26 17:18:21 +00:00
Aleksey Bragin 90f36847bc [KERNEL32]
- Fix buffer overwrite in GetModuleFileName(). Spotted by DPH.
See issue #5964 for more details.

svn path=/trunk/; revision=50912
2011-02-26 16:50:20 +00:00
Amine Khaldi 2119a3b309 [ROSTESTS]
- Skip test_apm to prevent the oleaut_winetest:olepicture crash.
See issue #5000 for more details.

svn path=/trunk/; revision=50911
2011-02-26 14:27:09 +00:00
Aleksey Bragin ac81886915 [NTDLL/LDR]
- Don't try to free a pointer allocated on stack.
See issue #4751 for more details.

svn path=/trunk/; revision=50910
2011-02-26 14:12:55 +00:00
Pierre Schweitzer 49516d9545 [USRMGR]
Fix build
Blame rbuild ~

svn path=/trunk/; revision=50909
2011-02-26 13:49:00 +00:00
Aleksey Bragin b49f53a6a5 - Don't free an invalid handle. Suggested by Johannes. Test failure remains in the log, so it's easy to spot the function misbehaves.
- P.S. Not much of an issue if it's lost during the next tests sync, as it would be a clearly visible change.
See issue #5771 for more details.

svn path=/trunk/; revision=50908
2011-02-26 13:31:58 +00:00
Pierre Schweitzer c1dc1d5ef0 [KERNEL32]
Remove unused .def file. We're using .pspec here

svn path=/trunk/; revision=50907
2011-02-26 13:26:02 +00:00
Pierre Schweitzer 363e880789 [USRMGR]
French translation by Jason Toscano <JasonGenie at gmail dot com>
Corrections/adjustements by me
See issue #5921 for more details.

svn path=/trunk/; revision=50906
2011-02-26 13:12:36 +00:00
Sylvain Petreolle 75d6f0438b [ROSTESTS]
Bug 5778:
Disable part of rpcrt4:rpc test,
it needs unimplemented functionality in current rpcrt4 version.

svn path=/trunk/; revision=50905
2011-02-25 23:34:52 +00:00
Pierre Schweitzer d6f4155e39 [NTOSKNRL]
For both FsRtlIsNameInExpression() & FsRtlIsDbcsInExpression():
As both UNICODE_STRING & ANSI_STRING might not be NULL-termined, don't attempt to read null char.
This fixes potential buffer overruns.
Then it fixes some (all?) 'TempPte.u.Long != 0' assertion failure.
See issue #5923 for more details.

svn path=/trunk/; revision=50904
2011-02-25 20:15:51 +00:00
Timo Kreuzer cd34e7ee1e [WININET]
Revert part of r47411. The revision was a wine sync, but no wine code was reverted, only the use of zlib is disabled. Fixes downloading audiograbber with rapps.
See issue #5663 for more details.

svn path=/trunk/; revision=50903
2011-02-25 18:44:20 +00:00
Timo Kreuzer 25a9c6fb49 [WIN32K]
- In BITMAP_CopyBitmap, also "copy" the palette of the source bitmap, instead of assuming the one created by GreCreateBitmapEx matches the bitmap bits we have copied.
Fixes broken colors on the firefox firstrun page
See issue #5902 for more details.

svn path=/trunk/; revision=50902
2011-02-25 17:37:25 +00:00
Sylvain Petreolle 0fcd8261f2 [ROSTESTS]
Bug 5957
Disable test_shell_window() in user32:win test.

Allow to run previously disabled tests in WINE_INTERACTIVE mode.

svn path=/trunk/; revision=50901
2011-02-25 16:21:04 +00:00