Commit graph

43683 commits

Author SHA1 Message Date
Amine Khaldi c8d65c59a4 [SHELL32]
Johannes Anderwald:
- Improve parameter checks for IShellLinkA interface.
- Fix heap corruption when an invalid pointer is passed.
- Implement IPersistFile_fnGetCurFile.
- TODO: Add same checks to IShellLinkW interface and fix IShellLink[A|W]::GetPath / SetPath / SetIdList / GetIdList logic.

svn path=/trunk/; revision=48786
2010-09-17 10:26:17 +00:00
Timo Kreuzer 253e949e7a [WIN32K]
Fix a bug, where a failure to allocate the kernel mode WINDOW_OBJECT would cause a page fault, because the WND was still allocated, but never initialized, and Wnd->rpdesktop was then dereferenced to free the WND again.

svn path=/trunk/; revision=48785
2010-09-17 01:34:50 +00:00
Timo Kreuzer 30fad2a263 [NTOS]
- More fixes to VDM PUSH/POPF code: 
- When doing a 32bit push, don't store the flags 2 bytes off
- Recalculate HardwareEsp, by substracting the segment part, instead of truncating the flat pointer to 16 bit.

svn path=/trunk/; revision=48781
2010-09-16 19:21:20 +00:00
Sir Richard cdebe5691a Patch by Anton Yarotsky:
[NTOSKRNL]: Fix support for non Headless scenarios as well.

svn path=/trunk/; revision=48780
2010-09-16 02:22:10 +00:00
Timo Kreuzer c2e13c8c49 Fix arm build a bit.
svn path=/trunk/; revision=48779
2010-09-15 23:48:38 +00:00
Sir Richard af197a47b2 Patch by Anton Yarotsky:
[NTOSKRNL]: Implement CmdPutString command, and add log message types. Kernel version/build, processor, and RAM, now appear on EMS screen (due to InbvDisplayString), as well as loaded drivers. Next steps are to support log entries and a flag to route debug output (a ReactOS-specific feature request).

svn path=/trunk/; revision=48778
2010-09-15 18:30:06 +00:00
Michael Martin 0b77725d6e [usb/usbehci]
- Change email address to one that actually works.

svn path=/trunk/; revision=48777
2010-09-15 13:16:59 +00:00
Amine Khaldi 61ae4ea31c [DDK]
- Define DECLSPEC_EXPORT when it's not already defined.

svn path=/trunk/; revision=48774
2010-09-15 09:03:57 +00:00
Sir Richard b52bd79196 Patch by Anton Yarotsky:
[NTOSKRNL]: Implement basic Headless support in the kernel. Implement missing InbvPort routines based on WinLdrPort (using cportlib). Add header for Hdl. Terminal initializes now on COM2. Added misisng code to InbvDisplayString to also display on Headless Terminal (requires unimplemented HeadlessDispatch). Next steps are to implement the kernel log buffer, and HeadlessCmdPutString to see boot strings.

svn path=/trunk/; revision=48773
2010-09-15 07:46:28 +00:00
Sir Richard c806e95592 Patch by Anton Yarotsky:
[FREELDR]: Fix Headless support.

svn path=/trunk/; revision=48772
2010-09-15 07:40:50 +00:00
Michael Martin 7a26c678b7 [usb/usbhub]
- On completion of SCE request, create and queue a workitem to handle:
Clearing the connection flag and reset the port. 
Create and initialize the USB device by calling the appropriate roothubs Direct Call Interface.
Create the device object, get the device descriptors and the serial and product strings of the USB device to be used for creating the deviceid and instanceid.
- Format code and misc changes.
- Together with the usbehci driver, ReactOS at least runs the device installation wizard with the correct device description.

svn path=/trunk/; revision=48771
2010-09-14 12:04:15 +00:00
Michael Martin 45bd4d8031 [usb/usbehci]
- Dont reset the port in the DPC after device is connected, the usbhub driver will do that later.
- Implement ResetPort and create a timer to call a DPC to coplete the SCE request.
- Dont queue all URBs and have seperate thread complete them as other URBs may still need to be completed.
Instead only queue the SCE request and complete it when a usb device is connected or reset.
- Implement RemoveURBRequest and fix bugs in URB_FUNCTION_GET_DESCRIPTOR_FROM_DEVICE.
- For IOCTL_INTERNAL_USB_GET_ROOTHUB_PDO dont return the FDO in Argument2 as no upper level driver should be communicating with the FDO of the roothub.
- Dont assign the usb device an address when initialized as the hub driver will do it later.

svn path=/trunk/; revision=48770
2010-09-14 09:46:28 +00:00
Sir Richard ef0d280232 Patch by Anton Yarotsky:
[FREELDR]: Implement support for /redirect=comX (usebiossettings not yet supported) and /redirectbaudrate. Uses cportlib. Tested, serial output works and kernel reports "Headless support is not yet implemented". Future revisions should support ACPI SRT for PCI-based serial ports on server systems.

svn path=/trunk/; revision=48768
2010-09-13 20:36:49 +00:00
Amine Khaldi 1a554af4a0 [USETUP]
- Sylvain Petreolle: Improve debug prints for disk space check.

svn path=/trunk/; revision=48767
2010-09-13 17:25:00 +00:00
Amine Khaldi 9c827ade73 [USETUP]
- Christoph von Wittich: Add a debug print, and improve an existing one.

svn path=/trunk/; revision=48766
2010-09-13 16:34:15 +00:00
Eric Kohl cab60ab876 [BATT]
Add missing 4th parameter to BatteryClassCoInstaller.

svn path=/trunk/; revision=48764
2010-09-13 11:48:59 +00:00
Cameron Gutman b4473ff304 [DESK]
- "repair DragFullWindows setting"
- Patch by Matthias Kupfer

svn path=/trunk/; revision=48761
2010-09-12 20:10:27 +00:00
Sir Richard 903bb1c887 Likely fix for bug 5600:
[NTOS]: Using IsBadRead/CodePtr, it's possible for user-mode code to generate cases where we *think* this is an ARM3-managed piece of VA, which will always have a VAD (Since we only manage the PEB/TEB), but actually it's a bogus VA-looking address that is actually invalid. We didn't consider this case. We now implement the same code Windows normally would also handle, when the VA is bogus, and accept that no VAD might be found, so MM_NOACCESS is returned and thus an access violation sent to the caller. In the case of the IsBad...Ptr, this function would then return TRUE, as the caller expects.

svn path=/trunk/; revision=48759
2010-09-12 19:10:27 +00:00
Sir Richard 3f003e294e [NTOS]: Move the fix for pool corruption due to dangling MmProcessLinks pointer into its correct location. Thanks again to Martin for the fix.
svn path=/trunk/; revision=48758
2010-09-12 19:02:39 +00:00
Eric Kohl 46d89d3a50 Make Services.exe and Winlogon.exe wait for the LSA server to be up and running. Otherwise calls to any LSA function might fail.
Thanks to Roel Messiant for testing and analyzing the debug logs.

See issue #5497 for more details.

svn path=/trunk/; revision=48757
2010-09-12 16:29:43 +00:00
Amine Khaldi 2270e330b0 [PSDK]
- Properly guard d3d9types.h and d3dtypes.h against DIRECT3D_VERSION versions.

svn path=/trunk/; revision=48754
2010-09-12 14:51:32 +00:00
Aleksey Bragin 078476414c - Revert 48750, I was misinformed.
svn path=/trunk/; revision=48753
2010-09-12 12:14:46 +00:00
Cameron Gutman 804899ffc6 [NDIS]
- Fix timer queuing
- See issue #5461 for details

svn path=/trunk/; revision=48752
2010-09-12 11:57:55 +00:00
Aleksey Bragin 8fcb361453 [PCIX]
- Stefan Ginsberg: Fix a typo in the if expression.

svn path=/trunk/; revision=48751
2010-09-12 10:35:01 +00:00
Aleksey Bragin 5bb5788d76 [NTOS]
- Add CmRegistryMachineSystemName to the internal header file, needed for Pierre's further work.

svn path=/trunk/; revision=48750
2010-09-12 10:29:35 +00:00
Aleksey Bragin 526130ba91 [FREETYPE]
- Fix FT_Get_CID_Is_Internally_CID_Keyed export name to match source code.

svn path=/trunk/; revision=48749
2010-09-12 10:11:55 +00:00
Sir Richard 6575a83c33 - Fix the ChangeResourceSetting and the Reset configurator callback parameter names
- Part support for resource change with PciComputeNewCurrentSettings... full support for PciSetResources, PciUpdateHardware, PcipUpdateHardare
- IRP_MN_START_DEVICE for PDO (PciPdoIrpStartDevice) implement 
- PciNextPartialDescriptor, PciDebugPrintCmResList, PciDebugPrintPartialResource helpers implement
- Now full PDO support almost done, PCIX driver ready for test
- Thanks to cgoodman assert fix
- PnP forever recursion in enumerate, must fix to finish
- Goodbye sir_richard, nice to have you

svn path=/trunk/; revision=48748
2010-09-12 06:03:12 +00:00
Cameron Gutman a0b7f0f4b9 [USETUP]
- Update the Polish translation
- Patch by Olaf Siejka

svn path=/trunk/; revision=48747
2010-09-12 00:47:07 +00:00
Aleksey Bragin a14482e225 [WINLOGON]
- Fix comments copypasta.

svn path=/trunk/; revision=48746
2010-09-11 21:16:41 +00:00
Aleksey Bragin a5c563dfdb [NTOS]
- Daniel Zimmermann: Fix POPF bugs in VDM mode, namely truncation of the stackpointer to 16 bit and setting proper flags in the trapframe eflags register. This fixes problems with videocards calling int 0x10 VESA BIOS extension.
See issue #5608 for more details.

svn path=/trunk/; revision=48745
2010-09-11 09:20:26 +00:00
Aleksey Bragin b8cbac25c2 - Fix build, sorry.
svn path=/trunk/; revision=48744
2010-09-11 09:01:58 +00:00
Aleksey Bragin c9888046ef [HAL]
- Don't include PCI IDs database into mini-HAL.

svn path=/trunk/; revision=48743
2010-09-10 21:57:46 +00:00
Eric Kohl c3c0a62855 [DESK.CPL]
Fix client font in the advanced appearance dialog. Patch by Katayama Hirofumi.
See issue #5552 for more details.

svn path=/trunk/; revision=48742
2010-09-10 21:57:36 +00:00
Aleksey Bragin 9488b4aab6 [FORMATTING]
- Fix indentation.

svn path=/trunk/; revision=48741
2010-09-10 21:51:32 +00:00
Aleksey Bragin 2d246e918e [HAL]
- Add missing call to HalInitPnpDriver during I/O manager initialization. The HAL PnP driver was never getting initialized.
- Add HAL callback for HalInitPnpDriver. It's going to be needed in future for eVb's PCI driver to fully work (interrupt translation, among other things).

svn path=/trunk/; revision=48740
2010-09-10 21:46:13 +00:00
Aleksey Bragin 1a029a622d [NTOS]
- Fix several bugs in Inbv (busted locking code, useless variables, magic initializers).

svn path=/trunk/; revision=48739
2010-09-10 21:28:24 +00:00
Michael Martin bd0767f9fd [ntoskrnl/io]
- Modify IopCreateDriver to accept the PLDR_DATA_TABLE_ENTRY instead of the DllBase and SizeOfImage from this structure.
- Set the DriverObject->DriverSection before calling the DriverEntry routine.
- If the DriverEntry routine fails then set the DriverObject->DriverSection back to NULL so that IopDeleteDriver doesnt attempt to unload the ModuleObject, after it was already unloaded by the caller.

svn path=/trunk/; revision=48738
2010-09-10 21:25:53 +00:00
Aleksey Bragin 0daaf9da75 [NTOS]
- Fix a code typo which led to a security issue when the XOR algorithm for the system cookie might actually yield zero. Now it's going to loop as long as the cookie is 0, attempting to generate a non-zero one.

svn path=/trunk/; revision=48737
2010-09-10 21:13:06 +00:00
Aleksey Bragin 9b12a8c1d7 [NDK]
- Remove deprecated KV86M structures and files.

svn path=/trunk/; revision=48736
2010-09-10 21:08:38 +00:00
Aleksey Bragin 1f4771d41b [NTOS]
- Fix a strange bug where we were only setting SharedUserData->TestRetInstruction conditionally only if lookup failed - it should be set on success. Also, bail out if the lookups failed.

svn path=/trunk/; revision=48735
2010-09-10 21:01:59 +00:00
Michael Martin dee985f9c6 [ntoskrnl/io/pnpmgr]
- Fix incorrect POOL_TYPE allocation in IoInvalidateDeviceRelations. This function can be called at DISPATCH_LEVEL, which requires NonPagedPool POOL_TYPE.

svn path=/trunk/; revision=48734
2010-09-10 19:45:01 +00:00
Aleksey Bragin 1355a06e32 [NDK]
- Fix KiBugCheckData declaration.

svn path=/trunk/; revision=48733
2010-09-10 18:20:37 +00:00
Aleksey Bragin 0955523e4f [WIN32K]
- Giannis Adamopoulos: Only dereference a class if it's valid, should fix Heroes 3 crash.
See issue #5606 for more details.

svn path=/trunk/; revision=48732
2010-09-10 18:13:02 +00:00
Aleksey Bragin cacc80ae3e [HAL]
- Stub support for future timer latency watchdog.
- Change older-style comments to standard ReactOS commenting style.

svn path=/trunk/; revision=48731
2010-09-10 13:15:51 +00:00
Aleksey Bragin b84512b555 [NTOS]
- Rename KINTERRUPT_DISPATCH_CODES to DISPATCH_LENGTH, as it is in PSDK.
- Enhance NMI debug support.
- Change some comments to standard ReactOS commenting style.

svn path=/trunk/; revision=48730
2010-09-10 09:54:30 +00:00
Aleksey Bragin 7a9bd9ccea [KERNEL32]
- Fix release build, part 2. Further improvement to gDebugChannels would be to convert them to a DECLARE_DEBUG_CHANNEL-alike macro.

svn path=/trunk/; revision=48729
2010-09-10 09:04:25 +00:00
Aleksey Bragin 60bb233f46 - Fix typos in the description of serial port defines.
svn path=/trunk/; revision=48728
2010-09-10 08:30:13 +00:00
Sir Richard c27087c0e6 Patch by Anton Yarotsky:
[CPORTLIB]: Implement Windows' Cp (ComPort) library. See Notes in C file. Not yet used. Based on MS Whitepaper: Building Hardware and Firmware to Complement Microsoft Windows Headless Operation.

svn path=/trunk/; revision=48727
2010-09-10 05:22:48 +00:00
Aleksey Bragin 228af0c797 [NTOS]
- Fix release build, leftover from 48692.

svn path=/trunk/; revision=48726
2010-09-09 21:06:13 +00:00
Michael Martin 322032192b [ntoskrnl/po]
- Fix typo.

svn path=/trunk/; revision=48725
2010-09-09 09:22:49 +00:00