Commit graph

77836 commits

Author SHA1 Message Date
Serge Gautherie
89971a3757
[CDFS][FLOPPY_NEW] Simplify unsupported NT6.2+ workarounds (#2956) 2020-07-18 15:31:48 +02:00
Victor Perevertkin
5201472be7
[NTOS:FSTUB] Simplify xHalIoReadPartitionTable function
Use single IOCTL (IOCTL_DISK_GET_DRIVE_GEOMETRY_EX) for retrieving
disk basic geometry information along with disk size.
Previous implementation used to issue two requests for that.
2020-07-15 03:20:13 +03:00
Thomas Faber
64abd9fca8
[LIBMPG123] Update to version 1.26.2. CORE-17158 2020-07-12 12:28:05 +02:00
Serge Gautherie
d6c4411207 [MSGINA] gui: Improve 'DlgData_Destroy()'
Addendum to 623dd26cce.
2020-07-11 01:44:26 +02:00
Serge Gautherie
bd593ed366
Merge pull request #2900 from SergeGautherie/SergeGautherie/PRonly_3rdPartyFiles-txt_chmc-lzxcomp
[3rd Party Files.txt] Add 'chmc and lzxcomp' entry
2020-07-11 01:38:15 +02:00
Serge Gautherie
f91144364b [TASKMGR] CachedGetUserFromSid(): Fix user name length on cache hit 2020-07-11 01:37:53 +02:00
Serge Gautherie
353b544047 [AUDIOSRV] logmsg(): Disable its file part
Mininal workaround for
CORE-16814
2020-07-11 01:22:56 +02:00
Serge Gautherie
db2aa4c8ca [APISETS] api-ms-win-core-localization-l1-2-1: Is NT6.3+ actually
CORE-17095
2020-07-11 01:16:38 +02:00
Serge Gautherie
0de16bc3ba [APISETS] api-ms-win-core-localization-l1-2-0: Is NT6.2+ actually
CORE-17095
2020-07-11 01:16:38 +02:00
Serge Gautherie
871f96b66e [APISETS] api-ms-win-core-localization-l1-1-0: Is NT6.1+ actually
CORE-17095
2020-07-11 01:16:38 +02:00
Mark Jansen
7dc306c440
[SDK] Fix host-tools build from visual studio ide in Release 2020-07-09 21:32:53 +02:00
Colin Finck
5f37b687b0
[OSK] Fix some mistakes in the German translation I just spotted 2020-07-08 23:32:17 +02:00
Thomas Faber
292f67af5b
[MBEDTLS] Update to version 2.7.16. CORE-17155 2020-07-04 21:53:46 +02:00
Thomas Faber
e57126f5e5
[MBEDTLS] Switch license headers to the dual-licensed version. CORE-17155
This is the default going forward, and separating it out into its own
commit removes the noise from the following sync commit.
2020-07-04 21:53:42 +02:00
Mark Jansen
cc7cf82673
[ROSAPPS] Remove applications from test directory
CORE-17097
2020-07-04 20:43:53 +02:00
Mark Jansen
ff6b138117
[ROSAUTOTEST] Add option to list all testable modules 2020-07-04 20:43:37 +02:00
Mark Jansen
6859348aea
[SVCHOST] Fix PSID initialization
CORE-17151
2020-07-04 19:39:06 +02:00
Nguyen Trung Khanh
37c63770d7
[NTOS:IO] Fix pool memory disclosure in IopQueueTargetDeviceEvent (#2966) 2020-07-04 15:41:18 +02:00
Nguyen Trung Khanh
50510538db
[WIN32SS][GDI] Fix pool memory disclosure in NtGdiGetOutlineTextMetricsInternalW (#2964) 2020-07-04 15:39:16 +02:00
Serge Gautherie
aae5cd8ea2
[CMAKE] Remove obsolete 'GCC_VERSION' checks (#2962)
following upgrade to RosBE 2.2.0 support and GCC 8.4.
2020-07-04 15:33:50 +02:00
Serge Gautherie
54e0dbe3b6
[ADVAPI32_WINETEST] test_create_delete_svc(): Fix 'account' size (#2960)
Cherry-pick
56a83c585a
2020-07-04 15:24:46 +02:00
Serge Gautherie
092e245754
[UTILDLL_APITEST] Create 'CachedGetUserFromSid()' test (#2954) 2020-07-04 15:24:13 +02:00
Serge Gautherie
7187b4d846
[ROSTESTS] sertest.c: Replace a busy loop with 'Sleep()' (#2886)
Detected by Cppcheck: uninitvar.
ROSTESTS-204

Co-authored-by: Victor Martinez <vicmarcal@gmail.com>
2020-07-04 15:18:22 +02:00
FritzsHero
fbb612f41a
[OSK] Updated German On-Screen Keyboard translation (#2882) 2020-07-04 15:17:26 +02:00
Serge Gautherie
4292fdd8aa
[NET] cmdAccounts(): Set ProductType default value (#2365) 2020-07-04 15:16:22 +02:00
Jose Carlos Jesus
62e52c7237
[USER32][NTUSER] Fix wrong return from LB_GETLISTBOXINFO (#2168)
And is now consistent with comctl32 and Wine too...
2020-07-04 15:11:10 +02:00
Victor Perevertkin
c40b0866b1
[UDFS] Zero-initialize IO_STATUS_BLOCK data in UDFCommonCreate
Some places have been changed to return FILE_DOES_NOT_EXIST, everything
else just returns 0. FastFAT driver from MS does the same (tm),
so I'm not going to have a big research here.
CORE-16623

Co-authored-by: Suraj K Suresh <kssuraj15@gmail.com>
2020-06-29 02:37:12 +03:00
Oleg Dubinskiy
622f187c04
[MSWSOCK] Use a correct prototype for SvchostPushServiceGlobals stub
See https://www.geoffchappell.com/studies/windows/win32/services/svchost/dll/svchostpushserviceglobals.htm.
2020-06-27 14:55:28 +02:00
Oleg Dubinskiy
dcc5dd2a69
[SDK][SVCHOST] Move all global svchost declarations to public header.
Also update the includes.
It will allow to use those declarations globally where they are required (e. g. for SvchostPushServiceGlobals functions in some services).
No functional changes.
2020-06-27 14:54:22 +02:00
Serge Gautherie
2dfcb500e2
[MSI] Remove obsolete '__ASM_DEFINE_FUNC()'
MSVC build reports:
{{
dll\win32\msi\msvchelper.h(3): warning C4005: '__ASM_DEFINE_FUNC': macro redefinition
sdk\include\reactos\wine/asm.h(60): note: see previous definition of '__ASM_DEFINE_FUNC'
dll\win32\msi\custom.c(547): warning C4003: not enough actual parameters for macro '__ASM_DEFINE_FUNC'
}}

Addendum to 476c99b and 9efafd6.
2020-06-27 14:48:00 +02:00
Serge Gautherie
82272f03e3
[OLE32] ole32_ros.diff: Remove remnant '__ASM_STDCALL_FUNC()'
Addendum to 0f5d91b.
CORE-16441
2020-06-27 14:48:00 +02:00
Serge Gautherie
bf88ce89c8
[APISETS] api-ms-win-crt-utility-l1-1-0: Fix 'llabs' return type
MSVC 'Release' build reports:
'dll\apisets\api-ms-win-crt-utility-l1-1-0_stubs.c(41): warning C4391: 'int llabs()': incorrect return type for intrinsic function, expected '__int64''

Addendum to 3f15a0d.
2020-06-27 14:46:15 +02:00
Serge Gautherie
02680ace4d
[POWRPROF_APITEST] Fix cppcheck warnings.
* test_CallNtPowerInformation(): Fix 2 'sizeof(sizeof())' copypastas
* test_ValidatePowerPolicies_Next(): Delete a duplicate line
2020-06-27 14:43:08 +02:00
Serge Gautherie
0b9cbc5179
[CRT] _onexit(): Fix 'memcpy()' size
Cherry-pick
70bff7377d
2020-06-27 14:38:21 +02:00
Serge Gautherie
4213c70e2e
[CRTDLL][CRT] Remove remnant declaration, silence cppcheck false positive.
* _atexit_cleanup is no longer used
* Fix cppcheck 'pointerSize' warning
2020-06-27 14:35:32 +02:00
Jared Smudde
9e20be0fbf [SYSDM] Set the proper icon in title bar 2020-06-27 10:22:07 +02:00
Thomas Faber
1481df94ab
[KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.
* Check the entire version field
* Check the variant field
* Accept RPC_NT_UUID_LOCAL_ONLY, which is sometimes returned by Windows
* Repeat the test to show that these things happen every time

Based on a patch by Serge Gautherie.
2020-06-27 10:13:51 +02:00
Serge Gautherie
8983adf967
[FASTFAT_NEW] Sync to upstream 16022c5 (#2938) 2020-06-26 20:03:01 +03:00
Serge Gautherie
ed7196d964 [TASKMGR] Remove 'Debug Channels' feature, which is Wine-specific 2020-06-25 22:08:03 +02:00
Serge Gautherie
a72b78558d [NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code
No impact.

Detected by Cppcheck: unreachableCode.
Addendum to ddaf47dec3 (r34976).
2020-06-25 21:59:02 +02:00
Victor Perevertkin
1e512e29dc
[USBSTOR] Correctly terminate a REG_MULTI_SZ string
returned by the IRP_MN_QUERY_ID handler
2020-06-24 21:15:58 +03:00
Nguyen Trung Khanh
a279b1d2c6
[WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory.
This avoids disclosing pool contents to user mode when not all members
of the respective structure are initialized or when there is padding.

In co_IntCallWindowProc, also zero the stack buffer since this can
be passed to user mode as well, and contains padding.
2020-06-24 09:15:27 +02:00
Thomas Faber
67592f9750
[NPFS] Fix querying FileAllInformation. 2020-06-24 09:04:05 +02:00
Victor Perevertkin
21e9e2baa5
[NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c
And rearrange them in more logical order.

This effectively splits the file, leaving public "Io" functions in
pnpmgr.c along with some things not related do device object management.
Functions which manipulate the device tree are left in devaction.c.
In future all these functions will only be accessed from
DeviceActionWorker.
While being public API, IoRequestDeviceEject and IoInvalidateDeviceState
have been moved to devaction.c as well. In next commits they will be
converted to DeviceActionWorker routines and their callers will be put
in pnpmgr.c
2020-06-24 04:03:35 +03:00
Victor Perevertkin
d230f8829c [ROSAUTOTEST] Add /t parameter for repeating tests 2020-06-24 02:40:18 +03:00
Thomas Faber
29b49c36ff
[KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136 2020-06-21 10:39:49 +02:00
Thomas Faber
23ccd13639
[I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136
We neither want to handle IRPs we don't understand, nor do we want to
assert in case of unexpected IOCTLs.
2020-06-21 10:39:34 +02:00
Victor Perevertkin
b5815efe83
[NTOS:IO] Move device node functions from pnpmgr/pnpmgr.c to pnpmgr/devnode.c
Add SAL2 annotations to functions while moving
Convert IopCreateDeviceNode description to a Doxygen format
2020-06-21 09:39:13 +03:00
Serge Gautherie
ab2b7a6bc6 [FASTFAT_NEW] Simplify unsupported NT6.2+ workarounds 2020-06-21 09:27:44 +03:00
Serge Gautherie
1ceed5ad5a [FASTFAT_NEW] Remove obsolete compiler workarounds
following upgrade to GCC 8.4 and MSVC 2015.
2020-06-21 09:27:44 +03:00