Commit graph

59607 commits

Author SHA1 Message Date
Jérôme Gardou 3ef4731492 [WIN32K]
- Properly free classes small icon handles
 - Do not use LR_SHARED when copying them from the large icon. There's no reason for them to outlive the class.
Should fix remaining failures in user32:class that I introduced.

svn path=/trunk/; revision=64939
2014-10-23 19:41:52 +00:00
Jérôme Gardou 25c228cd3f [WIN32K/USER32]
- Simplify an overcomplicated way to get buffer size from win32k
 - Do not spaghettize between string length and buffer size.
 - Properly use GetModuleFileName.

svn path=/trunk/; revision=64938
2014-10-23 19:41:42 +00:00
Amine Khaldi a8e3dcc9e1 [ADVAPI32]
* Introduce a wine folder to group the Wine synced source files.
* Use the crypt folder as a starting point. More will follow.
CORE-8540

svn path=/trunk/; revision=64937
2014-10-23 18:58:35 +00:00
Amine Khaldi 73e6ff1519 [PCIX]
* PciIdPrintfAppend is a vararg too.

svn path=/trunk/; revision=64936
2014-10-23 18:51:12 +00:00
Amine Khaldi a0a95141dd [PCIX]
* PciIdPrintf is a vararg.

svn path=/trunk/; revision=64935
2014-10-23 18:42:39 +00:00
Eric Kohl 903f5b3e03 [NET]
Implement the first part of the NET USER command.

svn path=/trunk/; revision=64934
2014-10-23 18:36:11 +00:00
Amine Khaldi 26272f6095 [COMPBATT]
* Arch, don't return NTSTATUS instead of PCOMPBATT_BATTERY_DATA!

svn path=/trunk/; revision=64933
2014-10-23 18:33:21 +00:00
Amine Khaldi 36609d44e0 [DSOUND]
* ProjectVector is used in commented out code.

svn path=/trunk/; revision=64932
2014-10-23 18:07:43 +00:00
Thomas Faber 863c3c8c19 [NTOS:FORMATTING]
- Try to fix indentation in iomgr/driver.c. Whitespace changes only

svn path=/trunk/; revision=64931
2014-10-23 17:59:16 +00:00
Amine Khaldi 5892b26e03 [WINSPOOL.DRV]
* We're not using any debugging routines here.

svn path=/trunk/; revision=64930
2014-10-23 17:55:42 +00:00
David Quintana 1cd79168e1 [RSHELL]
* CMenuBand: Increase the refcount of m_smc before returning it.
* CMenuBand: Improve the closing logic so that the object is reusable when it needs to be, and can still be released properly.
* CMenuDeskBar: Protect self against unexpected termination.
* CMenuFocusManager: Refcount objects that are being used.
* CStartMenu: Properly release the created objects after it's done using them (by using CComPtr instead of raw pointers).

[BROWSEUI]
* AddressBand: Release the addressband site when closing the band.
* InternetToolbar: Do not filter away ALL the items of the favorites folder.
* InternetToolbar: Do not AddRef a CComPtr that already did the refcounting itself.

CORE-8690

svn path=/branches/shell-experiments/; revision=64929
2014-10-23 17:17:16 +00:00
Jérôme Gardou 532e8139c5 [USER32]
- Fix wrong size check.
Spotted by Thomas

svn path=/trunk/; revision=64926
2014-10-23 15:40:13 +00:00
Thomas Faber d617e9abfc [NTOS:IO]
- Simplify how IopLoadUnloadDriver is called by making the function queue a work item instead of its caller

svn path=/trunk/; revision=64925
2014-10-23 14:37:51 +00:00
Amine Khaldi cfb9b0f028 [USER32]
* Merge r64866 from the shell branch which had:

* Fix wrong array length passed to GetClassNameW. CID 716222
* Replace other instances of explicit array length to GetWindowTextW with _countof(x).
Based on a patch by Christoph von Wittich.

svn path=/trunk/; revision=64924
2014-10-23 12:24:07 +00:00
Hermès Bélusca-Maïto 19b3162442 [NTVDM]: Addendum to revision 64917: remove unnecessary casts.
svn path=/trunk/; revision=64923
2014-10-23 12:21:46 +00:00
Amine Khaldi 121e60dbda * Sync up to trunk head (r64921).
svn path=/branches/shell-experiments/; revision=64922
2014-10-23 12:17:44 +00:00
Jérôme Gardou 8cbba79468 [WIN32SS]
- In an incredibly daring move, enable the long awaited new cursors & icons implementation, featuring:
   - Alpha channeled cursors
   - Animated cursors (only the first frame is displayed now)
   - Less leaks (tm)
   - Tests that pass(tm)
   - Copying icons and cursors from DLL resources, for beautifuler ReactOS, your turn gigaherz ;-)
   - A lot of other things which I am very proud of.
CORE-7575 #resolve

svn path=/trunk/; revision=64921
2014-10-23 11:46:06 +00:00
Jérôme Gardou 946d03c45b [WIN32K]
- Use shared icon handles when copying the small class icon from the larger one.
CORE-7575

svn path=/trunk/; revision=64920
2014-10-23 11:46:01 +00:00
Jérôme Gardou f20e2e7a8f [USER32]
- Implement CopyImage(LR_SHARED) case.
CORE-7575

svn path=/trunk/; revision=64919
2014-10-23 11:45:55 +00:00
Jérôme Gardou 796aebbf35 [USER32]
- Cursoricon objects are allocated on the user heap, not the desktop heap.
CORE-7575

svn path=/trunk/; revision=64918
2014-10-23 11:45:50 +00:00
Aleksandar Andrejevic f991665f09 [FAST486][NTVDM]
Arch, I/O port numbers should always be stored in USHORT variables!


svn path=/trunk/; revision=64917
2014-10-23 11:44:07 +00:00
Jérôme Gardou 03b386d0e0 [USER32_APITEST]
- Add a test showing that CopyImage accepts LR_SHARED flag.
CORE-7575

svn path=/trunk/; revision=64916
2014-10-23 11:19:21 +00:00
Jérôme Gardou f0e276168d [WIN32K]
- Call IntDestroyCurIconObject instead of explicitly destroying the handle.
CORE-7575

svn path=/trunk/; revision=64915
2014-10-23 09:52:57 +00:00
Jérôme Gardou 6e51ca263b [WIN32K]
- Reference cursor and icon objects when copying a class from one heap to another.
CORE-7575

svn path=/trunk/; revision=64914
2014-10-23 09:32:46 +00:00
Jérôme Gardou 78c8971f65 [USER32]
- Return the right value in CopyImage when copying cursors/icons
CORE-7575

svn path=/trunk/; revision=64913
2014-10-23 09:32:43 +00:00
Jérôme Gardou 54592b1afb [WIN32K]
- Remove the cursor from the process cache when its handle is deleted, not after.
 - Do not return an invalid handle in NtUserSetCursor.
CORE-7575

svn path=/trunk/; revision=64912
2014-10-23 09:32:39 +00:00
Jérôme Gardou 797a6346f2 [USER32]
- Fix LookupIconIdFromDirectoryEx, returning 0 when no matching entry is found.
 - Fix error handling when opening a cursor file.
 - Various code beautification here and there
CORE-7575

svn path=/trunk/; revision=64911
2014-10-23 09:32:21 +00:00
Timo Kreuzer 8dc7d09ca1 [CRT/OLDNAMES]
Fix ARM build, patch by Yuntian Zhang with minor adjustment by me.
CORE-8666 #resolve #comment Committed in r64910, thanks!

svn path=/trunk/; revision=64910
2014-10-23 09:22:45 +00:00
Timo Kreuzer 70bd834afe [CRT]
Do not raise an exception in _invalid_parameter, which is only done in later MSVCRTs. Wine uses a symbolic constant (_MSVCR_VER) to handle this and other things and compiles their CRT code multiple times. As an alternative we could use a global version variable to avoid recompiling, once we implement other CRT dlls.
CORE-8670 #resolve

svn path=/trunk/; revision=64909
2014-10-23 09:05:32 +00:00
Kamil Hornicek 0f21d941ce [I8042PRT]
- check the right buffer's length
[WIN32K]
- simplify IntKeyboardUpdateLeds a bit and mind previous mode
- fixes keyboard indicators
CORE-8547

svn path=/trunk/; revision=64908
2014-10-22 20:05:32 +00:00
Thomas Faber b990d9a4c9 [RTL]
- Address a review comment by Timo -- use more explicit comparison

svn path=/trunk/; revision=64907
2014-10-22 19:40:13 +00:00
Thomas Faber d13df46fe4 [NTOS:FORMATTING]
- Trip trailing whitespace in Io/Pnp

svn path=/trunk/; revision=64906
2014-10-22 19:34:46 +00:00
Timo Kreuzer 5c0f6850a4 [XDK/DDK]
Improve debugprint in __assert_annotationA/W

svn path=/trunk/; revision=64905
2014-10-22 19:30:27 +00:00
Kamil Hornicek 93d7ffd181 [SERVMAN]
- better fix for CDI 513719, LVText might not be null terminated - spotted by Timo

svn path=/trunk/; revision=64904
2014-10-22 19:28:33 +00:00
Timo Kreuzer 86018d03c4 [NTOSKRNL]
- Fix potential use-after-free CID 732509
- Fix buffer size in call to ObQueryNameString

svn path=/trunk/; revision=64903
2014-10-22 19:20:03 +00:00
Hervé Poussineau f42c9182f2 [NTOS:IO] Replace an error message by an assert
This was expected to be done soon after r32518.

svn path=/trunk/; revision=64902
2014-10-22 19:17:13 +00:00
Amine Khaldi a1bc1edda7 [ADVAPI32/CRED]
* Sync with Wine 1.7.27.
CORE-8540

svn path=/trunk/; revision=64901
2014-10-22 18:41:40 +00:00
Amine Khaldi 3bfe9ee622 [ADVAPI32/CRYPT]
* Sync with Wine 1.7.27.
CORE-8540

svn path=/trunk/; revision=64900
2014-10-22 18:29:59 +00:00
Amine Khaldi eabfb53a71 [PSDK]
* Add missing PFE_IMPORT_FUNC and WriteEncryptedFileRaw.

svn path=/trunk/; revision=64899
2014-10-22 18:26:47 +00:00
Amine Khaldi d7530c0ea5 [KERNEL32]
* Zap szCountryListName.
* Comment out unused charset_names and strcpynAtoW.
CORE-8540

svn path=/trunk/; revision=64898
2014-10-22 18:05:36 +00:00
Amine Khaldi 5bc272dbc3 [KERNEL32]
* Sync GetStringTypeW with Wine 1.7.27.
* Allows more kernel32:locale tests to run.
CORE-8540

svn path=/trunk/; revision=64897
2014-10-22 17:58:58 +00:00
Amine Khaldi 1994661271 [KERNEL32]
* Sync LCMapString{A,W} with Wine 1.7.27.
CORE-8540

svn path=/trunk/; revision=64896
2014-10-22 17:52:18 +00:00
Amine Khaldi 06e986393a * Sync up to trunk head (r64894).
svn path=/branches/shell-experiments/; revision=64895
2014-10-22 17:07:43 +00:00
Amine Khaldi c094a9b51f [CMAKE]
* Allow the use of the LOCATION property with new CMake versions.

svn path=/trunk/; revision=64894
2014-10-22 16:56:56 +00:00
Amine Khaldi f47eeb21ab [TASKMGR]
* Minor style changes in wWinMain.

svn path=/trunk/; revision=64893
2014-10-22 16:51:25 +00:00
Amine Khaldi 4ef9ff28e2 [KERNEL32]
* Zap NLS_RegEnumSubKey.

svn path=/trunk/; revision=64892
2014-10-22 16:43:19 +00:00
Amine Khaldi 18ec4d369d [KERNEL32]
* Replace EnumSystemGeoID with the one from Wine 1.7.27.
* Fixes some kernel32:locale tests.
CORE-8540

svn path=/trunk/; revision=64891
2014-10-22 16:40:54 +00:00
Kamil Hornicek 6f16539c0c [TASKMGR]
- fix CIDs 731628 (unlikely buffer overrun), 500038 (dead code), 1101977 (unchecked return value)

svn path=/trunk/; revision=64890
2014-10-22 16:01:24 +00:00
Thomas Faber 6256673633 [NTOS:MM]
- Add a way to generate a pool tag from the calling driver name if none is specified. Disabled by default.

svn path=/trunk/; revision=64889
2014-10-22 13:26:50 +00:00
Thomas Faber 2e4b0e9661 [NTOS:MM]
- Add missing call to ExpSeedHotTags

svn path=/trunk/; revision=64888
2014-10-22 13:18:10 +00:00