Fix the value for EIP used by KDBG after an INT3 set by KDBG itself. The address is already fixed by KiDispatchException, but only in the context frame, not in the trap frame and KDBG insists to use the trap frame for a lot of things. Also, after a cont from such an int3, KDBG uses a single step to re-enable the breakpoint (it needs to disable it after it was hit to be able to execute the actual instruction), but it used to dismiss *any* single steps after that. So make sure, that an actual single step, as created by the debugger is not being dismissed, but the break point is still restored after the next single step entry. You might expect that a kernel debugger would at least support setting breakpoints, but this is KDBG.
svn path=/trunk/; revision=70416
- Change the start type to demand.
- Should stop free loader from throwing a tantrum because it can't load a non-existant boot driver
svn path=/trunk/; revision=70414
Correctly fix the definition of DRIVER_FS_NOTIFICATION (done the same way as the other DRIVER_xxx "callback" functions; by the way you'll notice they are all NTAPI aka. __stdcall. This is not explicitely mentioned in the W(D)DK, because MS supposes you compile all your kernel-mode code in stdcall convention, the WDK environment coming with preset default compiler switches enabling that. But if you try changing them, you'll run into big troubles. In our headers on the contrary we explicitely mention the calling conventions).
[FLTMGR]
Fix FltpFsNotification to adhere to the correct DRIVER_FS_NOTIFICATION definition.
Addendum to r70410.
svn path=/trunk/; revision=70413
Pass cjMaxBits parameter from GreCreateDIBitmapInternal to IntCreateDIBitmap and check the image size before creating the bitmap.
Should fix crash when hitting about tab in Office2000 WinWord.
CORE-10583 #comment please retest
svn path=/trunk/; revision=70412
- Add the beginning of the fltmgr. It's called rosfltmgr for now so I can test in Windows.
- It's currently just base code which registers for file systems appearing (or disappearing), and attaches itself to them and all other mounted devices in their chain.
- Although it builds (touch wood), don't add it to a running system. The IRPs aren't plugged in yet and it'll just bugcheck lower down the stack.
svn path=/trunk/; revision=70409
- Raise the IRQL when enumerating device lists so it doesn't get edited mid-listing
- Don't hardcode the pointer size when checking the buffer size
svn path=/trunk/; revision=70408
Save parameter registers (rcx, rdx) before calling CallRealMode. Patch by andy-123, applied to a secondary location by me.
CORE-10511 #resolve #comment Thanks. I added the same fix to PnpBiosGet below.
svn path=/trunk/; revision=70407
Hack, that fixes the "Volatile Environment" bug by deleting the "Volatile Environment" key before the user hive is unloaded.
CORE-10705
svn path=/trunk/; revision=70406
Do not use the "LoaderBlock->u.I386.CommonDataArea;" hack to use FreeLdr's DbgPrint function inside KDCOM, for the simple reason that while it works when KDCOM just initializes, the memory area where FreeLdr's DbgPrint function is, gets erased when ReactOS is running. As a result, all attempts to call the DbgPrint function when tracing something in KDCOM at the end of life of ReactOS, just fails lamentably (it hangs).
We therefore cannot rely on external code to provide us with DbgPrint. Instead, implement a very simple DbgPrint function inside KDCOM, as done by KDGDB.
The KD serial port serving for debugging KDCOM is chosen dynamically amongst the other free COM ports.
This needs to be also fixed in KDVM.
[KDGDB]
Instead of hardcoding the KD serial port number serving for debugging KDGDB, determine it dynamically amongst the other free COM ports.
svn path=/trunk/; revision=70405
- Allow to specify in freeldr.ini the debugging port parameters, similarly to what NTLDR allows to do: http://naesten.blogspot.fr/2010/07/undocumented-debug-section-in-bootini.html
- Update the FREELDR.INI example file to reflect these changes.
- Because some FreeLdr components, that need to be initialized before the debugging port parameters can be read from freeldr.ini, use debugging features, we still need to choose some default parameters. For serial ports, we select the possible port starting from COM4 down to COM1.
CORE-9023 #comment Revision 70403: Allow to specify a debugging port in freeldr.ini .
svn path=/trunk/; revision=70403
When the root item in the treeview is selected, remove all items from the listview and wipe the address bar and status bar.
svn path=/trunk/; revision=70402
- Improve implementation of RtlActivateActivationContextUnsafeFast / RtlDeactivateActivationContextUnsafeFast by replace magic numbers by flag values, which are already defined in rtltypes.h, and adding various debugging checks. Two of them are triggered for yet unknown reason:
* Assert in RtlActivateActivationContextUnsafeFast
* "Trying to activate already activated activation context"
They are commented out in trunk not to annoy everyone.
svn path=/trunk/; revision=70396
Initialize the defauls users locale settings based on the selected locale Id from first stage setup.
#CORE-5989 #resolve
svn path=/trunk/; revision=70389
Fix bugs in pen implementation:
- Do not use the x coordinate to adjust styles, instead they start where the lines start
- Don't leak allocated styles
- Make sure the PEN fields are initialized correctly, even for BRUSHES, so that the destructor can do it's cleanup work
- Fix numerous parameter checks
gdi32_apitest:pen now shows 0 failures!
svn path=/trunk/; revision=70388
- Add french translation (not complete, but enough for now: only what can be currently displayed is translated).
- Don't hardcode the "History" item in the travel-log, but use the localized string. Use the hardcoded string *only* if loading the translation failed.
svn path=/trunk/; revision=70376
Fix hebrew "registry editor" translation.
[SHORTCUTS.INF]
Fix regedit shortcut name (localize it instead of using "regedit")
svn path=/trunk/; revision=70373
Rewrite the two existing tests for ICMP and add a third one (for IPv6).
Patch by Tim Crawford.
ROSTESTS-212 #resolve #comment Commited in r70367. Thanks!
svn path=/trunk/; revision=70367
Surround welcome & debugging messages in #ifndef NDEBUG blocks, that should be compiled in trunk but will be disabled in the release.
This is to "cure" the bad-looking problem described in http://www.reactos.org/forum/viewtopic.php?f=25&t=14620 .
svn path=/trunk/; revision=70365
Apply patch by Mark Jansen (learn_more) with a few tweaks. Fixes calls to Shell_NotifyIconA such as those from VBoxTray.
CORE-10497 #resolve
svn path=/trunk/; revision=70360
- When cleaning the clipboard, cancel any pending delayed rendering and increment all the sequence&serial numbers.
- Fix the clipboard access check when performing a delay rendering. This fixes VBox host <-> guest copy/paste amongst others...
CORE-5512 CORE-9620
CORE-8367 CORE-8627 #comment Please retest with revision >= 70355.
svn path=/trunk/; revision=70355
- Reduce indentation level of some code.
- No need to initialize pWinStaObj when it is reinitialized just after.
- Fix some comments.
svn path=/trunk/; revision=70354
Fix the computation of where bitmap pixels start, depending on whether we are dealing with DIBs or DIBs version 5+ (depending on the header BITMAPINFOHEADER or BITMAPV5HEADER etc...).
I also noticed a bug in Windows that few other people already discovered, related to the automatic conversion of CF_DIBV5/CF_BITMAP to CF_DIB clipboard format. See the comment in the code.
CORE-10679
svn path=/trunk/; revision=70349
- Add support for scrolling with the mouse wheel, by Ricardo Hanke.
- No need to check for CloseClipboard failure & display an error message if the clipboard was successfully opened just before.
- Use ARRAYSIZE macro instead of hardcoding the length of available clipboard format list.
CORE-10679
svn path=/trunk/; revision=70347
