Katayama Hirofumi MZ
a938d19714
[SHELL32] Commonize CCopyToMenu and CMoveToMenu ( #5873 )
...
Reduce code. And correctly do the filename check.
CORE-18909
2023-11-04 21:56:15 +09:00
Andrei Miloiu
c1b12b3f46
[SHELL32] Update Romanian (ro-RO) translation ( #5838 )
2023-11-01 16:56:50 +01:00
Katayama Hirofumi MZ
8a049d0b68
[SHELL32][SDK] Implement CopyStreamUI ( #5848 )
...
- Modify shell32.spec.
- Add CopyStreamUI prototype to <undocshell.h>.
CORE-19278
2023-10-31 22:32:02 +09:00
Katayama Hirofumi MZ
00f192fa94
[SHELL32] Improve file properties dialog ( #5852 )
...
Based on KRosUser's patches.
- Add missing version strings "Comments" and
"LegalTrademarks".
- Add version strings "PrivateBuild" and
"SpecialBuild" if necessary.
- Trim the version string for pretty display.
CORE-19270, CORE-19114, CORE-19275
2023-10-30 15:34:03 +09:00
Katayama Hirofumi MZ
128e7f5aea
[SHELL32][SDK] Implement SHStartNetConnectionDialogA ( #5847 )
...
and add SHStartNetConnectionDialog prototype to <shlobj.h>.
2023-10-28 22:29:05 +09:00
Katayama Hirofumi MZ
a52c713755
[SHELL32][SDK] Follow-up of #5840 ( ad5df2d
)
...
Fix the parameters of Activate_RunDLL.
2023-10-28 21:31:11 +09:00
Katayama Hirofumi MZ
ad5df2d199
[SHELL32][SDK] Implement Activate_RunDLL ( #5840 )
...
- Add Activate_RunDLL function implementation.
- Add Activate_RunDLL prototype to <undocshell.h>.
2023-10-28 14:56:27 +09:00
Katayama Hirofumi MZ
2ccdd87809
[SHELL32][SDK] Implement ShortSizeFormatW ( #5829 )
...
- Implement ShortSizeFormatW.
- Add ShortSizeFormatW prototype into <undocshell.h>.
- Modify shell32.spec.
2023-10-28 14:55:25 +09:00
Katayama Hirofumi MZ
81e936486e
[SHELL32] Implement ExtractIconResInfoA ( #5846 )
...
- Add ExtractIconResInfoA implementation.
- Add ExtractIconResInfo prototype to <undocshell.h>.
2023-10-28 11:38:29 +09:00
Katayama Hirofumi MZ
9dfb3e8e05
[SHELL32][SDK] Implement PathIsSlowA and SHSetFolderPathA ( #5841 )
...
- Implement PathIsSlowA and SHSetFolderPathA functions.
- Add PathIsSlow and SHSetFolderPath prototypes to <shlobj.h>.
- Fix some <shlobj.h>'s bugs.
- Improve SHOpenPropSheetA function.
2023-10-28 09:59:12 +09:00
Katayama Hirofumi MZ
dcc9a2d8f3
[SHELL32][SDK] Implement SHOpenPropSheetA ( #5830 )
...
- Add SHOpenPropSheetA and
SHOpenPropSheetW prototypes to <shlobj.h>.
- Implement SHOpenPropSheetA function.
2023-10-27 19:34:02 +09:00
Katayama Hirofumi MZ
8f6b016963
[SHELL32] Fix copyto/moveto actions of Search Results ( #5816 )
...
- Extend CDefView::InvokeContextMenuCommand 2nd parameter to LPCSTR.
- Add CDefView::_DoCopyToMoveToFolder method.
- Use CDefView::_DoCopyToMoveToFolder for FCIDM_SHVIEW_COPYTO
and FCIDM_SHVIEW_MOVETO command actions.
CORE-18426
2023-10-27 12:34:51 +09:00
Katayama Hirofumi MZ
995f56d1d3
[SHELL32][SDK] Implement IsSuspendAllowed ( #5831 )
...
- Add IsShutdownAllowed helper function.
- Add IsSuspendAllowed prototype to
<undocshell.h>.
- Implement IsSuspendAllowed function.
2023-10-26 23:27:45 +09:00
Katayama Hirofumi MZ
6f86e11aa2
[SHELL32] Revert CDefView change at bc70af4
...
CORE-18426
2023-10-23 08:13:29 +09:00
Katayama Hirofumi MZ
bc70af4c13
[SHELL32] Use IS_INTRESOURCE in CCopyToMenu/CMoveToMenu::InvokeCommand
...
CORE-18426
2023-10-23 07:55:24 +09:00
Whindmar Saksit
ded91e310a
[SHELL32] Enable Apply button when shortcut show mode is changed ( #5807 )
...
Basically this happens when the combobox selection changes.
2023-10-20 13:02:14 +02:00
Whindmar Saksit
34066e475a
GetDetailsOf does not support column flags ( #5755 )
...
GetDetailsOf does not support the column flags used by CompareIDs.
As a side effect, also fixes LPARAM to UINT truncation on 64-bit.
2023-10-03 10:43:44 +02:00
Joachim Henze
058b746bbe
[SHELL32] *.rc: AGAIN! Use 1996 as birth year in IDD_ABOUT for consistency
...
We do use the birth year 1996 instead of 1998
within our msgina pictures already,
and also within the [SDK] for autogenerated file-info.
Since SHELL32 IDD_ABOUT is used by many applications it makes sense to harmonize with that.
Was done already during 0.4.15-dev for SHELL32, but we have to do it again,
since some recent translation PRs to match the en-US.rc again.
2023-09-27 22:23:31 +02:00
Katayama Hirofumi MZ
d1e9fe13de
[SHELL32][SDK] Implement SHTestTokenPrivilegeW ( #5725 )
...
and modify shell32.spec.
2023-09-26 07:36:07 +09:00
Doug Lyons
1b3eed58ca
[SHELL32] Fix for shlexec.cpp regressions ( #5282 )
...
fixes CORE-18967 'Taskbar toolbar - Right click > Open folder fails'
by restoring the code-path we removed with the guilty
0.4.15-dev-3847-g /9b716539182864bc077e362febcda74da50287ed
and add test_sei_lpIDList to shell32:ShellExecuteEx apitest test to protect
that functionality on future attempts to simplify.
2023-09-24 20:35:28 +00:00
Katayama Hirofumi MZ
cc6e444ceb
[SHELL32][SDK] Implement SHInvokePrivilegedFunctionW ( #5718 )
...
Add it to <undocshell.h>. Modify shell32.spec.
2023-09-24 07:11:38 +09:00
Katayama Hirofumi MZ
4407e0aefa
[SHELL32][SDK] Implement SHOpenEffectiveToken and SHGetUserSessionId ( #5713 )
...
- Implement SHOpenEffectiveToken and
SHGetUserSessionId functions.
- Add them to <undocshell.h>.
2023-09-21 22:44:20 +09:00
Katayama Hirofumi MZ
539123c62f
[SHELL32] SHChangeRegistrationReceive just returns FALSE
2023-09-21 12:09:28 +09:00
Katayama Hirofumi MZ
29e1a41d07
[SHELL32][SDK] Implement SHGetShellStyleHInstance ( #5707 )
...
Co-authored-by: Oleg Dubinskiy <oleg.dubinskij30@gmail.com>
This PR supersedes PR #3851 .
- Implement SHGetShellStyleHInstance function.
- Add SHGetShellStyleHInstance prototype to <shlobj.h>.
CORE-17707
2023-09-21 09:22:33 +09:00
Katayama Hirofumi MZ
6c55a3aa2a
[SHELL32][SHELL32_APITEST][SDK] Implement Int64ToString ( #5706 )
...
- Implement Int64ToString and LargeIntegerToString functions.
- Add Int64ToString and LargeIntegerToString prototypes to <shellundoc.h>.
- Add Int64ToString testcase.
- I found a bug in GetNumberFormat.LeadingZero.
http://undoc.airesoft.co.uk/shell32.dll/Int64ToString.php
http://undoc.airesoft.co.uk/shell32.dll/LargeIntegerToString.php
2023-09-21 09:14:40 +09:00
Katayama Hirofumi MZ
5c7a5786fd
[SHELL32] Check m_ListView on some methods ( #5684 )
...
- comdlg32:filedlg could encounter an assertion error in CWindow::SendMessage.
- Assert the existence of the listview control m_ListView in the CDefView::LV_... function.
- Actually check the existence of m_ListView outside the CDefView::LV_... function.
ROSTESTS-388
2023-09-13 22:41:00 +09:00
Stanislav Motylkov
995d255962
[REACTOS] Fix various '% s' typos with a space
...
- [NOTEPAD][REGEDIT][SHELL32] were affected.
- Also while being here, fix headers.
2023-09-07 00:34:02 +03:00
Stanislav Motylkov
6a81e5f4d7
[SHELL32] Fix standard log off dialog layout
...
Make it consistent between translations and other misc fixes.
2023-09-07 00:16:08 +03:00
Tibor Lajos Füzi
3068422d51
[TRANSLATION] Update hungarian translation for mspaint, notepad, taskmgr, explorer, appwiz, browseui, msgina, shell32 ( #5645 )
2023-09-03 17:46:38 +02:00
Stanislav Motylkov
67645ab7a8
[SHELL32] Update Russian (ru-RU) translation
2023-09-02 22:56:38 +03:00
Whindmar Saksit
ed9d2a06b0
[SHELL32] Handle HotKey and ShowCmd on the shortcut property page ( #5638 )
...
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
2023-09-02 21:16:22 +03:00
Stanislav Motylkov
72b59e2459
[SHELL32] Update Russian (ru-RU) translation
2023-08-31 20:10:02 +03:00
Katayama Hirofumi MZ
294ec1e6f4
[SHELL32] Update Japanese (ja-JP) tranlation
...
CORE-18706
2023-08-31 20:21:45 +09:00
Katayama Hirofumi MZ
aa719b9989
[SHELL32] SHFileOperation: Confirm overwrite on moving files ( #5618 )
...
- Add move_file_to_file helper function.
- Modify move_to_dir and move_files helper
functions.
CORE-18910
2023-08-29 19:29:05 +09:00
William Kent
bea7848fa9
[SHELL32] Add two missing GlobalUnlock() calls ( #5625 )
...
* [SHELL32] Release DROPFILES structures
* [SHELL32] Release the STGMEDIUM when returning on error
2023-08-28 21:56:02 +02:00
Katayama Hirofumi MZ
2c9c634a8e
[SHELL32] Implement SHFindComputer ( #5524 )
...
CORE-9277
2023-08-12 18:17:13 +09:00
Andrew Dent
815d55c378
[REACTOS] British English spellings ( #5533 )
...
Fix spellings for en-GB:
- Centre.
- Colour.
- Customise.
- Unauthorise.
2023-08-09 11:48:59 +02:00
Andrew Dent
72ea2d4c26
[REACTOS] Spelling fixes ( #5534 )
...
Fix spellings / hyphenation: `unassociate` ; `read-only` ; `double-click`
2023-08-09 11:48:07 +02:00
Katayama Hirofumi MZ
ea97c48909
[SHELL32][SDK] Implement SHCreatePropertyBag ( #5541 )
...
- Implement SHCreatePropertyBag function in utils.cpp.
- Add its prototype to <undocshell.h>.
CORE-9283
2023-08-07 17:02:39 +09:00
Katayama Hirofumi MZ
63fae07d12
[SHELL32][SDK] Implement SHIsTempDisplayMode ( #5523 )
...
CORE-9277
2023-08-07 09:50:30 +09:00
Katayama Hirofumi MZ
520577a8ec
[SHELL32] Rename file on copy-paste path collision ( #5462 )
...
- If the source and destination of copying file are on the same directory,
then enable FOF_RENAMEONCOLLISION flag. End if.
- Don't show error message IDS_COPYERRORSUBFOLDER or
IDS_MOVEERRORSUBFOLDER if the source and the destination are the same.
CORE-18599
2023-08-06 20:56:45 +09:00
Katayama Hirofumi MZ
6413024cab
[SHELL32] Move SheRemoveQuotesA/W to utils.cpp ( #5535 )
...
* [SHELL32] Move SheRemoveQuotesA/W to utils.cpp
Follow-up to #5529 (7100fa8
).
JIRA issue: CORE-9277
2023-08-06 13:07:39 +02:00
Katayama Hirofumi MZ
7100fa8854
[SHELL32] Move SheRemoveQuotesA/W to iconcache.cpp ( #5529 )
...
Follow-up to #5517 (358e45d
). stubs.cpp is for stub functions only. CORE-9277
2023-08-05 21:17:06 +09:00
Katayama Hirofumi MZ
358e45d33a
[SHELL32][SHELL32_APITEST][SDK] Implement SheRemoveQuotesA/W ( #5517 )
...
- Implement SheRemoveQuotesA and SheRemoveQuotesW functions.
- Add She testcase into shell32_apitest.
- Add SheRemoveQuotesA/W into <undocshell.h>.
CORE-9277
2023-08-05 19:44:13 +09:00
Huw Campbell
1273bbe417
[SHELL32] Improve CFSDropTarget::CopyItems logic ( #5481 )
...
The previous version resolved the path of the parent then did logic
assuming simple pidls. This now resolves each source directly.
This change addresses a longstanding TODO in copying and moving to shell folders.
It's a simple change, but it removes a bit of code and makes things simpler.
Corresponding Wine PR: https://gitlab.winehq.org/wine/wine/-/merge_requests/3360
2023-08-05 13:12:36 +03:00
Katayama Hirofumi MZ
2e9d03da90
[SHELL32][SDK] Implement SHLimitInputCombo ( #5521 )
...
SHLimitInputCombo function sets limits on valid characters for a combobox control.
This function works like SHLimitInputEdit, but the target is a combobox instead of a textbox.
CORE-9277
2023-08-04 22:29:05 +09:00
Thamatip Chitpong
32411dece0
[SHELL32] Fix taskbar large icon for control panel applets
...
Addendum to 0e8cf6f
(#5465 ).
CORE-11698
2023-08-03 16:43:08 +07:00
Katayama Hirofumi MZ
52bc5f7c5d
[IEXPLORE][IEFRAME][SHELL32] Add Internet icon on Desktop ( #5451 )
...
- Add Internet icon on Desktop. You can hide/show
the icon from Desktop's customization.
- Modify "HKCR\CLSID\%CLSID_Internet%" registry key.
- Add IDS_INTERNET and IDS_INTERNET_DESCRITION into ieframe.dll.
- Modify folders/CDesktopFolder.cpp and folders/CRegFolder.cpp to add the icon.
CORE-18625
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
2023-07-22 19:28:37 +09:00
Doug Lyons
d02cb099c8
[SHELL32] Fix condition check for GetDisplayNameOf() return value ( #5444 )
...
This fixes 'Attempt to free an invalid HEAP address' error. CORE-18841
Confirmed by running new tests written by Mark Jansen, showing that
previous behavior was wrong. While here, also fix a typographical error.
2023-07-22 13:24:25 +03:00
Katayama Hirofumi MZ
62eaad1811
[SHELL32] CD-ROM drive shouldn't be renamed ( #5461 )
...
- Add _ILGetDriveType helper function.
- Use _ILGetDrive and GetDriveType functions to determine the drive type.
- If it was a CD-ROM drive, then remove SFGAO_CANRENAME flag.
CORE-18272
2023-07-20 16:53:04 +09:00