Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-04-05 13:11:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SHELL32] Fix condition check for GetDisplayNameOf() return value (#5444)

Browse source 
This fixes 'Attempt to free an invalid HEAP address' error. CORE-18841

Confirmed by running new tests written by Mark Jansen, showing that
previous behavior was wrong. While here, also fix a typographical error.
This commit is contained in:
Doug Lyons 2023-07-22 05:24:25 -05:00 committed by GitHub
parent 104ef25fcc
commit d02cb099c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dll/win32/shell32/droptargets/CFSDropTarget.cpp
View file

@ -74,7 +74,7 @@ HRESULT CFSDropTarget::_CopyItems(IShellFolder * pSFFrom, UINT cidl,
STRRET strretFrom;
hr = pSFFrom->GetDisplayNameOf(NULL, SHGDN_FORPARSING, &strretFrom);
if (FAILED_UNEXPECTEDLY(hr))
if (hr != S_OK)
return hr;
pszSrcList = BuildPathsList(strretFrom.pOleStr, cidl, apidl);