Commit graph

2862 commits

Author SHA1 Message Date
Maj Soklič
8ba5f1c1db
[SNDVOL32] Remove redundant WS_TABSTOPs from RC files (#7003) 2024-06-12 12:09:47 +02:00
Katayama Hirofumi MZ
e1094e6f8a [USETUP] Update Japanese (ja-JP) translation
CORE-18706
2024-06-11 15:15:26 +09:00
Hermès Bélusca-Maïto
c752e8c0be
[SETUPLIB] FindSupportedSystemPartition(): Add missing NULL check
Addendum to commit 59acff79e.
2024-06-10 13:14:28 +02:00
Piotr Hetnarowicz
ca4faec8a3
[EXPLORER] Update Polish (pl-PL) translation (#6685)
Reviewed-by: Adam Stachowicz <saibamenppl@gmail.com>
Reviewed-by: Adam Słaboń <asaillen@protonmail.com>
2024-06-10 12:52:16 +03:00
Whindmar Saksit
3f6af8b848
[RAPPS] Improve existing window re-use (#5617)
- Fix small race between CreateMutex and CMainWindow creating the window, and another instance getting NULL from FindWindow.
- If the existing window is minimized, it should be restored.
2024-06-08 01:18:18 +02:00
Anderson Rodrigues
a061747295
[TASKMGR] Fix orthographic error in Portuguese Brazilian (pt-BR) translation (#6980) 2024-06-05 21:30:49 +03:00
Whindmar Saksit
063997f2e0
[REGEDIT] Implement the "Go to HKCU/HKLM" feature (#6900) 2024-06-04 15:40:14 +02:00
Thamatip Chitpong
b631c5d3b1 [WINMINE] Add EXE version info 2024-06-04 00:36:04 +07:00
Thamatip Chitpong
b399f7d5b4 [SPIDER] Add EXE version info 2024-06-04 00:36:04 +07:00
Thamatip Chitpong
a01cbc3ac2 [SOLITAIRE] Add EXE version info 2024-06-04 00:36:04 +07:00
Oleg Dubinskiy
4ad83ef095 [WINMINE] Update Ukrainian (uk-UA) translation
Translate the "Sound" menu item to Ukrainian.
2024-06-03 18:45:04 +02:00
Oleg Dubinskiy
94a25e66de [WINMINE] Update Russian (ru-RU) translation
Translate the "Sound" menu item to Russian.
2024-06-03 18:41:04 +02:00
Thamatip Chitpong
580574fba8
[WINMINE] Add sound effects (#6969)
- Sound is disabled by default
- Use WinXP-compatible registry key and value
2024-06-03 21:57:44 +07:00
Jose Carlos Jesus
51f3cf0509
[NOTEPAD] pt-PT: Fix accel collisions. Improve menu cmd translation (#6978)
* [NOTEPAD] Fix accel collisions. Improve menu cmd translation (pt-PT)
* [NOTEPAD] Update portuguese (pt-PT) translation
2024-06-02 20:02:33 +02:00
Jose Carlos Jesus
abd34b6d90
[REGEDIT] pt-PT.rc: Fix accels collisions (#6975)
accels compatibility closer to Win2003 Server

Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
2024-06-02 12:06:13 +02:00
Joachim Henze
e1db293f12
[REGEDIT] *.rc Improve accels and harmonize a bit, especially de-DE (#6964)
- all languages: Strip unintended accelerators for Cancel-buttons
- many languages: had accel collision between "&File"-menu and "&Favorites" menu. It must be "F&avrites" for those!
- de-DE: "&Wertname:" -> "&Name:" was done because this is what Windows does and to fix an accel collision between "&Wert" and "&Wertname"
- de-DE: use the same name for String, DWORD, MULTISTRING, EXPANDABLESTRING in all 3 dialogs (each of the 3 dlgs used different names before), which also fixes an accel collision between "&Schlüssel" and "&String"
- de-DE: structurally use "Sc&hlüssel", instead of mixed things
- de-DE: "&Trennen" -> "&Teilen" is what Windows does
- de-DE "&Ändern" -> "Än&dern" is what Windows does, and avoids accel at a special character
- de-DE "&Über" -> "Inf&o" is what Windows does, and avoids accel at a special character
- de-DE "S&chlüsselnamen kopieren" -> "Schlüsselnamen &kopieren" is to match another already existing "Schlüsselnamen &kopieren" in the file
- de-DE "A&lles auswählen" -> "Alles &markieren" is what Windows does
- all languages: fix 26x wrong capitalization for "Ms Shell Dlg" -> "MS Shell Dlg"
- use the correct fonts for some asian languages (font-size9) this was for 5 new dlgs from 0.4.15-dev'ing
- fix many accelerator collisions for many languages, or leave FIXMEs for them where I found it to be better for the native speakers to act on their own in the future

JIRA issue: none
2024-05-31 17:28:39 +02:00
Serge Gautherie
3cc4361cca
[CMAKE] Clang*: Add '-Werror=unknown-warning-option' for C/CXX (#6383)
* [UDFS] Clang: Fix a #pragma

'warning: unknown warning group '-Wstringop-overflow', ignored [-Wunknown-warning-option]'

Follow-up to 612b1f2e6 (0.4.15-dev-1129).

* [CREATESPEC] Clang: Fix a target_compile_options()

'warning: unknown warning option '-Wno-stringop-overflow'; did you mean '-Wno-shift-overflow'? [-Wunknown-warning-option]'

Addendum to 00ed72d7e (0.4.15-dev-1169).

* [MSVCRT_WINETEST] Clang*: Fix a target_compile_options()

'warning: unknown warning option '-Wno-stringop-truncation'; did you mean '-Wno-string-concatenation'? [-Wunknown-warning-option]'

Addendum to commits 00ed72d7e (0.4.15-dev-1169) then f155b9377 (0.4.15-dev-4612).

* [TELNET] Clang*: Fix a target_compile_options()

'warning: unknown warning option '-Wno-restrict' [-Wunknown-warning-option]'

Addendum to 447ef2aa4 (0.4.15-dev-4613).
2024-05-31 16:26:11 +02:00
Whindmar Saksit
43b3280f69
[EXPLORER] Don't use Explorers ID_SHELL_CMD IDs in IShellFolder menu (#6872)
Explorer does not control the IDs used by CFSFolder::QueryContext menu and therefore cannot share its ID range with it. The range passed to CFSFolder::QueryContext also cannot start at 0 because CTrayWindow::TrackCtxMenu would interpret that as user cancel.
2024-05-21 12:57:54 +02:00
Whindmar Saksit
2198247bdf
[REGEDIT] Implement "Add to favorites" feature (#6890)
The ability to go to a favorite and the dialog was already there, just needed to fill in the blanks.
2024-05-21 09:31:24 +02:00
Whindmar Saksit
108db8f007
[CSCRIPT][WSCRIPT][BOOTDATA] Basic .wsf support (#6140)
Support for .wsf files with a single script block
2024-05-19 13:57:47 +02:00
Katayama Hirofumi MZ
e0ba2f3372 [NOTEPAD] Kill warning by typecast (int) in DIALOG_StatusBarUpdateCaretPos
JIRA issue: N/A
2024-05-16 12:35:01 +09:00
Whindmar Saksit
15c42f3ef8
[REGEDIT] Check the correct value in WM_ACTIVATE (#6895) 2024-05-15 22:33:41 +02:00
Katayama Hirofumi MZ
2b0d1faaa9
[WORDPAD] Use FILE_SHARE_READ and OPEN_ALWAYS for writing (#6883)
Follow-up to #6880. Fix access denial on
writing file "C:\freeldr.ini".
JIRA issue: CORE-19575
- Add FILE_SHARE_READ flag in CreateFileW
  call.
- Use OPEN_ALWAYS instead of
  CREATE_ALWAYS, and then explicitly use
  SetEndOfFile function.
2024-05-15 01:23:30 +09:00
Katayama Hirofumi MZ
a64cccd711
[NOTEPAD] Use FILE_SHARE_READ and OPEN_ALWAYS for writing (#6880)
Fix access denial on writing file "C:\freeldr.ini".
JIRA issue: CORE-19575
- Add FILE_SHARE_READ flag and delete
  FILE_SHARE_WRITE flag in CreateFileW call.
- Use OPEN_ALWAYS instead of
  CREATE_ALWAYS, and then explicitly use
  SetEndOfFile function.
2024-05-15 01:22:17 +09:00
Doug Lyons
1a162375f9
[W32TIME] Change clock update interval to 4 hours (#5940)
* Create W32TIME_POLL_INTERVAL. Set it to 4 hours and use it to set SpecialPollInterval.
2024-05-13 15:01:25 -05:00
Whindmar Saksit
5db69da46b
[RAPPS] DelRegEmpty instruction should be best-effort, don't propagate any errors (#6860)
DelRegEmpty exists to clean up "company" registry parent keys. If another application is writing to the key at the same time as we are gently trying to remove it, our uninstaller should ignore any errors.
2024-05-12 00:07:54 +02:00
Connie Sarah
ede7389fb6
[SNDVOL32] Add CTRL-S hotkey to switch between Small/Normal modes (#6867)
This adds a hotkey (CTRL-S) which switches between the Normal and Small
modes of the Volume Control window (also seen in Windows XP).

CORE-17043

Signed-off-by: Connie Julie <alexnicolas155@yahoo.com>
2024-05-11 11:22:39 +03:00
Andrei Miloiu
762d042a15
[MSTSC] Update Romanian (ro-RO) translation (#6841) 2024-05-10 22:33:08 +02:00
Andrei Miloiu
2c96a6b614
[WINLOGON] Update Romanian (ro-RO) translation (#6773) 2024-05-10 21:46:46 +02:00
Andrei Miloiu
c2931ef23d
[OSK] Update Romanian (ro-RO) translation (#6706) 2024-05-10 21:41:00 +02:00
Andrei Miloiu
7fe8512f4f
[MAGNIFY] Update Romanian (ro-RO) translation (#6664) 2024-05-10 21:36:42 +02:00
Thamatip Chitpong
750bf12256
[RAPPS] Fix refresh not working correctly (#6864)
Addendum to commit 33c2903e6d
CORE-18459
2024-05-10 22:59:19 +07:00
Carl J. Bialorucki
190b3da95d
[CMD][BOOTDATA] Minor improvements (#5745)
* Remove a hardcoded copyright string and move into localizable resources.
* Remove the PROMPT environment variable from clean installs of ReactOS. By default, the command prompt uses $P$G (path + '>') as its prompt settings and does not require this environment variable. Clean installs of Windows Server 2003 do not include this environment variable either. I documented this environment variable in our wiki if anyone would like to set it on their own ReactOS installs.
* Remove the new line above the copyright notice when the information line is turned off.

CORE-16193, CORE-17031
2024-05-09 10:03:43 -06:00
Whindmar Saksit
57b775ef6e
[RAPPS] Automatically generate installer/uninstaller for downloaded zip/cab files (#6652)
With a single database line added to applications distributed as zip/cab allows rapps.exe to act as an installer that automatically extracts the files and creates a startmenu shortcut. It can also uninstall the extracted files (and optionally other files and registry entries created by the application).
2024-05-08 23:58:54 +02:00
Maj Soklič
ad8392602e
[EVENTVWR] Fix missing keyboard navigation (#6835)
CORE-19566

- Move IDC_NO_OVERWRITE right below IDC_OVERWRITE_OLDER_THAN;
- Remove WS_GROUP from IDC_NO_OVERWRITE, IDC_OVERWRITE_OLDER_THAN and IDC_UPDOWN_EVENTS_AGE.
2024-05-08 19:00:02 +02:00
Hermès Bélusca-Maïto
a7cbb60ebf
[SETUPLIB] Don't flag freeldr.ini as read-only during installation.
CORE-19575

For the time being, don't add read-only attribute for ease of testing
and modifying files, but it won't always stay this way.

For example, Windows sets its boot.ini (as well as NTLDR, NTDETECT.COM
etc.) as read-only (+ hidden and system) during its 1st-stage setup.
2nd-stage setup makes some adjustments in boot.ini but doesn't restore
its read-only attribute.
Windows tools that can modify boot.ini (i.e. msconfig.exe, bootcfg.exe,
and sysdm.cpl) **ALL** know how to remove the read-only attribute for
modifying boot.ini, before restoring it if needed.
2024-05-07 19:30:33 +02:00
Hermès Bélusca-Maïto
2b43390d04
[SETUPLIB] Use new BootPath value for BootSector boot entries (#6815)
The BootDrive and BootPartition values are deprecated, and support
for them will soon be removed from FreeLoader.

Add an helper function to migrate these values during ReactOS
(re)installation / update.
2024-05-07 12:33:14 +02:00
Maj Soklič
e79c896592
[REGEDIT] Early return FALSE in CreateNewKey() if pszKeyPath is NULL (#6840)
This fixes unhandled exception when trying to create a new key
in the root/"My computer". CORE-19567
2024-05-06 23:46:55 +03:00
Hermès Bélusca-Maïto
c7295b2cdf
[SETUPLIB] Support different boot store file creation/opening and access modes
The support is so far enabled only for INI files (freeldr.ini, boot.ini).
May be subject to further improvements in the future.

Usage examples:

- When finding existing ReactOS or Windows installations, the boot store
  should exist and is opened in read-only mode. Closing the boot store
  doesn't store any temporary modifications made to it.

- When doing a clean installation, freeldr.ini is created in read-write
  access.

- When installing with an existing freeldr.ini or boot.ini, they are
  opened as existing files in read-write access.
2024-05-06 21:13:23 +02:00
Hermès Bélusca-Maïto
9b563d32d2
[SETUPLIB] Improve a bit the management of boot-store options
- QueryBootStoreOptions(): De-duplicate code.
- SetBootStoreOpt(): Respect the FieldsToChange flag.
- BOOT_STORE_OPTIONS: Remove unused Version field and distinguish
  between "Current" and "Next" BootEntryKey.
2024-05-06 17:05:03 +02:00
Hermès Bélusca-Maïto
68c2a28973
[SETUPLIB] Split OpenAndMapFile function and Doxygen-ize it 2024-05-06 17:00:01 +02:00
Hermès Bélusca-Maïto
e151ef9ae1
[SETUPLIB] Add support for removing sections and key values, and remove some hacks (#6815)
- Use LIST_ENTRY instead of custom list pointers;
- Fix key/section unlinking before freeing.
2024-05-05 18:15:31 +02:00
Hermès Bélusca-Maïto
b9ca9b0061
[SETUPLIB] Don't create new INI sections or key-values if they already exist (#6815)
- If a section already exists, return the existing one. This allows
  avoiding different section entries with the same name in the cache.
  If an INI file has separate sections with the same name, their
  contents (key-values) get merged into a unique section.

- If a key-value already exists, update its data value and return the
  existing one. (Note that this may be subject to behaviour change in
  the future.)
2024-05-05 18:15:31 +02:00
Hermès Bélusca-Maïto
817c27a54e
[SETUPLIB] Some INI support refactoring: function/struct names, duplicated code (#6815)
And convert ANSI strings to UNICODE in a better way instead of
zero-extending them.
2024-05-05 18:15:24 +02:00
Thamatip Chitpong
cd0bb1af07 [TASKMGR] Process page: Allow using "Open File Location" functionality without running Explorer shell
If Explorer shell is not available, use ReactOS's alternative file browser instead.
2024-04-26 07:16:00 +07:00
Thamatip Chitpong
6d16d27462 [TASKMGR] Process page: Improve readability of command line string formatting code 2024-04-26 07:16:00 +07:00
Carlo Bramini
605fa32d45
[CALC] Fix input bug when display is in error. (#5988)
CORE-19191

Reproduce the same behaviour of the calculator for Windows XP when an error condition is met.
When the result is NaN and it cannot be printed, the error condition is cleared by pressing the CLEAR button.
2024-04-18 11:39:46 +02:00
Katayama Hirofumi MZ
d383b20b01
[REGEDIT] Correctly limit splitter's X coordinates (#6758)
JIRA issue: CORE-19516
- Add ClampSplitBarX helper function to delete
  duplicated code.
- Use a signed value in WM_LBUTTONUP handling.
- Use ClampSplitBarX in ResizeWnd function,
  WM_LBUTTONDOWN, WM_MOUSEMOVE, and
  WM_LBUTTONUP handling.
2024-04-18 06:09:58 +09:00
Carl J. Bialorucki
ea34ecc9ec
Check if dwBandID is NULL before getting band object (#6738)
fixes CORE-18807 'Our explorer.exe ATL-asserts when executed on XPSP3'
which most likely got unhidden when we enabled the ATL-assertions in
0.4.15-dev-5023-g 55343f04b0
2024-04-15 01:08:01 +02:00
Joachim Henze
ba170757d6
[REGEDIT] Anonymize CONTROL "List1" (#6735)
This saves a few bytes in the binary, e.g.
regedit.exe master 0.4.15-dev-7887-g64a59a1 RosBEWin2.2.2 GCC8.4.0 dbg x86 shrinks
from 1.049.600 bytes to 1.049.080 bytes.

Furthermore it syncs the translations at this line, because es-ES.rc even translated that identifier to "Lista1" already.
2024-04-14 11:10:01 +02:00