Commit graph

660 commits

Author SHA1 Message Date
Katayama Hirofumi MZ a882ec7a02 [SHELL32][EXPLORER] Update system-wide environment variables (#663)
- Implement shell32 RegenerateUserEnvironment() function and use it.
- CShellBrowser and CDesktopBrowser implements WM_SETTINGCHANGE actions.

CORE-1459, CORE-14397
2018-07-08 16:32:42 +02:00
Hermès Bélusca-Maïto c7022c1b0c
[KERNEL32] Use NULL for pointers. 2018-07-07 18:58:03 +02:00
Mark Jansen 3904fd6257
[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond.
This should fix a timeout on the apitests.
2018-07-06 21:51:24 +02:00
Timo Kreuzer e39876dab7 [SDK] Fix 64 bit issues 2018-07-01 14:45:21 +02:00
Hermès Bélusca-Maïto b7c4c4dc79
[COMDLG32] Add the missing NEWFILEOPENV2ORD dialog resource, whose absence made all of the Open/Save-file dialogs not displaying anymore.
This was a regression from last Wine (Staging) 3.9 sync (f68b0c51) that
introduced the usage of this new dialog.
To do: Properly generate the dialog localization.

CORE-14656, CORE-14674, CORE-14689, CORE-14769
2018-07-01 00:44:48 +02:00
Hermès Bélusca-Maïto 2afb483a9e
[SHELL32] Shell Profile Folders fixes.
- Fix a regression introduced in r65415 (1795a3bf) where the directory
  paths stored in "Windows\CurrentVersion\Explorer\User Shell Folders"
  were stored in expanded format instead of in unexpanded format:
  _SHGetDefaultValue() *MUST* return unexpanded paths by design!!

- Augment _SHExpandEnvironmentStrings() and _SHGetUserShellFolderPath()
  to take a user token handle to be able to correctly resolve/expand
  user-specific directory paths.

- Fix _SHExpandEnvironmentStrings() so that it always retrieve the
  correct current user / all-users directory paths by calling userenv
  functions, instead of hardcoding a broken logic. As a result this
  removes the "C:\Documents and Settings\SYSTEM" ghost directory we got
  during ReactOS installation.

- Delimit the changes with respect to Wine by #if(n)def __REACTOS__ .
2018-06-30 18:20:08 +02:00
Stanislav Motylkov 73aa420f0e [SHELL32] Update russian translation
CORE-11407
2018-06-30 01:15:41 +02:00
Stanislav Motylkov 707f2ed360 [SHELL32] Fix some elements positions and styles
Addendum to eb1912b. CORE-11407
2018-06-30 01:15:41 +02:00
Katayama Hirofumi MZ e353b48cb2 [SHELL32] Refresh 'General' tab if the folder icon is updated (#646)
CORE-11407
2018-06-29 14:13:37 +02:00
Katayama Hirofumi MZ eb1912b15f [SHELL32] Initial implementation of Folder Customization (#642)
- Add property sheet;
- Implement changing the folder icon.
CORE-11407
2018-06-28 21:51:37 +02:00
Serge Gautherie 3766d836c7 [DBGHELP] Fix 3 MSVC warnings about MiniDumpWriteDump() (#643)
- Fixes MSVC errors: "...\dll\win32\dbghelp\minidump.c(857) : error C4028: formal parameter 5 different from declaration", for parameters 5, 6 and 7.
- Fix spec file too.
CORE-7538
2018-06-28 17:44:49 +02:00
Hermès Bélusca-Maïto a9eda8f492
[LSASRV] Enable SE_CREATE_TOKEN_PRIVILEGE in LSASS since one of our purposes is to create access tokens -- NtCreateToken() requires this privilege. 2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto c901c3d37f
[LSASRV] Move the LSA_RPC_SERVER_ACTIVE event creation to a better place, in LsarStartRpcServer(). 2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto 0208a4d196
[LSASRV] Add the SE_GROUP_OWNER attributes to the token owner. 2018-06-27 23:40:16 +02:00
Hermès Bélusca-Maïto cf56db2eb3
[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status fixup in the assignment loop as done in the allocation loop.
This avoids this function returning failure while everything actually succeeded.
2018-06-27 23:40:13 +02:00
Hermès Bélusca-Maïto 62384951c8
[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid pointer to a valid but empty privilege structure to NtCreateToken(), as it always want a non-NULL pointer. 2018-06-27 23:40:12 +02:00
Hermès Bélusca-Maïto d4b4da5385
[ADVAPI32] Additions for CreateProcessAsUserA/W().
- Use a common helper function used by both the ANSI and UNICODE functions
  so that the large code block that deals with setting the new process token
  becomes automatically common to both these functions, while the ANSI vs.
  UNICODE conversions are handled directly via the CreateProcessA/W() calls.

- Duplicate the token and acquire the process primary token assignment
  privilege before calling NtSetInformationProcess().
2018-06-27 23:40:07 +02:00
Katayama Hirofumi MZ 3189ec9428 [SHELL32] Add missing desktop.ini files (#640)
Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045
2018-06-27 23:11:31 +02:00
Katayama Hirofumi MZ c74bd5d662 [SHELL32] Enable custom CD/DVD icons (#639)
Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766
2018-06-27 23:06:54 +02:00
Bișoc George 23881cfcf3 [NEWDEV] Fix a truncated text 2018-06-25 13:55:19 +02:00
Russell Johnson 6a683dc6d8 [SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635)
Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.

CORE-12340
2018-06-24 20:29:57 +02:00
Katayama Hirofumi MZ 1b1e1baa6e [SHELL32] Implement Folder Options File Types 'Change' button (#629)
CORE-12906
2018-06-24 20:04:25 +02:00
Katayama Hirofumi MZ 6e6c46a832 [BROWSEUI] Re-enable the "Folder Options" menu item (#630)
It was originally disabled in r71192 (8b77c254).
CORE-11141
2018-06-24 20:02:36 +02:00
Katayama Hirofumi MZ 1829f5fed7 [SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632)
#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196
2018-06-24 19:59:03 +02:00
Katayama Hirofumi MZ cc8b2717ae [SHELL32] Implement OpenAs_RunDLLA/W (#628)
CORE-14751
2018-06-24 19:46:06 +02:00
Abdulganiev Rafael 824a52aa99 [TRANSLATION][SHELL32] Update Russian translation (#633) 2018-06-24 19:42:34 +02:00
Katayama Hirofumi MZ a33908b60f [SHELL32] Improve French Folder Options 2018-06-23 10:51:48 +02:00
Katayama Hirofumi MZ 6f82659da6 [SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602)
ROSTESTS-308
2018-06-22 16:44:58 +02:00
Katayama Hirofumi MZ cb69443362 [SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)
CORE-14678
2018-06-22 16:40:06 +02:00
Katayama Hirofumi MZ f8926dccbd [SHELL32] Fix desktop.ini folder icon (#595)
The folder icon location specified in desktop.ini of a folder should accept its relative path.
CORE-9196
2018-06-22 15:37:03 +02:00
Andrea Crescentini d303b70b7a [TRANSLATION] Improving italian translation (#623)
- Improved Italian translation for USETUP, WELCOME, REACTOS, EXPLORER.
- Completed translation in SYSSETUP.
- Correct some characters encoding and text alignment in USETUP.
2018-06-21 14:03:35 +02:00
Denis Malikov 7916d0ae3e [SHELL32] Copy-paste files/folders into current place.
Files are copied with trying to find new path by adding (%d) suffix before asking for overwrite existing item

CORE-13788
2018-06-13 20:13:44 +02:00
Serge Gautherie 1668527acf
[SYSSETUP] Fix a DPH report about dwPageCount
- "(sdk/lib/rtl/heappage.c:1329) corrupted suffix pattern"
  detected at
  "dll/win32/syssetup/wizard.c:2672 (InstallWizard)"
- Add an ASSERT(), as hinted by Mark Jansen.
2018-06-12 23:57:12 +02:00
Adam Słaboń 565ce5e827 [TRANSLATION] Polish translation update (#611)
Polish translation update for MODE, USETUP and SHELL32.
2018-06-12 15:51:37 +02:00
Thomas Faber 95c3e17a80
[ADVAPI32] Fix crash when running advapi32:security with DPH.
Import the following Wine commits:
* 79636bebbfa Michael Müller: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
* 1d03ba76116 Hans Leidekker: advapi32: Fix parsing empty DACL/SACL security descriptor strings.
* 5bc2e83c7ab Hans Leidekker: advapi32: Fix size returned from ConvertStringSecurityDescriptorToSecurityDescriptor on 64-bit.
2018-06-10 19:05:26 +02:00
Katayama Hirofumi MZ 698cbc6184 [SHELL32] Split dialogs/folder_options.cpp (#582)
The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906
2018-06-06 14:04:50 +02:00
Serge Gautherie 2ca29e142c [BROWSEUI] Remove a duplicated add_custom_command() call 2018-06-05 20:03:16 +02:00
Jared Smudde 76a73b4295 [MSHTA] Implement MSHTA.exe (#577) CORE-12813
Implement mshta.exe. It links directly to the function RunHTMLApplication in mshtml and passes the file name and other optional arguments along. While the function is unimplemented in mshtml, it's a start.

[MSHTML] Add ADD_IMPORTLIB to CMakeLists so mshta can link to mshtml.
[BOOTDATA] Add the association information for mshta.exe to the registry.
2018-06-05 17:17:00 +02:00
Thomas Faber c6f49f5394
[JSCRIPT] Fix MSVC build. 2018-06-04 20:26:14 +02:00
Amine Khaldi f554481baf [WTSAPI32] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:59:11 +01:00
Amine Khaldi c399348b83 [WMVCORE] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:58:45 +01:00
Amine Khaldi 2f569d4a7f [WINTRUST] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:58:20 +01:00
Amine Khaldi 12381d5dc1 [WININET] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:57:34 +01:00
Amine Khaldi 8317165d65 [WINHTTP] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:56:48 +01:00
Amine Khaldi 324214f998 [WINDOWSCODECS] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:55:39 +01:00
Amine Khaldi 983dc4266c [WBEMPROX] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:54:01 +01:00
Amine Khaldi 6091f5c76b [VERSION] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:53:34 +01:00
Amine Khaldi bcea8c65d0 [VBSCRIPT] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:52:36 +01:00
Amine Khaldi aa15c73fc5 [USP10] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:51:34 +01:00
Amine Khaldi d0eebfbd6f [URLMON] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:50:24 +01:00
Amine Khaldi 96d77d846f [RPCRT4] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:49:11 +01:00
Amine Khaldi aefc6e4447 [RICHED20] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:48:07 +01:00
Amine Khaldi be43e1385f [PROPSYS] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:47:25 +01:00
Amine Khaldi 4523246628 [PIDGEN] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:46:44 +01:00
Amine Khaldi 85037eb745 [OLE32] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:45:35 +01:00
Amine Khaldi d52f5b708b [ODBCCP32] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:44:04 +01:00
Amine Khaldi 33bcb8c53a [NTDSAPI] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:43:22 +01:00
Amine Khaldi 4335e46944 [MSCTF] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:41:08 +01:00
Amine Khaldi 3f071cc527 [JSCRIPT] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:38:45 +01:00
Amine Khaldi e64b032987 [ITSS] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:37:18 +01:00
Amine Khaldi 1656f44ad3 [IMM32] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:36:30 +01:00
Amine Khaldi 88b70c737a [IEFRAME] Sync with Wine Staging 3.9. CORE-14656 2018-06-04 03:35:42 +01:00
Hermès Bélusca-Maïto c441de2232
[SYSSETUP] If creating the default-user hive file fails because the file already exists, make a backup (i.e. rename it) and retry its creation.
This situation happens when one "updates" ReactOS by re-installing it on top of an existing installation.
2018-06-04 01:36:19 +02:00
Joachim Henze 1c151c9977 [COMCTL32] Simplify some ifdefs CORE-14649
Addendum to 16d6c9b5e0
Giannis suggested and Thomas explained:

Before the Wine sync, comctl32/button.c was based on ROS's
user32/button.c, so _USER32_ would highlight changes between
user32 (originally based on Wine) and comctl32. Now our
comctl32/button.c is based on Wine's comctl32/button.c, so
__REACTOS__ is enough.
2018-06-03 14:27:34 +02:00
Joachim Henze 16d6c9b5e0 [COMCTL32] Fix regression CORE-14649
Fixes a regression that was introduced by Wine Staging 3.3 Sync.
Symptom was missing button text and icons for specific buttons
in Delphi applications, e.g. Double-Commander, Lazarus, Peazip.
The patch restores and ifdef-guards previous changes of Giannis.
2018-06-02 12:28:47 +02:00
Eric Kohl bd2f3d39a9 [KERNEL32] Get/SetTimeZoneInformation: Convert the Milliseconds value between TIME_FIELDS and SYSTEMTIME too
CORE-14658
2018-06-01 12:49:26 +02:00
Eric Kohl 4911382913 [NDK] Replace the SYSTEMTIME fields StandardDate and DaylightDate in RTL_TIME_ZONE_INFORMATION by TIME_FIELDs and fix resulting errors
Patch will be sent upstream.

CORE-14658
2018-05-31 17:48:29 +02:00
Katayama Hirofumi MZ 222534a5a2 [SHELL32] Fix and improve the PickIconDlg function (#574)
CORE-10972
2018-05-31 15:33:07 +02:00
Eric Kohl 5d8bbf72e3 [USERENV] LoadUserProfileW: User the user name passed in via lpProfileInfo to create the profile directory instead of the user name extracted from the token 2018-05-30 23:29:14 +02:00
Katayama Hirofumi MZ 5187ec858f [SHELL32] Implement the 'Advanced' button of the 'File Types' dialog (#565)
This allows the user to edit the File Type / extension information by clicking 'Advanced' button in the 'File Types' property sheet of Folder Options.
CORE-12906, CORE-10972
2018-05-30 17:22:31 +02:00
Eric Kohl f0a792631d [MSGINA] Remove a dialog that should not have been added. 2018-05-30 15:22:56 +02:00
Baruch Rutman a4a59ad413 [GDI32][LPK] BiDi support for ExtTextOut and GetCharacterPlacement (#534)
Introduce BiDi (bi-directional text) support for ExtTextOut and GetCharacterPlacement, using Wine's GDI BIDI_Reorder function.
Solves the main issue with CORE-7003.

To be compatible with Win2k3+, introduce the "Language Pack" (LPK) dll.
- All the bidi code is removed from gdi32 and replaced by calls to LPK.
  Gdi32 uses dynamic linking to lpk.dll. In case of linking failure no bidi processing will be available.
- Implemented LpkGetCharacterPlacement.
- Implement LpkExtTextOut.
- Add a demo test program to show how the apis should function.
- Added all the remaining code, added special case for lpDx calculation if also GCP_GLYPHSHAPE flag was called.
  Applications that call GCP that use GCP_GLYPHSHAPE flags should also use the GCP_REORDER flag.
  (As written in https://msdn.microsoft.com/en-us/library/windows/desktop/dd144860(v=vs.85).aspx )
- Add ETO_RTLREADING flag handling.
  Imported the ETO_RTLREADING flag handling from wine, which changes the string part order (runs).
  A RRR1LLLRRR2 string without will show as RRR1LLLRRR2 without it, with it RRR2LLLRRR1.
2018-05-30 14:41:22 +02:00
Serge Gautherie 3ca1ac639c [REACTOS] Improve/Fix some "printf" formats (#555)
The smbios.c one was initially spotted by "Alahndro" on CORE-6328.
2018-05-30 14:18:23 +02:00
Eric Kohl f0273d814e [SYSSETUP][USERENV] Create the system profile after the creation of the default profile has been finished
CopySystemProfile: Don't try to create the user hive. Just copy it as it has already been created.
2018-05-30 09:21:14 +02:00
Eric Kohl e7340a2800 [SYSSETUP] Save the HKEY_USERS\.DEFAULT hive in the ntuser.dat file of the default user profile 2018-05-30 08:18:55 +02:00
Eric Kohl 249dc97165 [SYSSETUP] Fix an issue that may be caused by a missing security settings file
Found by Serge Gautherie
2018-05-29 12:49:24 +02:00
Eric Kohl 67e45c41ee [SYSSETUP] Open the security settings inf file only once in order to apply the settings 2018-05-29 01:32:52 +02:00
Eric Kohl cd9f22e9e5 [SYSSETUP][INF] Add the 'Registry Values' section to the default security settings and apply it to the registry 2018-05-28 19:26:02 +02:00
Eric Kohl 1f9543940c [USERENV] Implement CopySystemProfile Part 2 (Create the profile directory) 2018-05-28 02:13:22 +02:00
Eric Kohl 334fe302a1 [USERENV] Implement CopySystemProfile Part 1 (Add a new profile subkey and values to the profile list)
CORE-12541
2018-05-27 15:31:43 +02:00
Amine Khaldi 1d62a5beb5 [HNETCFG] Sync with Wine Staging 3.9. CORE-14656 2018-05-27 04:12:51 +01:00
Amine Khaldi 6619d0261f [GDIPLUS] Sync with Wine Staging 3.9. CORE-14656 2018-05-27 04:10:39 +01:00
Amine Khaldi 2fb248c799 [DBGHELP] Sync with Wine Staging 3.9. CORE-14656 2018-05-27 04:08:32 +01:00
Amine Khaldi 102f53e05c [CRYPT32] Sync with Wine Staging 3.9. CORE-14656 2018-05-27 04:07:57 +01:00
Amine Khaldi f68b0c5100 [COMDLG32] Sync with Wine Staging 3.9. CORE-14656 2018-05-27 04:06:36 +01:00
Amine Khaldi 01707e98b5 [AVIFIL32] Sync with Wine Staging 3.9. CORE-14656 2018-05-27 04:02:26 +01:00
Eric Kohl f42b4bbe17 [MSV1_0] Add logon support for the LocalService and NetworkService accounts 2018-05-26 18:43:46 +02:00
Pierre Schweitzer de58c459fa
[UBTRFS] Upgrade to 1.0.2
CORE-14655
2018-05-26 11:00:51 +02:00
Eric Kohl 4db10a404c [MSGINA] Clean-up the resource IDs and the dialog function names. 2018-05-26 01:54:58 +02:00
Katayama Hirofumi MZ ed1c6bb006 [SHELL32] Add icons to the 'File Types' listview (#557)
This commit adds icons to the listview of the 'File Types' property sheet of Folder Options.
CORE-12906
2018-05-23 23:25:11 +02:00
Eric Kohl ef9cfec290 [MSGINA] Implement the Welcome text feature 2018-05-23 13:51:45 +02:00
Eric Kohl 39281f0f70 [MSGINA] Clear the password on logoff 2018-05-23 00:27:11 +02:00
Eric Kohl 8828567086 [MSGIINA] Make sure we do not leak bitmaps 2018-05-23 00:24:53 +02:00
Eric Kohl 8c5cf73018 [MSGINA] Always stop the automatic login after the first try
Fixes CORE-14643
2018-05-22 21:19:58 +02:00
Eric Kohl 47567abf27 [MSGINA] Do not try to impersonate the user on shutdown when we are already logged off 2018-05-22 17:35:33 +02:00
Eric Kohl 4c4c6e88b3 [MSGINA] Close the LSA handle on shutdown 2018-05-22 17:31:20 +02:00
Eric Kohl bab4d87ac8 [MSGINA] Close the user token in WlxLogoff 2018-05-22 16:32:10 +02:00
Eric Kohl c98b8dc98c [MSGINA] Rename context variable: Domain -> DomainName 2018-05-22 14:39:38 +02:00
Eric Kohl b784c7bfba [BOOTDATA][MSGINA][SYSSETUP] Rename the DefaultDomain registry value to DefaultDomainName 2018-05-22 11:30:27 +02:00
Eric Kohl 665926d38b [MSGINA] Add the IgnoreShiftOverride feature again 2018-05-22 11:06:38 +02:00