* Mark SelectTimeout as a KDEFERRED_ROUTINE and fix its calling convention. This fixes a potential stack corruption.
* Brought to you by Nikolay Borisov and the MSVC static analyzer ;)
CORE-7171 #resolve
svn path=/trunk/; revision=58969
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
* This fixes several warnings emitted by the MSVC static analyzer.
* Brought to you by Nikolay Borisov, with minor consistency styling changes by me.
CORE-7171
svn path=/trunk/; revision=58966
In fact, the kdcom used for KDBG (in GCC builds) is really a thin layer atop of CPORTLIB.
Remove extra code (remove also the KD_PORT_INFORMATION type) and replace it with calls to CPORTLIB functions.
Next step is to put all that thing into KDBG directly, as helper functions. Then, if one wants to make a really kdcom (as we have for MSVC builds), one has to refactor all KDBG.
svn path=/branches/kd++/; revision=58964
Finally reenable RtlAcquirePrivilege and RtlReleasePrivilege now that they are fixed.
[KERNEL32]
Remove the hacks in SetSystemTime() and SetLocalTime() now that RtlAcquirePrivilege is working properly.
[SYSSETUP]
Remove the hack for privileges in SetSystemLocalTime() now that SetLocalTime() can properly acquire needed privilege.
CORE-7168 #comment Fixed with r58960 #resolve
svn path=/trunk/; revision=58960
When we are impersonating, also set the flag, so that on release, we can kill it.
This hopefully fixes 2nd stage and the whole mess it was causing in privileges.
svn path=/trunk/; revision=58959
Place the (unimplemented) real KD functions into a dedicated file and isolate ReactOS-specific port functions. They can go into a libary along KDBG !
svn path=/branches/kd++/; revision=58958
Comment that part too, because it was in KdPortInitialize and here, it reported an invalid port. KdPortInUse is initialized by KDBG.
svn path=/branches/kd++/; revision=58957
Also "fix" hack of RtlAcquirePrivilege in SetSystemTime(). Spotted by Thomas.
Note for syssetup/rtl/kernel32 devs:
Make it crystal clear that this is a hack and has to be deleted once RAP is fine.
Also note that for SetLocalTime() and 2nd stage, syssetup acquires the privilege itself
in SetSystemLocalTime() before calling SetLocalTime().
This will also have to be deleted once RAP is working fine. Otherwise it will keep failing:
it is not possible to acquire a privilege already held.
svn path=/trunk/; revision=58953
Comment out RtlAcquirePrivilege & RtlReleasePrivilege for the moment.
It appears we are overflowing memory and thus corrupting registry, that breaks ReactOS install.
To be investigated...
svn path=/trunk/; revision=58938
ISO images generated by cdmake have invalid time and date.
Patch by Aleksandar Andrejevic, aka. [TheFlash]
CORE-7163 #resolve #comment Committed in revision r58932, thanks for the patch ;)
svn path=/trunk/; revision=58932
* Add NT_CONSOLE_PROPS and NT_FE_CONSOLE_PROPS and fix EXP_SZ_LINK.
* Add SHELL_LINK_INFO_* and some Shell Link Extra Data structures (for IShellLinkDataList).
[USERINIT][CPLS][DLLS]
* Add the now necessary wincon.h inclusion.
* Brought to you by Dominik Hornung.
CORE-7162 #resolve #comment Committed in r58930. Danke !
svn path=/trunk/; revision=58930
Hack: To try to uncover a heap corruption in CONSRV, use our own heap instead of the (default) CSR heap, so that we won't corrupt it and obtain strange bugs thrown by memory allocation in csrsrv.
Thanks to Aleksandar Andrejevic, aka. [TheFlash] for having seen that.
See CORE-7157 for more information.
svn path=/trunk/; revision=58926
Be sure to use our local heap instead of the current application heap, to store the console title.
To simplify the code, I introduced helper functions based on well-known Rtl functions.
svn path=/trunk/; revision=58925
