Commit graph

55048 commits

Author SHA1 Message Date
Amine Khaldi b55a445031 [NTOSKRNL]
* Fix an uninitialized pointer read. CID 1102504.
CORE-6681

svn path=/trunk/; revision=60570
2013-10-07 11:44:07 +00:00
Pierre Schweitzer 8b0bbbdc07 [PSAPI_APITEST]
Complete the test (tested under w2k3)

svn path=/trunk/; revision=60569
2013-10-07 06:16:19 +00:00
Eric Kohl 22175a9d82 [SAMSRV]
A password is present only if the passwords value has been set and the password is not the empty password.

svn path=/trunk/; revision=60567
2013-10-06 23:09:46 +00:00
Pierre Schweitzer b7674bb164 [PSAPI_APITEST]
Add an apitest for psapi GetDeviceDriverFileName.

I'm looking for help to bring it even farther. Ideally, it would be interesting
to be able to GetDeviceDriverFileName on ntoskrnl base address. The whole point is
about getting it dynamically.

The day we can do it properly, I can predict that it will fail on ReactOS, we're not having
correct paths for KDCOM, HAL, and NTOSKRNL modules in the kernel (thank you FreeLdr? - Where are you
starting '\'?)

svn path=/trunk/; revision=60566
2013-10-06 22:16:42 +00:00
Amine Khaldi 81708b99cd [MSHTML/GECKO]
* Move the gecko prompt from the mshtml registration to the second stage installer itself. This allows mshtml to register properly regardless of the availability of the gecko package.

svn path=/trunk/; revision=60565
2013-10-06 16:51:45 +00:00
Amine Khaldi 511ad66bae [DINPUT8]
* Speedup build.

svn path=/trunk/; revision=60564
2013-10-06 16:34:03 +00:00
Hermès Bélusca-Maïto 55edd14587 [BOOTDATA]
- Add some descriptions.
- Add HKLM\Software\Microsoft\Windows NT\CurrentVersion\IniFileMapping needed for win2k3 basesrv (otherwise it fails to initialize) (and ours when the INI File Mappings functionality will be fully implemented). INI File Mappings allows redirections from e.g. system.ini --> Adequate Registry Key, when you use APIs such that WritePrivateProfileString to write settings in those INI files (for 16-bit compat).

svn path=/trunk/; revision=60563
2013-10-06 16:01:01 +00:00
Hermès Bélusca-Maïto eb9d268653 [CSRSRV]: In CsrCaptureArguments, be sure that the number of captured pointers is at most equal to MAXUSHORT (and not the total length of the captured buffer).
svn path=/trunk/; revision=60561
2013-10-06 14:20:18 +00:00
Hermès Bélusca-Maïto 46e2b227f2 [CSR]
During my investigations for making working Win2k3 csrsrv.dll (or other CSR servers) into ROS (to compare our behaviour with our own csrsrv.dll and Win2k3 one), I hit a problem: if I test a checked-build version of csrsrv (or other CSR servers), everything was fine when they were loaded, but if I use a release-build version (i.e. without any debug information), I systematically hit a memory access violation which was traced back to the moment when a CSR server's CsrInitialization entry point was called.
So I did the experiment, where I used our (debug-build) csrsrv with a free-build win2k3 CSR server dll (it was winsrv.dll, and I retested with basesrv.dll after). I hit the access violation. But if I took a debug-build version of winsrv.dll, everything was OK.
I then added in our csrsrv' server.c file the following line (around line 212 of the current file version):
DPRINT1("%s ; ServerDll->ValidTable = 0x%p ; ServerDll->NameTable = 0x%p ; ServerDll->SizeOfProcessData = %d ; ServerDll->ConnectCallback = 0x%p\n", DllString, ServerDll->ValidTable, ServerDll->NameTable, ServerDll->SizeOfProcessData, ServerDll->ConnectCallback);
and I saw that, when using a debug-build win2k3 CSR server, everything was fine (in particular the ServerDll->SizeOfProcessData member contained a reasonable value, e.g. a size of 88 bytes), whereas if I used a free-build version, I got an off-by-one problem, with the ServerDll->ValidTable pointer valid but the ServerDll->NameTable member being equal to 88 (i.e. invalid pointer) and the ServerDll->SizeOfProcessData member being equal to a very large value, which looked like a pointer value.
After more investigations, I saw that in debug-build CSR servers the list of API names were stored, whereas it was not the case in free-build versions. Therefore I concluded that the API names table was included *ONLY* in debug builds and not in release builds.

Hence, to be able to test in ROS either debug-builds or release-builds versions of Windows CSR servers in ROS (and vice-versa), I introduced a #define called CSR_DBG, which is defined only if the DBG macro is != 0, and which is not defined otherwise. When the CSR_DBG flag is defined, API names tables are added in CSR servers and otherwise, they are not.

Therefore, we are now able to test debug-build Windows CSR servers in ROS (the default possibility) or free-build versions of these CSR servers (but first, we have to build the other ones without the CSR_DBG flag, to avoid the off-by-one problem described above).

svn path=/trunk/; revision=60560
2013-10-06 13:33:17 +00:00
Sylvain Petreolle c6ac881351 [SETUPAPI]
Add stubs for SetupVerifyInfFile, called by VMWare tools installer.

svn path=/trunk/; revision=60559
2013-10-06 12:56:48 +00:00
Sylvain Petreolle de6a0ec0d4 [SETUPAPI]
Add _SP_INF_SIGNER_INFO and _SP_ALTPLATFORM_INFO defines.

svn path=/trunk/; revision=60558
2013-10-06 12:56:01 +00:00
Thomas Faber d7e61c38c1 [POWERCFG.CPL]
- Use Yes/No instead of Ok/Cancel for "Are you sure you want to delete the power scheme?" Patch by Lee Schroeder.
- Remove some unnecessary casts
CORE-7503 #resolve

svn path=/trunk/; revision=60557
2013-10-06 10:31:02 +00:00
Hermès Bélusca-Maïto c67aad2c5d [CSRSRV]: Fix long-time SMSS port name typo (it is SbApiPort).
svn path=/trunk/; revision=60556
2013-10-06 00:30:29 +00:00
Hermès Bélusca-Maïto f308eed7ef [CSRSRV]: Less PPORT_MESSAGE casts.
svn path=/trunk/; revision=60555
2013-10-06 00:04:18 +00:00
Hermès Bélusca-Maïto f73271123c [CSRSRV]: Add the 0x prefix when we display some hex output.
svn path=/trunk/; revision=60554
2013-10-05 23:56:12 +00:00
Hermès Bélusca-Maïto 607b6f3f01 [CSRSRV][CONSRV]
CSR_WAIT_FUNCTION functions are callbacks and therefore are __stdcall aka. NTAPI. Fix this.
Now, using either our csrsrv or win2k3' csrsrv works without problems; there is no console key-press problems anymore (aka. stack corruption when calling multiple times CsrNotifyWait, which called those CSR_WAIT_FUNCTION functions).

svn path=/trunk/; revision=60553
2013-10-05 23:34:25 +00:00
Sylvain Petreolle 5cd9f97182 [GDI32_WINETEST]
[USER32_WINETEST]
Use Jira bug ids.

svn path=/trunk/; revision=60552
2013-10-05 22:20:32 +00:00
Hermès Bélusca-Maïto 2739584249 [CSRSRV][CONSRV]
- Fix the second parameter WaitType (aka. NotifyAll) of CsrNotifyWait. Indeed, we used before the constants WaitAll == 0 / WaitAny == 1 (see the WAIT_TYPE enum); however, it appeared that Win2k3's CsrNotifyWait wanted a WaitType parameter == 1 when waiting for all the waits in a given wait-list. Therefore we would have to use WaitAll for waiting for any of the wait blocks, and WaitAny for waiting for all the wait blocks... looks illogical. Therefore I use instead a BOOLEAN variable (that I call NotifyAll) which is TRUE when I want to wait for all the wait blocks, and FALSE otherwise (as done e.g. for the WaitForMultipleObjects API).
- Fix its usage in CONSRV.

Magically fix key presses problems in console, when using Win2k3 csrsrv.dll ...

svn path=/trunk/; revision=60551
2013-10-05 22:17:34 +00:00
Amine Khaldi 44276fa90e [RPCSS]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60550
2013-10-05 21:05:04 +00:00
Amine Khaldi 2b72d38908 [WINE]
* Mark localspl as in sync.
* Hide evidence re. the existence of my time machine.
CORE-7469

svn path=/trunk/; revision=60549
2013-10-05 21:00:36 +00:00
Amine Khaldi 5a71791fd5 [STRMBASE]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60548
2013-10-05 20:55:09 +00:00
Amine Khaldi aaed681d85 [MSVCRTD_WINETEST]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60547
2013-10-05 20:50:11 +00:00
Amine Khaldi 43ef186f8f [COMDLG32_WINETEST]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60546
2013-10-05 20:44:20 +00:00
Amine Khaldi 64e052cb3e [COMDLG32]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60545
2013-10-05 20:43:34 +00:00
Amine Khaldi 80c153e755 [UUID]
* Add IID_IPrintDialogCallback.

svn path=/trunk/; revision=60544
2013-10-05 20:39:50 +00:00
Hermès Bélusca-Maïto 03a6dfe408 Forgot this one.
svn path=/trunk/; revision=60542
2013-10-05 20:10:06 +00:00
Hermès Bélusca-Maïto e2de2a4610 [CSRSRV]
- Do not associate the newly created wait block to the waiting thread (in CsrInitializeWait) in case this one is going to terminate, but do it instead in CsrCreateWait, where the check actually takes place.
- Avoid PPORT_MESSAGE casts.
- Fix a list insertion problem in CsrMoveSatisfiedWait.
- Fix some descriptions / comments.

svn path=/trunk/; revision=60541
2013-10-05 20:06:47 +00:00
James Tabor f01c97ea16 [Win32ss]
- Add support for loading hook modules.

svn path=/trunk/; revision=60539
2013-10-05 19:57:22 +00:00
Hermès Bélusca-Maïto ae0bca8de5 [CSRSRV]
- Hardcoded_value--;
- Be sure SizeOfProcessData is initialized to zero before doing anything later on.

svn path=/trunk/; revision=60538
2013-10-05 17:29:27 +00:00
Hermès Bélusca-Maïto ea17b18f2b [CSRSRV]: Fix two DPRINTs.
svn path=/trunk/; revision=60537
2013-10-05 17:24:31 +00:00
Amine Khaldi e54abc2fe5 [PSDK]
* Update commdlg.h.

svn path=/trunk/; revision=60536
2013-10-05 16:43:32 +00:00
Eric Kohl f5a5066918 [MSV1_0]
Add the password check to the logon routine.

svn path=/trunk/; revision=60535
2013-10-05 15:27:26 +00:00
Amine Khaldi 46c770f191 [BROWSEUI_WINETEST]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60534
2013-10-05 12:32:51 +00:00
Eric Kohl 3526d54b33 [SAMRPC]
SampQueryUserAll: Implement the retrieval of LM and NT passwords by trusted callers.

svn path=/trunk/; revision=60533
2013-10-05 12:26:33 +00:00
Hermès Bélusca-Maïto 498ca6d41a [NTDLL]: Stubplement and export LdrFlushAlternateResourceModules needed for Windows 2k3 user32.dll and winsrv.dll .
[RTL]: Stubplement and export RtlConsoleMultiByteToUnicodeN (and fallback to RtlMultiByteToUnicodeN) needed for WIndows 2k3 winsrv.dll

CORE-7481 #comment LdrFlushAlternateResourceModules and RtlConsoleMultiByteToUnicodeN stubplemented in revision 60532.

svn path=/trunk/; revision=60532
2013-10-05 12:06:59 +00:00
Amine Khaldi 490190e205 [ADVAPI32_WINETEST]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60531
2013-10-05 10:38:32 +00:00
Amine Khaldi cfc62dc4d1 [USER32_WINETEST]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60530
2013-10-05 10:20:53 +00:00
Amine Khaldi a614ebc27e [SETUPAPI_WINETEST]
* Sync with Wine 1.7.1.
CORE-7469

svn path=/trunk/; revision=60529
2013-10-05 09:51:37 +00:00
Amine Khaldi acb2207e13 [PSDK]
* Add missing ERROR_IN_WOW64 define.

svn path=/trunk/; revision=60528
2013-10-05 09:50:21 +00:00
Eric Kohl ae7b8ae784 [SAMSRV]
SampQueryUserAll: Rewrite the handling of the WhichFields variable in order to simplify the support of trusted user information.

svn path=/trunk/; revision=60527
2013-10-04 22:23:25 +00:00
Timo Kreuzer 7d04df4c46 [INTSAFE.H]
- Mark UINT_MAX and UINT32_MAX as unsigned

svn path=/trunk/; revision=60524
2013-10-04 14:08:27 +00:00
Timo Kreuzer 7806be19d5 [INTSAFE.H]
- Use SAL2 instead of SAL1

svn path=/trunk/; revision=60523
2013-10-04 13:39:58 +00:00
Timo Kreuzer 1753f36879 [INTSAFE.H]
- Rename internal macros and add comments to make it more obvious what the macro does
- Add UShortMult

svn path=/trunk/; revision=60522
2013-10-04 13:37:25 +00:00
Amine Khaldi 2752d3ffd5 [LIBWINE]
* Use atl100.dll directly to create a registrar instance.
CORE-7469

svn path=/trunk/; revision=60521
2013-10-04 11:02:39 +00:00
Jérôme Gardou bb82633e0e [MESA]
- fix build
CORE-7499

svn path=/trunk/; revision=60520
2013-10-04 10:51:37 +00:00
Jérôme Gardou 8c71d40b78 [OPENGL32]
- Assorted changes of previous commit
CORE-7499

svn path=/trunk/; revision=60519
2013-10-04 10:44:43 +00:00
Jérôme Gardou 9b51b6aa91 [MESA]
- leaner build part 12 of X
 - Get rid of ARB_color_buffer_float, ARB_framebuffer_object, EXT_texture_lod_bias, SGIS_generate_mipmap and SGIS_texture_lod extensions.
CORE-7499

svn path=/trunk/; revision=60518
2013-10-04 10:33:03 +00:00
Eric Kohl f812408c06 [NTMARTA]
AccRewriteSetEntriesInAcl: Do not allocate an empty ACL.

svn path=/trunk/; revision=60517
2013-10-03 20:58:47 +00:00
Jérôme Gardou 3073548a43 [MESA]
- leaner build part 11 of X
 - Get rid of ARB_draw_buffers, ARB_draw_buffers2, ARB_draw_buffers_blend extensions.
CORE-7499

svn path=/trunk/; revision=60516
2013-10-03 20:56:51 +00:00
Jérôme Gardou 837a526ab8 [MESA]
- leaner build part 10 of X
 - Get rid of ARB_copy_buffer, ARB_depth_buffer_float, ARB_draw_instanced, ARB_texrure_buffer_object, ARB_uniform_buffer_object, EXT_framebuffer_sRGB, EXT_packed_depth_stencil, {MESA,EXT}_texture_array, EXT_texture_sRGB extensions.
CORE-7499

svn path=/trunk/; revision=60514
2013-10-03 18:35:20 +00:00