- Rewrite TLS part of the ntdll loader. Old TLS-related messy, duplicated and hard to maintain code is gone.
- Disclaimer: All new ldr-rewrite code is almost entirely based on Alex's patch made in 2006, with my improvements, bugfixes and adapting existing codepaths.
- File naming convention: Files of the ldr*.c mask are considered as a new rewritten loader code. All other files in ntdll/ldr directory are old code which soon may be deprecated.
svn path=/trunk/; revision=51051
- Add a "mIRC 6" entry to have a working IRC client while keeping "mIRC 7" for testing. (see bug 6005)
Keep in mind that the automatically downloaded app database is the same for previous releases, current releases and Trunk, so just changing the version for the release wouldn't have been a solution.
- Add SumatraPDF 1.2 (working) to the app database. Patch by Vincenzo Cotugno (vins820 at hotmail dot com), German translation by me.
- Change all .txt files to svn:eol-style CRLF, these are target files which should have Windows line-endings.
svn path=/trunk/; revision=51048
- Print the caller in MsafdReturnWithErrno
- Initialize SockAsyncCompletionPort handle
- Check if the creation of the completion port failed
- Defer free of the socket information struct until the socket handle has been closed because the socket may have a pending select. When the socket is closed, the pending select is canceled, thus a apc routine is invoked which access the freed socket information struct.
- Fixes mIRC crash
- Should be merged to 0.3.13 branch
svn path=/trunk/; revision=51047
Added French translation for all the available applications. Only strings that other translators have translated are translated here.
Regarding OOo 2.4, as 2.4.3 version isn't available in French (wut?!), it has been set to 2.4.2.
If anything wrong, let me know.
svn path=/trunk/; revision=51046
- Fix "EnableUserModePnpManager() failed!" in second stage setup.
Tested by Eric Kohl and igorko.
See issue #5989 for more details.
svn path=/trunk/; revision=51043
Rafal Harabien (rafalh1992@o2.pl)
- Fix links and descriptions in the Rapps database, also update some application versions
I took the last patch in the bug report and applied the changes to remood.txt manually (due to mixed encoding within the same file).
See issue #5999 for more details.
svn path=/trunk/; revision=51034
Fix a bug while testing Rapps under Windows. If you had an application with no registered DisplayName installed, Rapps used to consider every application with no RegName in its database (= currently all Rapps applications) installed. Therefore the list of available applications has always been empty.
Now an application is always added to the ListView if no RegName is set for it.
svn path=/trunk/; revision=51033
- Rafal Harabien:
- Always call IntKeyboardInput and co_MsqPostKeyboardMessage while holding the user lock
- Simplify cleaning up sent messages
See issue #5580 for more details.
svn path=/trunk/; revision=51031
French translation by Jason Toscano <JasonGenie at gmail dot com>
Corrections/adjustements by me
See issue #5993 for more details.
svn path=/trunk/; revision=51030
- Rafal Harabien: Add some missing bitmaps to user32. They are copied from Wine. Change "old" cursors identifiers to defines from winuser.h (OCR_*).
See issue #6000 for more details.
svn path=/trunk/; revision=51029
- FTP has been a really, really naughty app.. Fix up function prototypes and definitions after () -> (void) change.
Fixes build.. if I'm lucky.
svn path=/trunk/; revision=51028
- Change all C function prototype declarations with an empty argument list to use void, or the list specified in the function definition.
According to the C language specification, such a declaration means "no information about the number or types of the parameters is supplied".
This can expose cases where gcc allows us to pass an excessive amount of arguments to functions in certain cases.
Thanks to Thomas Faber for informing us about this.
svn path=/trunk/; revision=51027
Revert r51017 that was reverting r51016.
In fact, it seems that cmlib assert error, whatever that eats randomly doesn't come from software issue inside ReactOS, but from a build issue.
Indeed, as you may see in the different tests I performed it shows that the same build produces the same failure, again and again. But, new build shows that there is no assert anylonger with that commit.
Don't ask me why or how it happens, I just don't get it.
But most of the time, it works, no one knows why ("as usual" (tm)). But it's cool.
Someone from BE team and/or buildslaves managers should take a serious look at this issue.
Just in case: if that commit re-hits cmlib assert, don't blame it immediatly, just commit something else, and see whether trunk is still broken.
But, as you can see in testman, we have now test results for r51016 ;-)
svn path=/trunk/; revision=51025
- Move the drag detection routine to kernel space, this will decrease the number of kernel calls that is noticeable with slower systems running an emulator.
svn path=/trunk/; revision=51021
- use well defined macro instead of weird pointer calculation
- reset thread specific data on a thread detach call
Fixes crash in heroes 3 and probably others
svn path=/trunk/; revision=51019
Revert r51016 that quite magically breaks Qemu test bot (Registry corruption?).
Everything was (and is still fine) on VirtualBox.
It will be put back online once the issue will have been fixed.
svn path=/trunk/; revision=51017
Implemented FstubTranslatorNull, FstubTranslateResource, FstubTranslateRequirement, xHalGetInterruptTranslator.
In other words: please welcome interrupt translator in ReactOS.
It's not used yet.
svn path=/trunk/; revision=51012
- EnableUserModePnpManager: StartServiceW can fail due to the service already running. Check last error for such a case. Should fix bug #5846.
svn path=/trunk/; revision=51006
- Fix calculation of dest rect in IntSetDIBits
- Rewrite NtGdiStretchDIBitsInternal. It now calls NtGdiSetDIBitsToDeviceInternal in case of SRCCOPY and no stretching and NtGdiCreateDIBitmapInternal + IntEngStretchBlt in the default case. This fixes RLE compressed dibs.
- The code isn't yet perfect, Windows behaviour is pretty complex, especially in regard to topdown/bottomup DIBs and the whole code needs to be rewritten. It will cause one more failed bitmap test, but another one that was formerly only passing with legacy 9x behaviour now behaves correctly.
See issue #5886 for more details.
svn path=/trunk/; revision=51005
Implemented FstubFixupEfiPartition():
Purpose is to let ReactOS handle realistic partitions length in case of an EFI/GPT protective MBR.
Indeed, when formatting a disk to GPT, you add a protective MBR that contains a fake partition entry, with type 0xEE having the following property: its size is set to maximum allocatable size in MBR.
In that case, if disk is small, you may go beyond disk size.
This is why a fix to partition length may be needed when re-reading partition entry.
This is the way ReactOS creates protective MBR.
You may find some more information here: http://msdn.microsoft.com/en-us/windows/hardware/gg463525
Fixed xHalIoReadPartitionTable():
- Allocate a buffer that has the proper size (instead of allocating a buffer which is too big). Especially since this leads to partial init only some lines after.
- Remove redundant & useless affectation.
- Check/fix 0xEE partition length in case of an EFI/GPT protective MBR (see upper point).
svn path=/trunk/; revision=51002
Fix IntCreateCompatibleBitmap, previously when the given DC was a memory DC with a dibsection selected, the function would only work if the dibsection was <= 8 bpp.
svn path=/trunk/; revision=50999
clip the destination rect against the bounds of the destination and source surface. Fixes a crash of gdi32_winetest bitmap that occurs as soon as IntCreateCompatibleBitmap is fixed. Other Eng* code needs to be checked as well.
svn path=/trunk/; revision=50998
