Justin Miller
6bbf09b6a5
[WINESYNC][SDK][DWMAPI] Import DWMAPI from WINE 8-14 ( #5594 )
2023-09-18 07:30:44 -07:00
Joachim Henze
0eecebb1cc
[KBDLAYOUT] Avoid (DLGPROC) cast ( #5698 )
...
- Avoid DLGPROC-cast
- Bring header-section closer to our coding guidelines
- Strip inconsistent empty-lines
- Strip useless return at the end of void func
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
2023-09-18 11:48:33 +00:00
Katayama Hirofumi MZ
1da71e2519
[SHDOCVW][SHDOCVW_APITEST] Implement MRU List for Shell Bag, Part 6 ( #5699 )
...
Follow-up to #5691 . Strengthen shdocvw_apitest
testcase. Fix CLSID_MruPidlList class.
CORE-9283
2023-09-18 20:13:29 +09:00
Joachim Henze
1e06be778b
[IMAGELISTVIEWER] Avoid (DLGPROC) cast ( #5697 )
2023-09-18 10:22:59 +00:00
Joachim Henze
8a54e4c9f6
[TEMPLATES] Avoid (DLGPROC) casts
...
The type-system is supposed to be our friend, not our enemy.
I pushed this without PR, because the buildbots don't
build the templates by default. That requires
configure -DENABLE_ROSAPPS=1 -DENABLE_ROSAPPS_TEMPLATES=1
So no gain in running them. Greta Thunberg will appreciate the saved CPU-cycles to fight global warming.
I verified it locally to compile without warnings on GCC8.4.0dbg x86
and it follows the same pattern as
0.4.15-dev-6626-g 806da4421c
which passed all the bots successfully. Also the x64 ones.
2023-09-17 20:50:04 +02:00
Joachim Henze
806da4421c
[CMICONTROL] Avoid (DLGPROC) cast ( #5693 )
...
Yes, might slightly improve with x64,
but that wasn't even my main motivation.
(DLGPROC)-casts are nonsense even for x86 actually.
2023-09-17 17:47:23 +00:00
Katayama Hirofumi MZ
fd626dc163
[SHDOCVW] Implement MRU List for Shell Bag, Part 5 ( #5691 )
...
Follow-up to #5686 .
Implement CSafeMutex and CMruPidlList classes.
CORE-9283
2023-09-17 19:52:50 +09:00
Timo Kreuzer
8650eac76c
[WIN32K] Do not try to free a unicode string that is an int-resource
2023-09-17 10:40:19 +03:00
Timo Kreuzer
26a64324e7
[NTOSKRNL/x64] Fix a bug in KeSwitchKernelStack
...
Don't safe anything in the callee's home space, because the callee can overwrite it. Use the functions home space instead.
2023-09-17 10:37:50 +03:00
Timo Kreuzer
d41a4030bc
[CRT] Import parameter check for fclose from wine
...
Fixes advpack_apitest:DelNode crash.
2023-09-17 10:19:15 +03:00
Katayama Hirofumi MZ
7cbca9ad8a
[SHDOCVW] Implement MRU List for Shell Bag, Part 4 ( #5686 )
...
Follow-up to #5646 . Implement CMruNode class. CORE-9283
2023-09-15 07:50:20 +09:00
Ratin Gao
4c8a2a8815
[KERNEL32][KERNEL32_APITEST] Implement user-mode UEFI / Firmware API ( #5149 )
...
- Implement firmware environment variable read/write APIs
- Add, fix and improve related definitions and declarations
- Add kernel32:UEFIFirmware apitest
CORE-11954
2023-09-14 22:14:07 +03:00
Justin Miller
961893a712
Revert "[DDRAW] Sync the fix for swap_interval from Wine ( #4831 )" ( #5690 )
...
This reverts commit 6755921560
.
2023-09-14 05:16:42 -07:00
Katayama Hirofumi MZ
5c7a5786fd
[SHELL32] Check m_ListView on some methods ( #5684 )
...
- comdlg32:filedlg could encounter an assertion error in CWindow::SendMessage.
- Assert the existence of the listview control m_ListView in the CDefView::LV_... function.
- Actually check the existence of m_ListView outside the CDefView::LV_... function.
ROSTESTS-388
2023-09-13 22:41:00 +09:00
Katayama Hirofumi MZ
bcd916bd4e
[NTUSER] Error of co_UserCreateWindowEx should display class name ( #5682 )
...
The error messsage of co_UserCreateWindowEx
was unfriendly to the debugger.
Show the window class name by using "%wZ" in
co_UserCreateWindowEx.
2023-09-12 06:16:05 +09:00
Katayama Hirofumi MZ
1961d708e7
[SHDOCVW][SHDOCVW_APITEST] Implement MRU List for Shell Bag, Part 3 ( #5646 )
...
Follow-up to #5634 .
- Implement CMruBase::_UseEmptySlot.
- Implement CMruLongList and CMruShortList.
- Add CMruClassFactory class and modify
DllGetClassObject function by using it.
- Add shdocvw_apitest.exe.
CORE-9283
2023-09-12 06:01:09 +09:00
Katayama Hirofumi MZ
2a16fc5e19
[NTGDI] GetPixel's return top byte is zero if valid ( #5677 )
...
According to the results of CImage testcase,
the top byte of the GetPixel() return value is
zero if the return is a valid color.
Do bitwise-AND operation if the color value is valid.
CORE-19008
2023-09-12 05:56:36 +09:00
Katayama Hirofumi MZ
ea5d2c5f7a
[MSPAINT][SDK] Add <ui/CWaitCursor.h> ( #5680 )
...
CORE-19094
2023-09-12 05:39:08 +09:00
Joachim Henze
e13ebd44c6
[USER32] Pure Whitespace sync from comctl32/combo.c, no functional change
...
This will make future syncs between those files much easier,
and fixes tons of mixed tab-space-indentation.
Please no whitespace nitpicks when reviewing this commit, it is a SYNC!
2023-09-11 17:57:40 +02:00
Joachim Henze
d97313181e
[USER32] Sync comctl32 combo.c code in context of CORE-17883
2023-09-11 17:57:40 +02:00
Katayama Hirofumi MZ
e4512e6af2
[MSPAINT] IDM_IMAGEROTATEMIRROR: Fix indent
...
Follow-up to #5660 . CORE-19094
2023-09-11 07:44:39 +09:00
Katayama Hirofumi MZ
85377ee3db
[SDK][CRT][MSVCRT] Implement _CrtSetReportMode and _CrtSetReportFile ( #5662 )
...
- Implement reporting to file.
CORE-11835, CORE-15517, ROSTESTS-386
2023-09-11 04:37:27 +09:00
Katayama Hirofumi MZ
993a45024e
[MSPAINT] Use wait cursor ( #5660 )
...
- Implement CWaitCursor class in newly-added "waitcursor.h".
- Use CWaitCursor to manage the wait cursor.
- Improve WM_SETCURSOR handlings.
CORE-19094
2023-09-10 22:28:28 +09:00
Katayama Hirofumi MZ
0ef9cfb04e
[NOTEPAD] Use wait cursor ( #5659 )
...
- Add WaitCursor helper function to display the wait cursor while
heavy operation.
- Manage the wait cursor by using a lock count.
CORE-18837
2023-09-10 22:27:16 +09:00
Timo Kreuzer
7497f028f4
[KERNEL32_APITEST] Improve InitOnce test
2023-09-10 14:58:54 +03:00
Timo Kreuzer
6286475d71
[KERNEL32_APITEST] Fix stack corruption in InitOnce test on x64
2023-09-10 14:58:54 +03:00
Timo Kreuzer
4459b4f42b
[GETUNAME] Build only english on DBG builds ( #5670 )
...
This massively cuts down build time on MSVC builds.
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
2023-09-10 14:43:41 +03:00
Serge Gautherie
a1ee35bdb2
[NDK] mmtypes.h: Fix a copypasta in a comment
2023-09-10 13:30:11 +03:00
Thomas Faber
f9212e4a72
[WIN32K:NTUSER] Avoid TOCTOU in ProbeAndCaptureUnicodeStringOrAtom.
2023-09-09 17:50:49 -04:00
Belle Aerni
ce43bf6ba7
[MESA] Change reported OpenGL version to 1.1.0 ( #5675 )
...
Fixes failing opengl32:sw_extensions test.
The test expects version `1.1.0` which is what Windows reports,
and ReactOS Mesa3D was reporting just `1.1`.
2023-09-09 22:30:44 +03:00
Julio Carchi
4976fba59e
[NTUSER] Reduce debug logging spam ( #5661 )
...
Silence two of the most debug log spammers in co_MsqSendMessage()
and in co_IntProcessMouseMessage() by demoting ERR to WARN.
2023-09-09 22:28:19 +03:00
Katayama Hirofumi MZ
6b69202016
[ATL] CImage: Simplify GetBits/GetPixelAddress ( #5671 )
...
CORE-19008
2023-09-09 20:20:22 +09:00
Timo Kreuzer
9666f00572
[WIN32K][NTOS] Fix parameter to MmMapViewOfSection
...
The code was passing 0 instead of SECTION_INHERIT::ViewUnmap (2). 0 isn't even a proper constant to be used here. It worked, because MmMapViewOfSection only compares against ViewShare (1) and treats everything else as ViewUnmap.
2023-09-09 12:15:24 +03:00
Katayama Hirofumi MZ
97b64c45c6
[ATL][ATL_APITEST] CImage testcase should cover all formats ( #5653 )
...
Strengthen CImage testcase and improve CImage class.
ROSTESTS-387, CORE-19008
2023-09-09 08:42:55 +09:00
Hermès Bélusca-Maïto
fdeb169a27
[PSDK] Add missing PNP_VETO_TYPE PNP_VetoInsufficientRights enumerator.
2023-09-07 20:28:03 +02:00
Timo Kreuzer
8f6aaa8af6
[RTL][NTDLL] Implement and export RtlInitializeCriticalSectionEx
2023-09-07 08:36:48 +03:00
Timo Kreuzer
1d59cf43af
[NTDLL_APITEST] Add tests for critical sections
2023-09-07 08:36:48 +03:00
Ratin Gao
f491d7cc99
[KERNEL32][RTL] Implement One-Time initialization API and improve RTL support ( #5046 )
...
* [KERNEL32][RTL] Implement One-Time initialization API and improve RTL support
2023-09-06 15:40:53 -07:00
Timo Kreuzer
583be404dd
[NTOSKRNL/x64] Fix bug in KiInitializeContextThread
...
The function set CtxSwitchFrame->ApcBypass to FALSE, preventing APCs (like when user mode sets the context while the thread is suspended) from being delivered as soon as the thread lowers IRQL to PASSIVE_LEVEL. This resulted in the SetContext APC to be delivered only after the user mode APC was initialized, overwriting the user mode APC context in the trap frame. This caused kernel32_winetest process to break.
2023-09-07 01:16:14 +03:00
Stanislav Motylkov
995d255962
[REACTOS] Fix various '% s' typos with a space
...
- [NOTEPAD][REGEDIT][SHELL32] were affected.
- Also while being here, fix headers.
2023-09-07 00:34:02 +03:00
Stanislav Motylkov
6a81e5f4d7
[SHELL32] Fix standard log off dialog layout
...
Make it consistent between translations and other misc fixes.
2023-09-07 00:16:08 +03:00
Doug Lyons
9ce81f6485
[WINHTTP_WINETEST] Skip wine_dbgstr_wn() call when returned text length is zero ( #5656 )
...
On receiving a zero length response, do not try to print returned text using wine_dbgstr_wn().
Instead check the returned string for zero length and skip the print in that case.
ROSTESTS-377
2023-09-07 00:02:48 +03:00
Joachim Henze
195c491880
[NTOSKRNL] Mute some good-path log-spam, no functional change
...
Now that the Memory Management is a bit more under control again,
and branching releases/0.4.15 is near,
do mute some frequent log-spam that got introduced during 0.4.15-dev'ing
regarding lazy-flushes and MM balancing.
It frequently logged even while being idle.
Slightly improve the headers of the two touched files.
No rocket-science.
2023-09-06 14:53:53 +02:00
Hermès BÉLUSCA - MAÏTO
d9cd760173
[TIMEDATE] Fix the way the current time-zone is found in the list. ( #5649 )
...
fies regression CORE-18666 'Wrong timezone saved/displayed'
which was introduced by 0.4.14-dev-1522-g aa69236646
2023-09-06 14:15:33 +02:00
Doug Lyons
2b14056600
[NTOS:CC][NTOS:MM] Add back CcRosTrimCache and add Delay for MM to work. ( #5630 )
...
MM/CC Add back CcRosTrimCache as suggested by Thomas Faber which was removed in 0.4.15-dev-1717-g d8cdb89fb0
and call it once in a while also during read-operations.
fixes JIRA issue: CORE-17624 'Cannot copy files > RAMsize anymore using TotalCommander'
1st testbot results on top of 0.4.15-dev-6526-g8d35887
VBox: https://reactos.org/testman/compare.php?ids=89111,89120 (additional random reboot in winhttp:winhttp)
KVM: https://reactos.org/testman/compare.php?ids=89110,89119
We do assume that reboot to be unrelated.
2nd testbot results on top of 0.4.15-dev-6526-g8d35887
VBox: https://reactos.org/testman/compare.php?ids=89111,89232
KVM: https://reactos.org/testman/compare.php?ids=89110,89233
2023-09-06 13:34:25 +02:00
Katayama Hirofumi MZ
289dec6c39
[NOTEPAD] Do type cast to kill C4244 warnings ( #5655 )
...
- Do type cast to int from SendMessage return value.
- Fix usage of EM_GETSEL and EM_LINEINDEX messages.
CORE-18837
2023-09-06 19:26:23 +09:00
William Kent
94e0c54c7d
[MSVCRT] Officially implement _localtime32{,_s} ( #5652 )
...
required by the guest additions of an app called "UTM", which is a QEMU fork
2023-09-06 12:04:05 +02:00
Katayama Hirofumi MZ
3f921d1119
[NOTEPAD] Use StringCchPrintf instead ( #5654 )
...
Use preferred string functions. CORE-18837
2023-09-05 22:36:18 +09:00
Katayama Hirofumi MZ
eb6561bbc7
[ATL] atlimage.h: Replace throw() with noexcept
...
throw() is deprecated in C++17. CORE-19008
2023-09-05 09:12:01 +09:00
Katayama Hirofumi MZ
b68a3f329c
[ATL][ATL_APITEST] Implement CImageDC class ( #5643 )
...
- Use reference count for CImage::GetDC / CImage::ReleaseDC.
- Add CImageDC class.
- Delete modules/rostests/apitests/atl/CImage_WIP.txt.
CORE-19008
2023-09-05 09:03:32 +09:00