Commit graph

67265 commits

Author SHA1 Message Date
Thomas Faber 67cbaa5a02 [PSEH3]
- Avoid trying to disable 'declaration after statement' warnings in C++
CORE-11794

svn path=/trunk/; revision=73211
2016-11-12 14:52:58 +00:00
Thomas Faber 790c388fd1 [SHELL32_APITEST]
- Don't compare a pointer to S_OK
CORE-11794

svn path=/trunk/; revision=73210
2016-11-12 12:43:02 +00:00
Thomas Faber df216319db [MSWSOCK]
- Remove broken 'inline' specifiers
CORE-11794

svn path=/trunk/; revision=73209
2016-11-12 12:23:49 +00:00
Pierre Schweitzer d121793bd6 [SNDREC32]
Don't double free buffers in case of failure

svn path=/trunk/; revision=73208
2016-11-12 09:24:09 +00:00
Hermès Bélusca-Maïto 3d204aa2b1 [EVENTVWR]: Fix translation for "Information" event type: it is really in singular, not plural.
svn path=/trunk/; revision=73207
2016-11-12 01:29:05 +00:00
Hermès Bélusca-Maïto b98bfc8583 [MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine Khaldi.
CORE-12335 #resolve
CORE-9312 #comment Please retest with r73206

svn path=/trunk/; revision=73206
2016-11-11 23:32:29 +00:00
Hermès Bélusca-Maïto ed21369043 [MSAFD]
- In C, void functions should better have 'VOID' mentioned in their prototypes.
- Simplify GetCurrentTimeInSeconds code.

svn path=/trunk/; revision=73205
2016-11-11 21:37:09 +00:00
Hermès Bélusca-Maïto 47cea24f67 [MSAFD]: Addendum to r73203.
svn path=/trunk/; revision=73204
2016-11-11 21:25:02 +00:00
Hermès Bélusca-Maïto 80ba74a493 [MSAFD]: Convert tabs to spaces.
svn path=/trunk/; revision=73203
2016-11-11 21:19:13 +00:00
Pierre Schweitzer cc6674b4d1 [NTOSKRNL]
Don't redefine RTL_NUMBER_OF

svn path=/trunk/; revision=73202
2016-11-11 18:16:43 +00:00
Christoph von Wittich 37cc16189d [PSDK] small fixes for dns headers
svn path=/trunk/; revision=73201
2016-11-11 14:21:55 +00:00
Pierre Schweitzer 2fdacdbbd6 [KMTESTS:MM]
Bugfix for IRP_MJ_SET_INFORMATION/FileEndOfFileInformation: really set the information. The test still works fine in Windows and still fails hard in ReactOS.

svn path=/trunk/; revision=73200
2016-11-11 10:44:51 +00:00
Pierre Schweitzer e01923caaa [NTOSKRNL]
In MmCreateDataFileSection(), when maximum size is higher than file size, don't deal with its allocation size, just move EOF.
This was shown by NtCreateSection() tests.

svn path=/trunk/; revision=73199
2016-11-10 21:17:21 +00:00
Pierre Schweitzer 6db40277dc [KMTESTS:MM]
Add tests for the NtCreateSection functions which mimic some of the behavior that can be exposed by FSDs (late init, too small files, and so on).
It was designed in W2K3.

svn path=/trunk/; revision=73198
2016-11-10 21:02:48 +00:00
Peter Hater ad99a6f7fd [MSAFD] Implement SO_CONNECT_TIME. CORE-12104
svn path=/trunk/; revision=73197
2016-11-10 17:55:00 +00:00
Thomas Faber 429d685816 [HOST-TOOLS]
- Fix some GCC6 warnings

svn path=/trunk/; revision=73196
2016-11-10 15:34:25 +00:00
Peter Hater 373bee1800 [WS2_32_APITESTS] Add nonblocking tests
svn path=/trunk/; revision=73195
2016-11-10 15:13:19 +00:00
Peter Hater ec87a34342 [WS2_32_APITESTS] Add more WSAAsync tests
svn path=/trunk/; revision=73194
2016-11-10 15:00:44 +00:00
Peter Hater b3bee8c862 [WS2_32_APITEST] Use test.winehq.org insteadof reactos.org. These days main reactos page is too big.
svn path=/trunk/; revision=73193
2016-11-10 14:23:49 +00:00
Peter Hater a32e890392 [MSAFD] Fix for WSPStringToAddressA/W wine tests. CORE-12104
svn path=/trunk/; revision=73192
2016-11-10 11:15:14 +00:00
Thomas Faber d26b1ff847 [FASTFAT]
- Generate LFNs for files containing non-ASCII characters in their names.
CORE-8617 #resolve

svn path=/trunk/; revision=73191
2016-11-10 11:04:29 +00:00
Thomas Faber ac5bba8ea8 [NTDLL_APITEST]
- Add tests for RtlIsNameLegalDOS8Dot3 and RtlUpcaseUnicodeStringToCountedOemString with the ® sign.
CORE-8617

svn path=/trunk/; revision=73190
2016-11-10 10:18:25 +00:00
Giannis Adamopoulos 8632758e52 [SHELL32] - CStartMenu: Add missing checks for failure and make some checks noisy. CORE-12300
svn path=/trunk/; revision=73189
2016-11-10 09:34:14 +00:00
Giannis Adamopoulos 0125f9192d [SHELL32] - CMenuBand: Don't accept a NULL shell folder in SetShellFolder. Should fix a test and possibly CORE-12300.
svn path=/trunk/; revision=73188
2016-11-10 08:10:28 +00:00
Giannis Adamopoulos d2812c3e70 [SHELL32]
- Make some checks for failure in CDefView and CDefaultContextMenu noisy.

svn path=/trunk/; revision=73187
2016-11-10 08:05:13 +00:00
Mark Jansen f6c36fb82e and of course also rename the test itself...
svn path=/trunk/; revision=73186
2016-11-09 23:23:50 +00:00
Mark Jansen cae3a4455e Rename shlexec.cpp to ShellExecuteEx.cpp as suggested by Thomas.
svn path=/trunk/; revision=73185
2016-11-09 23:18:23 +00:00
Thomas Faber 03d2a4b809 [PROPSYS_WINETEST]
- Fix VS2010 build

svn path=/trunk/; revision=73184
2016-11-09 22:55:16 +00:00
Mark Jansen c707b2d936 addendum to r73180 (aka, fix the build)
svn path=/trunk/; revision=73183
2016-11-09 22:24:42 +00:00
Mark Jansen 813cc3f137 [SHELL32] Automatically add the .exe extension for App Paths in ShellExecuteEx. Patch by Yaroslav Veremenko. CORE-12049
svn path=/trunk/; revision=73182
2016-11-09 22:18:33 +00:00
Hermès Bélusca-Maïto 1d2fe2375a [EVENTVWR]: Adjust some menu keyboard shortcuts.
svn path=/trunk/; revision=73181
2016-11-09 22:14:20 +00:00
Mark Jansen 353c67c0d4 [SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049
svn path=/trunk/; revision=73180
2016-11-09 22:13:26 +00:00
Christoph von Wittich d4c71dda90 [PSDK] fix DNS_RECORDW definition
svn path=/trunk/; revision=73179
2016-11-09 21:29:09 +00:00
Hermès Bélusca-Maïto 54c7babbb3 [EXPLORER]: Add missing keyboard shortcuts for some commands.
svn path=/trunk/; revision=73178
2016-11-09 18:03:19 +00:00
Peter Hater 38d1fdf118 [MSAFD] Fix possible memory corruption in WSPIoctl. Brought to you by Andreas Maier aka andy-123. Thanks.
CORE-12322

svn path=/trunk/; revision=73177
2016-11-09 12:05:48 +00:00
Peter Hater 781673fa3d [MSAFD] Minor changes. Code style fixes. tabs->spaces. CORE-12104
svn path=/trunk/; revision=73176
2016-11-09 11:49:55 +00:00
Giannis Adamopoulos 2c118e1890 [BROWSEUI]
- CAddressBand: Call the SetOwner method with NULL parameter to CAddressEditBox to let it know that it should deinitialize.
- CAddressEditBox: Release the connection with the browse window and release the pointer to the site during deinitialization.
- CInternetToolbar: Destroy the toolbar and release pointers when CloseDW method gets called.
- CBaseBar: Destroy the window when SetClient is called with NULL parameter.
- CToolbarProxy: Add a Destroy method to release resources because we hold a pointer to the CInternetToolbar.
- CShellBrowser: When storing the pointer  to the new basebar add a new reference because we directly change the pointer in the smart pointer and not the smart pointer itself. Destroy the toolbar proxy and properly release all references to containted objects. Also expect the reference count of the shell view to reach zero after the internet toolbar gets freed because it also keeps a reference.

This should fix all the leaking objects and windows when closing the shell browser. It should also fix CORE-12066.

svn path=/trunk/; revision=73175
2016-11-08 23:38:42 +00:00
Christoph von Wittich a0aeb266fa [PSDK] add some missing DNS structures, add incomplete dnsrslvr.idl
svn path=/trunk/; revision=73174
2016-11-08 12:27:55 +00:00
Christoph von Wittich 4c9e70a899 [PSDK] disable SAL for WIDL as well
svn path=/trunk/; revision=73173
2016-11-08 11:33:54 +00:00
Thomas Faber 602c2dd81e [USETUP]
- Critical errors are worth a debug print
CORE-11819

svn path=/trunk/; revision=73172
2016-11-08 09:40:05 +00:00
Hermès Bélusca-Maïto a9c9bed2e2 [NTOS]: Fix MmPt and DOPE tags.
svn path=/trunk/; revision=73171
2016-11-07 20:41:24 +00:00
Hermès Bélusca-Maïto 98ffc124f5 [NTOS:IO]: IopCreateDriver(): Set the returned DriverObject value only in case of success.
svn path=/trunk/; revision=73170
2016-11-07 15:51:56 +00:00
Hermès Bélusca-Maïto 12e8ef0213 [TCPIP]
- Enable logging now that IoWriteErrorLogEntry works.
- Check for log event size before calling IoAllocateErrorLogEntry.
- Reduce code indentation in the logging function.

svn path=/trunk/; revision=73169
2016-11-07 15:48:34 +00:00
Hermès Bélusca-Maïto 323bd18771 [NTOS:IO]: An improvement for the total log size check (addendum to r73167).
svn path=/trunk/; revision=73168
2016-11-07 13:57:11 +00:00
Hermès Bélusca-Maïto 0dfecf815d [NTOS:IO][INCLUDES][EVENTLOG]: Fix support for event logging through the "ErrorLogPort" LPC. See the details in CORE-12301 #resolve
svn path=/trunk/; revision=73167
2016-11-07 13:29:09 +00:00
Hermès Bélusca-Maïto 824c5e07c0 [NTOS:LPC]
- Capture the ServerView/ClientView *only* when those pointers are not NULL.
- Fix a LpcRequest vs. CapturedLpcRequest in a call to LpcpMoveMessage. Caught by Thomas. CORE-7371 CR-100

svn path=/trunk/; revision=73166
2016-11-07 12:35:09 +00:00
Peter Hater 09207124de [MSAFD] Implement SOL_SOCKET/SO_ERROR. CORE-12104
svn path=/trunk/; revision=73165
2016-11-07 08:50:31 +00:00
Hermès Bélusca-Maïto f197af7358 [NTOS:LPC]
- Fix the usage, or add support (for NtSecureConnectPort based on patches by Alexander Andrejevic, and for NtReplyPort, NtReplyWaitReceivePortEx, NtListenPort by me) for capturing user-mode parameters and using SEH in LPC functions.
CORE-7371 #resolve
- Make NtSecureConnectPort call SeQueryInformationToken, now that the latter is implemented since r73122.
- Fix ObDereferenceObject usage for Port vs. ClientPort in NtSecureConnectPort.
- ObCloseHandle certainly needs to be called with the actual 'PreviousMode'.

svn path=/trunk/; revision=73164
2016-11-07 01:24:24 +00:00
Hermès Bélusca-Maïto a066c5bbb0 [NTOS:LPC]: Fix the function prototypes (reference: Process Hacker + how the parameters are used in the code).
[NOTS][NDK]: Fix whitespace in header files.
[XDK]: Define PORT_MAXIMUM_MESSAGE_LENGTH before actually using it in the different IO_ERROR_LOG_xxx #defines, for consistency purposes.

svn path=/trunk/; revision=73163
2016-11-07 01:06:24 +00:00
Hermès Bélusca-Maïto 06807aee1b [NTOS:LPC]: Improve the lisibility of some functions:
- Group together the local parameters used for capturing user variables;
- Add some space between the list of parameters and the beginning of the code proper;
- Rename some variables or move some code to make some different functions look more similar (helps in finding functionality-similar functions in the code);
- Improve some comments;
- Whitespace fixes;
- Few code formatting.
- Use a ExFreePoolWithTag instead of ExFreePool, but otherwise no other functional code changes.

svn path=/trunk/; revision=73162
2016-11-07 00:55:34 +00:00