Commit graph

82666 commits

Author SHA1 Message Date
Hervé Poussineau
3a32d5980c [ISAPNP] Generate hardware ids and compatible ids in upper case 2022-09-23 23:07:45 +02:00
Hervé Poussineau
f3506ee626 [SHELL32] Prevent use after free
'buffer' is local to the function, while m_sPath is an instance class member.
Fix that by calling the IShellLink::Resolve() function, which will allocate
and fill the m_sPath variable.

CORE-15229
2022-09-23 23:07:26 +02:00
Katayama Hirofumi MZ
f79e80c520 [USER32][IMM32] Use wcscspn instead of wcsspn
b4575ec and db00a75 were my mistakes.
CORE-11700
2022-09-23 13:50:24 +09:00
Katayama Hirofumi MZ
46de3a22ac [EXPLORER] Follow-up of #4718 (ba2cead)
Handle click OnNcLButtonUp instead of OnNcLButtonDown/OnNcLButtonDblClick.
CORE-15369
2022-09-23 08:25:27 +09:00
Katayama Hirofumi MZ
ba2cead8a2
[EXPLORER] 'Show Desktop' button should work on button up (#4718)
Follow-up of PR #4715. CORE-15369
- The 'Show Desktop' button of taskbar works on button up instead of button down.
- Add NULL checks for m_ShowDesktopButton.
- Fix hung-up in rebooting.
2022-09-22 23:01:12 +09:00
Katayama Hirofumi MZ
26efda4d8d
[EXPLORER] Add 'Show Desktop' button at right edge of taskbar (#4715)
This PR adds a tiny button of window class "TrayShowDesktopButtonWClass" at right/bottom edge of taskbar.
This button allows the user to access "Show/Restore Desktop" feature by mouse.
You can toggle visibility of this button by registry value "TaskbarSd" in key "HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced".
The button is themed when theme is available.
CORE-15369
2022-09-22 12:18:59 +09:00
Katayama Hirofumi MZ
34635e1585
[CPL][INTL] Realize automatic Japanese IME installation (#4705)
In intl.cpl, realize semi-automatic Japanese IME installation by checkbox "Install files for East Asian languages" by using rapps.exe. CORE-11700
2022-09-19 18:13:17 +09:00
Kyle Katarn
32c20ab112
[SHELL32] Fix property sheets that can't be closed due to failed init (#4709)
When a PropertySheet fails to init, that fact is being logged
and it shows an empty page, but it can't be closed.

Handle second failure properly by using FAILED_UNEXPECTEDLY macro.

CORE-18333
2022-09-19 04:06:47 +03:00
Kyle Katarn
456f9f96e7
[HOTPLUG] Add French (fr-FR) translation (#4703) 2022-09-19 02:14:23 +03:00
Andrei Miloiu
5f0132ee95
[APPWIZ] Update Romanian (ro-RO) translation (#4700) 2022-09-19 02:10:49 +03:00
Thamatip Chitpong
7244a4a2f5
[ZIPFLDR] Set large icon correctly (#4708)
Now it's correctly displayed in Alt+Tab window selection.
2022-09-19 01:56:35 +03:00
Joachim Henze
305aae75f5
[DDRAW] Handle DDLOCK_WRITEONLY in wined3dmapflags_from_ddrawmapflags() CORE-18378 (#4713)
Mutes the logging:
fixme:(dll/directx/wine/ddraw/utils.c:584) Unhandled flags 0x20.
gets logged many times per second.

It does affect several applications, e.g. the game 'Anno 1602' from 1998, and the 'Diablo 2 demo' from rapps,
For both games it can be observed with both: our VBEMP driver and the VBox4.3.12 3D-accelerated-driver.

Muting may improve performance a bit in such apps.
It gets logged although no missing features can be perceived visually in the rendering.

Fix it by importing Wine-commit b943c7910b3261c9603343369cd632f7a3b56bba
 ddraw: Handle DDLOCK_WRITEONLY in wined3dmapflags_from_ddrawmapflags().
 Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
 Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-09-18 20:53:30 +02:00
Mark Jansen
d84b76a69e
[GDI32] Fix ExtTextOutA with ETO_GLYPH_INDEX
CORE-18365
2022-09-18 20:51:12 +02:00
Jérôme Gardou
75125228be [NTOS] Add some sanity checks when synchronizing PDEs 2022-09-17 13:48:56 +02:00
Katayama Hirofumi MZ
e5ebbc8afa
[CPL] Boundary check of Control Panel applets (#4706)
- Check the boundary (i < NUM_APPLETS) of the variable i in CPlApplet functions.
- Use UINT type for the variable i.
2022-09-17 13:59:51 +09:00
Katayama Hirofumi MZ
37ccb9e594
[MEDIA][INF] The name of rapps in Japanese is too long (#4707)
Renaming: 「アプリケーション マネージャ」→「アプリ マネージャ」
2022-09-17 07:56:41 +09:00
Katayama Hirofumi MZ
fd46398b63 [INPUT] Fix IsRebootNeeded condition
If there is any IME HKL, reboot is needed.
Follow-up to #4666 (596f04b). CORE-11700, CORE-18364
2022-09-17 07:12:05 +09:00
Katayama Hirofumi MZ
75116d6b87 [USER32] Avoid szImeFileName buffer overrun
CORE-11700
2022-09-16 18:04:55 +09:00
Katayama Hirofumi MZ
b4575eccd7 [USER32] Don't allow invalid 'IME File' values
Improve security. CORE-11700
2022-09-16 18:01:19 +09:00
Katayama Hirofumi MZ
787bbf0693 [IMM32] Follow-up of db00a75
Add more invalid characters. CORE-11700
2022-09-16 17:54:15 +09:00
Katayama Hirofumi MZ
8a48446d11 [NTUSER] Use IS_CICERO_MODE() macro in co_UserActivateKeyboardLayout
CORE-11700
2022-09-16 17:41:12 +09:00
Katayama Hirofumi MZ
db00a75227 [IMM32] Don't allow invalid 'IME File' values
Improve security. CORE-11700
2022-09-16 17:38:48 +09:00
Katayama Hirofumi MZ
87f2950e1a [INPUT] Follow-up of #4666 (596f04b)
Reboot is still needed for IME settings.
CORE-11700, CORE-18364
2022-09-16 08:26:22 +09:00
Katayama Hirofumi MZ
596f04be6b
[USER32][INPUT] Support various keyboard layouts (#4666)
- Fix IntLoadKeyboardLayout function to return the correct HKL value.
- Modify LAYOUT_LIST_NODE structure to add more information.
- Fix LayoutList_GetByHkl function to choose the IME HKLs correctly.
- Ignore DELETED entries correctly.
- Improve UI/UX.
CORE-11700, CORE-13244, CORE-18364
2022-09-16 08:09:37 +09:00
Artyom Ovsyannikov
3f411c5da7
[REACTOS] Various Russian (ru-RU) translation fixes (#4696)
Reviewed-by: Stanislav Motylkov <binarymaster@mail.ru>
2022-09-15 18:46:03 +03:00
Thamatip Chitpong
474f406496
[HOTPLUG] Add title bar icon (#4695)
- Add small icon to the title bar
- Set large icon correctly

CORE-15445
2022-09-15 17:54:10 +03:00
Andrei Miloiu
cd6c7272a4
[HOTPLUG] Add Romanian (ro-RO) translation (#4693)
Signed-off-by: Andrei Miloiu <miloiuandrei@gmail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Reviewed-by: Ștefan Fulea <reactos-contributor@programmer.net>
2022-09-15 17:42:03 +03:00
Kyle Katarn
c994ba79d1
[MMC] Implement standard "About" menu action (#4639)
Reviewed-by: Serge Gautherie <reactos-git_serge_171003@gautherie.fr>
Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
2022-09-15 16:56:31 +03:00
Kyle Katarn
67d063cbc8
[SNDVOL32][MMSYS] Fix French (fr-FR) layout and translation (#4678)
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Co-authored-by: Serge Gautherie <32623169+SergeGautherie@users.noreply.github.com>
2022-09-15 12:14:50 +02:00
Kyle Katarn
a623990b15 [SHELL32] Fix French message for "Overwrite Folder" confirmation message
[SHELL32] Fix French message for "Overwrite Folder" confirmation message
2022-09-15 12:08:34 +02:00
Stanislav Motylkov
0eb042b74c
[INF] Update Russian (ru-RU) translation
Addendum to a03ef85b.
2022-09-14 23:48:21 +03:00
Stanislav Motylkov
c46b1d75f1
[HOTPLUG] Update Russian (ru-RU) translation
Addendum to 21824a25.
2022-09-14 23:44:17 +03:00
Dmitry Borisov
a03ef85b5a
[INF] Add description for IDE-compatible controllers (#4690)
Add missing string. CORE-17256
2022-09-14 23:40:47 +03:00
Thamatip Chitpong
21824a2596
[HOTPLUG] Add missing string resources for applet (#4689)
Use `IDS_CPLNAME` for the window title.
This also fixes the missing title text on the taskbar.
2022-09-14 23:12:50 +03:00
Thamatip Chitpong
781c247bd3
[MMSYS] Multimedia Control Panel diverse fixes (#4572)
- Use Unicode (WCHAR) instead of TCHAR
- Code formatting
- Use string safe functions
- Close handles after calling `CreateProcess`
- Save sound path as `REG_EXPAND_SZ` only if the path
  contains '%' character, like Windows does
- Fix `wcsdup` leaks

Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Reviewed-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
2022-09-14 20:06:22 +03:00
Thamatip Chitpong
67f7971fa2
[INPUT] Fix taskbar icon and remove small icon hack (#4688)
- Use int for applet index (like other CPLs).
- Revert some changes from 976d48b.
2022-09-14 23:29:29 +09:00
Vitaly Orekhov
3647f6a5eb
[LOGONUI] Make Logon UI compilable again (#4684)
Logon UI was excluded from CMake build, probably for not being compliant
with 'warnings are errors' standard introduced at some point.
In the future, I would probably try to make Logon UI usable
alongside with the classic msgina interface.

- Add logonui back to CMakeLists
- Replace 'wcscpy_s' Vista+ function with StringCchCopyW
- Exclude some unused functions

Signed-off-by: Vitaly Orekhov <crce2000@mail.ru>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2022-09-14 15:10:37 +03:00
Mark Jansen
c8f4e4de62
[REGEDIT] Fix possible buffer overflow 2022-09-13 20:49:00 +02:00
Katayama Hirofumi MZ
976d48baeb [CPL][INPUT] s/IDI_KEY_SHORT_ICO/IDI_CPLSYSTEM/ and small icon
The task icon of Taskbar was wrong...
2022-09-14 03:39:18 +09:00
Katayama Hirofumi MZ
8e110335e7
[USER32] Load keyboard layouts on logon correctly (#4686)
- Add IntLoadPreloadKeyboardLayouts helper function to load the layouts on log-on.
- In UpdatePerUserSystemParameters function, call CliImmInitializeHotKeys and IntLoadPreloadKeyboardLayouts functions.
CORE-16600
2022-09-14 02:58:28 +09:00
Jose Carlos Jesus
e215a088f9
[ATL] Fix window position to fit in screen area (#4512)
Clicking "Edit compatibility modes" button in the "Compatibility" tab
opens a window centered on the parent window. If we move the parent
window to one of the screen edges and then click this button again,
the new window will appear off screen.

Adjust position of created window, so now it would be completely visible.

CORE-17089

Reviewed-by: Mark Jansen <mark.jansen@reactos.org>
Reviewed-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2022-09-13 18:00:45 +03:00
Joachim Henze
d7f75a88ea
[SYSSETUP] Update German (de-DE) translation (#4679)
- Fix typos in existing translation
- Update new strings that were added during 0.4.15-dev'ing

Addendum to 3f053db3 and 6d09885c. CORE-18357
2022-09-13 16:22:51 +03:00
Serge Gautherie
8482972a41
[DOC] 3rd Party Files.txt: Fix Buslogic driver version (#4685)
Correct version is in the BusLogic958.rc file.
Addendum to 5ee633f7d7 (0.4.15-dev-4556).

CORE-18180
2022-09-13 15:30:13 +03:00
Serge Gautherie
8d6a11eaa3
[DOC] 3rd Party Files.txt: Add 3rdparty/ to some sdk/lib/ paths (#4642) 2022-09-13 15:08:45 +03:00
Katayama Hirofumi MZ
b6cabfd1f3 [BOOTDATA] Fix 'Layout Id' values of hivesys.inf
Fix them to Win2k3's settings.
CORE-11700
2022-09-13 15:50:18 +09:00
Katayama Hirofumi MZ
b76602ff22 [NTUSER] Fix UserSetDefaultInputLang by using reordering
- Move IntReorderKeyboardLayouts function.
- Fix UserSetDefaultInputLang function.
CORE-11700
2022-09-13 14:32:39 +09:00
Serge Gautherie
f308c6a2bc
[NTFS] PrintAllVCNs(): Fix a typo in an ASSERT() (#4682)
It was introduced in 0.4.7-dev-590-g 5579428b4f.
2022-09-12 22:30:28 +03:00
Mark Jansen
96e3c7bcc5
[SHELL32] Only hide a window when there is a window to hide 2022-09-12 20:00:39 +02:00
Mark Jansen
d0ba8fd4a3
[SHELL32] Properly destroy window 2022-09-12 20:00:39 +02:00
Mark Jansen
a6b8d4f6f0
[SHELL32] Don't try to remove buttons on a nonexisting window 2022-09-12 20:00:39 +02:00