Commit graph

68132 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 552610d60d [CLT-2017]: The very last sync!
[SHUTDOWN]: shutdown -t causes crash. Patch by Michael Fritscher. (r74131 by Eric).
<@dreimer> OMG!!!!
<@hbelusca> hm dreimer?
<@dreimer> ITS SO IMPORTANT!!!!
<@hbelusca> ah you want it? <@hbelusca> ok <@hbelusca> let's add it :D
<@dreimer> jkjkjk

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74133
2017-03-08 22:34:01 +00:00
Hermès Bélusca-Maïto c036b65fcd [CLT-2017]: Add the lstrlenA/W fixes from r74117,r74118,r74119.
svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74130
2017-03-08 22:22:13 +00:00
Hermès Bélusca-Maïto 46c0880849 [CLT-2017]: For this 0.4.4 release, let's play safe & revert the USB stack import from r73605, as the latter need more real-hardware testing & fixes.
svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74129
2017-03-08 22:20:11 +00:00
Daniel Reimer 79d74debe5 [CLT2017]
Make CLT logo a bit more... on screen

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74124
2017-03-07 22:34:08 +00:00
Daniel Reimer 3eeb4124c8 [CLT2017]
Add wallpapers to ISO

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74122
2017-03-07 22:13:23 +00:00
Hermès Bélusca-Maïto 7fbaac54b4 [NTOS]: Modify the ReactOS boot logo for the CLT 2017 edition, similarly to what was done for FOSDEM 2017.
svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74121
2017-03-06 23:37:31 +00:00
Hermès Bélusca-Maïto f66503f65f [REACTOS-CLT2017]: Cherry-pick few trunk improvements/fixes:
- [UXTHME] Implement drawing themed text with shadows, by Giannis (r74083)
- [MKISOFS] Update mkisofs to schily-2017-02-16, by Colin (r74112)

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74115
2017-03-06 00:13:43 +00:00
Hermès Bélusca-Maïto a9ebf1a4d9 [REACTOS-CLT2017]: Sync with ROS 0.4.4 release branch. In particular the following fixes/hacks:
- Apply the Wordpad related hack from CORE-5823 by Jared Smudde (r73624).
- Disable COMMAND.COM debugging messages. CORE-10710 (r73625).
- Add a hack by Thomas to avoid MmGetPhysicalAddress failures during USB transfers. CORE-9224 (r73627).
- Apply the patch that allows us to dynamically change the resolution by resizing in VirtualBox. CORE-6742 (r73628).
- Mask WndProc exceptions CORE-11915 (r73631).

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74114
2017-03-06 00:05:13 +00:00
Hermès Bélusca-Maïto 896701f5ca [EXPLORER]: Update the Start Menu banner for CLT 2017.
svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74113
2017-03-05 23:05:49 +00:00
Hermès Bélusca-Maïto 8348d716cd [INF]: Disable hdaudbus.inf registration, because the driver currently crashes on the demo laptops Dell Latitude D531.
svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74084
2017-03-05 19:43:33 +00:00
Hermès Bélusca-Maïto 5849d40c93 [FREELDR]: HACK: Manually reduce the size of the temporary heap from 32MB down to 10MB, because, in some situations (e.g. Bochs, or real HW, see CORE-12694), FreeLDR fails when creating the temporary heap with an "out of memory" error.
See also r73653 for other details.

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74082
2017-03-05 17:03:57 +00:00
Hermès Bélusca-Maïto d358fe320a [BOOTDATA][FREELDR]
- By default, boot the livecd without the kernel debugger enabled, but...
- ... augment the FreeLdr "Debugging Mode" option with serial+screen debug ports, so that, if someone wants to run ReactOS with the kernel debugger on real hardware, without serial port, (s)he still can do it and see the debug output.
I do that, until FreeLdr can support run-time editing boot options of existing boot menu entries.

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74081
2017-03-05 17:01:37 +00:00
Hermès Bélusca-Maïto 311ee91e5d [BOOTDATA]
- Add user-friendly boot menu.
[README]
- Update the ReadMe.txt for CLT 2017.
[WELCOME]
- Add the welcome.exe localized customizations for CLT 2017.
[VERSION]
- Adjust version to 0.4.4 CLT 2017.

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74080
2017-03-05 16:58:55 +00:00
Hermès Bélusca-Maïto ea00f5ba6c [BOOTDATA]
- Flatten out the ISO layout for hybridcd (otherwise some problems appear for the livecd: see r66114 for more details).

svn path=/branches/ReactOS-0.4.4-CLT2017/; revision=74079
2017-03-05 16:38:33 +00:00
Thomas Faber f59a44447a [FREELDR]
- "ReactOS Medium" isn't a trademark or anything, no need to capitalize it

svn path=/trunk/; revision=74077
2017-03-05 11:24:31 +00:00
Giannis Adamopoulos 504b19f120 [COMCTL32] -Slightly improve the hack.
svn path=/trunk/; revision=74076
2017-03-05 10:26:57 +00:00
Giannis Adamopoulos cd690901ea [COMCTL32] -Remove a debug print that is no longer needed.
svn path=/trunk/; revision=74075
2017-03-05 09:42:29 +00:00
Giannis Adamopoulos f3a00c2f57 [COMCTL32] - A button with the style BS_DEFPUSHBUTTON is drawn as defaulted instead of normal.
svn path=/trunk/; revision=74074
2017-03-05 09:35:12 +00:00
Giannis Adamopoulos c27717bac7 [COMCTL32] -Make the lautus hack a bit more strict.
svn path=/trunk/; revision=74073
2017-03-05 09:14:12 +00:00
Giannis Adamopoulos 2e5058f3bf [COMCTL32] Ha^^Fix the size of the start button for lautus so as it gets the same size with our shell in ros and windows.
svn path=/trunk/; revision=74072
2017-03-05 09:09:30 +00:00
Hermès Bélusca-Maïto 71c5ed5c2f [USER32]: Use RtlInitEmptyUnicodeString where needed. Fix CID 1401230 and CID 701428 in the process.
svn path=/trunk/; revision=74071
2017-03-05 01:20:40 +00:00
Hermès Bélusca-Maïto 254b1fbb03 [USER32]: Trim trailing whitespace + few code style changes only.
svn path=/trunk/; revision=74070
2017-03-05 01:19:07 +00:00
Thomas Faber a8d5478895 [NTOS:LPC]
- Implement the early exit case (e.g. on connection refused) in NtAcceptConnectPort
CORE-12145

svn path=/trunk/; revision=74069
2017-03-05 00:55:50 +00:00
Hermès Bélusca-Maïto cc3b08af40 [WS2_32]
- Fix pointers verification in WSALookupServiceNextW and WSALookupServiceNextA;
- In WSALookupServiceNextA: Perform extra checks to see whether we failed the first local buffer allocation, and if so, retrieve the needed size by calling a first time WSALookupServiceNextW, then reallocate the temp buffer and redo a WSALookupServiceNextW call (if it still fails, then we bail out).
  CID 513448.

svn path=/trunk/; revision=74068
2017-03-05 00:40:22 +00:00
Hermès Bélusca-Maïto abc2d4d228 [WS2_32]: Fix the crash in ws2_32 reported in CORE-12852, that happens when opening e.g. Word 2010 for the first time (when it asks for registration):
- Check whether WsNcLoadProvider really succeeded in loading a provider in WsNcGetCatalogFromProviderId, and return appropriate error code.
- In WsNqLookupServiceBegin, initialize CatalogEntry to NULL prior to calling WsNcGetCatalogFromProviderId, and check for success or failure of WsNqAddProvider (and fail in accordance).

svn path=/trunk/; revision=74067
2017-03-05 00:24:08 +00:00
Hermès Bélusca-Maïto 0989caed38 [WS2_32]
- Let require explicit semicolons when using the Ws***(Un)Lock macros (and thus remove the semicolon from their definition).

svn path=/trunk/; revision=74066
2017-03-04 23:55:30 +00:00
Giannis Adamopoulos 6e64a5904a [UXTHEME]: Handle WM_NCACTIVATE only when the window has a themed caption (it's not like windows with classic borders and no caption need to be redrawn to reflect that they get or lose the active state). Fixes the classic border drawn on deactivation in the taskbar. Found by Sylvain Deverre. CORE-12887
svn path=/trunk/; revision=74065
2017-03-04 22:33:21 +00:00
Mark Jansen 80c4567edf [NTDLL] Implement some basic shim engine integration. CORE-10368
svn path=/trunk/; revision=74064
2017-03-04 20:34:36 +00:00
Mark Jansen ba1534d005 [NTDLL] Fix RtlDecodeSystemPointer for usage inside ntdll. CORE-10368
svn path=/trunk/; revision=74063
2017-03-04 20:32:12 +00:00
Mark Jansen 0adcb4d02a [APPHELP] Fix a possible read past the buffer in SdbpIsPathOnRemovableMedia.
svn path=/trunk/; revision=74062
2017-03-04 20:29:46 +00:00
Mark Jansen 985555c58f [APPHELP_APITEST] Check which parts of apphelp accept NT paths
svn path=/trunk/; revision=74061
2017-03-04 20:27:39 +00:00
Eric Kohl 6c5070eb34 [NTOS:CM]
CmpSecurityMethod:
- Lock and unlock the Hive and the KCB.
- Fail, if we try to access a key that has been marked for deletion.

svn path=/trunk/; revision=74060
2017-03-04 19:48:27 +00:00
Thomas Faber fd343d21dd [USER32]
- Fix overflow check in SetScrollRange. CID 731535
CORE-12763 #resolve

svn path=/trunk/; revision=74059
2017-03-04 19:02:30 +00:00
Thomas Faber 3df8b3ccc8 [USER32_APITEST]
- Add a test for SetScrollRange
CORE-12763

svn path=/trunk/; revision=74058
2017-03-04 18:34:35 +00:00
Robert Naumann 5641391fa5 [DESK] Fix Font Smoothing Dropdown Field. Patch by Katayama Hirofumi MZ CORE-12568
svn path=/trunk/; revision=74057
2017-03-04 18:12:42 +00:00
Thomas Faber 2c49ea705c [ACPICA]
- Update to version 20170303
CORE-12885

svn path=/trunk/; revision=74056
2017-03-04 16:54:26 +00:00
Thomas Faber 95cf9fc991 [BOOTDATA]
- Support integrating Intel's DC21x4 network card driver (for Hyper-V/VirtualPC) into our ISOs until we have our own.
CORE-8724

svn path=/trunk/; revision=74055
2017-03-04 16:29:51 +00:00
Eric Kohl 3625064e10 [NTOS:OB]
Create a custom security descriptor for the global DosDevices directory.

svn path=/trunk/; revision=74054
2017-03-04 16:02:06 +00:00
Thomas Faber 16b4b0a874 [NTOS:PNP]
- Make device instance paths unique if necessary (by adding the parent ID prefix), regardless of the return status from IRP_MN_QUERY_ID/BusQueryInstanceID. Support for this IRP is optional in most cases, and a failure status just indicates no instance id information is needed by the driver stack.
Major thanks to Vadim Galyant for debugging this and identifying the root cause.
CORE-12732 CORE-12818 CORE-12745 CORE-12733 CORE-12717 CORE-12735

svn path=/trunk/; revision=74053
2017-03-04 16:01:59 +00:00
Thomas Faber ab14ba211c [NTOS:PNP]
- Use UNICODE_STRINGs in IopCreateDeviceInstancePath instead of messing around with unsafe string functions and stack buffers

svn path=/trunk/; revision=74052
2017-03-04 15:17:30 +00:00
Thomas Faber bf594249dd [FASTFAT]
- Avoid use after free in vfatDestroyFCB

svn path=/trunk/; revision=74051
2017-03-04 14:48:05 +00:00
Eric Kohl 81b072cc64 [NTOS:SE]
Add a missing ACE(SeAliasAdminsSid / GENERIC_ALL) to the SePublicDefaultDacl ACL. This fixes a kmtest:ObSecurity failure. 

svn path=/trunk/; revision=74050
2017-03-04 14:38:13 +00:00
Thomas Faber 4c03c1a55a [NTOS:PNP]
Fix IopGetParentIdPrefix:
- Do not include null terminator in UNICODE_STRING::Length
- Use pool tagging
- Use strsafe printf
- Avoid a magic number

svn path=/trunk/; revision=74049
2017-03-04 13:50:55 +00:00
Thomas Faber 54688094ac [NTOS:PNP]
- Improve use of local variables in IopCreateDeviceInstancePath and IopActionInterrogateDeviceStack
- Improve debug prints in IopCreateDeviceInstancePath. By Vadim Galyant
- Fix formatting in IopGetParentIdPrefix

svn path=/trunk/; revision=74048
2017-03-04 13:20:25 +00:00
Pierre Schweitzer 3676af8656 [FASTFAT]
When un/locking a volume, also handle VPB state

svn path=/trunk/; revision=74047
2017-03-04 11:34:13 +00:00
Kamil Hornicek a2bf0e2023 [WIN32K]
- GreGetDIBitsInternal:
- Prevent an access violation in DIB_FreeConvertedBitmapInfo by initializing the bit count before calling DIB_ConvertBitmapInfo and setting clrUsed.
- Validate input parameters and return correct values - only return number of scan lines if bits are not null and bpp is not zero. Otherwise return 1 on success.
- We now pass more gdi32:GetDIBits and gdi32:bitmap tests.
CORE-9270

svn path=/trunk/; revision=74046
2017-03-04 10:37:00 +00:00
Hermès Bélusca-Maïto f752d4ffda [WS2_32]
- Turn the "!memcmp(ptr1, ptr2, sizeof(GUID))" into IsEqualGUID(ptr1, ptr2) macro calls (aka. make code readable);
  this also allowed me to discover a logical bug in the GUID comparison in WsNcUpdateNamespaceList.
- Fix few comments, and rename some goto labels to make their meaning clearer (they are not only taken for error code paths,
  but also on regular path, for cleanup before returning from the function).
CORE-12880

svn path=/trunk/; revision=74045
2017-03-04 01:09:28 +00:00
Hermès Bélusca-Maïto 99e8525cb3 [WS2_32]: More fixes:
- Perform success checks in WsAsyncCheckAndInitThread, in particular, check whether Context is correctly allocated,
  and check whether the WsAsyncThread was correctly started up. In case of failure, perform the necessary cleanup,
  including calling WSACleanup().
- Check also the returned error code of WSAStartup. Fixes CID 1101934.
- Fix logic mess-up in WsNqLookupServiceNext when updating NsQuery->ActiveProvider;
- Fix copy-pasta errors (using 'lpafpProtocols' instead of 'lpcsaBuffer') in CopyQuerySetIndirectA and CopyQuerySetIndirectW,
  that triggered CID 513446 + CID 513447 (CopyQuerySetIndirectA), and CID 513444 + CID 513445 (CopyQuerySetIndirectW).
- Check for 'lpdwBufferLength' pointer validity in WSALookupServiceNextW;
- Check for 'lpdwBufferLength' and 'lpqsResults' pointers validity in WSALookupServiceNextA, and dereference lpdwBufferLength only afterwards.
- Check for return value of RegCreateKeyEx in WsOpenRegistryRoot(), fixes CID 715923.

svn path=/trunk/; revision=74044
2017-03-04 00:35:02 +00:00
Hermès Bélusca-Maïto ba1cd55e86 [WS2_32]
- Check for NULL pointers after HeapAlloc calls, in the constructor functions, before initializing members of created objects;
- Add a bunch of missing HeapFree in the corresponding destructor functions.
  In particular, fix the root cause of CID 1401152 in WsTpDelete: missing HeapFree call.
CORE-12880

svn path=/trunk/; revision=74043
2017-03-03 23:47:26 +00:00
Hermès Bélusca-Maïto 0386475fc9 [WS2_32]: Addendum to r74041: Forgot these changes too. CORE-12880
svn path=/trunk/; revision=74042
2017-03-03 23:34:47 +00:00