Commit graph

74873 commits

Author SHA1 Message Date
Thomas Faber
e1b20681f5
[NTOS:IO] Avoid a fixed-length buffer in IopGetDriverObject. CORE-15882 2019-05-05 10:39:01 +02:00
Thomas Faber
6fdff1f970
[NTOS:KDBG] Avoid use of MAX_PATH. CORE-15882 2019-05-05 10:38:10 +02:00
Pierre Schweitzer
8d128aa441
[KERNEL32] Reduce QueryDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
Also, properly handle RtlUnicodeStringToAnsiString failures.
Finally, make sure output buffer is properly 0 terminated.
2019-05-05 10:17:16 +02:00
Pierre Schweitzer
1ed7f27466
[KERNEL32] Reduce DefineDosDeviceA memory footprint
by using TEB static unicode string (which is already
preallocated).
2019-05-05 10:17:16 +02:00
Hermès Bélusca-Maïto
2ebda0e3d0
[CONSOLE.CPL] Fix the console screen preview when selecting TrueType fonts.
CORE-13182 CORE-13196

- Use the correct character height & width.
- Additions: use StringCch*() when initializing the dialog title.

[CONSRV:CONCFG] Minor fixes.

- When retrieving font characteristics in ConCfgReadUserSettings(),
  check for NULL/zero values that indicate that we should use default
  ones instead.
- Rename 'dwNumSubKeys' into 'dwNumValues'.
2019-05-05 01:20:19 +02:00
Eric Kohl
fa63416d87 [MC] Add message tranlations. Supplement to 3acec58f. 2019-05-04 23:13:28 +02:00
Eric Kohl
3acec58fb5 [NET] Replace remaining strings of the NET ACCOUNTS command by messages 2019-05-04 21:12:09 +02:00
Pierre Schweitzer
83d8fbf434 [ROSAUTOTEST] Don't disallow buffering for journal file
This fixes back journal in ReactOS "at low costs". Indeed,
because write are improperly aligned right now, journaling
just fails.
With that patch, Cc will take care of aligning writes and
journal will be written again. Because flush operations
happen at each and every write to the journal, we expect
changes to land on disk quickly (not as quickly as if
they were directly written). But that's a good trade off
between over engineering and fixing a broken feature.

CORE-15973
2019-05-04 11:54:39 +02:00
Pierre Schweitzer
ab69736a1d
[AUTOCHK] Don't check any volume on boot
This will avoid triggering a FAT repair on
unclean FAT volumes.

If dosfstools.fsck works fine in Linux, its
usage on ReactOS triggers worse corruption
than unclean shutdown.

Given I've no time for debugging this, I
kill it off.

CORE-14638
2019-05-04 11:02:29 +02:00
Katayama Hirofumi MZ
262f712810 [WIN32SS][NTGDI] Correctly get/update ptlCurrent about TA_UPDATECP 2019-05-04 10:07:24 +09:00
Katayama Hirofumi MZ
cb9a9fa984 [WIN32SS][NTGDI] Wrap IntLPtoDP and IntDPtoLP macros by do { .... } while (0) 2019-05-04 09:56:09 +09:00
Mark Jansen
1292f5f881
[APPSHIM_APITEST] Fix 2k3 test failures 2019-05-02 22:07:49 +02:00
jimtabor
b3b40b35c9 [HIDParser] Fix MSVC build
Attempt to fix build for MSVC.
This effected local build GCC system with newer Ninja version. Not sure
if this has an effect.
2019-05-02 14:33:07 -05:00
Eric Kohl
5164c852e8 [POWERPROF] ValidatePowerPolicies: Do not fail because of legal power states which were set by FixSystemPowerState. 2019-05-02 20:39:58 +02:00
Hervé Poussineau
7033ab18df [HID] Use hidparser static library for HidP_* functions
hid.dll and hidparse.sys must understand the same HID preparsed data,
so use the same code in hid.dll and in hidparse.sys

At the same time, this permis implementation of some HidP_* functions.
2019-05-02 20:06:47 +02:00
Hervé Poussineau
2978d4b61b [HIDPARSE/HIDPARSER] Move HidP_* functions from hidparse.sys to hidparser library
Interface between both is not anymore the HidParser_* functions, but
the HidP_* functions and the AllocFunction/FreeFunction/DebugFunctions/
ZeroFunction/CopyFunction.
2019-05-02 20:06:47 +02:00
Hervé Poussineau
bef39dd62e [SERIAL] Immediately complete read IRP if all requested bytes have been found in circular buffer
Previously, we had to wait to receive another byte to finish the first IRP.
2019-05-02 20:06:47 +02:00
Hervé Poussineau
ebd39aa266 [I8042PRT] Do not assert on unknown IOCTL 2019-05-02 20:06:47 +02:00
jimtabor
2cc766b0c6 [NtGDI] Set Xform flags if a changed
Missed more flags changes.
2019-05-02 11:56:55 -05:00
jimtabor
b2ce1ae206 [NtGDI] Set Xform flags if a changed
Missed flags changes.
2019-05-02 10:16:50 -05:00
jimtabor
04a04659da [NtGDI] Adding Support for Viewport TextOut
Add Viewport changes to Text Out Batch.
2019-05-02 10:11:11 -05:00
Katayama Hirofumi MZ
dcaaf3e7af
[COMDLG32] Fix treatment of wrong filename extension (#1545)
Fix treatment of wrong filename extensions upon GetOpenFileName/GetSaveFileName. CORE-15270
2019-05-02 22:48:01 +09:00
Pierre Schweitzer
bdaa8e5ad1
[NTDLL_APITEST] Query sector size for NtWriteFile tests 2019-05-02 13:59:47 +02:00
Pierre Schweitzer
64b6327dd7
[NTDLL_APITEST] Add tests for alignment for NtWriteFile
This mimics the usage of WriteFile which is done in rosautotest.

 CORE-15973
2019-05-02 12:09:34 +02:00
James Tabor
9d00413754 [GDI32] Add batch flag for Text Out
Set batch flag for Text Out with font and attributes change sets.
2019-05-01 23:24:53 -05:00
James Tabor
44b11ad6a9 [GDI32] Fix MS build
Fix old uncovered code.
2019-05-01 20:53:06 -05:00
James Tabor
b751c31c74 [GDI32] Update signal flags for batch.
Add removed flags for batch signaling. This will allow syncing of
changed Xfroms after batched drawing. Disable calls to kernel mode since
the code is closely identical. Kernel calls are for init time when
PDCATTR is normally zero. ReactOS seems to work better keeping this from
NULL.
While making code changes add Xform state flags from:
https://www.reactos.org/archives/public/ros-diffs/2019-May/070693.html

Test BOT results:
https://reactos.org/testman/compare.php?ids=67251,67254
https://reactos.org/testman/compare.php?ids=67253,67255
2019-05-01 20:33:09 -05:00
Bișoc George
f8b90805ff
[OSK] Hotfix for PR #1536 (#1549)
CORE-15965
2019-05-01 22:22:08 +02:00
Mark Jansen
575ab6c760
[ACGENRAL] Add a test shim 2019-05-01 19:22:19 +02:00
Mark Jansen
0e9ca37517
[ROSAPPS] Add a test application for shims 2019-05-01 19:22:19 +02:00
Mark Jansen
1570f08b4d
[APPHELP] Add ordinal import support 2019-05-01 19:22:19 +02:00
Eric Kohl
2872cfc3b7 [POWERCFG] Fix indentation. No code changes! 2019-05-01 13:16:38 +02:00
Katayama Hirofumi MZ
88fbb600bf
[GDI32_APITEST] Improve SetMapMode testcase (#1547)
Check the relation of mode change and viewport change. CORE-14994
2019-05-01 18:28:18 +09:00
Katayama Hirofumi MZ
f7bc0543cb
[WIN32SS][NTGDI] Fix ExtTextOut about TA_UPDATECP (#1546)
Add WORLD_XFORM_CHANGED flag to some positioning functions.
Fix IntExtTextOutW function for TA_UPDATECP alignment, so that it can correctly update the current position. CORE-14994
2019-05-01 16:51:00 +09:00
Katayama Hirofumi MZ
0ac563b3ec [KERNEL32_APITEST] JapaneseCalendar: Reiwa era has come! 2019-05-01 16:15:23 +09:00
Mark Jansen
2450dec427
[NTOS/MM] Ensure ImageBase is not used uninitialized 2019-04-30 18:57:43 +02:00
Hermès Bélusca-Maïto
77d234b049
[KERNEL32] Addendum to 0e3a0435 (PR #803): always return TRUE in the stub-plemented SetThreadStackGuarantee() to continue satisfying programs that use it. CORE-15989 2019-04-29 22:51:35 +02:00
Bișoc George
f681bad246 [OSK] Make the buttons themed
Our On-Screen Keyboard has a manifest and the buttons (the ones with BS_ICON styles) aren't rendered with the specific theme as it should be but instead it takes the classic theme.

The code relies on NM_CUSTOMDRAW notification, which is more intuitive and efficient than doing owner-drawn operations as NM_CUSTOMDRAW allows the controls to use styles whereas you cannot do it on owner-drawn controls.

CORE-15965
2019-04-29 21:31:29 +02:00
Katayama Hirofumi MZ
9ce337242b [WIN32KNT_APITEST] Forgot a extension in CMakeLists.txt 2019-04-29 19:42:04 +09:00
Katayama Hirofumi MZ
8bdfdd5c17
[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540)
Fix NtGdiTransformPoints, gdi32!DPtoLP, gdi32!LPtoDP and gdi32!SetMapMode functions. Fix CORE-15983. CORE-15983
2019-04-29 14:45:44 +09:00
Katayama Hirofumi MZ
45ec49ca2f [APITESTS] set_module_type(win32u module) 2019-04-29 12:49:54 +09:00
Katayama Hirofumi MZ
45bbb11a50
[APITESTS] Add NtGdiTransformPoints testcase (#1542)
Add a testcase for NtGdiTransformPoints function. set_module_type(win32u... win32dll) CORE-15983
2019-04-29 09:13:22 +09:00
Hermès Bélusca-Maïto
f21f750467
[KERNEL32_APITEST] Rename the 'Console.c' file into 'ConsoleCP.c' and its test-function as well, in order to reflect the actual name of the corresponding test. 2019-04-28 23:46:35 +02:00
Colin Finck
2c11c41115
Add a shared "port" directory for POSIX functions needed by multiple host tools (getopt/mkstemps) and import the one and only getopt from glibc.
This finally fixes our duplicated getopt functions from different sources and gives us an up to date and the most compatible implementation.
isohybrid actually relies on a glibc-specific getopt behavior that we previously hacked into the reactos_support_code.c implementation derived from BSD/mingw-w64.
widl also needs getopt and previously used an even older BSD-derived code.
2019-04-28 23:23:06 +02:00
Colin Finck
c02257ef57
[ISOHYBRID] Fix the remaining warnings properly.
I will send these changes upstream (minus the REACTOS_ISOHYBRID_EFI_MAC_SUPPORT ifdefs).
2019-04-28 23:22:53 +02:00
Timo Kreuzer
f47f45dbdd
[TOOLS] Fix/suppress all MSVC/x64 warnings (#1525) 2019-04-28 23:21:48 +02:00
Hermès Bélusca-Maïto
0aed8b09a4
[CONSRV] Cache the console window system menu handle; simplify its initialization code. 2019-04-28 21:47:55 +02:00
Serge Gautherie
cf48f8bf8a [REACTOS] Replace remnant legacy SPIF_SENDWININICHANGE by SPIF_SENDCHANGE (#1526)
No functional change otherwise.
2019-04-28 21:19:42 +02:00
Bișoc George
89f6929dae [ACCESS] Reposition the "ToggleKeys" group box control (#1541)
CORE-15383
2019-04-28 20:21:38 +02:00
Andrew Boyarshin
458a26ab76
[WIN32SS:NTUSER] Use the 2nd parameter of NtUserGetThreadDesktop() as fallback. (#1065)
- The 2nd parameter is already passed in user-mode by GetThreadDesktop().
  It is then used by NtUserGetThreadDesktop() as a fallback for console
  threads.

- Lookup and validate the thread by using the IntTID2PTI() helper.
- Don't reference the desktop with too many access rights.
- Get rid of the old-school DECLARE_RETURN() & co. macros.

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2019-04-28 19:27:45 +02:00