Commit graph

57201 commits

Author SHA1 Message Date
Robert Naumann 507c4db50d [TASKMGR] improvement german: too long string in statusbar - Patch by Joachim Henze.
svn path=/trunk/; revision=71360
2016-05-19 22:41:08 +00:00
Hermès Bélusca-Maïto fe1096e0c0 [SDK/INCLUDE]: Fix a typo in ntstatus.mc (Debuger --> Debugger).
svn path=/trunk/; revision=71359
2016-05-19 22:18:11 +00:00
Hermès Bélusca-Maïto c294e76682 [SDK/INCLUDE]: Fix ntstatus.mc: extra end-line whitespace and erroneous newlines at the end of the messages.
svn path=/trunk/; revision=71358
2016-05-19 21:22:41 +00:00
Thomas Faber 28b4a2412b [AFD]
- Don't overwrite values in a completed IRP in ReceiveActivity
CORE-11276 #resolve

svn path=/trunk/; revision=71357
2016-05-19 21:17:18 +00:00
Eric Kohl 811a8408d0 [NETSHELL]
- Provide a common struct for the network setup data.
- Remember the typical/custom setup decision in order to return to the proper previous page when we click the 'Back' button on the domain page.
- Rename network setup page functions in a consistent way.
CORE-10955

svn path=/trunk/; revision=71356
2016-05-19 13:42:37 +00:00
Thomas Faber 6b27b08a69 [SERVICES]
- On service stop, set Service->lpImage to NULL after calling ScmDereferenceServiceImage, so the same image is not dereferenced again on service deletion
- Do not call ScmDereferenceServiceImage in CreateServiceListEntry, as the service should never have an image there
CORE-11273 #resolve

svn path=/trunk/; revision=71355
2016-05-19 13:01:04 +00:00
Thomas Faber 407f2e8218 [ACPI]
- Correctly double-null-terminate hardware IDs
CORE-11271 #resolve

svn path=/trunk/; revision=71354
2016-05-19 10:15:15 +00:00
Hermès Bélusca-Maïto 63318080ba [NETSHELL]
Addendum to r71348:
Fix MSVC build: "netshell\lang/de-DE.rc(87) : warning RC2182 : duplicate dialog control ID 3501" . Both IDC_NETWORK_TYPICAL and IDC_NETWORK_CUSTOM setup wizard pages had this same ID.
Obviously, GCC didn't catch this error. But the generated code would not have worked as expected.

CORE-10955 #comment [~milawynsrealm], please retest with r71353.

svn path=/trunk/; revision=71353
2016-05-18 21:49:31 +00:00
Colin Finck 270d4db920 Test commit to fix the nightmare caused by "previous" r71352.
See https://reactos.org/archives/public/ros-dev/2016-May/017845.html

svn path=/trunk/; revision=71352
2016-05-18 17:01:01 +00:00
Robert Naumann 59c83ddfe9 [SHELL32] Addendum to r71343: Remove some unneeded checks. The handles are initialized as NULL so they will never be true
svn path=/trunk/; revision=71351
2016-05-18 10:12:13 +00:00
Robert Naumann 0b4cad0a63 [TASKMGR] Use the correct title string for create new task dialog. Spotted by Jared Smudde. CORE-11129
svn path=/trunk/; revision=71350
2016-05-18 08:30:45 +00:00
Eric Kohl 97f7bbfc4b [SYSSETUP/NETSHELL]
2nd Stage Network Setup
Patch by Lee Schroeder and Eric Kohl.
- Move Lees 2nd stage network setup wizard code to netshell. It gets called by syssetup via NetSetupRequestWizardPages().
- Add code to syssetup which calls NetSetupRequestWizardPages and inserts the retrieved wizard pages into the setup wizard.
- Prevent a font handle leak by storing the bold font handle in the SetuData.

CORE-10955 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71348
2016-05-17 22:38:58 +00:00
Mark Jansen 256737ae18 [PSDK] now the ICurrentWorkingDirectory interface is actually an interface.
svn path=/trunk/; revision=71347
2016-05-16 18:50:14 +00:00
Eric Kohl 6f7967123d [NETAPI32]
Add NetGetAnyDCName stub.
CORE-11261 #comment Please test again!

svn path=/trunk/; revision=71346
2016-05-16 18:34:52 +00:00
Mark Jansen cb31fa202a [PSDK] Add missing definitions for IACList2 Options. CORE-9281
svn path=/trunk/; revision=71344
2016-05-16 17:59:10 +00:00
Robert Naumann 8d49e82b9c [SHELL32] - Implement a skeleton DlgProc for the folder options general dialog
- show icons depending on button states in folder options general dialog

svn path=/trunk/; revision=71343
2016-05-16 11:58:31 +00:00
Daniel Reimer 4cc03bbf01 [BOOTDATA]
Fix autorun.inf on LiveCD and HybridCD linking to a non existent welcome.exe. HybridCD now links to the correct folder to welcome.exe and LiveCD just opens the readme.txt
https://www.reactos.org/forum/viewtopic.php?f=2&t=15406

svn path=/trunk/; revision=71342
2016-05-16 11:11:22 +00:00
Christoph von Wittich d2a7e3aea8 [REGSRV32] accept '-' as command line delimiter symbol as well
svn path=/trunk/; revision=71340
2016-05-16 07:17:45 +00:00
Hermès Bélusca-Maïto 8a7240c71a [NTOS][NDK][RTL]: Move the SEM_xxx flags and their corresponding RTL flags around so that they can be accessed in kernel code. I'll need them soon.
svn path=/trunk/; revision=71339
2016-05-15 22:40:34 +00:00
Hermès Bélusca-Maïto ad5dceff98 [NTOS][USERSRV]: Both hard-error message box options "OptionOkNoWait" and "OptionCancelTryContinue" are valid!
svn path=/trunk/; revision=71338
2016-05-15 22:32:17 +00:00
Hermès Bélusca-Maïto 497e74bc43 [USERSRV]: Code formatting.
svn path=/trunk/; revision=71337
2016-05-15 22:29:23 +00:00
Hermès Bélusca-Maïto 02a7b8eca5 [NTOS]: Remove hardcoded constants; fix a comment; move some code around to reduce the level of code indentation.
svn path=/trunk/; revision=71336
2016-05-15 22:23:14 +00:00
Mark Jansen fb1cfa467b [PSDK] Add missing ICurrentWorkingDirectory definition. CORE-9281
svn path=/trunk/; revision=71333
2016-05-15 10:31:15 +00:00
Mark Jansen 70595b9400 [SHELL] Addendum to r71328, correct one german resource id.
svn path=/trunk/; revision=71332
2016-05-15 10:25:47 +00:00
Hermès Bélusca-Maïto d74b93c5eb [NTOS][MUP]: Use the correct constant for the PriorityBoost parameter in the IoCompleteRequest calls.
svn path=/trunk/; revision=71331
2016-05-15 00:18:44 +00:00
Hermès Bélusca-Maïto a8924f81c4 [DRIVERS][NTOSKRNL]
Don't use PWORK_QUEUE_ITEM casts in ExQueueWorkItem calls, but use the explicit underlaying work queue item object instead.

svn path=/trunk/; revision=71330
2016-05-15 00:16:31 +00:00
Hermès Bélusca-Maïto fb35282eb3 [PROGMAN]
Implement drag&drop support for program items. A similar functionality can be implemented later in our shell32/explorer, based on this code.
We do here better than Windows' progman since we can select and move more than one icon.
Note that if you test it on ReactOS you will see nice bugs coming from our (well, Wine's) comctl32.dll xD :P

svn path=/trunk/; revision=71329
2016-05-12 22:36:05 +00:00
Robert Naumann a8097ca3e1 [SHELL] Change the icon controls of the folder-options general page to static ones. Also give them and the radio buttons some meaningfull identifiers. Big thanks to our flying dutchman ;)
svn path=/trunk/; revision=71328
2016-05-12 21:26:55 +00:00
Hermès Bélusca-Maïto 41ed1557a2 [PROGMAN]
- Fix the icon chooser dialog: icon enumeration, icon list cleanup... Similar fixes should also be ported to our shell32 icon list dialog code!
- Remove erroneous LBS_SORT style from the icon list box.

svn path=/trunk/; revision=71327
2016-05-12 21:12:40 +00:00
Hermès Bélusca-Maïto 1e2e730dd3 [PROGMAN]
- Load the main icon in a global variable (we use it at different places).
- Use the main icon for the shell-about dialog.

svn path=/trunk/; revision=71325
2016-05-12 19:54:53 +00:00
Hermès Bélusca-Maïto 021e1a40a4 [PROGMAN]: Use a ListView to list program items. On systems that support it (aka. Vista+), enable ListView theming.
svn path=/trunk/; revision=71324
2016-05-12 19:45:26 +00:00
Amine Khaldi 80d2a73871 [PROGMAN] Fix PCH build.
svn path=/trunk/; revision=71322
2016-05-12 16:32:35 +00:00
Eric Kohl 1732ee52e0 [USETUP]
Pressing F3-Enter during setup behaves wrong sometimes.
Patch by Wim Hueskes.
CORE-11231 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71321
2016-05-12 16:18:32 +00:00
Eric Kohl ade016e3a4 [USETUP]
Debug output in usetup.
Patch by Wim Hueskes.
CORE-11230 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71320
2016-05-12 15:30:49 +00:00
Eric Kohl beacbdfc3b [TELNET]
Updating Turkish Translation.
Patch by Erdem Ersoy.
CORE-11226 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71319
2016-05-12 14:44:25 +00:00
Thomas Faber 297eae47ed [EXPLORER]
- Avoid activating windows when updating their size and position
CORE-11217

svn path=/trunk/; revision=71318
2016-05-12 12:14:42 +00:00
Hermès Bélusca-Maïto 6df01a9cb0 [PROGMAN]: Commit 90% of the work I did on progman since its first inclusion in ReactOS: this concerns upgrading its user interface code from Wine's Win3.11-compatible code to WinNT-compatible code.
As this is *recovered* code from what I had in my local trunk before my HDD crash that occurred last month, this is almost pure code without most of the comments (this especially concerns the MAIN_LoadSettings function).
The 10% code that is not restored yet concerns the reader/writer code for program group files, and it will be committed separately later. This (missing) code is the core of progman; without it progrman does nothing interesting apart from displaying its main window (and its utility dialogs).

svn path=/trunk/; revision=71317
2016-05-11 22:21:53 +00:00
Thomas Faber bae547dcec [I8042PRT]
- Don't access device control IRPs after handing them off to a worker routine that has potentially already freed them.
CORE-11229 #resolve

svn path=/trunk/; revision=71316
2016-05-11 12:30:12 +00:00
Pierre Schweitzer cfe81c2bb8 [BTRFS]
Cherry pick d71baf195715601212a2043f153400a964da6a18: Don't remove an entry list twice in add_to_space_list()

This avoids linked list entry twice removal

CORE-11057

svn path=/trunk/; revision=71315
2016-05-10 21:08:50 +00:00
Pierre Schweitzer e1036d5ff1 [BTRFS]
Cherry pick aa04ca0ea4cadb0c70ff6d659916cc98b7b02c27: uninit: don't free roots before FCBs are freed

This avoids use-after-free on shutdown

svn path=/trunk/; revision=71314
2016-05-10 21:07:56 +00:00
Robert Naumann ece9acc307 [SHELL32] Improve a list view header. Patch by Jared Smudde. CORE-11151
svn path=/trunk/; revision=71313
2016-05-10 20:48:39 +00:00
Mark Jansen 4a7af46cee [APPHELP] Remove imagehlp.dll dependency. CORE-10367
svn path=/trunk/; revision=71312
2016-05-10 20:42:37 +00:00
Thomas Faber 67c8423d4f [FASTFAT]
- Fix a use after free in VfatFlushVolume
CORE-11224 #resolve

svn path=/trunk/; revision=71311
2016-05-10 18:29:06 +00:00
Mark Jansen 64f0b43852 [UNIATA] Fix uninitialized variable usage. Patch by 'Alter'. CORE-11157 #resolve #comment Thanks!
svn path=/trunk/; revision=71309
2016-05-10 18:15:35 +00:00
Thomas Faber bc4d7ba184 [IPHLPAPI]
- Don't use uninitialized values in AllocateAndGet*TableFromStack functions. CID 716757
- Free buffers on failure
CORE-11227 #resolve

svn path=/trunk/; revision=71308
2016-05-10 17:53:36 +00:00
Thomas Faber ba1fac2999 [HAL]
- Create a wrapper version of HalpEndSoftwareInterrupt that frees its stack before calling the noreturn version of the next software interrupt handler. Fixes excessive stack usage when DPCs are queued in quick succession.
CORE-11123 #resolve

svn path=/trunk/; revision=71307
2016-05-10 15:03:56 +00:00
Thomas Faber 418ef674ed [IPHLPAPI]
- Fix memory leaks in getInterfaceInfoSet (CIDs 716370 and 716371)
- Fix a benign uninitialized variable use (CID 500783)
CORE-11224 #resolve

svn path=/trunk/; revision=71306
2016-05-10 13:59:41 +00:00
Thomas Faber f40cfb8b12 [IPHLPAPI]
- Tabs to spaces. No code changes.

svn path=/trunk/; revision=71305
2016-05-10 13:42:57 +00:00
Thomas Faber 1ebef466b4 [NTOS:MM]
- Keep track of physical pages allocated for special pool, and respect the initially calculated MiSpecialPagesNonPagedMaximum

svn path=/trunk/; revision=71304
2016-05-10 11:47:05 +00:00
Hermès Bélusca-Maïto bbc880b695 [CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched by Victor Martinez Calvo Should fix CID 1322302 "Fix an use after free".
Please reanalyze with Coverity :)
CORE-11179

svn path=/trunk/; revision=71303
2016-05-09 22:06:27 +00:00