Commit graph

77349 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto e3a7066279
[CSRSRV] CsrCaptureArguments(): Tell the compiler the contents ClientCaptureBuffer points to has a volatile character.
See https://docs.microsoft.com/fr-fr/archive/blogs/itgoestoeleven/why-your-user-mode-pointer-captures-are-probably-broken
for more details.

Since the contents of ClientCaptureBuffer is in the shared memory, the
client could modify it while it is being probed and captured, and so we
have to avoid any potential compiler optimizations regarding the
captured "Length = ClientCaptureBuffer->Size" and
"PointerCount = ClientCaptureBuffer->PointerCount" values.
2020-04-15 14:14:06 +02:00
Julen Urizar Compains d7a632a094
[TRANSLATION] Spanish minor fixes (#2547)
Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup

- Add Spanish translation for Accesibility Utility (utilman).

Update for the "Choose product options" strings in syssetup:

Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
2020-04-15 13:27:36 +02:00
Serge Gautherie f540b2b20c
[IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526)
And fix 4 comments.
Follow-up to 68d94581.
2020-04-15 13:05:54 +02:00
Erkin Alp Güney 1769793bd1
[SYSSETUP] Added a flag for mandatory password (#2500)
Use a human-readable #define flag 'PASSWORDS_MANDATORY' instead of the #if 0.
See also CORE-8038.
2020-04-15 12:50:36 +02:00
Serge Gautherie efd59ec202
[README.WINE] Fix 'User32' typo and add winetests/winmm. CORE-16441 (#2525)
CORE-16441
2020-04-15 12:48:54 +02:00
Bișoc George 12d4409086
[SDK][PSDK] Add a version check for DiskGeometryGetPartition and DiskGeometryGetDetect and add a missing member to PARTITION_INFORMATION_EX structure (#2541)
DiskGeometryGetPartition() and DiskGeometryGetDetect() are guarded in NTDDI_VERSION for version checking as they differ between Windows XP and Server 2003. In conjunction to that, the PARTITION_INFORMATION_EX structure has "IsServicePartition" as member which is missing in the current NT IOCTL Disk interface header.
2020-04-15 12:47:01 +02:00
Stanislav Motylkov 643458114f [ZIPFLDR] Fix FriendlyTypeName registry value (#2548)
It should be a value inside CompressedFolder key, not a subkey.
2020-04-15 12:38:27 +02:00
Stanislav Motylkov 978bcf8601 [ZIPFLDR] Add Russian translation (#2548) 2020-04-15 12:38:27 +02:00
Stanislav Motylkov 033f0d998a [SHELL32] Add Russian translation (#2548)
CORE-16866
2020-04-15 12:38:27 +02:00
Adam Słaboń d7856b4236
[THEMES][LUNAR] Add bitmaps for quick launch toolbar (#2549) 2020-04-15 12:37:54 +02:00
Adam Słaboń 7b24d00ef1
[FREELDR][INSTALL][FDEBUG] Include FreeLDR tools in LiveCD and HybridCD (#2550)
It might be useful to have them on LiveCD/HybridCD as well.
2020-04-15 12:37:21 +02:00
Hermès Bélusca-Maïto 7e2db77338
[CSRSRV] Improve validation of CSR API Message's capture buffers.
- Improve capture buffer validation in CsrCaptureArguments(), by
  implementing the checks done by Windows 2003 (NT 5.2) described
  in section "Server-Side Validation and Capture" of the article
  https://www.geoffchappell.com/studies/windows/win32/csrsrv/api/apireqst/capture_header.htm

- In CsrReleaseCapturedArguments(), protect the data copy back into
  the client buffer within a SEH block.
2020-04-15 02:07:00 +02:00
Hermès Bélusca-Maïto 358dd50d61
[CSRSRV] CsrCaptureArguments() and CsrReleaseCapturedArguments(): Use better names for the capture buffers.
Rename inaccurate names 'LocalCaptureBuffer' and 'RemoteCaptureBuffer'
into 'ClientCaptureBuffer' and 'ServerCaptureBuffer' respectively.
(Recall: CSRSRV is the 'Server', and any app doing LPC calls to it is
the 'Client'.)
2020-04-15 02:06:59 +02:00
Hermès Bélusca-Maïto dd77ac67d0
[CSRSRV] Protect the Server DLL entrypoint calls under SEH. 2020-04-15 02:06:58 +02:00
Hermès Bélusca-Maïto 835f3ef13d
[CSRSRV] Only when CSRSRV is compiled in debugging mode, should we display debugging messages and support debug breakpoints.
Also, trigger the less fatal breakpoints only if CSRSS/CSRSRV is being
debugged (the 'BeingDebugged' flag is set in the current PEB). This will
avoid any unhandled breakpoint exceptions when testing/fuzzing running
debug builds of ReactOS without any debugger attached.
2020-04-15 02:06:58 +02:00
Hermès Bélusca-Maïto 37b2c1450c
[CSRSRV] s/LPWSTR/PWSTR/ as the former is not NT type. 2020-04-15 02:06:57 +02:00
Joachim Henze feeeca2695 [SYSDM.CPL] fr-FR Resize & Reposition 3 buttons CORE-16595
to avoid text truncation of the button
"Environment Variables"
2020-04-14 01:35:10 +02:00
Hermès Bélusca-Maïto c05df38e86
[CONSRV] Move process-initialization-specific functions from handle.c into console.c .
- Move ConSrvInitHandlesTable() & rename it ConSrvInitProcessHandles()
  since its purpose is to initialize the standard input, output and
  error handles for a console process.

- Move ConSrvAllocateConsole(), ConSrvInheritConsole() and
  ConSrvRemoveConsole().
2020-04-14 01:19:48 +02:00
Joachim Henze 951e5f2851 [DXDIAG] fr-FR Translation Addendum CORE-12477 part 3/3
Leave english strings untouched regarding space before colon.
Thanks to HBelusca for review as well.
I hope next one translating these will take care still.
2020-04-14 00:42:33 +02:00
Joachim Henze f03c4c4378 [DXDIAG] fr-FR Translation Addendum CORE-12477
Addendum to 0.4.14-dev-1405-g
dcc6dcb0bd

Readd all spaces before the colons that I removed,
as that is a french speciality and was correct,
and also add some more of those that were missing even
before my commit (was inconsistent).

Thanks to Serge Gautherie, Thomas Faber and hpoussin
for the review.
2020-04-14 00:06:48 +02:00
Joachim Henze a050378835 [MSPAINT] fr-FR Translate some menu items CORE-12357 2020-04-13 23:28:30 +02:00
Mark Jansen 365fafc03b
[MSCTF_WINETEST] Skip crashing test when it fails
CORE-16797
2020-04-13 22:44:56 +02:00
Joachim Henze dcc6dcb0bd [DXDIAG] Less text truncation for all languages
Manually Tweaked fr-FR the most, see CORE-12477
Manually Tweaked de-DE enlarged a buttons size
For All Languages harmonized " :"->":"

For All Languages harmonized the maximized available space
for dynamic strings in 2nd tab right side from 100->120
2020-04-13 22:43:37 +02:00
Thomas Faber f4a8d3d704
[WINDOWSCODECS] Avoid buffer underflow in TiffFrameDecode_ReadTile. CORE-16796 2020-04-13 18:18:35 +02:00
Hermès Bélusca-Maïto 2b64d45377
Fix build. 2020-04-13 18:13:42 +02:00
Hermès Bélusca-Maïto 83c238e490
[CONSRV] Convenience fixes.
- Simplify screen-buffers initialization.
- Get rid of this CONSOLE_SCREEN_BUFFER_VTBL virtual table.
- Move ConsoleInput to a proper header.
2020-04-13 16:22:53 +02:00
Eric Kohl 69e565891d [SHELL32] No french translation from "right click drag'n'drop"
CORE-16815
2020-04-13 15:41:13 +02:00
Eric Kohl c037278c5f [SHELL32] Fix missing french translation for "Command prompt here"
CORE-16855
2020-04-13 15:27:47 +02:00
Eric Kohl 16a4fc76de [DEVMGR] Do not add the 'Resources' page to the device properties if the device does not have any resources 2020-04-13 12:33:58 +02:00
Eric Kohl 1ca7d5d948 [IPCONFIG] Improvements to ipconfig
- Simplify the cleanup-code in ShowInfo
- Print the 'Primary DNS suffix' and the 'DNS Suffix Search List'
- Move the /registerdns message into its own function
2020-04-13 11:25:50 +02:00
Katayama Hirofumi MZ 5af2570b37 [SHELL32] Follow-up No.3 of #2539
Improve a comment in CreateNotificationParamAndSend.
CORE-13950
2020-04-13 13:19:12 +09:00
Katayama Hirofumi MZ b76d053a30 [SHELL32] Follow-up No.2 of #2539
Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950
2020-04-13 13:06:15 +09:00
Katayama Hirofumi MZ bfe36e4f0d [SHELL32] Follow-up of #2539
Improve comment. CORE-13950
2020-04-13 10:41:26 +09:00
Katayama Hirofumi MZ 2727245c86
[SHELL32] Shell notify rework for simplicity and readability (#2539)
Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950
2020-04-13 10:36:24 +09:00
Mark Jansen b68749c727
[WINMM] Fix crashing winetest
CORE-16795
CORE-16806
2020-04-13 01:41:02 +02:00
Victor Perevertkin 58bc93f164
[BOOTDATA] Add FsType into default unattend.inf template 2020-04-12 17:23:17 +03:00
Hermès Bélusca-Maïto 9261110760
[CONSRV] Introduce a set of macros CON_API / CON_API_NOCONSOLE for wrapping around the repetitive prologue/epilogue of every console CSR API entrypoint.
All the per-API message structure unpacking and console validation done
with ConSrvGetConsole() is now automatically generated using the macros,
so that the actual implementation of each API can be done independently
of how the console object is obtained.

This could also allow reusing these API implementations with a different
mechanism for obtaining the console without changing anything in them.
2020-04-12 16:09:36 +02:00
Saibamen 7173a21f4a
[TRAVIS] Fix inconsistent git clone depth in CI 2020-04-12 16:36:07 +03:00
Andreas Maier ae0bc81a96 [PSDK] fix typedef PLSA_AP_CALL_PACKAGE_PASSTHROUGH (ntsecpkg.h) 2020-04-12 16:26:13 +03:00
Eric Kohl 4735cc2ab5 [TIMEDATE] Pervent running multiple NTP updates at once
- Run the NTP uptate from a separate thread
- Do not accept another update until the current one has finished

CORE-16835
2020-04-12 13:12:23 +02:00
James Tabor 7772f97241 [User32] Return Default Window Procedure for WM_DEVICECHANGE
See CORE-16492.
2020-04-11 17:58:38 -05:00
James Tabor 1e0bb66452 [User32] Implement Device Event Message handler
Need a way to send WM_DEVICECHANGE from the Service manager application.
Next step is to process it in the Client/Server Run-time Subsystem.
See CORE-16492.
2020-04-11 17:41:26 -05:00
Thomas Faber 152265729b
[ACPI] Properly return a single alternative in Bus_PDO_QueryResourceRequirements. CORE-12892 CORE-14688
In ACPI resource descriptors, alternatives are marked with
StartDependent tags. Only the last set is terminated with EndDependent.
Therefore, since we only return the first alternative list for now,
ignore the first StartDependent tag and terminate enumeration at the second.

In the future we will need to build the full set of alternative lists here,
which will also make the unit test succeed fully.

This should fix random resource conflicts and make COM ports usable.
2020-04-11 23:43:05 +02:00
Thomas Faber 28be285da5
[ACPI] Avoid unnecessary casts. 2020-04-11 23:43:05 +02:00
Thomas Faber 9bcd835074
[ACPI_APITEST] Add a unit test for Bus_PDO_QueryResourceRequirements. CORE-12892
This will allow us to verify fixes made to function, which is quite broken.
2020-04-11 23:42:59 +02:00
Hermès BÉLUSCA - MAÏTO deebc5848e
Remove the 'end_of_line' value. Addendum to 32db19f6 - PR #2528
According to https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#end_of_line
there is not yet any value to translate "use the native end-of-line" from the VCS.
So for the time being, let's follow the advice mentioned in the article:
> if you want to use native line endings between different operating systems it is better not to set this option and leave that task to the VCS.
2020-04-11 17:56:23 +02:00
Saibamen 32db19f68f
Create .editorconfig (#2528)
By Adam "Saibamen" Stachowicz.
2020-04-11 17:40:36 +02:00
Saibamen e4ff6a52f0
Simplify .gitignore (#2531)
By Adam "Saibamen" Stachowicz.
2020-04-11 17:40:16 +02:00
Hermès Bélusca-Maïto 75d0346c54
[CONSRV] Finally fix CONSOLE vs. CONSRV_CONSOLE/WINSRV_CONSOLE stuff. CORE-9496
What remains to be cleared up are the ugly casts.
2020-04-11 16:27:09 +02:00
Hermès Bélusca-Maïto a3ea0a39f1
[WIN32SS] Get rid of "consrv_new".
Any new features/architectural changes to the console will either be
done in separate branches, or incrementally in master within the
existing console module.
2020-04-11 15:37:27 +02:00