Commit graph

66286 commits

Author SHA1 Message Date
Sylvain Petreolle 445ae177c1 Get rosautotest from the web.
@aminekhaldi thanks for the idea.
ONLINE-567

svn path=/trunk/; revision=72234
2016-08-15 23:32:42 +00:00
Giannis Adamopoulos bed40f1d7e [EXPLORER]
- Implement resizing the taskbar in steps based on the way the rebar resizes. It works in windows (a bit buggy) and it would work in ros if our rebar could resize on demand.
- Let CStartButton handle the creation of the start button.

svn path=/trunk/; revision=72233
2016-08-15 20:53:12 +00:00
Christoph von Wittich d1686ea263 [ADVAPI32] add DECLSPEC_HOTPATCH to CreateProcessAsUser
svn path=/trunk/; revision=72231
2016-08-15 17:25:04 +00:00
Christoph von Wittich 3f62a5f7f8 [GDI32] sync GetICMProfileA to wine
svn path=/trunk/; revision=72230
2016-08-15 17:04:05 +00:00
Daniel Reimer 69a268849d Bye SHA1 @utorrent and bittorrent. Still no nice direct links for the broken ones found.
svn path=/trunk/; revision=72229
2016-08-15 15:02:07 +00:00
Amine Khaldi 450c7177af [CMAKE] Update baseaddress.cmake for the GCC build.
svn path=/trunk/; revision=72228
2016-08-15 11:56:47 +00:00
James Tabor fddaeea688 [Win32SS]
- Fix regression from 62529, striped all the MF_POPUP from the code, no way to know if the submenu is a drop menu. See CORE-9269.

svn path=/trunk/; revision=72227
2016-08-15 01:14:47 +00:00
Eric Kohl 12ea67644c [LSASRV]
Implement LsarEnumerateAccountsWithUserRight.

svn path=/trunk/; revision=72226
2016-08-14 20:37:35 +00:00
Hermès Bélusca-Maïto 13478a6cb0 [ROSTESTS]: Add an interactive test that tests some parts of the event log service.
CORE-11843 CORE-11838

svn path=/trunk/; revision=72225
2016-08-14 19:15:54 +00:00
Hermès Bélusca-Maïto e7ce655076 [ROSTESTS]: Update the code file header.
svn path=/trunk/; revision=72224
2016-08-14 19:12:30 +00:00
Hermès Bélusca-Maïto 2081c44ca0 [SDK:MC]: Ensure the EOL style of MC files is *always* CR-LF in *all* platforms.
svn path=/trunk/; revision=72223
2016-08-14 19:10:41 +00:00
Eric Kohl deec91b6c2 [LSASRV]
Add missing TRACE messages.

svn path=/trunk/; revision=72222
2016-08-14 16:16:40 +00:00
Giannis Adamopoulos 21f8a27469 [SHELL32]
- Fix a bug in CStartMenu_Constructor and add some comments to explain what this part does.

svn path=/trunk/; revision=72221
2016-08-14 16:15:02 +00:00
Eric Kohl 09e88a8e27 [LSASRV]
LsarQuerySecurityObject: Build a new SD that conatains requested information only and return it to the caller.

svn path=/trunk/; revision=72220
2016-08-14 15:42:40 +00:00
Eric Kohl e60fde9ccb [LSASRV]
Implement LsaIFree_LSAPR_CR_CIPHER_VALUE, LsaIFree_LSAPR_PRIVILEGE_ENUM_BUFFER and LsaIFree_LSAPR_REFERENCED_DOMAIN_LIST.

svn path=/trunk/; revision=72218
2016-08-14 10:26:23 +00:00
Eric Kohl 9426bb9c91 [SYSSETUP]
InstallPrivileges: 
- Use LsaAddAccountRights instead of LsaAddPrivilegesToAccount. This enables us to add privileges and user rights to a given account.
- Identify SIDs by a leading asterisk. Account names do not start with an asterisk.
defltws.inf:
- Add user rights.
- Add an asterisk before all SIDs.

svn path=/trunk/; revision=72217
2016-08-13 19:25:31 +00:00
Eric Kohl 7265f00e4e [LSASRV]
Implement LsaIFree_LSAPR_ACCOUNT_ENUM_BUFFER and fix a typo.

svn path=/trunk/; revision=72216
2016-08-13 17:15:04 +00:00
Eric Kohl 3890a9cf57 [LSASRV]
- LsapRegQueryKeyInfo: Return the maximum sub key name length too.
- LsarEnumerateAccounts: User the maximum sub key name length to allocate a large enough buffer instead of using a fixed size one.
- LsarAddAccountRights: Use the proper value size to retrieve the system access attribute.

svn path=/trunk/; revision=72215
2016-08-13 16:26:23 +00:00
Mark Jansen caa5c5b12d [CRT][CRT_APITEST] Fix __getmainargs and __wgetmainargs parsing, verified with apitests. Patch by Yaroslav Veremenko. CORE-11673 #resolve #comment Thanks!
svn path=/trunk/; revision=72214
2016-08-12 21:31:32 +00:00
Hermès Bélusca-Maïto f7cb5ca5c0 [EVENTLOG]
- Use NT functions to retrieve timestamps for events.
- Log kernel events with the current computer name.
- Don't hardcode variables types for sizeofs.
- Add type-checks for the data to be retrieved from the registry, and use default values in case the values do not exist or are invalid.
- Use ULONG_PTR to perform pointer arithmetics.
- Use string-safe functions for copy/concatenation.
- Cache EventLog source for eventlog service self-logging.
- Unlock the LogFile in LogfClearFile.
- Fix rounding in LogfAllocAndBuildNewRecord.
- Verify ELF handle validity in ElfrGetLogInformation.
- Implement IELF_HANDLE_rundown to correctly cleanup ELF handles when client apps shut down. Adapt also the parameter of ElfDeleteEventLogHandle for reusing it there.
- Update some code formatting.
CORE-11842 #resolve

I don't completely touch file.c as it contains most of my upcoming eventlog fixes...

svn path=/trunk/; revision=72213
2016-08-12 19:14:55 +00:00
Hermès Bélusca-Maïto 275590c74e [EVENTLOG]: Fix also ElfrChangeNotify here. Addendum to r72211. Must fix the build.
CORE-11839

svn path=/trunk/; revision=72212
2016-08-12 17:25:36 +00:00
Hermès Bélusca-Maïto 6fe74528cb [SDK:IDL]: Fix the event log RPC IDL file definitions:
- ElfrChangeNotify takes a IELF_HANDLE handle as its first parameter, not a pointer to it.
- Since we already use NT-like types (especially for USHORT variables), do the same for the other parameters (DWORD -> ULONG), and also use the Pxxx for pointers to xxx.
- Use Windows 2003 maximum size (0x3FFFF) for the event data to be written, instead of the Vista+ limit that is much smaller (0xF000). See also revisions r72207 and r72209.
CORE-11839 #resolve

svn path=/trunk/; revision=72211
2016-08-12 17:22:15 +00:00
Hermès Bélusca-Maïto 8402a33700 [SDK]: Move some event log flags to the correct header (from winbase.h to winnt.h).
CORE-11839

svn path=/trunk/; revision=72210
2016-08-12 14:24:55 +00:00
Hermès Bélusca-Maïto 0bdab15b0f [ADVAPI32_APITEST]: Addendum to r72207:
- Fix the tests so that they test what they have to test, on ReactOS & Windows 2k3/XP. (Note that here, ReactOS used the more restrained event size limitations of Vista+ compared to those of Win2k3. I choose to test, and will implement, the size limitations of Win2k3.)
- Choose a different name for the test such that it doesn't collide with the 'eventlog' test from advapi32_winetest.
CORE-11838 CORE-11839

svn path=/trunk/; revision=72209
2016-08-12 13:38:49 +00:00
Giannis Adamopoulos 43728d3f66 [SHELL32]
- Get rid of the functions that handle guid pidls and move their implementation in CRegFolder.cpp.

svn path=/trunk/; revision=72208
2016-08-12 12:21:13 +00:00
Hermès Bélusca-Maïto b3195b9538 [ADVAPI32_APITEST]: Add some supplemental tests for Winetests' Event Logging functions, testing different RPC limits related to the maximum size of the data buffer in events.
CORE-11838 CORE-11839

svn path=/trunk/; revision=72207
2016-08-12 12:15:24 +00:00
Giannis Adamopoulos 87bf08acdb [SHELL32]
- Move CFSDropTarget to its own file.

svn path=/trunk/; revision=72206
2016-08-12 11:35:24 +00:00
Daniel Reimer 65ed10be3f [RAPPS}
Fix structural errors, fix some dead links, fix wrong lang inclusions, fix trailing spaces etcetc
Some entries are dead, like nirlauncher, watercolor, tahoma and audacity. Feel free to fix em. (@holiday till monday now, cya)

svn path=/trunk/; revision=72205
2016-08-12 11:00:21 +00:00
James Tabor cbdab97572 [NtUser]
- Get the right shift to pass through the keyboard subsystem. (WIP)

svn path=/trunk/; revision=72204
2016-08-12 00:54:44 +00:00
James Tabor 018df975b6 [NtUser]
- Send Input Language Change System Character flag if font signature and system character is set.

svn path=/trunk/; revision=72203
2016-08-11 22:33:12 +00:00
James Tabor d3001862bf [NtUser]
- If focus window null use active.

svn path=/trunk/; revision=72202
2016-08-11 22:04:33 +00:00
James Tabor 5b2fac1964 [NtUser]
- Fix registry update when turning on/off keyboard layout hotkey and selecting. VK_RSHIFT (WIP).

svn path=/trunk/; revision=72201
2016-08-11 21:36:55 +00:00
Hermès Bélusca-Maïto 9a84ae8ab1 Remove extra ending semicolons in our C code base.
svn path=/trunk/; revision=72199
2016-08-11 16:50:41 +00:00
Pierre Schweitzer 24572de19c [MPR]
Import Wine commit:
- b452e6285915b1ad46920fc8551335ab28bfb4c0, Implement local name automatic redirection for disks.
- a65c31e46fa354fc8fbf86c0b9f273f86132a571, Implement provider selection given remote name.

CORE-11757

svn path=/trunk/; revision=72198
2016-08-11 16:29:36 +00:00
James Tabor 4afd025847 [NtUser]
- Fix up Language Layout Hotkey Toggle support for the new Keyboard switching. Support registry settings. Dedicated to Dmitry Chapyshev.
- The registry entry it reads from is the wrong (the short number) one. Someone with registry knowledge please help.
  Also VK_LSHIFT is passed all the time and not VK_RSHIFT (WIP). Support for Left Alt and Control work including SysParam.
- Side Tracks : Fixed CORE-5683. ReactOS can switch from keyboard processing or from DeferWindowProc.

svn path=/trunk/; revision=72197
2016-08-11 15:53:05 +00:00
Thomas Faber a93f0e73ff [FASTFAT]
- Fail invalid opens specifying FILE_DELETE_ON_CLOSE
CORE-6931

svn path=/trunk/; revision=72196
2016-08-11 13:25:57 +00:00
Thomas Faber 3b70374248 [FASTFAT]
- Cancel deletion of a directory if it is not empty when its last handle is closed
CORE-6931

svn path=/trunk/; revision=72195
2016-08-11 11:41:25 +00:00
James Tabor d2ae65c710 - Fix Desktop hang if no windows open.
svn path=/trunk/; revision=72194
2016-08-11 00:29:26 +00:00
Thomas Faber aed9207c96 [NTOS:FSRTL]
- Use the correct parent node when replacing an identical cache entry in FsRtlAddToTunnelCache
CORE-11819

svn path=/trunk/; revision=72193
2016-08-10 21:09:50 +00:00
Pierre Schweitzer 72eefb7a68 [KMTESTS:FSRTL]
Add a stress test for tunnel cache implementation, where we have fun adding duplicated entries.
It doesn't seem to go well.
These tests are also known as "Learn your English ordinals", or as "Learn how to count in English". My pleasure.

CORE-11819

svn path=/trunk/; revision=72192
2016-08-10 20:50:36 +00:00
Mark Jansen da6a705bb1 [ATL][ATL_APITEST] Partially implement CRegKey + add tests. CORE-11746
svn path=/trunk/; revision=72191
2016-08-10 19:34:38 +00:00
Dmitry Chapyshev ac58e0fdf6 [SDK]
- KLF_SHIFTLOCK is not equal 65535. Correct value is 0x00010000

svn path=/trunk/; revision=72190
2016-08-10 19:05:54 +00:00
Dmitry Chapyshev 4245233f5f [INPUT]
- Draw 0x2022 unicode symbol instead 0x25CF (marking default input method)
- Fix incorrect logic in CapsLock parameters
- Notice system of change CapsLock mode parameters

svn path=/trunk/; revision=72189
2016-08-10 19:04:11 +00:00
Giannis Adamopoulos 22c0bb2723 [SHELL32]
- Add CRegFolder using the guid item specific functions. So far it is only partly implemented with stuff like enumerating still missing.
- Use CRegFolder in CDesktopFolder, CDrivesFolder and CControlPanelFolder and stop using guid item specific functions.

svn path=/trunk/; revision=72188
2016-08-10 18:56:48 +00:00
Amine Khaldi 5645cda63f [SHIMLIB] Improve header inclusions.
svn path=/trunk/; revision=72187
2016-08-10 13:37:22 +00:00
Pierre Schweitzer e3b0a95319 [NTOSKRNL]
While attempting to read data from disk in CcReadVirtualAddress(), always align our read size by pages.
That means that even on boundaries, we will read a complete page.
This fixes FSD relying on Cc to properly align reads and thus poorly failing in disk.sys because of unaligned reads.
Notably, it helps MS FastFAT loading a bit farther in ReactOS (but it still fails :-().
This also fixes a few kmtests.

CORE-11003
CORE-11819

svn path=/trunk/; revision=72186
2016-08-10 11:52:30 +00:00
Hermès Bélusca-Maïto 57888376d9 [INPUT]
- Fix misspelling "Dublicate" -> "Duplicate".
- Use ZeroMemory instead of memset(..., 0, ...).
- Don't hardcode most of the variable types for sizeof.

svn path=/trunk/; revision=72185
2016-08-10 11:42:21 +00:00
Thomas Faber 079e405958 [TCPIP]
- Use pool tagging

svn path=/trunk/; revision=72184
2016-08-10 11:19:59 +00:00
Thomas Faber 0439f525d3 [IP]
- Only accept an incoming connection on one listening socket, not all. Fixes use after free when multiple connection endpoints are assigned the same PCB.
CORE-11649 #resolve

svn path=/trunk/; revision=72183
2016-08-10 10:28:28 +00:00
Pierre Schweitzer f27ecf0960 [KMTESTS:CC]
New test case which is matching the MS FastFAT CcCopyRead (minus the offset) and shows clearly the issue in our Cc.
It also shows that my hack is utterly broken :-).

CORE-11003
CORE-11819

svn path=/trunk/; revision=72182
2016-08-10 07:39:20 +00:00