Commit graph

66316 commits

Author SHA1 Message Date
Dmitry Chapyshev dea009126c [USER32]
- Add missing NULL-pointer checkes in rect functions
- Small coding-style fixes

svn path=/trunk/; revision=72052
2016-07-30 11:31:33 +00:00
Hermès Bélusca-Maïto 155818fc70 [PCIX]
Fix Device_SaveCurrentSettings: do not reference BarArray too soon if the index is out of bounds (in that case it means we are handling a ROM "BAR").
CID 716153, reported by Victor Martinez Calvo.
CORE-11215 #resolve

svn path=/trunk/; revision=72050
2016-07-29 13:44:37 +00:00
Hermès Bélusca-Maïto d35cbe1643 [XDK]
- Move the PCI_COMMON_HEADER_LAYOUT next to the structures that use it.
- Add IRP flags description comments.

svn path=/trunk/; revision=72049
2016-07-29 13:17:58 +00:00
Giannis Adamopoulos 80cd3d14ba Fix build.
svn path=/trunk/; revision=72048
2016-07-29 12:59:16 +00:00
Giannis Adamopoulos 4d9d28fbd3 [SHELL32]
- Factor CFSDropTarget out of CFSFolder.
- For now their code is mixed (no code was moved), until we decide where exactly is should be kept.

svn path=/trunk/; revision=72047
2016-07-29 12:56:06 +00:00
Robert Naumann a57e61507d [BROWSEUI] - explorerband: get the caption string from resource file instead of hardcoding it
svn path=/trunk/; revision=72046
2016-07-29 12:05:06 +00:00
Giannis Adamopoulos 5575b8bacc [SHELL32]
- CDefView: Add a missing error check.
CORE-11594

svn path=/trunk/; revision=72045
2016-07-29 12:03:20 +00:00
Pierre Schweitzer 80e79970b3 [EXT2]
Reduce driver verbosity

svn path=/trunk/; revision=72044
2016-07-29 11:54:08 +00:00
Giannis Adamopoulos 0aed20a50c [BROWSEUI]
- CExplorerBand: TranslateAcceleratorIO should return S_FALSE when it doesn't process the message in order to let other components process it.
CORE-11709

svn path=/trunk/; revision=72043
2016-07-29 10:38:22 +00:00
Pierre Schweitzer b5746c9e6b [EXT2]
Upgrade the driver to release 0.68.

CORE-11714

svn path=/trunk/; revision=72042
2016-07-29 10:29:16 +00:00
Giannis Adamopoulos 45aa3e9f88 [SHELLL32]
- Split GenericExtractIcon_CreateInstance into CGuidItemExtractIcon_CreateInstance, CFSExtractIcon_CreateInstance and CDrivesExtractIcon_CreateInstance.

svn path=/trunk/; revision=72041
2016-07-29 06:21:11 +00:00
Sylvain Petreolle 4bbb7474b4 [INF]
Add data for generic container devices.

svn path=/trunk/; revision=72036
2016-07-28 17:12:31 +00:00
Thomas Faber ba1b985215 [SHELL32_APITEST]
- Add a test for CShellLink::GetDescription/SetDescription
CORE-5272

svn path=/trunk/; revision=72035
2016-07-28 15:25:35 +00:00
Christoph von Wittich ad14fb5ef9 [SHELL32] apply similar fixes to SetWorkingDirectory, SetArguments, SetIconLocation and SetRelativePath
svn path=/trunk/; revision=72034
2016-07-28 15:24:44 +00:00
Christoph von Wittich de1219eb52 [SHELL32]check for NULL pointer in CShellLink::SetDescription. patch by Joachim Henze. fixes Opera 12 installer CORE-5272
svn path=/trunk/; revision=72033
2016-07-28 15:12:23 +00:00
Robert Naumann 372d5c10c4 [HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655
svn path=/trunk/; revision=72032
2016-07-28 13:27:33 +00:00
Pierre Schweitzer 98136578cf [DOC]
Mark BTRFS as synced

svn path=/trunk/; revision=72031
2016-07-28 07:39:37 +00:00
Hermès Bélusca-Maïto 172e136024 [CONSRV]
- Do not hardcode the values of some flags used with GetKeyState.
- Rework a bit the 'OnScroll' function.
- Implement mouse scrolling the console.
CORE-9900 #resolve
CORE-8394
- In mouse selection mode, allow the user to enlarge the current selection area by pressing the SHIFT key together with clicking on some point.

svn path=/trunk/; revision=72030
2016-07-27 23:30:53 +00:00
Amine Khaldi cb11c8aa56 [SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need to mention it in every single build.
svn path=/trunk/; revision=72028
2016-07-27 21:38:56 +00:00
Giannis Adamopoulos 21c051f4ff [SHELL32]
- Query the drop effect from the key state. After latest wine sync we correctly get all possible effects instead of the effect of the last DragOver event.
CORE-11681

svn path=/trunk/; revision=72026
2016-07-27 20:51:36 +00:00
Pierre Schweitzer b139d1b07b [BTRFS]
Import three fixes from my local GitHub repository:
- Don't attempt to remove Vcb from list twice on shutdown
- Properly add CCB to root_file
- Init cache for root_file so that cache uninit on shutdown isn't problematic

This fixes BTRFS in ReactOS.
These fixes have already been submitted upstream (https://github.com/maharmstone/btrfs/pull/23).

CORE-11674

svn path=/trunk/; revision=72024
2016-07-27 19:32:05 +00:00
Pierre Schweitzer 7695f39c11 [BTRFS]
Sync btrfs to 0.5.
This breaks BTRFS in ReactOS.

CORE-11674

svn path=/trunk/; revision=72023
2016-07-27 19:24:26 +00:00
Hermès Bélusca-Maïto 8c418c8bdb [SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local differences wrt. the synced Wine code. Per Amine request.
ROSTESTS_234

svn path=/trunk/; revision=72022
2016-07-27 19:17:35 +00:00
Hermès Bélusca-Maïto 9bd7b2e1f0 [SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out unexpectedly. We don't lose functionality wrt. what we had before r72008 (or with what Wine currently has).
CORE-11689

svn path=/trunk/; revision=72021
2016-07-27 19:12:35 +00:00
Hermès Bélusca-Maïto 1044e92a20 [SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable" test path.
ROSTESTS-234

svn path=/trunk/; revision=72020
2016-07-27 19:05:52 +00:00
Pierre Schweitzer 9c749a7606 [KMTESTS]
Add missing dependency

svn path=/trunk/; revision=72019
2016-07-27 16:40:30 +00:00
Thomas Faber cb6e26b3db [NTOS:PO]
- Send power IRPs to the top of the device stack instead of the PDO
CORE-10110 #resolve

svn path=/trunk/; revision=72017
2016-07-27 11:15:52 +00:00
Hermès Bélusca-Maïto 7bd6365632 [SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging 1.9.15.
(Add also the patch "Add patch to support IDF_CHECKFIRST in SetupPromptForDisk." by DarkPlayer - 541cc8d08661980dfe80fe2bb9dd27c91879e09f)

svn path=/trunk/; revision=72009
2016-07-27 00:48:41 +00:00
Hermès Bélusca-Maïto 86ff038c51 [SETUPAPI]
- Transform the cached OsVersionInfo structure into a OSVERSIONINFOEXW that is then reused in SetupDiGetActualSectionToInstallExW.
- Remove few unused hardcoded strings.
- Add two TRACEs in SetupDiGetActualSectionToInstallExW to debug diverse INF file installation problems.
- parser.c: enclose the contents of the for-loop inside braces.
- Implement pSetupSetGlobalFlags and pSetupModifyGlobalFlags, see https://msdn.microsoft.com/en-us/library/bb432397(v=vs.85).aspx
- Popup an error message box in InstallHinfSectionW if an error happened and if interactive setup is allowed (through the global setup flags).

svn path=/trunk/; revision=72008
2016-07-27 00:10:14 +00:00
Hermès Bélusca-Maïto 79ce70c1dd [NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously initialized.
CORE-10182 #resolve

svn path=/trunk/; revision=72007
2016-07-26 19:57:40 +00:00
Hermès Bélusca-Maïto ad81a85370 [INF]: Use the correct icon for audio controller devices in the device manager. By Jared Smudde.
CORE-11679 #resolve #comment Committed, thanks!

svn path=/trunk/; revision=72006
2016-07-26 19:09:18 +00:00
Giannis Adamopoulos 37a1045d72 [BROWSEUI]
- CExplorerBand: Implement showing the context menu on right click.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72004
2016-07-26 15:09:04 +00:00
Giannis Adamopoulos 0c47416f5d [BROWSEUI]
- CExplorerBand: Expand the tree view to the current folder when a new folder is browser (either with the addressbar or by double clicking a folder).
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72003
2016-07-26 14:31:38 +00:00
Pierre Schweitzer 4e4861b392 [NTOSKRNL_VISTA]
Implement KeQueryActiveProcessorCount().

CORE-11674

svn path=/trunk/; revision=72001
2016-07-25 20:45:48 +00:00
Hermès Bélusca-Maïto b79e7d2eee [MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification by myself):
 Don't return TRUE when CB_SETITEMDATA fails.
 Avoid pScheme NULL dereference if allocation fails. CID 1223154
 Avoid overflowing the destiny buffer by using StringCchCopy() CID 510953
and:
1) Make it more readable by returning as soon as possible when an error happens.
2) Make it more readable by reducing the nested ifs-checks.
3) Remove the added string in the combobox if the sound scheme buffer mem allocation fails (pt.3 modified).
CORE-11603 #resolve #comment Thanks!

svn path=/trunk/; revision=72000
2016-07-25 20:24:30 +00:00
Thomas Faber 42abc25acc [TOOLS]
- Fix MSVC 2013+ build. Patch by Victor Matovykh.
CORE-11575 #resolve

svn path=/trunk/; revision=71998
2016-07-25 19:28:40 +00:00
Thomas Faber 4d367e4fd3 [SHELL32]
- Add missing dependency

svn path=/trunk/; revision=71997
2016-07-25 19:25:46 +00:00
Christoph von Wittich 359533fc32 [ADVAPI32] silence debug spam
svn path=/trunk/; revision=71995
2016-07-25 11:07:44 +00:00
Thomas Faber d84820daa7 [WIN32K:NTUSER]
- Fix UserDrawCaptionBar debug spam

svn path=/trunk/; revision=71994
2016-07-25 10:45:30 +00:00
Thomas Faber 5203dd99be [NTOS:CC]
- Unconditionally acquire the VACB lock during map/pin/unpin operations and release it appropriately
CORE-11555 #resolve
CORE-11654 CORE-11504 CORE-11328 #comment This might be fixed with r71993. Could you retry please?

svn path=/trunk/; revision=71993
2016-07-25 08:48:50 +00:00
Aleksandar Andrejevic 45fe0d3a21 [NTVDM]
Implement the VGA AC Color Select register.
Implement INT 0x10, AH = 0x10, subfunction AL = 0x13.


svn path=/trunk/; revision=71992
2016-07-24 18:25:50 +00:00
Thomas Faber 2a6c4f1119 [NTOS:CC]
- Centralize VACB locking/unlocking into inline functions for easier instrumentation

svn path=/trunk/; revision=71991
2016-07-24 17:10:30 +00:00
Aleksandar Andrejevic 7c0554a53f [NTVDM]
Always reset the AC latch before writing to the AC index register.
CORE-11669 #resolve #comment Should be fixed in revision r71990.


svn path=/trunk/; revision=71990
2016-07-24 15:45:50 +00:00
Hermès Bélusca-Maïto 493ec0db98 [EVENTVWR]
- Use helper functions for doing the filtering on the events (idea by Mark Jansen).
- Fix the states of menu items, depending on which event log/item (log file/filter; event item...) is currently selected.
- Correctly empty the event items list & cache whenever an event log/filter is closed (and avoid a crash when all logs/filters are closed and someone attempts to open an event item), during concurrent accesses. I use a reference count and AddRef/Release helpers.
- Get rid of the annoying log loading popup, and use instead the loading message displayed in the events listview as well as a progress-bar in the status bar.
CORE-11637

svn path=/trunk/; revision=71989
2016-07-24 15:24:50 +00:00
Amine Khaldi 0fb5509517 [GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521
svn path=/trunk/; revision=71986
2016-07-23 21:33:40 +00:00
Mark Jansen 517ee59e43 [CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
As suggested by Thomas :)

svn path=/trunk/; revision=71985
2016-07-23 20:35:11 +00:00
Pierre Schweitzer 0ee9e9b016 [MPR]
Provide ReactOS specific implementation for WNetGetConnection(), we cannot use Wine's due to Wine specific MountMgr calls.

svn path=/trunk/; revision=71984
2016-07-23 19:52:23 +00:00
Christoph von Wittich 1ce557f97e [SHELL32] close hKey in error case
svn path=/trunk/; revision=71983
2016-07-23 19:39:16 +00:00
Thomas Faber 43ed362610 [NTOS:IO]
- Avoid infinite loop in IopMountVolume. Brought to you by Vadim Galyant.
CORE-11663 #resolve

svn path=/trunk/; revision=71982
2016-07-23 18:18:11 +00:00
Mark Jansen 98de7f1bae [SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE-10439
svn path=/trunk/; revision=71981
2016-07-23 13:15:19 +00:00