Commit graph

1362 commits

Author SHA1 Message Date
Joachim Henze 3803e58bb5 [0.4.13][WINHTTP] Fix regression CORE-13952
Fixes symptom
"Adobe Flash player online setup fails downloading itself"

by porting back
0.4.14-dev-560-g
5bd6580fc6
and 0.4.14-dev-716-g
4bf76a659e
and additionally updating README.WINE

Testbots LGTM:
https://reactos.org/testman/compare.php?ids=70898,71103 VBox
https://reactos.org/testman/compare.php?ids=70899,71104 KVM

Thanks to Matthias Basler, Amine Khaldi, Victor Perevertkin.

recent ros releases that were affected by this bug:
0.4.7, 0.4.8, 0.4.12

recent ros releases that were NOT affected by this bug:
- 0.4.6, 0.4.9, 0.4.10, 0.4.11 (thanks to revert)
- 0.4.13, and presumably 0.4.14 (thanks to the proper fix)
2020-01-09 02:39:03 +01:00
Joachim Henze baa9a3e611 [0.4.13][APISETS][KERNEL32] Appease regression CORE-16563
Symptom "Far Manager 3.0 Build 5200 can not load NetBox.dll"
due to uncaught exception when accessing GetSystemTimePreciseAsFileTime().

The symptom started to show with 0.4.13-dev-986-g
029b8f2cf9
as LDR exposes more Vista+ stuff since then.

The fix is a selective backmerge of master PR-1963
2019-12-25 16:24:55 +01:00
Mark Jansen 7896d3d4ec [0.4.13][URLMON] Delay-load advpack
I doubt it helps for CORE-5007 (as it was stated in master),
that ticket most likely got fixed beforehand already.

But I already tested: Delay-loading fixes CORE-15795,
which was unhidden by 0.4.12-dev-632-g
d93e516747

The fix by delay loading was cherry picked from commit
0.4.14-dev-475-g
82b758974f

It's not just a workaround, Windows delay-loads like that as well.
Thomas believes this specific delay-load will not trigger
the LD bug CORE-6504 within our gcc toolchain.

Thanks for help of Mark Jansen, Thomas Faber and Fabian Maurer.
2019-11-30 00:55:08 +01:00
Joachim Henze ec663c87f0 [0.4.13][COMCTL32] Fix listview scrollbars flashing CORE-16466
Many Thanks to patches author JIRA user 'I_Kill_Bugs',
but also to Doug Lyons and Fabian Maurer.

Unhidden by SVN r75735 == git 0.4.7-dev-168-g
6af37fd54e

cherry-picked from 0.4.14-dev-312-g
b931f643e3
2019-11-13 00:59:13 +01:00
Joachim Henze e5018461c1 [0.4.13][COMCTL32] Address regression CORE-14622
"Avira Antivir Personal 6.35.00.243" had issues painting its
setup wizard dialog with correct background color.
That part was a regression of SVN r74136 == git
b1b42795a9

and also did not draw its umbrella bmp, which did never work
in ros up to now afaik.

https://reactos.org/testman/compare.php?ids=69394,69478 VBOX
https://reactos.org/testman/compare.php?ids=69395,69479 KVM

Thanks to patches author Doug Lyons and HBelusca.

Wine has been reported to be affected by that bug as well:
https://bugs.winehq.org/show_bug.cgi?id=46636
Not sure whether our patch will be accepted by Wine,
to my naive eye this looks like an interim solution.

cherry picked from commit 0.4.14-dev-107-g
f2f833c53c
2019-10-22 01:48:57 +02:00
Joachim Henze 45dbb08422 [0.4.13] Revert "[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF"
To avoid CORE-15804 MSTSC fails to connect with error "ERROR: Bad packet header"

This reverts commit 0.4.12-dev-752-g
6bc61f63f1.

like last release
2019-10-15 01:49:07 +02:00
Joachim Henze e2e90230d1 [0.4.13][BROWSEUI][SHELLFIND] Allow to 'Open Containing Folder' CORE-16391
of a search result again.

The feature regressed by 0.4.13-dev-1133-g
a3ee648d8b

I chose the shorter solution of Brock Mammen instead
of the patch of Doug Lyons from PR1960.

Still many thanks to Doug Lyons for his encouragement
in creating a fix as well and performing
regression-testing.

cherry picked from commit 0.4.14-dev-39-g
cd2a274ef7
2019-10-12 16:50:56 +02:00
Doug Lyons 44202f0749 [0.4.13][BROWSEUI][SHELLFIND] Make Search Item general and Show Sub-directories (#1927)
Shell Find Improvement to make Search Item general by adding asterisks
before and after before search and show sub-directories in find listing. CORE-16152

cherry picked from commit 0.4.14-dev-9-g
b6b7bda443
2019-10-12 16:48:55 +02:00
Joachim Henze 67211fa366 [0.4.13][COMCTL32] Appease regression CORE-14671 & CORE-14701
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).

Thanks to patches author Doug Lyons.

The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.

Like in last releases.
2019-10-04 20:27:14 +02:00
Thomas Faber a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403
Fixes one of many crashes in shell32_winetest:shlfolder.
2019-09-29 12:42:26 +02:00
Thomas Faber be1f95527a
[SHELL] IPersistIDList/IShellLink use P(C)IDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:39 +02:00
Thomas Faber b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:02 +02:00
Thomas Faber 6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385
Addendum to c2b476bd77.
2019-09-29 12:07:43 +02:00
Shy Zedaka acaff47682 [BROWSEUI][SHELL32][TRANSLATION] Major Translations to BROWSEUI And New Search function to Hebrew, and Some Other changes. (#1938) 2019-09-26 22:18:59 +02:00
Lee Schroeder 43f03da358 [MSXML3R] XML/XSL file description localization (#1926)
Add localization for the file description of both XML and XSL file formats.
Please check for copypasta errors!

CORE-16390

Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
2019-09-23 23:30:53 +02:00
Abdulganiev Rafael 9dd71e12b9 [TRANSLATION] Russian translation for browseui (#1928)
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
2019-09-23 23:28:46 +02:00
Joachim Henze a40331b0f4 [COMCTL32] Workaround v6 button redraw regressions CORE-13278 & CORE-16093
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147

But greatly eliminates perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We suffered from these regressions for years and nobody did
find a proper solution, therefore it's time to at least workaround them.
The patch did not expose any new real-world-issues after I retested
the whole rapps suite against it in 0.4.12RCs.

I committed the same workaround already into 0.4.12-RC-30-g
9513c9bf12

CORE-13278 was once introduced/unhidden by SVN 73806 ==
c607de714c

CORE-16093 was once introduced/unhidden by SVN 74149 ==
301c476074
2019-09-22 21:17:10 +02:00
Joachim Henze b7f62b9bf9 [BROWSEUI] RC de-DE of Search feature & Folderoptions caption CORE-16392 2019-09-22 19:11:39 +02:00
Thomas Faber c2b476bd77
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385 2019-09-22 16:19:11 +02:00
Thomas Faber b90c24d640
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385 2019-09-22 16:19:09 +02:00
Thomas Faber d41c5be3bd
[BROWSEUI] Fix a PIDL leak. 2019-09-22 11:42:06 +02:00
Thomas Faber cfc5b3749f
[SHLWAPI] Import Wine commit c8175e6c7a7 (Fix Stat() method for file streams) by Nikolay Sivov.
Fixes crash in shlwapi_winetest:istream.
2019-09-22 11:42:01 +02:00
Thomas Faber faae7e5790
[SHELL32] Handle BYREF variants in CFolderItems::Item.
Fixes crash in shell32_winetest:shelldispatch.

See also:
6634b31520
2019-09-22 11:41:57 +02:00
Hermès Bélusca-Maïto 7fccd6b763
[UBTRFS] Addendum to 255ef2c3: Add missing exports expected by mkbtrfs.
CORE-16383 CORE-16354
2019-09-21 04:35:01 +02:00
Adam Słaboń c81af08f51 [TRANSLATION] Polish translation update (#1916)
Added translation for netstat, utilman and netplwiz. Updated translation of find, reg, rapps, regedit, sndvol32, usetup, hivesys, mmsys, openglcfg, powercfg, sysdm, shellext, browseui, devmgr, msgina, netcfgx, shell32, syssetup, shortcuts and vcdcontroltool.
2019-09-20 21:51:47 +02:00
Joachim Henze 841732e45c [COMCTL32] Updown Suppress the NM_RELEASEDCAPTURE notification CORE-14365
This fixes a strange toggle-back-effect in 'Zeckensacks Glide Wrapper 0.84c'
by importing Wine commit
9dbe886e3f
Thanks to patches author Akihiro Sagawa <sagawa.aki@gmail.com>
2019-09-20 20:13:09 +02:00
Pierre Schweitzer 86c94e7858
[BROWSEUI] Translate search function into French
CORE-9279
2019-09-17 23:06:34 +02:00
Eric Kohl a66c7d2ecc [LSA][SECUR32] Check for untrusted clients
Calls  to LsapCallAuthenticationPackage are routed to LsaApCallPackageUntrusted instead of LsaApCallPackage for  untrusted clients.
2019-09-17 12:58:11 +02:00
Eric Kohl ba43d1e839 [MSV1_0] Implement LsaApCallPackageUntrusted()
An untrusted client is only allowed to change passwords
2019-09-17 12:46:49 +02:00
Brock Mammen 9b75b67e9d [SHELLFIND] Use IS_INTRESOURCE() 2019-09-15 19:46:36 +03:00
Brock Mammen 8da23e7eb9 [SHELLFIND] Add missing dependency to CMakeLists.txt 2019-09-15 19:46:36 +03:00
Brock Mammen 80f67b1111 [BROWSEUI] Add search strings to all language resources 2019-09-15 19:46:36 +03:00
Brock Mammen e32b88be3d [BROWSEUI] Add search dialog to all language resources 2019-09-15 19:46:36 +03:00
Brock Mammen 0311544bb3 [SHELLFIND] Fix return values 2019-09-15 19:46:36 +03:00
Brock Mammen b766576487 [SHELLFIND] Remove unused COM interfaces 2019-09-15 19:46:36 +03:00
Brock Mammen 8228844241 [SHELLFIND] Remove unused functions 2019-09-15 19:46:36 +03:00
Brock Mammen 12451dc172 [SHELLFIND] Change parameter from array reference to pointer 2019-09-15 19:46:36 +03:00
Brock Mammen 7ac9fd9f51 [SHELLFIND] Remove unnecessary cast 2019-09-15 19:46:36 +03:00
Brock Mammen 0eee3ed368 [SHELLFIND] Remove redundant check 2019-09-15 19:46:36 +03:00
Brock Mammen 2513c47452 [SHELLFIND] Fix unsafe cast 2019-09-15 19:46:36 +03:00
Brock Mammen fbdc08dceb [SHELLFIND] Use CoTaskMemAlloc instead of SHAlloc 2019-09-15 19:46:36 +03:00
Brock Mammen d0171027e0 [SHELLFIND] Fix IImageList leak 2019-09-15 19:46:36 +03:00
Brock Mammen a3ee648d8b [SHELLFIND] Simplify PIDLs to paths 2019-09-15 19:46:36 +03:00
Brock Mammen 0f995d77d1 [SHELLFIND] Remove search results folder from address edit box 2019-09-15 19:46:36 +03:00
Brock Mammen e6a5821e0c [SHELLFIND] Subscribe to folders that are already opened 2019-09-15 19:46:36 +03:00
Brock Mammen 07d37180a1 [SHELLFIND] Open search bar when search results folder is opened 2019-09-15 19:46:36 +03:00
Brock Mammen 312b628fe1 [SHELLFIND] Remove dependency on internal shell32 functions 2019-09-15 19:46:36 +03:00
Brock Mammen 6c6fd6d989 [SHELLFIND] Localize column names 2019-09-15 19:46:36 +03:00
Brock Mammen 641988a386 [SHELLFIND] Rename data members 2019-09-15 19:46:36 +03:00
Brock Mammen fe5c76a034 [SHELLFIND] Fix handle leak for stop event 2019-09-15 19:46:36 +03:00