Commit graph

65637 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 1e2e730dd3 [PROGMAN]
- Load the main icon in a global variable (we use it at different places).
- Use the main icon for the shell-about dialog.

svn path=/trunk/; revision=71325
2016-05-12 19:54:53 +00:00
Hermès Bélusca-Maïto 021e1a40a4 [PROGMAN]: Use a ListView to list program items. On systems that support it (aka. Vista+), enable ListView theming.
svn path=/trunk/; revision=71324
2016-05-12 19:45:26 +00:00
Amine Khaldi 80d2a73871 [PROGMAN] Fix PCH build.
svn path=/trunk/; revision=71322
2016-05-12 16:32:35 +00:00
Eric Kohl 1732ee52e0 [USETUP]
Pressing F3-Enter during setup behaves wrong sometimes.
Patch by Wim Hueskes.
CORE-11231 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71321
2016-05-12 16:18:32 +00:00
Eric Kohl ade016e3a4 [USETUP]
Debug output in usetup.
Patch by Wim Hueskes.
CORE-11230 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71320
2016-05-12 15:30:49 +00:00
Eric Kohl beacbdfc3b [TELNET]
Updating Turkish Translation.
Patch by Erdem Ersoy.
CORE-11226 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71319
2016-05-12 14:44:25 +00:00
Thomas Faber 297eae47ed [EXPLORER]
- Avoid activating windows when updating their size and position
CORE-11217

svn path=/trunk/; revision=71318
2016-05-12 12:14:42 +00:00
Hermès Bélusca-Maïto 6df01a9cb0 [PROGMAN]: Commit 90% of the work I did on progman since its first inclusion in ReactOS: this concerns upgrading its user interface code from Wine's Win3.11-compatible code to WinNT-compatible code.
As this is *recovered* code from what I had in my local trunk before my HDD crash that occurred last month, this is almost pure code without most of the comments (this especially concerns the MAIN_LoadSettings function).
The 10% code that is not restored yet concerns the reader/writer code for program group files, and it will be committed separately later. This (missing) code is the core of progman; without it progrman does nothing interesting apart from displaying its main window (and its utility dialogs).

svn path=/trunk/; revision=71317
2016-05-11 22:21:53 +00:00
Thomas Faber bae547dcec [I8042PRT]
- Don't access device control IRPs after handing them off to a worker routine that has potentially already freed them.
CORE-11229 #resolve

svn path=/trunk/; revision=71316
2016-05-11 12:30:12 +00:00
Pierre Schweitzer cfe81c2bb8 [BTRFS]
Cherry pick d71baf195715601212a2043f153400a964da6a18: Don't remove an entry list twice in add_to_space_list()

This avoids linked list entry twice removal

CORE-11057

svn path=/trunk/; revision=71315
2016-05-10 21:08:50 +00:00
Pierre Schweitzer e1036d5ff1 [BTRFS]
Cherry pick aa04ca0ea4cadb0c70ff6d659916cc98b7b02c27: uninit: don't free roots before FCBs are freed

This avoids use-after-free on shutdown

svn path=/trunk/; revision=71314
2016-05-10 21:07:56 +00:00
Robert Naumann ece9acc307 [SHELL32] Improve a list view header. Patch by Jared Smudde. CORE-11151
svn path=/trunk/; revision=71313
2016-05-10 20:48:39 +00:00
Mark Jansen 4a7af46cee [APPHELP] Remove imagehlp.dll dependency. CORE-10367
svn path=/trunk/; revision=71312
2016-05-10 20:42:37 +00:00
Thomas Faber 67c8423d4f [FASTFAT]
- Fix a use after free in VfatFlushVolume
CORE-11224 #resolve

svn path=/trunk/; revision=71311
2016-05-10 18:29:06 +00:00
Mark Jansen 64f0b43852 [UNIATA] Fix uninitialized variable usage. Patch by 'Alter'. CORE-11157 #resolve #comment Thanks!
svn path=/trunk/; revision=71309
2016-05-10 18:15:35 +00:00
Thomas Faber bc4d7ba184 [IPHLPAPI]
- Don't use uninitialized values in AllocateAndGet*TableFromStack functions. CID 716757
- Free buffers on failure
CORE-11227 #resolve

svn path=/trunk/; revision=71308
2016-05-10 17:53:36 +00:00
Thomas Faber ba1fac2999 [HAL]
- Create a wrapper version of HalpEndSoftwareInterrupt that frees its stack before calling the noreturn version of the next software interrupt handler. Fixes excessive stack usage when DPCs are queued in quick succession.
CORE-11123 #resolve

svn path=/trunk/; revision=71307
2016-05-10 15:03:56 +00:00
Thomas Faber 418ef674ed [IPHLPAPI]
- Fix memory leaks in getInterfaceInfoSet (CIDs 716370 and 716371)
- Fix a benign uninitialized variable use (CID 500783)
CORE-11224 #resolve

svn path=/trunk/; revision=71306
2016-05-10 13:59:41 +00:00
Thomas Faber f40cfb8b12 [IPHLPAPI]
- Tabs to spaces. No code changes.

svn path=/trunk/; revision=71305
2016-05-10 13:42:57 +00:00
Thomas Faber 1ebef466b4 [NTOS:MM]
- Keep track of physical pages allocated for special pool, and respect the initially calculated MiSpecialPagesNonPagedMaximum

svn path=/trunk/; revision=71304
2016-05-10 11:47:05 +00:00
Hermès Bélusca-Maïto bbc880b695 [CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched by Victor Martinez Calvo Should fix CID 1322302 "Fix an use after free".
Please reanalyze with Coverity :)
CORE-11179

svn path=/trunk/; revision=71303
2016-05-09 22:06:27 +00:00
Sylvain Petreolle 2a4dd63e17 [TEST]
svn path=/trunk/; revision=71302
2016-05-09 20:57:35 +00:00
Thomas Faber 80c690a270 [USBHUB]
- Fix memory leak in failure case of CreateDeviceIds. Patch by Víctor Martínez Calvo. CID 1102364
CORE-11208 #resolve

svn path=/trunk/; revision=71301
2016-05-09 17:44:16 +00:00
Eric Kohl 6645a97ddb [SHELL32]
Improvements to the file types property page:
- Always show the selected file type.
- Set the focus to the listview control when the file types page gets activated.
- Enable/disable the Delete button for the initial file type selection too.

svn path=/trunk/; revision=71300
2016-05-09 15:11:25 +00:00
Eric Kohl 44a2d2b8b6 [NETAPI32]
Prevent dereferencing null-pointers.

svn path=/trunk/; revision=71299
2016-05-09 10:26:55 +00:00
Thomas Faber 9f70db7773 [BTRFS]
- Fix warnings

svn path=/trunk/; revision=71298
2016-05-09 09:10:13 +00:00
Thomas Faber c2cc2ba3be [NTOS:SE]
- In SepPropagateAcl, gracefully handle unknown ACE types by simply copying them.
CORE-10694 #resolve

svn path=/trunk/; revision=71296
2016-05-09 08:49:18 +00:00
Thomas Faber d9217570cb [SHELL32]
- Fix uninitialized return value in _SHGetDefaultValue. CID 1322231
CORE-11213 #resolve

svn path=/trunk/; revision=71295
2016-05-09 08:12:00 +00:00
Christoph von Wittich 8a8de70eb2 ZeroMemory expects buffer size in bytes
svn path=/trunk/; revision=71294
2016-05-09 08:01:49 +00:00
Thomas Faber 7fb10cb4d0 [WS2_32_NEW]
- Use the correct size of ServiceBuffer in getnameinfo. Patch by Víctor Martínez Calvo. CID 716150
CORE-11214 #resolve

svn path=/trunk/; revision=71293
2016-05-09 07:49:58 +00:00
Thomas Faber 274daad96e [WS2_32_NEW]
- Add missing null termination for the line buffer in GetProtoGetNextEnt. Patch by Víctor Martínez Calvo. CID 716700
CORE-11218 #resolve

svn path=/trunk/; revision=71292
2016-05-09 07:34:46 +00:00
Thomas Faber 7c3631a94b [SHELL32]
- Fix check for GCS_VALIDATE in CDefaultContextMenu::GetCommandString. Patch by Jared Smudde.
CORE-11183

svn path=/trunk/; revision=71291
2016-05-09 07:22:59 +00:00
Mark Jansen d923444b3c [APPHELP] Addendum to r71226, fix some failing testcases of SdbGetFileAttributes + make it more robust. CORE-10367
- Work around a ROS bug (CORE-11206) by doing some better bounds checking.
- Silence a VAD warning by checking for NULL instead of blindly passing mem to NtUnmapViewOfSection
- Rewrite module type lookup code to use an enum and to return the found header.

svn path=/trunk/; revision=71290
2016-05-08 20:43:59 +00:00
Mark Jansen 0f8226d756 [NTDLL_APITEST] Show that NtMapViewOfSection does not properly NULL out the remainder of the mapped memory. CORE-11206
svn path=/trunk/; revision=71289
2016-05-08 17:01:15 +00:00
Sylvain Petreolle da19f382ab Add the AHK tests as an optional module.
ONLINE-567

svn path=/trunk/; revision=71288
2016-05-08 15:01:46 +00:00
Hermès Bélusca-Maïto c716950d97 [KSFILTER]: We may need to check the result of KspScanBus call here. To see whether we need to do that, add an assert. If hit then we know KspScanBus can fail and some proper failure code will be needed.
svn path=/trunk/; revision=71287
2016-05-08 14:53:14 +00:00
Hermès Bélusca-Maïto 2171daa6f5 [KSFILTER]: Return from KsCreateBusEnumObject() when scanning the bus fails. By Victor Martinez Calvo.
CID 1322294
CORE-11201 #resolve

svn path=/trunk/; revision=71286
2016-05-08 14:35:50 +00:00
Hermès Bélusca-Maïto 81ed2a4ade [BOOTLIB]: Fix EtfspGetDirentNameLength loops. By Victor Martinez Calvo.
CID 1341138
CORE-11178 #resolve

svn path=/trunk/; revision=71285
2016-05-08 14:28:06 +00:00
Hermès Bélusca-Maïto ea332e56c0 [USETUP]: Fix typo in SectorCount.QuadPart calculation (and add ULONGLONG casts).
By Victor Martinez Calvo.
CORE-11205 #resolve

svn path=/trunk/; revision=71284
2016-05-08 13:50:38 +00:00
Hermès Bélusca-Maïto dcf5329778 [TELNET]: Move around the resource files, in order to add the ability to localize telnet.
By Robert Naumann.
CORE-10717 #resolve #comment Thanks!

svn path=/trunk/; revision=71283
2016-05-08 13:46:16 +00:00
Hermès Bélusca-Maïto a2812af07f [TELNET]: Correctly show the icon.
By Henry Tang Ih and Robert Naumann.
CORE-10717

svn path=/trunk/; revision=71282
2016-05-08 13:37:18 +00:00
Thomas Faber 6b172f26a4 [RTL]
- In RtlpGrowBlockInPlace, copy the heap block's user value if the old block has the HEAP_ENTRY_EXTRA_PRESENT flag, instead of looking at the flags of the following block (where this will never be set).
CORE-11196 #resolve

svn path=/trunk/; revision=71279
2016-05-08 08:07:11 +00:00
Thomas Faber 0f3e91c5f7 [NTDLL_APITEST]
- Add a test for heap user values and flags when using RtlReAllocateHeap in-place
CORE-11196

svn path=/trunk/; revision=71278
2016-05-08 08:03:50 +00:00
Hermès Bélusca-Maïto c93051dff0 [CONSRV]: Use cmd's terminal icon that doesn't include crazy sizes.
svn path=/trunk/; revision=71277
2016-05-07 23:17:09 +00:00
Hermès Bélusca-Maïto 02a960b81c [PROGMAN]: Add some icons (will be used later).
svn path=/trunk/; revision=71276
2016-05-07 23:14:43 +00:00
Eric Kohl c5cff1ce1b [SHELL32]
Improvements to the file type property page:
- Read the EditFlags value for each file type from the registry.
- Sort the file type list by extension and description.
- Do not add a file type to the list if the FTA_Exclude flag is set for the file type.
- Disable the delete button if the FTA_NoRemove flag is set fot the file type.
- Set the FTA_Exclude flag for the dllfiles, lnkfiles and piffiles file types.
- Set the FTA_NoRemove flag for the batfile, cmdfile, comfile and exefile file types.

svn path=/trunk/; revision=71275
2016-05-07 21:59:00 +00:00
Daniel Reimer 94edad6a7f [RAPPS]
FTP direct links are bad for ROS.

svn path=/trunk/; revision=71274
2016-05-07 15:17:21 +00:00
Daniel Reimer 2eafaecd6a [RAPPS]
Fix changed SHA1, fix broken downloads. Have fun 0.4.1 testers ^^

svn path=/trunk/; revision=71273
2016-05-07 13:01:25 +00:00
Mark Jansen 2c3a40046f [UDFS] Avoid double free in UDFLoadLogicalVolInt. Patch by Víctor Martínez Calvo. CID 1322300 CORE-11181 #resolve
#comment Thanks!

svn path=/trunk/; revision=71272
2016-05-07 11:50:03 +00:00
Mark Jansen 5994ce5887 [KBDTOOL] Handle failure to parse scancodes. Patch by Víctor Martínez Calvo. CID 1341307 CORE-11177 #resolve
#comment Thanks!

svn path=/trunk/; revision=71271
2016-05-07 10:22:45 +00:00