Commit graph

69979 commits

Author SHA1 Message Date
Joachim Henze 2d9dabac60 [0.4.7][SHELL32] Fix a directory handle leak when browsing folders
A bit of history: in SVN r71528 == git
4322caeede
I tried to fix our explorer often
crashing while browsing directories. It was linked to the fact
that a notification result may arrive while the notification
structure had already been deleted.

The fix for this was actually broken and was leading to a double
leak: the notification structure was leaked. But also the handle
to the directory that had been browsed!
This means that the directory couldn't be modified anymore as
a leaked handle to it was still open.

Actually, when notifications are cancel, the kernel properly
calls the notification routine, but with a specific error code.
So the correct fix is to stop handling that notification when
we receive this error code. This is the correct fix with no leaks.

This commit is a complete r71528 revert with the appropriate fix.

CORE-10941
CORE-12843

cherry picked from commit 0.4.9-dev-144-g
da8a41b97b

Joachim Henze: I suspect that this patch will introduce
CORE-15703 but I think it's an improvement even if it would.
2020-10-06 16:24:44 +02:00
Joachim Henze 3abdd259bb [0.4.7][MSPAINT] Revert LoadDIBFromFile for workaround (#2186) CORE-16566
This fixes the regression of mspaint not being able any longer to
overwrite an existing file.
The regression was once introduced by
0.4.7-dev-118-g
44fc547ffa
when trying to determine the resolution on load.

Our new fix does cover both issues and even reduces imports: win-win.

fix cherry picked from commit 0.4.14-dev-691-g
be40a0e296
2020-10-06 03:26:24 +02:00
Joachim Henze f7e3858f0b [0.4.7][WINED3D] Workaround regression CORE-15408
Many 3D applications crashed with 'WineD3D fake window' msgbox
if they were used in VirtualBox with graphics driver
'VBoxDisp.sys from VM guest additions + installed 3D acceleration'

That was a regression of SVN r75847 == git 0.4.7-dev-319-g
3d13ed394e

Contrary we had no such issues with the SW emulation.
The reason for the bug is that
VBoxDisp only supports OpenGL 2.1 (GLSL 120) and WineD3D
tried to use shaders for OpenGL 3.2 (GLSL 150).

This workaround disables the usage in a hard-coded way for
all graphics adapters. Should be ok for now, as ros does not
really support any modern GPU drivers yet.
Proper working runtime detection would be better ofc.

Thx to Doug Lyons & Fabian Maurer

Fix cherry picked from 0.4.14-dev-113-g
082f230ac7
2020-10-04 15:45:50 +02:00
Joachim Henze 25515885f3 [0.4.7][GDIPLUS] Fix a regression painting gradient CORE-15479
patch is import of Wine commit 0937186f7d15fed60f77fa2014d650f4d0b6b20b
by Nikolay Sivov

regression was introduced by SVN r75872 == git 0.4.7-dev-344-g
c6f32e4a5f

fix cherry picked from 0.4.12-dev-360-g
daadcc6141
2020-10-03 23:24:06 +02:00
Joachim Henze b638ba6426 [0.4.7][SHELL32] Fix item order in Folder Options (#415)
This fixes regression CORE-14393 for russian ros setups.

regression was introduced by SVN 75534 == git 0.4.7-dev-54-g
959a179f58

fix cherry picked from commit 0.4.9-dev-141-g
1f4c636453
2020-10-03 21:50:32 +02:00
Joachim Henze d7a6774bd7 [0.4.7][EXPLORER] Fix showing the lock status in the taskbar popup menu CORE-14058
regression was introduced by SVN 75313 == git
0e8444a310

fix cherry picked from 0.4.8-dev-931-g
fabf069daf
2020-10-03 13:55:53 +02:00
Joachim Henze be84e3f4e5 [0.4.7][SETUPAPI] Apply fix for CORE-12616 PR-408
This fixes a regression introduced in SVN r73442 == git
7e9b3d61c0
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.

This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.

I ported this fix from 0.4.8-RC-22-g
dba2f743c5
which is what we used successfully from 0.4.8rls-0.4.10rls
but does NOT reflect the latest additions yet to restore
lastError that were added by Pierre in
0.4.11-dev-643-g
8236bb8f38
but even without that few additional lines the patch did
100% what it promised: fixing CORE-12616
2020-10-02 19:37:03 +02:00
Joachim Henze ca2308d54c [0.4.7][RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75895 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.

The regression was introduced by SVN r75896 == 0.4.7-dev-368-g
ec29185ee5

fix cherry picked from 0.4.11-dev-634-g
ad34c91d1c
2020-10-02 16:56:49 +02:00
Joachim Henze 5eb70f85e6 [0.4.7][OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608
Looks better and reduces memory consumption.

The regression was introduced by SVN r75890 == 0.4.7-dev-362-g
7634613083

Fix cherry picked from 0.4.9-dev-877-g
6d5aae4865
2020-10-02 12:54:09 +02:00
Joachim Henze 5de8d5c559 [0.4.7][DHCPSVC/IPHLPAPI] Fix 2 memory leaks CORE-14353
that are triggered repeatedly when just idling on
the desktop and therefore will lure ros into
inevitable BSOD after some days.

fix cherry picked from 0.4.9-dev-52-g
87d3fdf99e

and 2nd fix cherry picked from 0.4.9-dev-50-g
182a31074f
2020-10-02 11:57:47 +02:00
Joachim Henze 3966ffa790 [0.4.7][RAPPS/ATL] Fast-forward both to state of 0.4.8-release-0-gd47d448
Due to infrastructure changes on 2018-02-17 (after initial 0.4.7rls)
we totally broke the rapps compatibility of all releases before 0.4.8
leaving rapps useless in those.

Therefore I decided to port back what is necessary to make rapps work
again also in this ancient release.

fixes CORE-14351 adapts to infrastructure changes
fixes CORE-14350 RAPPS Certificate pinning
fixes download from FTP
and merges many other improvements from GSOC 2017 back in time
2020-10-02 01:51:07 +02:00
Joachim Henze 45044a8371 [0.4.7][COMCTL32] use previous version of cursor files CORE-14144,
idc_divider.cur & idc_divideropen.cur,
justify their diff in comctl32/comctl32_ros.diff
2020-09-21 01:31:20 +02:00
Joachim Henze 31794c27eb [0.4.7] remove "dev" from version string and add the golden release-kiss 2017-11-24 21:02:01 +01:00
Giannis Adamopoulos 2fda8374a2 [0.4.7] cherry-pick [COMCTL32] Button: Don't use a class brush. CORE-13445
(cherry picked from commit 34c563fa2a)
2017-11-17 17:11:08 +01:00
Giannis Adamopoulos 850c1d6b6d [0.4.7] cherry-pick [COMCTL32] Button: Draw the image list even when the button has the BS_ICON or the BS_BITMAP style. CORE-13170
(cherry picked from commit a98ff4d77c)
2017-11-14 20:08:13 +01:00
Giannis Adamopoulos 2534bc6542 [0.4.7] cherry-pick [COMCTL32] -Button: Implement drawing the image list with the BUTTON_IMAGELIST_ALIGN_CENTER parameter. This is enough to fix buttons with images created by Lazarus but only with themes. The non themed branch of the code is slightly more complex and will be fixed next. CORE-13170
(cherry picked from commit dea602cd70)
2017-11-14 20:08:05 +01:00
Giannis Adamopoulos 2e469036b3 [0.4.7] cherry-pick [SHELL32] SHBrowseForFolderW: Fix creating directories in the desktop and in drives like C: CORE-13925
(cherry picked from commit 78b78d6e73)
2017-11-14 20:08:00 +01:00
Giannis Adamopoulos 276f77a3a3 [0.4.7] cherry-pick [SHELL32] SHBrowseForFolder: Fix creating a new folder (which was broken two years ago and was properly reported 3 days ago). CORE-13925
(cherry picked from commit dd4af77703)
2017-11-14 20:07:53 +01:00
Joachim Henze 85d686904a [0.4.7] cherry-pick [EXPLORER] Remove version number from the start menu banner image, as requested.
Also, since we won't be editing the svg as often, move it to the media/graphics folder.
by David Quintana
SHA-1: e10108c088
2017-11-14 19:20:48 +01:00
Mark Jansen 23af2fa257 [0.4.7] cherry-pick [WIN32K] Check if the window being destroyed is currently tracked. by mjansen CORE-13619 (to fix several related BSODs)
SHA-1: 9e4d2f1f9e
2017-11-05 14:22:49 +01:00
Hermès Bélusca-Maïto 8b16304062
[0.4.7] Apply drawing issue fix for propsheets in comctl32, approved by Joachim Henze. See commit 11049bd (issue CORE-13929). 2017-11-03 00:16:15 +01:00
Mark Jansen 68655cc1e9 [0.4.7] Apply workaround for BSOD in win32k CORE-13629 2017-10-29 14:53:42 +01:00
Thomas Faber cf3e1d4e19 [0.4.7] Revert r73436 to avoid trouble with VirtualBox Guest Additions. CORE-13172 CORE-12700 CORE-12765 2017-10-29 14:41:08 +01:00
Thomas Faber c9bd78c5b7 [0.4.7] Apply the WordPad icon hack by Jared Smudde CORE-5823 2017-10-29 14:40:59 +01:00
Thomas Faber 04d7a3c0d0 [0.4.7] Mask WndProc exceptions CORE-11915 2017-10-29 14:40:44 +01:00
David Quintana 5a2e3e9bed [EXPLORER] Update start menu banner 2017-10-26 22:30:14 +02:00
Timo Kreuzer 959d9c6201 [NTOSKRNL] Fix out-of-bounds access (CID-1401083) and potencial memory leak in FsRtlIsNameInExpressionPrivate 2017-10-26 20:52:27 +02:00
Timo Kreuzer 561f18afea [NTOSKRNL] Fix our-of-bounds access and memory leak (CID-1401178, 1401177) in FsRtlIsDbcsInExpression 2017-10-26 20:52:27 +02:00
Giannis Adamopoulos d310df0dd2 [SHELL32] CDefView: Fix a leak of an HMENU. This fix is thanks to Joachim Henze who found the bug and quickly found the guilty revision. CORE-13911 2017-10-26 21:39:32 +03:00
Giannis Adamopoulos 27fe3d475f [ACPPAGE] Convert CLayerUIPropPage to use CPropertyPageImpl 2017-10-26 12:37:08 +03:00
Giannis Adamopoulos 283afefc4e Add CPropertyPageImpl that allows us to make property pages object oriented 2017-10-26 12:37:08 +03:00
Giannis Adamopoulos e7c29bb1fc [ATL] Add CHAIN_MSG_MAP macro 2017-10-26 12:37:08 +03:00
Katayama Hirofumi MZ 85ae842105 [WIN32SS] fix font extent.
CORE-13840
2017-10-25 21:10:35 +02:00
Ged Murphy b10dd06aa5 [KMTEST] Initial usermode support for testing FS mini-filters (#81)
* [KMTEST] Initial usermode support for testing FS mini-filters
- Add base routines to wrap the win32 'Filter' APis
- Add support routines to be used when testing FS filter drivers
- Move KmtCreateService to a private routine so it can be shared with KmtFltCreateService
- Completely untested at the mo, so likely contains bugs at this point
2017-10-25 10:39:55 +01:00
Eric Kohl 5cfc1e3152 [STORPORT] Get the interrupt from the resource list, connect it and call the miniports HwInterrupt routine.
CORE-13866
2017-10-23 23:21:58 +02:00
Serge Gautherie deb9c5416f CORE-13048. [I8042PRT] keyboard.c: Restore 1 "Irql =" (which was lost in r30000). (#63)
[I8042PRT] Restore 1 "Irql =" (which was lost in r30000). CORE-13048
2017-10-23 21:18:27 +02:00
Alexander Shaposhnikov b46d3ce5e9 [CONFIGURE] Add -VS_VER flag (#86)
This flag can override the detected version of VS.
Usage example: `configure.cmd vssolution -VS_VER 14`
2017-10-23 19:28:15 +03:00
Pierre Schweitzer 0add5d0a79 [KERNEL32] Fix MSVC build 2017-10-23 17:25:19 +02:00
Pierre Schweitzer 34c39a1336 [KERNEL32] Implement NpGetUserNamep() 2017-10-23 17:09:21 +02:00
Amine Khaldi f7932ba2de [NTDLL_WINETEST] Sync with Wine Staging 2.16. CORE-13762 2017-10-23 13:48:05 +01:00
Amine Khaldi ab3045c504 [INCLUDE/WINE] Update winternl.h. CORE-13762 2017-10-23 13:48:05 +01:00
Amine Khaldi 6595983e83 [REGEDIT_WINETEST] Sync with Wine Staging 2.16. CORE-13762 2017-10-23 13:47:48 +01:00
Amine Khaldi 8901d24b00 [QEDIT_WINETEST] Sync with Wine Staging 2.16. CORE-13762 2017-10-23 13:47:37 +01:00
Amine Khaldi bff534936a [PSAPI_WINETEST] Sync with Wine Staging 2.16. CORE-13762 2017-10-23 13:47:21 +01:00
Amine Khaldi 3ce9d8ab17 [OPENGL32_WINETEST] Sync with Wine Staging 2.16. CORE-13762 2017-10-23 13:47:02 +01:00
Samuel Serapion 136fabd357 [CRT] Use MAX_PATH for buffer meant to contain an arbitrary path
The cFileName member of WIN32_FIND_DATA is an array of MAX_PATH(260). Using strcpy/wcscpy with the target buffer being smaller is potentially bad. Corresponds to CID 1401198 and 1401195.
2017-10-23 14:44:38 +02:00
Pierre Schweitzer 19cef7806c [KERNEL32] Fix a FIXME in GetNamedPipeHandleStateW and stub a private function for a left unimplemented function 2017-10-23 14:36:18 +02:00
Pierre Schweitzer 3832f83a32 [KERNEL32] Check Basep8BitStringToDynamicUnicodeString() return and only call -W in case of success
CID 1419330
2017-10-23 13:39:44 +02:00
Pierre Schweitzer 19f1cd78c1 [KERNEL32] Check NtQueryInformationFile succeed before using its return. Also fix coding style
CID 512966
2017-10-23 12:36:43 +02:00
Pierre Schweitzer 361664d57f [FFS] Don't leak on failure
CID 1363596
2017-10-23 10:35:21 +02:00