Commit graph

63269 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 26b7393e00 [NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed don't take any arguments.
svn path=/trunk/; revision=68971
2015-09-03 23:57:39 +00:00
Pierre Schweitzer 9f74cf45b1 [NTOSKRNL]
Mark more functions as INIT

svn path=/trunk/; revision=68970
2015-09-03 22:19:16 +00:00
Aleksandar Andrejevic f79d3eb7e7 [SHELL32]
Make the RLE-compressed AVIs even smaller.
CORE-10093 #resolve #comment Fixed in revision r68969.


svn path=/trunk/; revision=68969
2015-09-03 22:16:28 +00:00
Pierre Schweitzer 17027f7e54 [ADVAPI32]
Fix memory leaks in case of failure

CID 1322129
CID 1322130

svn path=/trunk/; revision=68968
2015-09-03 21:27:51 +00:00
Pierre Schweitzer ae490fe18e [MUP]
Fix an hypthetic uninit var usage in MupCreate().
Dedicated to Chris.

CID 1322239

svn path=/trunk/; revision=68967
2015-09-03 21:19:05 +00:00
Eric Kohl a8934e6e69 [INTL]
- Update all values in "HKCU\Control Panel\International" when a new language is selected.
- Update the language examples after a language change.
- Disable all settings that should not be affected by a language change.
Missing:
- Top-level windows do not get notification yet.
- Language settings customization should not work yet.
CORE-10074

svn path=/trunk/; revision=68966
2015-09-03 20:37:17 +00:00
Pierre Schweitzer f3b5c2fe1e [CDFS]
[FASTFAT]
[MUP]
[NTFS]
Mark DriverEntry() and associated functions as INIT

svn path=/trunk/; revision=68965
2015-09-03 20:34:47 +00:00
Stefan Ginsberg 7c209f0f0f - Now that we actually take the trouble to set up MmLargeStackSize properly, use it! Also make it possible to set via the registry by adding it to the control vector table.
svn path=/trunk/; revision=68964
2015-09-03 20:04:28 +00:00
Aleksandar Andrejevic cfea1726c5 [SHELL32]
RLE-compress the AVIs.


svn path=/trunk/; revision=68963
2015-09-03 19:42:46 +00:00
Stefan Ginsberg 9baf0c2a4e - Enable INIT_FUNCTION for HAL while keeping FreeLdr happy and not putting anything into .INIT when compiling mini-HAL for it.
svn path=/trunk/; revision=68962
2015-09-03 17:52:13 +00:00
Christoph von Wittich acbf8ce925 [RECYCLEBIN] tabs to spaces (no code changes)
svn path=/trunk/; revision=68961
2015-09-03 17:40:13 +00:00
Christoph von Wittich d4e8254f9e [RECYCLEBIN] fix some resource leaks CID 716559 716560
svn path=/trunk/; revision=68960
2015-09-03 17:35:37 +00:00
Stefan Ginsberg da0a374ef0 - Don't put VdmpInitialize in .INIT either as it is not called during kernel initialization, but from videoport driver during its initialization. CORE-10097
svn path=/trunk/; revision=68938
2015-09-03 16:52:28 +00:00
Stefan Ginsberg 72a849ff44 - Enable placing kernel functions in the .INIT section (GCC only, MSVC is TBD). This allows them to be freed from memory after initialization is finished.
- PspMapSystemDll and IopDisplayLoadingMessage are called from non-initialization code, so don't put them in .INIT. CmpHiveRootSecurityDescriptor is called from initialization code, but too late in boot, so don't discard it either.
- Trying to enable this for HAL as well leads to a weird crash very early in boot. Investigation is ongoing. Until then we will just have to keep the huge PCI Class/Vendor tables in memory...
- Enable it for Win32k though as it seems to work fine there.
- Remove INIT_FUNCTION from function prototypes, it serves no purpose there.
See issue 10097 for more details.

svn path=/trunk/; revision=68937
2015-09-03 15:31:09 +00:00
James Tabor 42a15c9829 [Win32SS]
- Fix hilite text with objects. Mirror changes.

svn path=/trunk/; revision=68936
2015-09-03 14:29:53 +00:00
James Tabor c10459d14a [RTL]
- Fix Underscore drawing for Win32k and related functions.

svn path=/trunk/; revision=68935
2015-09-03 12:59:26 +00:00
Pierre Schweitzer 00bc01249e [NTFS]
Remove deadcode CID 1321946

svn path=/trunk/; revision=68934
2015-09-03 12:57:04 +00:00
Pierre Schweitzer 5fed17ea9a [NTFS]
With the newly introduced mechanism (in r68829), on attributes list loop, there shouldn't be any AttributeList attribute anymore.
So, don't attempt to dump them.

svn path=/trunk/; revision=68933
2015-09-03 12:49:36 +00:00
Christoph von Wittich 43a7da8886 [WS2_32] leave critical section in error case CID 716028
svn path=/trunk/; revision=68932
2015-09-03 11:22:11 +00:00
Christoph von Wittich 0b74f9e65e [OSK] fix resource leak in error case CID 1322148
svn path=/trunk/; revision=68931
2015-09-03 09:33:58 +00:00
Stefan Ginsberg 349dd3bfe4 - Explicitly make the kernel .rsrc/Resource Directory non-discardable and non-pageable on MSVC builds, as it is accessed from bugcheck code. Previously this data was marked as discardable and the bugcheck routine would bugcheck (after a certain stage in boot) when trying to access the bugcheck code data because the data was discarded and the memory invalidated. Thanks to Thomas for the help and the fix.
svn path=/trunk/; revision=68930
2015-09-03 09:29:26 +00:00
Christoph von Wittich 638a301cd5 [WINLOGON] fix resource leak in error case CID 1322159
svn path=/trunk/; revision=68929
2015-09-03 08:48:31 +00:00
Christoph von Wittich 4c72ff9871 [CRT] Addendum to r68927
svn path=/trunk/; revision=68928
2015-09-03 07:42:05 +00:00
Christoph von Wittich d98b8f9a71 [CRT] atan2 pass arguments in the correct order CID 1322203
svn path=/trunk/; revision=68927
2015-09-03 07:35:54 +00:00
Thomas Faber 743db122d7 [KERNEL32_WINETEST]
- Enable test_thread_fpu_cw on MSVC builds

svn path=/trunk/; revision=68926
2015-09-03 07:18:00 +00:00
Christoph von Wittich 075ba93d0c [NTOS:SE] fix uninitialized variable usage CID 1322236
svn path=/trunk/; revision=68925
2015-09-03 07:15:52 +00:00
Christoph von Wittich 818c6c4afc [EXPLORER] proper fix for CID 1321923, 1321924
svn path=/trunk/; revision=68924
2015-09-03 07:01:29 +00:00
Christoph von Wittich 831d7c9721 [EXPLORER] remove dead code CID 1321923, 1321924
svn path=/trunk/; revision=68923
2015-09-03 06:24:13 +00:00
James Tabor a6e0a15e60 [Win32k]
- Yes we must specify everything in ReactOS. Fix CORE-10085.

svn path=/trunk/; revision=68922
2015-09-02 23:25:48 +00:00
James Tabor d557af6005 - Remove test code from nonclient.
svn path=/trunk/; revision=68921
2015-09-02 23:08:04 +00:00
James Tabor edef1feae7 [Win32k]
- Use the same style for get messages in nonclient.
- Remove bit checks left over from testing. Fix CORE-10086.

svn path=/trunk/; revision=68920
2015-09-02 23:06:19 +00:00
Sylvain Petreolle 4921df2054 [COM_APITEST]
Do not test for ISFHelper anymore.

svn path=/trunk/; revision=68919
2015-09-02 20:52:34 +00:00
Pierre Schweitzer e3825569ca [RTL]
Finally, use the correct implementation for RtlAssert().

In testbots, the behavior will be the following:
On prompt, sysreg will always issue a 'break once' instruction. In umode, where kdbg isn't instructed to handle breakpoint, this will lead to application being killed. With a lot of noise. This matches previous behavior.
In kmode, where kdbg handles breakpoints, sysreg2 will ask for a bt and will reboot the VM. As it was done previously.

The testbots already have the newest available sysreg2 revision.

This was made possible thanks to the help of Stefan and Thomas.
It was also made possible thanks to the commits:
- in trunk: r68899, r68905, r68917
- in project-tools: r2074, r2232

CORE-10088 #resolve #comment Fixed with r68918

svn path=/trunk/; revision=68918
2015-09-02 20:18:42 +00:00
Pierre Schweitzer db71d8393e [KERNEL32]
Always print information about unhandled exception, even when GUI error dialog boxes are disabled

CORE-10088

svn path=/trunk/; revision=68917
2015-09-02 20:11:39 +00:00
Giannis Adamopoulos a5b00b8271 [SHELL32] - Remove Reactos only ISFHelper interface that is no longer used.
svn path=/trunk/; revision=68916
2015-09-02 18:20:40 +00:00
Giannis Adamopoulos b228db061a [SHELL32]
- CNewMenu: Get the folder path from the pidl passed in the Initialize method. No need to query the defview for that.
- Dont use a reactos only interface to create a new directory. Prefer to do it with less code using exported functions.
- Add a new SelectNewItem method that is used when creating a new file or directory.
- Apply same fix for browse for folder dialog.

svn path=/trunk/; revision=68915
2015-09-02 13:14:46 +00:00
Christoph von Wittich 1ac43d0e3f [CRT] just print the error number if we don't have a matching string
svn path=/trunk/; revision=68914
2015-09-02 12:33:11 +00:00
Christoph von Wittich 3c5b952cb3 [CRT] fix null pointer deref in _gmtime64_s CID 515314
svn path=/trunk/; revision=68913
2015-09-02 10:20:21 +00:00
Giannis Adamopoulos cba771af31 [SHELL32] - Fix copy paste bug
svn path=/trunk/; revision=68912
2015-09-02 09:31:16 +00:00
Thomas Faber f14431ec16 [NTOS:SE]
- Correctly check ACE type in SeFastTraverseCheck. CID 1102005

svn path=/trunk/; revision=68911
2015-09-02 09:19:52 +00:00
Christoph von Wittich e560a1993f [NTMARTA] fix copypasta
svn path=/trunk/; revision=68910
2015-09-02 08:56:58 +00:00
Thomas Faber 16deb5bf24 [RTL]
- Fix check for optional parameters in RtlGetCallersAddress

svn path=/trunk/; revision=68909
2015-09-02 05:38:02 +00:00
James Tabor ff31610bfb [Win32k]
- Fix painting message regression.

svn path=/trunk/; revision=68908
2015-09-01 23:58:23 +00:00
Stefan Ginsberg e4007ae73a - Implement super-simple KeSweepICache that always flushes the entire instruction cache. Use it in KD64 after modifying memory to make sure CPU gets the correct code to execute, and in NtFlushInstructionCache. May improve breakpoints somewhat.
- Move NtFlushInstructionCache from sysinfo.c to virtual.c where it fits better. Likewise, move it from kefuncs to mmfuncs in NDK, and fix function arguments (ULONG -> SIZE_T).
- Re-enable TRAP_DEBUG, adding back critical checks in the trap code. Checks can be improved but it is better than potentially silently messing up system state.
- Move remaining RtlPrefetchMemoryNonTemporal code into kernel. Stubbed for non-x86.
- By Hermes suggestion, override ASSERT to NT_ASSERT only for MSVC builds as that is where the main benefit is.

svn path=/trunk/; revision=68907
2015-09-01 23:45:48 +00:00
Pierre Schweitzer e33dc625bc [HHPCOMP]
Fix headers inclusion on MacOSX.
This fixes hhpcomp build on MacOSX
Patch by Nicolas Rouvière

CORE-10084 #resolve #comment Committed in r68906. Thanks!

svn path=/trunk/; revision=68906
2015-09-01 22:44:56 +00:00
Pierre Schweitzer 9bd7b06448 [NTOSKRNL]
Fix KdpPrompt():
- Don't attempt to return in the middle of the loop. It leads to keep the mouse disabled instead of reenabling it.
- Also, return a string length that actually matches what was written to the output buffer.

This fixes invalid behavior on RtlAssert when used with #if 0 moved to #if 1, or when Windows NTDLL is used in ReactOS.

CORE-10082 #resolve #comment Fixed with r68905
CORE-10083 #resolve #comment Fixed with r68905

svn path=/trunk/; revision=68905
2015-09-01 22:32:55 +00:00
James Tabor 6dfa71c487 [Win32SS|UxTheme]
- Move Menu to server side. See CORE-7797 and CORE-8299.
- This was for speed while moving windows about the desktop and fixed test results too.

svn path=/trunk/; revision=68904
2015-09-01 22:10:13 +00:00
Stefan Ginsberg eebbf23330 - Move misplaced RtlPrefetchMemoryNonTemporal from rtl into kernel where it belongs (it only exists as an export for use by drivers to safely try to use prefetchnta even if it may not be available). Use existing global KePrefetchNTAGranularity that is set to the correct value via cpuid instead of hardcoded "Ke386CacheAlignment".
svn path=/trunk/; revision=68903
2015-09-01 19:51:52 +00:00
Thomas Faber fb17ced703 [NTOS:KE]
- Enable DPC timeout check on debug builds. Suggested by Stefan

svn path=/trunk/; revision=68902
2015-09-01 18:26:29 +00:00
Thomas Faber 62945a0c1c [NTOS:EX]
- Remove the timer's list entry instead of the list head in NtSetTimer and NtCancelTimer. Fixes list entry corruption on VMware Hybrid builder
CORE-10081 #resolve

svn path=/trunk/; revision=68901
2015-09-01 17:52:09 +00:00