- If we do arithmetics using an non-defined env-var, the latter is automatically understood to be zero.
- If one left-shifts more than 31 bits (or left-shifts a negative number of bits), the result is automaticaly set to zero (checked on Windows'cmd + with cmd_winetest + wine cmd code).
svn path=/trunk/; revision=67062
Allocate the device lock semaphore for a PDEVOBJ in PDEVOBJ_AllocPDEV and implement PDEVOBJ_vDeletePDEV. Fixes a PDEVOBJ leak, found by Thomas and Giannis.
svn path=/trunk/; revision=67060
Check in BltMask if the masking operation would exceed the mask bitmap. Should fix crash when running gdi32_apitest MaskBlt.
CORE-9483
svn path=/trunk/; revision=67058
- Fix some comments that were otherwise hard to understand.
- Don't hardcode MAX_PATH in some API calls but instead use the real array char size.
- Don't leak find-file handles: fix leaked handles to NUL pseudo-file in situations where we do: copy some_file+NUL some_dest_file . Should fix some cmd winetests.
svn path=/trunk/; revision=67055
In a quest to better registry,
don't break VSSolution builds.
freeldr_pe is not in the same directory and copy doesn't care if you ask to concatenate C:\tomatoes, it already has the first file.
svn path=/trunk/; revision=67053
Add more tests for ExtCreatePen. This adds tests for almost all thinkable combinations of parameters. On win7: "ExtCreatePen: 7594830 tests executed (0 marked as todo, 0 failures), 0 skipped." After evaluating the results on WHS2003, this test will be disabled, since it is expected that most of these fail on ros atm.
svn path=/trunk/; revision=67040
- Remove old hack member in SC_RPC_CONFIG_INFOA that is no longer necessary and makes info levels other than SERVICE_CONFIG_DESCRIPTION fail. Fixes failure in VMware Tools installer.
- Actually save the new service description in RChangeServiceConfigW
CORE-9479 #resolve
svn path=/trunk/; revision=67027
- Actually create the "InstallEvent" as an event and use it to communicate success from newdev back to umpnpmgr. This works better than checking the process exit code from rundll32 (which always returns 0).
CORE-9477 #resolve
svn path=/trunk/; revision=67025
- GOTO command: Add a lower-bound test when skipping trailing spaces and such.
- CD/CHDIR command: Fix the helper SetRootPath function so that it fails if getting the full path string fails, and remove trailing whitespace from directory string. Fixes stuff like:
cd .. && echo success
cd ".. " && echo success
etc...
CORE-6810
svn path=/trunk/; revision=67020
- CFSFolder: Explicitly check for the supported pidl types. A CFSFolder can be created by a drive pidl. Handle this case and return the appropriate attributes in GetAttributesOf.
CORE-9458
svn path=/trunk/; revision=67017
- CControlPanelFolder: Factor out CCPLItemMenu class. Use it if the user selected a cpl item and use the default context menu otherwise.
- CControlPanelFolder: Use ExpandEnvironmentStrings when enumerating applets from the registry. Patch by Christoph.
- CCPLItemMenu: Call Control_RunDLLA directly so as to be able to run control panel applets that don't use the cpl extension.
CORE-7755 CORE-9466
svn path=/trunk/; revision=67016
- CControlPanelFolder: Explicitly check the pidl type in GetAttributesOf. Do not call the generic SHELL32_GetItemAttributes for cpl items.
svn path=/trunk/; revision=67015
