Commit graph

68906 commits

Author SHA1 Message Date
Mark Jansen
2366903f94 [COMCTL32_IMAGELIST] Prevent dereferencing a null pointer.
svn path=/trunk/; revision=74998
2017-06-11 11:08:32 +00:00
Mark Jansen
182d125bc0 [SHELL32] Do not fail CFSFolder::GetDisplayNameOf with a NULL pidl, preventing another crash in shell32:CFSFolder
svn path=/trunk/; revision=74997
2017-06-11 10:39:55 +00:00
Mark Jansen
7583b2b298 [WIN32KNT_APITEST] Do not assert on the result of an unimplemented function.
svn path=/trunk/; revision=74996
2017-06-11 08:51:36 +00:00
Mark Jansen
6c7fe2fb5f [SHELL32] Don't try to follow a null pointer inside CFSDropTarget, this fixes a crash in shell32:CFSFolder
svn path=/trunk/; revision=74995
2017-06-11 08:38:16 +00:00
Mark Jansen
178bc77a1f [SHELL32] Expose IID_CDefView in our CDefView implementation, this fixes a crash on shell32:shlview
svn path=/trunk/; revision=74994
2017-06-11 08:37:03 +00:00
Thomas Faber
16370e7605 [WIN32K:NTUSER]
Fix pool use after free during user32📋
- Rename IntIsFormatAvailable to IntGetFormatElement to better reflect what it does
- Introduce a new IntIsFormatAvailable that actually returns BOOL as implied by the name
- In IntAddSynthesizedFormats, call IntGetFormatElement right before its data is actually used, since IntAddFormatedData will invalidate the element pointer.
Thanks to Kamil for the initial investigation on this.
CORE-13408 #resolve

svn path=/trunk/; revision=74993
2017-06-11 08:33:36 +00:00
Pierre Schweitzer
1bde2edfcb [WS2_32]
Don't pass a null ptr at MSAFD to avoid dereference.
Fixes crash in ws2_32:sock

svn path=/trunk/; revision=74992
2017-06-11 07:56:18 +00:00
Thomas Faber
fbfe11f633 [WIN32K:NTUSER]
- Initialize BITMAPINFOHEADER::biSize before calling GreGetDIBitsInternal in IntSynthesizeDib. Fixes use of uninitialized memory and subsequent stack buffer overflow.
CORE-13408

svn path=/trunk/; revision=74991
2017-06-11 06:53:28 +00:00
Thomas Faber
ea1f78da72 [WIN32K:NTUSER]
- Include the CLIPBOARDDATA structure itself when calculating the size passed to UserCreateObject in IntSynthesizeDib. Fixes user heap corruption when running user32_winetest:clipboard.
CORE-13408

svn path=/trunk/; revision=74990
2017-06-11 06:05:42 +00:00
Pierre Schweitzer
f45315d051 [RDBSS]
Cosmetic fix

CID 1411968, 1411969

svn path=/trunk/; revision=74989
2017-06-10 20:58:22 +00:00
Pierre Schweitzer
fc8affc217 [RDBSS]
Fix reading parameters from registry

CID 1411973

svn path=/trunk/; revision=74987
2017-06-10 20:46:28 +00:00
Mark Jansen
be0666cf16 [APPHELP_APITEST] Add tests for ApphelpCheckRunApp[Ex], SdbGetMatchingExe, Sdb[Un]PackAppCompatData. CORE-13284
svn path=/trunk/; revision=74986
2017-06-10 20:31:58 +00:00
Pierre Schweitzer
50f668e4b3 [RXCE]
Misc. fixes.

CID 1411918, 1411929, 1411919

svn path=/trunk/; revision=74985
2017-06-10 20:28:25 +00:00
Mark Jansen
1b27b462ec [SHLWAPI_APITEST] Add PathFindOnPath tests. Patch by Katayama Hirofumi MZ. ROSTESTS-283 #comment Thanks!
svn path=/trunk/; revision=74984
2017-06-10 19:41:31 +00:00
Mark Jansen
d4db41b968 Addendum to r74982, remove some debugging code.
svn path=/trunk/; revision=74983
2017-06-10 17:47:56 +00:00
Mark Jansen
20cbe80c85 [SHELL32_APITEST] Add tests for PathResolve. Patch by Katayama Hirofumi MZ. CORE-12665 #comment Thanks!
svn path=/trunk/; revision=74982
2017-06-10 17:46:11 +00:00
Eric Kohl
d22bf76977 [SCHEDSVC]
Add a loop at the end of SchedServiceMain that will run until a stop event is signaled. This loop will be used to run the schduled jobs.

svn path=/trunk/; revision=74981
2017-06-10 10:51:49 +00:00
Thomas Faber
f5362e927f [NTOS:EX]
- Stub NtQuerySystemInformation:SystemExtendedHandleInformation. Avoids crashes in the upcoming ntdll_winetest sync.
CORE-13368 #resolve

svn path=/trunk/; revision=74980
2017-06-10 07:59:50 +00:00
Pierre Schweitzer
79a42b92f4 [UDFS]
Fix UDFS volume size computation.
Note that side effect of this is that free space computation is broken;
due to larger bitmap walk. To be fixed...

CORE-4375
CORE-13366

svn path=/trunk/; revision=74979
2017-06-10 05:45:26 +00:00
Amine Khaldi
071ff079a6 [PSDK] Add some missing definitions.
svn path=/trunk/; revision=74978
2017-06-09 23:13:23 +00:00
Thomas Faber
3fd5666e63 [WIN32K:NTUSER]
- Fix fmt range check in NtUserGetClipboardFormatName (see Wine commit 4bdcf512). Fixes new test failures (and resulting debug spam) in user32_winetest:clipboard
CORE-13402 #resolve

svn path=/trunk/; revision=74977
2017-06-09 21:36:15 +00:00
Mark Jansen
630bbc5421 [CALC] Explicitly link against comctl32. Patch by Carlo Bramini. CORE-10727
svn path=/trunk/; revision=74976
2017-06-09 18:21:54 +00:00
Thomas Faber
c16f5dc411 [USER32_WINETEST]
- Hackfix crash in user32:clipboard test due to NULL pointer returned from GetClipboardData.

svn path=/trunk/; revision=74974
2017-06-09 14:08:50 +00:00
Thomas Faber
3cbe1ae789 [GDI32]
- Check for lpResults == NULL in GetCharacterPlacementA. Patch by Doug Lyons. Fixes crash in gdi32_winetest:font
CORE-13401 #resolve

svn path=/trunk/; revision=74973
2017-06-09 11:14:11 +00:00
Giannis Adamopoulos
19dd22d422 [EXPLORER] -Use WM_POPUPSYSTEMMENU to open the system menu of a window. CORE-13400
svn path=/trunk/; revision=74972
2017-06-09 09:16:44 +00:00
Giannis Adamopoulos
e340056142 [EXPLORER] -Fix the return value in HandleShellHookMsg. Suggestion by Christoph.
svn path=/trunk/; revision=74971
2017-06-09 08:29:04 +00:00
Mark Jansen
8d15eb4dea [NTOS:MM] Do not queue debugger events after notifying process exit. CORE-13393
Patch suggested by Thomas.

svn path=/trunk/; revision=74969
2017-06-08 20:34:47 +00:00
Giannis Adamopoulos
8ad0eae687 [EXPLORER] -Revert a hack from r63304 that caused CORE-13388. This hid another bug and the correct way to fix this is to return MA_NOACTIVATE to WM_MOUSEACTIVATE.
svn path=/trunk/; revision=74968
2017-06-08 20:31:49 +00:00
Pierre Schweitzer
1ac1c1b261 [KMTESTS:MM]
When testing noncached mapping, use MmAllocateNonCachedMemory() as suggested by Thomas to avoid later potential failures

svn path=/trunk/; revision=74967
2017-06-08 20:16:34 +00:00
Hermès Bélusca-Maïto
7384a6a1d5 [GDI32_APITEST]: Fix the "missing braces around initializer" GCC error that I've introduced in r74962.
svn path=/trunk/; revision=74966
2017-06-08 19:09:01 +00:00
Giannis Adamopoulos
6b8f404594 [EXPLORER] -Open the start menu on mouse down. Patch by Joachim Henze (reactosfanboy). CORE-13375
svn path=/trunk/; revision=74965
2017-06-08 18:57:53 +00:00
Hermès Bélusca-Maïto
349d9f652b [ADVAPI32_WINETEST]: Fix compilation with MSVC 2010 (guarded via __REACTOS__).
svn path=/trunk/; revision=74963
2017-06-08 17:04:24 +00:00
Hermès Bélusca-Maïto
72c5e65e8c [GDI32_APITEST]: Fix compilation under MSVC 2010.
svn path=/trunk/; revision=74962
2017-06-08 17:00:55 +00:00
Giannis Adamopoulos
438d60c401 [UXTHEME] -Implement support for non rectangular caption buttons in WM_NCHITTEST handling. Please note that non rectangular buttons or buttons with no gaps between them are HACKY for XP so hittesting will never work properly (we really mimic windows xp here). Cache the position of caption buttons in the WINDOWINFO. CORE-13171
svn path=/trunk/; revision=74960
2017-06-08 14:27:52 +00:00
Eric Kohl
30ad304570 [NETAPI32]
Add obsolete NetErrorLog and NetService functions.

svn path=/trunk/; revision=74958
2017-06-08 09:34:31 +00:00
Eric Kohl
6d28124a20 [NETAPI32]
Add obsolete NetAudit and NetConfig functions.

svn path=/trunk/; revision=74957
2017-06-08 08:41:28 +00:00
Eric Kohl
658595fb98 [PSDK]
Fix NetAuditRead and NetAuditWrite prototypes (LPTSTR->LPCWSTR).

svn path=/trunk/; revision=74956
2017-06-08 08:37:59 +00:00
Pierre Schweitzer
453fae7f31 [KMTESTS:MM]
Make MmMapLockedPagesSpecifyCache a bit more robust. Based on Thomas' suggestions

svn path=/trunk/; revision=74955
2017-06-08 06:44:48 +00:00
Eric Kohl
eb6360d80f [NETAPI32]
Add obsolete NetAlert and NetMessage functions.

svn path=/trunk/; revision=74950
2017-06-08 00:30:49 +00:00
Eric Kohl
544223fa5a [NETAPI32]
Implement NetServerTransportAdd, NetServerTransportAddEx, NetServerTransportDel and NetServertransportEnum. These functions call their counterparts in the server service.


svn path=/trunk/; revision=74949
2017-06-07 23:35:09 +00:00
Eric Kohl
312c89f38e [NETAPI32]
- Implement NetServerDiskEnum, NetServerGetInfo and NetServerSetInfo. These functions call their counterparts in the server service.
- The new NetServerGetInfo function is disabled because its server side (NetrServerGetInfo) must be implemented before we can replace the Wine implemenation without loss of functionality.


svn path=/trunk/; revision=74948
2017-06-07 22:27:34 +00:00
Mark Jansen
2252393eeb [KERNEL32_WINETEST] Kill process that hangs on an unimplemented feature.
svn path=/trunk/; revision=74947
2017-06-07 20:40:42 +00:00
Thomas Faber
c2486683cc [NTOS:DBGK]
- Add SEH in DbgkpPostFakeModuleMessages. Fixes crash in ntdll_winetest:info when trying to debug another process that was started suspended.
CORE-13369 #resolve

svn path=/trunk/; revision=74946
2017-06-07 20:23:53 +00:00
Pierre Schweitzer
68dca562d7 [UDFS]
Set the volume label with the logical volume ident contained in the file set descriptor.
Microsoft appears to do so, so mimic this behavior to have consistent volumes labels with Windows.

CORE-4375

svn path=/trunk/; revision=74945
2017-06-07 19:33:55 +00:00
Eric Kohl
5ec31693b0 [SCHEDSVC]
Avoid JOBs overrunning in LoadJobs().
- Define JOB_NAME_LENGTH and use it instead of hardcoded values.
Based on a patch by Victor Martinez Calvo.
CORE-13389

svn path=/trunk/; revision=74944
2017-06-07 17:45:05 +00:00
Eric Kohl
3e87295366 [INTL]
- Fix a potential overflow and uninitialized variable in InitNegNumFmtCB().
- Get rid of the now useless string buffer szNewSample.
Based on a patch by Victor Martinez Calvo.
CORE-13384

svn path=/trunk/; revision=74942
2017-06-07 15:55:16 +00:00
Eric Kohl
fd32dd8623 [INTL]
Fix freeing logic in GetSupportedCP().
Patch by Victor Martinez Calvo.
CORE-13385

svn path=/trunk/; revision=74941
2017-06-07 14:10:43 +00:00
Eric Kohl
2c1c8e2f94 [INTL]
Fix GetDateSetting() overruns.
Patch by Victor Martinez Calvo.
CORE-13387

svn path=/trunk/; revision=74940
2017-06-07 13:48:49 +00:00
Eric Kohl
d6f5debb07 [INTL]
Fix overruns in GetTimeSetting().
Patch by Victor Martinez Calvo.
CORE-13386

svn path=/trunk/; revision=74939
2017-06-07 13:43:33 +00:00
Eric Kohl
b3b8277a07 [INTL]
Prevent wcsncopy overflows in GetCurrencySettings().
Patch by Victor Martinez Calvo.
CORE-13379

svn path=/trunk/; revision=74938
2017-06-07 13:37:43 +00:00