Commit graph

58055 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 22c9e139a1 [KERNEL32][CONSRV]
- Make kernel32 / winsrv console CSR structures Win2k3-compliant for Read/WriteConsole functions.
  An attentive code reader will see that there are structure members in CONSOLE_WRITECONSOLE that are
  indeed unused by kernel32 that can be used in ReactOS for undocumented extensions of WriteConsole...
  (for instance, adding a parameter for ANSI codes support, who knows!... :P)
- Fix a bit the support for the CONSOLE_READCONSOLE_CONTROL parameter in ReadConsole (for unicode only).
- Use the actual exe name for command history management, given via a hackish way by ReadConsole:
  the exe name is passed via the 80-byte-length limited static buffer, and is of course retrieved before
  actually using the static buffer (if needed).

[CONSRV]
- Fix writing input events in the console, but first preprocessing them for pausing commands (we treat them separately and remove them),
  then, in case we write many single events, we merge them in case they are mouse moves or repeated key down presses. This helps in not
  overflowing too quickly the input buffer, and that fixes all the remaining kernel32:console winetests!! (see CORE-8256)
- Use the actual exe name for command history management, given via a hackish way by ReadConsole (blame MS!)

Part 8/X

CORE-7931
CORE-8256 #resolve #comment Fixed in the condrv_restructure branch in revision .

svn path=/branches/condrv_restructure/; revision=63793
2014-08-01 18:08:29 +00:00
Hermès Bélusca-Maïto ac51557c0a [CONSRV]
- Start a better fix for the mouse event problem described in r62739.
- Add a hack for the problem described in CORE-8394, that fixes some Far Manager mouse issues.
CORE-8394

svn path=/branches/condrv_restructure/; revision=63792
2014-08-01 13:36:44 +00:00
Hermès Bélusca-Maïto d06d5833ea [KERNEL32]
- It is supposed that user buffers are valid, and if not, access to them is protected with SEH. This fixes almost all of the kernel32_winetest:console tests.
- Add parameter annotations.

svn path=/branches/condrv_restructure/; revision=63772
2014-07-29 15:59:17 +00:00
Hermès Bélusca-Maïto 2ae25e18a8 [CONSRV]
Fix returned number of read/write codes.

svn path=/branches/condrv_restructure/; revision=63770
2014-07-29 15:54:03 +00:00
Hermès Bélusca-Maïto 4a285f0633 [CONSRV]
Add the optional "number of things read/written" parameters back.

svn path=/branches/condrv_restructure/; revision=63769
2014-07-29 14:00:46 +00:00
Hermès Bélusca-Maïto 5ce6a6c12b Simplify code.
svn path=/branches/condrv_restructure/; revision=63768
2014-07-29 13:49:03 +00:00
Hermès Bélusca-Maïto 2d9a888371 [KERNEL32][CONSRV]
- Use a CODE_ELEMENT structure in order to simplify the code.
- Do not do an on-place ansi to unicode conversion.

svn path=/branches/condrv_restructure/; revision=63766
2014-07-29 13:18:59 +00:00
Hermès Bélusca-Maïto 6f772ac651 [CONSRV]
Add diagnostics ASSERTs for MultiByteToWideChar & its companion (the source and target pointers must not be the same, otherwise it doesn't work).

svn path=/branches/condrv_restructure/; revision=63764
2014-07-29 12:54:01 +00:00
Hermès Bélusca-Maïto 19e30db97b [KERNEL32][CONSRV]
- Make kernel32 / winsrv console CSR structures Win2k3-compliant for Read/WriteConsoleCharacter/Attribute and FillConsoleOutputCharacter/Attribute functions.
  The underlying CONSOLE_READOUTPUTCODE and CONSOLE_WRITEOUTPUTCODE structures are the same.
  It should be noticed, as for the Read/WriteConsoleInput functions of r63754 and the other Read/WriteConsole*** functions, that for performance purposes Windows uses a local buffer for "small" sizes;
  we should do the same too because both the client and the server use the number of elements to actually read/write in order to determine which buffer one should use (local or some shared buffer).
- Some memcpy --> RtlCopyMemory.

Part 7/X

CORE-7931

svn path=/branches/condrv_restructure/; revision=63755
2014-07-29 00:00:21 +00:00
Hermès Bélusca-Maïto e9c7111b66 [KERNEL32][CONSRV]
- Make kernel32 / winsrv console CSR structures Win2k3-compliant for Read/WriteConsoleInput functions.
- Really fix some ASSERTS from r63108.

Part 6/X

CORE-7931

svn path=/branches/condrv_restructure/; revision=63754
2014-07-28 21:20:36 +00:00
Hermès Bélusca-Maïto dd733c2951 [KERNEL32]
- No need to use another NTSTATUS variable, since all of the information is already contained in ApiMessage.Status.
- Do not hardcode the type of the request variables in the sizeofs used in the CsrClientCallServer calls.

svn path=/branches/condrv_restructure/; revision=63753
2014-07-28 13:37:54 +00:00
Hermès Bélusca-Maïto b06a89c070 [KERNEL32][CONSRV]
Make kernel32 / winsrv console CSR structures Win2k3-compliant.

- Fix UNICODE and ANSI versions of the Alias and History APIs. Tested with unicode and ansi version of our doskey.exe
- Implement GetNumberOfConsoleMouseButtons.

Part 5/X

CORE-7931

svn path=/branches/condrv_restructure/; revision=63751
2014-07-28 13:20:54 +00:00
Hermès Bélusca-Maïto 9ed2e0b5bc Sync with trunk r63743.
svn path=/branches/condrv_restructure/; revision=63744
2014-07-27 20:52:13 +00:00
Jérôme Gardou f637c9716a [WIN32K]
- Hack around a bug (tm)

svn path=/trunk/; revision=63743
2014-07-26 15:53:20 +00:00
Jérôme Gardou 2d6704f615 [WIN32K]
- Avoid useless casts
 - Add a few debug prints
 - Add sanity check

svn path=/trunk/; revision=63742
2014-07-26 15:41:33 +00:00
Jérôme Gardou 6d7085f177 [WIN32K]
- Explicitly initialize PropListItems

svn path=/trunk/; revision=63741
2014-07-26 15:41:25 +00:00
Jérôme Gardou bbaddbe80c [WIN32K]
- Some more DPRINT -> DEBUGCHANNEL

svn path=/trunk/; revision=63740
2014-07-26 15:41:21 +00:00
Jérôme Gardou 4069d63c30 [WIN32K]
- Improve the WNDOBJ/CLIPOBJ hack by using the same internal structure for both object.
This way a driver can enumerate WNDOBJ::coClient safely.
Also take this as an opportunity to get rid of DC::ros_dc.

svn path=/trunk/; revision=63739
2014-07-26 15:41:08 +00:00
Jérôme Gardou f00899b378 [WIN32K]
- Do not offset the window visible region when creating the WNDOBJ, it's already fine

svn path=/trunk/; revision=63738
2014-07-26 15:40:57 +00:00
Jérôme Gardou 5398dcffe8 [WIN32K]
- Use debug channel for debug outputs

svn path=/trunk/; revision=63737
2014-07-26 15:40:44 +00:00
Jérôme Gardou 0e90ca943e [NTOS/MM]
- First implementation of NtProtectVirtualMemory with Transition PTE
 - Release PTE frame page after erasing the PTE to avoid useless page fault

svn path=/trunk/; revision=63736
2014-07-25 22:13:35 +00:00
Jérôme Gardou f3b4339291 [WIN32K]
- Improve parameter checking in NtGdiExtSelectClipRgn
 - Update the DC clipping regions before getting the clipbox

svn path=/trunk/; revision=63735
2014-07-25 10:56:50 +00:00
Thomas Faber dca53f8c00 [NTOS:CC]
- Remove useless list entry from ROS_VACB

svn path=/trunk/; revision=63734
2014-07-24 08:40:51 +00:00
Thomas Faber 304292d17e [WBEMPROX]
- Don't omit lpBytesReturned in DeviceIoControl call
ROSTESTS-120 #resolve

svn path=/trunk/; revision=63733
2014-07-23 18:50:09 +00:00
Jérôme Gardou df7f9319c2 [WIN32K]
- Correctly use the Clip, Meta, Rao, API and Vis Regions in DCs
     - Update the DC clipping object on demand each time a blt is performed
     - Reduce the number of region allocated with handles when it's not needed
This commit fixes numerous bugs regarding clipping, most notably SetDIBitsToDevice overlapping foreground windows
CORE-8353 #resolve #comment There are still a few quirks in winetests which will get fixed in a next commit
CORE-7628 #comment should be fixed in rev 63731, please confirm.

svn path=/trunk/; revision=63731
2014-07-23 16:05:47 +00:00
Thomas Faber 022f198f1e [FORREALTHISTIME]
- Apparently we got that typo from Wine. Fix build. Will send upstream.

svn path=/trunk/; revision=63730
2014-07-23 12:46:47 +00:00
Thomas Faber 73304fbcaa [PSDK]
- Fix a typo in ntstatus.h

svn path=/trunk/; revision=63726
2014-07-23 12:23:31 +00:00
Thomas Faber ca688e6e46 [WININET_WINETEST]
- Add back work-around for testbot hang lost in winesync.
ROSTESTS-73

svn path=/trunk/; revision=63725
2014-07-20 11:19:44 +00:00
Thomas Faber 18ad0bd565 [WININET]
- Apply Wine commit 8fd44a3d (wininet: Fix invalid memory access in HTTP_QUERY_RAW_HEADERS (Valgrind).) by Sebastian Lackner. Fixes crash in wininet:http InternetReadFile_test

svn path=/trunk/; revision=63724
2014-07-20 08:30:21 +00:00
Eric Kohl 737295142c [SCSIPORT]
ScsiPortLogError: Print the information that is to be logged.

svn path=/trunk/; revision=63723
2014-07-20 07:19:42 +00:00
Thomas Faber 5a8c0d9fc1 [NTOS:FSTUB]
- Make sure to NULL the return pointer in the failure case of xHalIoReadPartitionTable.
CORE-8359

svn path=/trunk/; revision=63722
2014-07-19 17:50:56 +00:00
Thomas Faber 5884949d32 [DISK]
- Fix memory leak in CreatePartitionDeviceObjects

svn path=/trunk/; revision=63721
2014-07-19 17:48:46 +00:00
Thomas Faber 6be6b3b4d4 [SERVICES]
- Silence some debug prints

svn path=/trunk/; revision=63720
2014-07-18 17:47:43 +00:00
Thomas Faber 16e23a8b75 [SERVICES]
- Use asynchronous I/O to correctly catch timeouts -- we have a reliable NPFS now.
This makes the timeout test in advapi32_winetest:service succeed, however I'm leaving it disabled because it takes two minutes to run (due to... timeouts).
ROSTESTS-56

svn path=/trunk/; revision=63719
2014-07-18 16:44:16 +00:00
Thomas Faber 2fd11216b0 [MSHTML_WINETEST]
- Enable htmllocation test again
ROSTESTS-81

svn path=/trunk/; revision=63718
2014-07-18 10:59:32 +00:00
Eric Kohl 80c4c0200f [BOOTDATA]
Create additional install directories.
Patch by Lee Schroeder. Thank you for updating the directory list!
CORE-8365 #resolve

svn path=/trunk/; revision=63717
2014-07-18 04:09:24 +00:00
Eric Kohl 7a9eb48cd8 [USETUP]
Create additional install directories. Patch by Lee Schroeder. Thanks a lot!

CORE-7987 #resolve #comment Fixed in r63716.

svn path=/trunk/; revision=63716
2014-07-16 19:43:23 +00:00
Eric Kohl 32e6eed760 [USETUP]
Reimplement SetupCreateDirectory in such a way, that a full directory path will be created, if needed. This enables us to install ReactOS in a sub-directory like for example '\OS\Test\Alpha\ReactOS'.

svn path=/trunk/; revision=63715
2014-07-15 21:34:12 +00:00
Eric Kohl 404855f50a [BOOTDATA]
Revert accidentially committed changes from r63713.

svn path=/trunk/; revision=63714
2014-07-13 18:33:40 +00:00
Eric Kohl 3a88ebcae3 [BOOTDATA]
Add / enable NLS settings for Arabic, Azeri, Kyrgyz, Latvian, Tatar and Uzbek.

CORE-8348 #resolve

svn path=/trunk/; revision=63713
2014-07-13 16:40:44 +00:00
Eric Kohl f6cabeaa54 [NETSHELL]
Add code to rename network conections.

svn path=/trunk/; revision=63712
2014-07-13 07:38:49 +00:00
Jérôme Gardou 970a537191 [NTOS/CM]
- Fix overzealous check

svn path=/trunk/; revision=63707
2014-07-10 09:43:30 +00:00
Jérôme Gardou 642d03e08b [APPWIZ]
- Expand the registry entry when installing gecko package from disk.
Now unattended setup can really be unattended.

svn path=/trunk/; revision=63706
2014-07-10 09:05:43 +00:00
Jérôme Gardou 62ae426e15 [NTOSKRNL]
- Partial revert of r63700 on Alex's request
 - This cancels the "Use ZwSetValueKey" instead of NtSetValueKey" part
Oddly enough, it doesn't cause a problem anymore. I must have messed up in my initial testings

svn path=/trunk/; revision=63705
2014-07-10 09:05:37 +00:00
Jérôme Gardou 92e130d1cc [SETUPAPI_APITEST]
- Try restoring UTF8 character which got lost in translation.

svn path=/trunk/; revision=63701
2014-07-08 22:44:44 +00:00
Jérôme Gardou 3eaff9c2bc [NTOSKRNL]
- Use ZwSetValueKey instead of NtSetValueKey
 - Properly probe and copy parameters when NtSetValueKey is called from UMode
CORE-7738 #resolve #comment fixed in r63700

svn path=/trunk/; revision=63700
2014-07-08 18:42:20 +00:00
Jérôme Gardou d331e1725b [NTDLL_APITEST]
- Add tests for NtDeleteKey

svn path=/trunk/; revision=63699
2014-07-07 14:46:04 +00:00
Sylvain Petreolle d21dde849e [DBGPRINT]
--winetest mode: Use --list to get the tests list.
Dedicated to Christoph :)

svn path=/trunk/; revision=63698
2014-07-06 18:09:58 +00:00
Sylvain Petreolle e3f91f127c [DBGPRINT]
Convert TABs to spaces.

svn path=/trunk/; revision=63697
2014-07-06 17:36:56 +00:00
Eric Kohl d3be6e62e8 [FMIFS]
Add Format prototype.

svn path=/trunk/; revision=63696
2014-07-06 16:13:49 +00:00