Commit graph

72597 commits

Author SHA1 Message Date
Joachim Henze
19e69a1315 [0.4.10][CDFS] Make windows gcc release build compile CORE-15659
This fixes a regression introduced by 0.4.8-dev-164-g
ec6b3ecbe4
when the new driver was activated for compiling.

Many thanks to Thomas Faber, Pierre Schweitzer, Serge Gautherie

The fix is squashed backport of commit 0.4.12-dev-431-g
bccad87f3c
and commit 0.4.12-dev-432-g
3463b2db9f
2020-10-03 19:31:28 +02:00
Joachim Henze
2be9148116 [0.4.10] [SDK] Remove 'RC' from version.cmake 2018-11-05 17:54:22 +01:00
Joachim Henze
51a70dcbde [0.4.10] [RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.

cherry picked from commit 0.4.11-dev-634-g
ad34c91d1c
2018-10-30 20:03:39 +01:00
Mark Jansen
f6a9392a3c [0.4.10] [FONT][WIN32SS] Include the style name in the registry key.
Thanks to Doug Lyons for pinpointing the issue.

CORE-14044

cherry picked from commit 0.4.11-dev-311-g
3d44f79e3e
2018-10-02 23:42:51 +02:00
Katayama Hirofumi MZ
86e0a30bcb [0.4.10] [FONTS] Fix underline/underscore position of Tahoma (#892)
Because of FontForge's bug, the underline position value of Tahoma and
Tahoma Bold was wrongly set (#789, #809). This commit fixes those values.

CORE-15079

cherry picked from commit 0.4.11-dev-309-g
b560491ccf
2018-10-02 23:42:13 +02:00
Hermès Bélusca-Maïto
0b39fbb24f [0.4.10] [SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed.
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).

cherry picked from commit 0.4.11-dev-208-g
7ee298bbfc
2018-09-23 17:22:55 +02:00
Hermès Bélusca-Maïto
ccf42ff45b [0.4.10] [SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings()
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981

cherry picked from commit 0.4.11-dev-207-g
e29609147b
2018-09-23 17:21:50 +02:00
Joachim Henze
c828fceb50 [0.4.10] [WIN32K:NTUSER] Fix WIN32K BSOD mentioned in CORE-15027
Fixes accessing nullptr / invalid handle in Window->SystemMenu
I could trigger this occasionally when moving Opera 12.18 window
in front of Spotify 1.0.29.92 window.

Fix was:
authored by Thomas Faber (Thank you!)
tested by me
reviewed by James Tabor

cherry-picked from 0.4.11-dev-195-g
ef016bfe0a
2018-09-21 03:09:47 +02:00
Eric Kohl
3194a21f39 [0.4.10] [WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service.
The Logoff-Handler might try to notify the scheduler service which might already
have been shut down. We need to fix the shutdown sequence,
so that the service manager stops all running services.

Might fix CORE-14521 according to patches author ekohl.

I tested myself, it properly works around regression CORE-14999 aka
"Long time to shutdown after installing .NET Framework"

cherry picked from commit 0.4.11-dev-189-g
5e2fe08918
2018-09-19 22:37:00 +02:00
Joachim Henze
2d74a9f25d [0.4.10] [FREETYPE] Fix Regression "Monospaced font in LibreOffice" CORE-15018
LibreOffice started to show GUI in a mono-spaced font after 0.4.10-dev-466-g
35f62fc5ba

We can fix this by partial revert
as proposed by Katayama Hirofumi MZ, who was author of those changes as well.
We revert the changes in penalty system here.

cherry-pick from master 0.4.11-dev-126-g
31c981c02a
2018-09-10 18:24:30 +02:00
Katayama Hirofumi MZ
d3cc0811ce [0.4.10] [WIN32SS][FONT] Fix GetTextFace function and related (#829) CORE-14926
Google Chrome with -no-sandbox parameter in ReactOS wouldn't display
the web page anymore because first-chance exception raised.

- Remove FullName, Style, and FaceName members from TEXTOBJ structure.
- Add TextFace member into TEXTOBJ structure.
- Add MatchFontName() and MatchFontNames() helper functions.
- Fix GetTextFace() and related.

The symptom started showing with
0.4.10-dev-466-g
35f62fc5ba

The fix was cherry-picked from commit
0.4.11-dev-48-g
c8749d379b

Many Thx to Katayama, Mark & Doug.
2018-08-30 19:50:06 +02:00
Katayama Hirofumi MZ
38462453e2 [0.4.10] [SHELL32] Avoid regression CORE-14974
Adjust the IDC_PICKICON_LIST control's height in the IDD_PICK_ICON dialog resource. (#824)

It changed the number of rows from 4 to 3 unintentionally by
0.4.10-dev-466-g
35f62fc5ba

The fix was cherry-picked from
0.4.11-dev-30-g
39dc3cdaf6
2018-08-30 19:47:35 +02:00
Joachim Henze
c9864a6ff2 [0.4.10] [USER32/COMCTL32] Avoid regression CORE-14906
This patch has not been committed to master yet.
It fixes the vertical position of button text,
which was shifted one pixel to the bottom since guilty commit
0.4.10-dev-466-g
35f62fc5ba
2018-08-30 19:42:31 +02:00
Hermès Bélusca-Maïto
f374d5110d [0.4.10] [CONUTILS] Fix regression with file redirection of 'more' CORE-14592
In ConWrite(), emit an \r when a \n is encountered but not already preceded by \r.

And, don't emit \r\n when an \r alone is encountered.
This fixes the problem of extra newlines appearing when redirecting
"more" output to a file.

CORE-14592

cherry picked from commit 0.4.11-dev-1-g
b277cbdf22
2018-08-28 21:47:05 +02:00
Joachim Henze
32ce3885d5 [0.4.10] [ADVAPI32] Avoid regression CORE-14874 "Java 7u80 fails to install"
by reverting "[ADVAPI32] Additions for CreateProcessAsUserA/W()."
This reverts commit 0.4.10-dev-260-g
d4b4da5385

Afterwards I could install Java 7u80 again
and the Java-dependent app "pdfSam 2.2.4" did install and run.
2018-08-28 17:29:56 +02:00
Joachim Henze
bb4c55d650 [0.4.10] Avoid regression CORE-14955 "Ddraw fullscreen crashes"
This reverts commit 0.4.10-dev-55-g
7af3969e9f

and therefore downgrades D3D8,D3D9,DDRAW,WINED3D from 3.9 to 3.3 for this rls.

This is still newer than last release where we had to go back to 3.0 even.

Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
 DxDiag crashed when switching to fullscreen,
 Diablo II crashed immediately,
 Monster-Truck-Madness 2 demo crashed after main menu

Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.

This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with Wine 3.9.
2018-08-28 15:16:10 +02:00
Joachim Henze
22e9f3a321 [0.4.10] [CDFS] ease further observation of CORE-14067
re-enable assert (requested by Pierre)
but then at least log the ambiguous file-name (in case it'll assert again)
2018-08-27 22:39:37 +02:00
Joachim Henze
37680ffa9c [0.4.10] [CDFS] state-of-the-art-fix for CORE-14067
Prevents CDFS asserting on more characters, tested for "äöüßÄÖÜ" at least.
Thanks to Pierre Schweitzer for that generalization.

This patch supersedes 0.4.10-RC-14-g
15c578fe0d
2018-08-27 22:24:38 +02:00
Joachim Henze
15c578fe0d [0.4.10] [CDFS] explicitly allow 'ü' character in filenames CORE-14067
A patch from Doug Lyons to appease regression CORE-14067 that works well for me.
Eventually the real bug is in func FsRtlIsAnsiCharacterLegalHpfs() ?
2018-08-27 13:22:34 +02:00
Katayama Hirofumi MZ
3a1fe9d044 [SHELL32] Fix CShellLink::GetIconLocation (#810)
Fixes a regression from PR #784.
CORE-14961

cherry-picked from commit 0.4.11-dev-11-g
6eb6aa2895
2018-08-26 22:27:21 +02:00
Katayama Hirofumi MZ
1194b0b9c7 [0.4.10] [FONTS] Improve Tahoma font (14px bitmap and ligatures) (#809)
Add 14-pixel height bitmap, and improve some ligatures (fi and fl).
CORE-12091, CORE-12172

cherry-picked from 0.4.11-dev-3-g
0f308a0076
2018-08-24 13:16:53 +02:00
Joachim Henze
6f6f20f5df [0.4.10] [SHELL32] Avoid regression CORE-14696
"It was not longer possible to delete any file or folder via context menu"

By applying the workaround from Doug Lyons and sraboy.
2018-08-24 00:18:04 +02:00
Joachim Henze
1351f4c194 [0.4.10] Avoid regression CORE-14839
"paths to source files in putty + gcc *win* logs are cut off"

by reverting "[CMAKE] Zap builddir.h.cmake and instead define macros globally"

This reverts commit 0.4.10-dev-289-g
79ad68ddc3

May lead to logging of different build environments looking a bit different,
but nothing should be cut off anymore.
2018-08-23 22:02:44 +02:00
Joachim Henze
e47857cbec [0.4.10] [WINHTTP] Sledge-Hammer-Revert to SVN r75943 to fix regression CORE-13952
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 30.0.0.154 to download.
(I was able to watch a flash video in Opera 12.18 afterwards.)

like in last release
2018-08-23 20:37:30 +02:00
Joachim Henze
5340d9d065 [0.4.10] [NFSD] Apply a hack to avoid CORE-13498
Committing into rls was requested by Pierre.
The hack allows to startup nfsd even when getnameinfo() fails.
My personal release-tests will not cover NFSD.

like in last release
(cherry picked from commit 39f5e56a29)
2018-08-23 18:22:59 +02:00
Joachim Henze
f1e80fe6f4 [0.4.10] [COMCTL32] Fix regression CORE-14671 & CORE-14701
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).

Thanks to patches author Doug Lyons.
The patch has not been committed to master yet.

like in last release
(cherry picked from commit 9d758ae1cd)
2018-08-23 18:20:12 +02:00
Joachim Henze
11c71f807c [0.4.10] revert [NTDLL/LDR] Overhaul sxs work
This reverts commit 0.4.8-dev-502-g
7000fe2340.

This reverts commit 0.4.8-dev-503-g
f318a25e10.

The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.

Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).

Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.

We revert both commits for this release to fix CORE-14433
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.

I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg

This revert also obsoletes works/fixes like
2f11904000.

like in last release
(cherry picked from commit 11bf8fa047)
2018-08-23 16:35:59 +02:00
Joachim Henze
10a84f3e97 [0.4.10] [SETUPAPI] Apply yet uncommitted fix for CORE-12616 PR-408
This commit was *not* committed to master yet.
I'll leave the ticket unresolved until it'll be.

This fixes a regression introduced in SVN r73442:
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.

This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.

There are ongoing discussions about an alternative approach
to the initial problem that SVN r73442 tried to address.
Serge Gautherie can and shall evaluate that alternative later in dev.

For now many thanks to Carlo Bramini for this fix.

like in last release
(cherry picked from commit dba2f743c5)
2018-08-23 15:37:32 +02:00
Joachim Henze
419aabfd90 [0.4.10] [RDBSS] avoid CORE-13938
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.

like in last release
(cherry picked from commit 1906186e83)
2018-08-23 15:36:34 +02:00
Joachim Henze
71ea3f9365 [0.4.10] [USP10] Apply unfinished patch to avoid CORE-14226
Thomas linked the patch in Wine Bug 44410
I tested it for some weeks without noticing any side-effects.
It avoids text rendering regressions in some setups like UltraISO

like in last release
(cherry picked from commit 937c2615e6)
2018-08-23 15:35:57 +02:00
Joachim Henze
3daa0f2759 [0.4.10] [CDFS_NEW] Mute continuable assertion to avoid CORE-14067
like in last release
(cherry picked from commit 51f9494d48)
2018-08-23 15:35:33 +02:00
Thomas Faber
ff49458f27 [0.4.10] [WIN32SS] Mask WndProc exceptions to hide all tickets linked to CORE-11915
e.g. this allows using MsDepends

like in last release
(cherry picked from commit 9274859438)
2018-08-23 15:35:07 +02:00
Joachim Henze
158ec48cc4 [0.4.10] Branch releases/0.4.10 & change KERNEL_VERSION_BUILD_TYPE "RC"
as first commit before! adding the git-tag
2018-08-23 01:17:27 +02:00
Katayama Hirofumi MZ
b8e98c4e66 [NFSD] [TELNET] Remove the hardcoded directory paths C:\ReactOS
CORE-14747
2018-08-22 19:40:11 +02:00
Katayama Hirofumi MZ
86b915ef84 [TRANSLATION][ZIPFLDR] Add Japanese translation (#799)
CORE-14954
2018-08-22 14:26:53 +02:00
Serge Gautherie
ab243b82b4 [ADVAPI32_WINETEST] Restore service.c changes from 3c1b7834e1
This reverts commit a67df65c4f.
New failure was fixed by previous SERVICES commit.
Thus new timeout is avoided.

CORE-14521
2018-08-21 17:36:47 +02:00
Serge Gautherie
e3a1c2c81b [SERVICES] RChangeServiceConfig2A(): Zero-Initialize InfoW variable
This lets forward NULL Info.psd/Info.psd->lpDescription/Info.psfa,
instead of an uninitialized value.

CORE-14521
2018-08-21 17:36:46 +02:00
Baruch Rutman
8a407b5c60 [FONTS] Update Hebrew font subtitutions (#795)
Updated the font substitutions to use the new Hebrew glyphs in the updated Tahoma font.
Also added substitution for the Ubuntu font to make the Lautus and Modern themes legible with Hebrew UI elements.

Follow up to PR #789 and #790 ; CORE-14880, CORE-14943
2018-08-21 17:21:21 +02:00
Andreas Bjerkeholt
5a2a0314a1 [TRANSLATION][ZIPFLDR] Add Swedish translation (#794) 2018-08-21 16:57:01 +02:00
Bișoc George
ee6bc66318 [USETUP] Implement CreateProgressBarEx() (#791)
Improve the progress bar functions:
- Add a member in the struct, which will be used as a bar colour parameter for the new CreateProgressBarEx().
- CreateProgressBar() which will now invoke the Ex variant without the additional parameter.
2018-08-21 15:49:54 +02:00
Serge Gautherie
afe5ecb6b7 [CMAKE] MSVC_IDE: Enable 'unset(CMAKE_IMPORT_LIBRARY_SUFFIX)'
Resolve r67773 "# FIXME: Remove the MSVC_IDE condition when the upcoming RosBE lands.".
2018-08-21 15:39:35 +02:00
Katayama Hirofumi MZ
e58607eaba [FONTS] Add Hebrew vector glyphs to Tahoma Bold font (#790)
Bitmap glyphs are not added.
CORE-14943
2018-08-21 15:35:52 +02:00
Katayama Hirofumi MZ
b80171e5d3 [FONTS] Add Hebrew vector glyphs to Tahoma font (#789)
Bitmap glyphs are not added.
CORE-14943
2018-08-21 15:35:18 +02:00
Serge Gautherie
990e7dfd1a [MSHTML] Fix 3 MSVC warnings about HTML*Element_handle_event()
- "...\htmlanchor.c(769) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlarea.c(427) : warning C4028: formal parameter 2 different from declaration"
- "...\htmlform.c(757) : warning C4028: formal parameter 2 different from declaration"

Cherry-pick Jacek Caban a660f673cb
CORE-7538
2018-08-21 14:33:52 +02:00
Hermès Bélusca-Maïto
3f892a8d6b
[CMD] Add missing memory allocation NULL checks (#161). CORE-8304
Adapted from a patch by Jacob S. Preciado.

Bring also the code suggestions emitted during review.
2018-08-21 14:02:24 +02:00
Katayama Hirofumi MZ
73798d2e71 [SHELL32] Enable to change shortcut icon (#784)
CORE-11407
2018-08-21 13:49:32 +02:00
Robert Naumann
b3cfe88eda [BROWSEUI] Show Tooltip text for 'Go' Button
-Patch by Barret Karish CORE-11058
2018-08-21 12:49:04 +02:00
Pierre Schweitzer
c15c61275c
Addendum to 45fd48b 2018-08-21 12:41:50 +02:00
Pierre Schweitzer
45fd48bd0f
[CDFS_NEW] -> [CDFS] No old driver, thus no new driver 2018-08-21 12:32:15 +02:00
Pierre Schweitzer
5795254933
[CDFS] Delete the old CDFS driver.
You served us well!
2018-08-21 12:27:35 +02:00