Prevents CDFS asserting on more characters, tested for "äöüßÄÖÜ" at least.
Thanks to Pierre Schweitzer for that generalization.
This patch supersedes 0.4.10-RC-14-g
15c578fe0d
"paths to source files in putty + gcc *win* logs are cut off"
by reverting "[CMAKE] Zap builddir.h.cmake and instead define macros globally"
This reverts commit 0.4.10-dev-289-g
79ad68ddc3
May lead to logging of different build environments looking a bit different,
but nothing should be cut off anymore.
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 30.0.0.154 to download.
(I was able to watch a flash video in Opera 12.18 afterwards.)
like in last release
Committing into rls was requested by Pierre.
The hack allows to startup nfsd even when getnameinfo() fails.
My personal release-tests will not cover NFSD.
like in last release
(cherry picked from commit 39f5e56a29)
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet.
like in last release
(cherry picked from commit 9d758ae1cd)
This reverts commit 0.4.8-dev-502-g
7000fe2340.
This reverts commit 0.4.8-dev-503-g
f318a25e10.
The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.
Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).
Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.
We revert both commits for this release to fix CORE-14433
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.
I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg
This revert also obsoletes works/fixes like
2f11904000.
like in last release
(cherry picked from commit 11bf8fa047)
This commit was *not* committed to master yet.
I'll leave the ticket unresolved until it'll be.
This fixes a regression introduced in SVN r73442:
Our setup created undesired temporary files and left them
in the temp folder. Also we saw a slight one-time-increase
in memory consumption.
This patch was the work of Carlo Bramini
He proposed the fix on 2016-12-30 already.
There are ongoing discussions about an alternative approach
to the initial problem that SVN r73442 tried to address.
Serge Gautherie can and shall evaluate that alternative later in dev.
For now many thanks to Carlo Bramini for this fix.
like in last release
(cherry picked from commit dba2f743c5)
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"
I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?
Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.
like in last release
(cherry picked from commit 1906186e83)
Thomas linked the patch in Wine Bug 44410
I tested it for some weeks without noticing any side-effects.
It avoids text rendering regressions in some setups like UltraISO
like in last release
(cherry picked from commit 937c2615e6)
Updated the font substitutions to use the new Hebrew glyphs in the updated Tahoma font.
Also added substitution for the Ubuntu font to make the Lautus and Modern themes legible with Hebrew UI elements.
Follow up to PR #789 and #790 ; CORE-14880, CORE-14943
Improve the progress bar functions:
- Add a member in the struct, which will be used as a bar colour parameter for the new CreateProgressBarEx().
- CreateProgressBar() which will now invoke the Ex variant without the additional parameter.
Short: The code was suffering from an off-by-one bug (inconsistency between inclusive end exclusive end address), which could lead to freeing one page above the initialization code. This led to freeing part of the kernel import section on x64. Now it is consistently using the aligned/exclusive end address.
Long:
* Initialization sections are freed both for the boot loaded images as well as for drivers that are loaded later. Obviously the second mechanism needs to be able to run at any time, so it is not initialization code itself. For some reason someone decided though, it would be a smart idea to implement the code twice, once for the boot loaded images, once for drivers and concluding that the former was initialization code itself and had to be freed.
* Since freeing the code that frees the initialization sections, while it is doing that is not possible, it uses a "smart trick", initially skipping that range, returning its start and end to the caller and have the caller free it afterwards.
* The code was using the end address in an inconsistent way, partly aligning it to the start of the following section, sometimes pointing to the last byte that should be freed. The function that freed each chunk was assuming the latter (i.e. that the end was included in the range) and thus freed the page that contained the end address. The end address for the range that was returned to the caller was aligned to the start of the next section, and the caller used it to free the range including the following page. On x64 this was the start of the import section of ntoskrnl. How that worked on x86 I don't even want to know.
This fixes a race condition, where the message thread was still running when InstallReactOS returned and syssetup.dll was unloaded by the caller (setup.exe).
