Commit graph

68681 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 0f80ead8ec [USETUP]: Creating a registry key with zero access is just plainly invalid. Fix it. It was not caught before because, we never ever booted a 1st-stage setup with a valid mounted existing SYSTEM key (as Windows does).
svn path=/trunk/; revision=74742
2017-06-02 00:44:04 +00:00
Hermès Bélusca-Maïto cead3c26ac [MKHIVE]: Fix string byte size vs. count in number of characters confusion in append_multi_sz_value(); this was already OK in wine's code. Should fix corrupted multi-string entries in the livecd registry hives, for example...
In addition, always open the hive file to be created in write mode only.
CORE-13347

svn path=/trunk/; revision=74740
2017-06-02 00:05:53 +00:00
Hermès Bélusca-Maïto b03f8990c0 [MKHIVE]: Formatting changes only + sync back the names of the reg-inf functions with the ones where they are coming from (aka. Wine's setupapi/install.c).
svn path=/trunk/; revision=74739
2017-06-02 00:00:37 +00:00
Hermès Bélusca-Maïto 375355b9a6 [MKHIVE]: Implement CmpFileRead().
svn path=/trunk/; revision=74738
2017-06-01 23:54:08 +00:00
Pierre Schweitzer b39d02678f [RDBSS]
Fix uninit var usage

CORE-13345
CORE-11327

svn path=/trunk/; revision=74737
2017-06-01 21:37:08 +00:00
Hermès Bélusca-Maïto fce964935e [BUGCODES]: Move our MORAL_EXCEPTION_ERROR BSOD to where it should really belong (aka BSOD 0x9A) (see https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/bug-check-0x9a--system-license-violation why). BSOD 0x7C is however legit: BUGCODE_NDIS_DRIVER.
svn path=/trunk/; revision=74736
2017-06-01 20:20:25 +00:00
Hermès Bélusca-Maïto 07a0591894 [NTOS]: Better clean up behind ourselves on failure paths (aka. closing handles). These functions are clearly not written with correct cleanup-on-failure concept in mind...
svn path=/trunk/; revision=74735
2017-06-01 18:37:48 +00:00
Hermès Bélusca-Maïto 7d14e79c4c [NTOS]: Code formatting only.
svn path=/trunk/; revision=74734
2017-06-01 18:35:48 +00:00
Hermès Bélusca-Maïto e5da5bc0d6 [NTOS]: Minor code formatting + don't leak a handle in case of failure, in CmpInitializeHardwareConfiguration().
svn path=/trunk/; revision=74733
2017-06-01 18:27:41 +00:00
Hermès Bélusca-Maïto 8538be9a1f [HAL]
Update the PCI hardware IDs database. Extracted from the pci.ids database from http://pci-ids.ucw.cz/ from 2017-05-25 03:15:02
Maintained by Albert Pool, Martin Mares, and other volunteers from the PCI ID Project.

svn path=/trunk/; revision=74732
2017-06-01 17:31:23 +00:00
Peter Hater 0c26c6fe3f [MSWSOCK] Unstub AcceptEx and GetAcceptExSockaddrs. Note that real implementation in msafd is not available, so result will still be FALSE
svn path=/trunk/; revision=74731
2017-06-01 15:25:25 +00:00
Peter Hater cc95312078 [MSWSOCK] Change functions to be able to use control flags with DnsQuery.
Add host aliases to hostent if available and requested.
Only copy servent aliases if available and requested.

svn path=/trunk/; revision=74730
2017-06-01 15:22:06 +00:00
Thomas Faber 50313aa5c8 [ACPICA]
- Update to version 20170531
CORE-13348 #resolve

svn path=/trunk/; revision=74729
2017-06-01 10:54:48 +00:00
Peter Hater 3be9010b96 [MSAFD] Don't try to accept on non listening socket. Return WSAEINVAL
svn path=/trunk/; revision=74728
2017-06-01 09:41:19 +00:00
Peter Hater d060749ca4 [MSWSOCK] Update network protocols. Patch by Marco Savelli. CORE-13320 #resolve
svn path=/trunk/; revision=74727
2017-06-01 09:00:32 +00:00
Hermès Bélusca-Maïto c1d754ee9f [FREELDR/WINLDR]: Rework LoadModule() so that we can load custom kernels & hals via the /KERNEL= and /HAL= boot option switches.
svn path=/trunk/; revision=74725
2017-05-31 18:40:29 +00:00
Pierre Schweitzer c6fc31e430 [RXCE]
Fix broken cast
By Thomas

svn path=/trunk/; revision=74724
2017-05-31 17:10:45 +00:00
Pierre Schweitzer 47a6faa9cd [DDK]
sed -i s/__volatile/volatile/g to fix build with VS2010

CORE-13345

svn path=/trunk/; revision=74723
2017-05-31 17:02:44 +00:00
Hermès Bélusca-Maïto f51faa4a0f [NTOS]: Underline the fact that CmpGetRegistryPath (especially when being run in 1st-stage text mode) is just a big hack (introduced in r3794 and r3795). I however need to monitor its output for the moment...
svn path=/trunk/; revision=74709
2017-05-31 00:03:33 +00:00
Hermès Bélusca-Maïto 3ef498a4de [NTOS]: Minor fixes:
- Correctly specify the buffer size for RtlInitEmptyUnicodeString calls;
- Prefer using RtlAppendUnicodeStringToString instead of RtlAppendStringToString: both actually do the very same job on counted strings, but the former doesn't need the explicit PSTRING casts, and NULL-terminate the string buffer if possible (aka. if the available remaining length permits it, otherwise it doesn't add any NULL terminator, falling back to the default behaviour of RtlAppendStringToString).
- Remove a deprecated commented-out variable.

svn path=/trunk/; revision=74708
2017-05-31 00:01:31 +00:00
Pierre Schweitzer 7b67bd00c4 [NTDLL_VISTA]
Fix GCC build after r74706.
Patch by Thomas

svn path=/trunk/; revision=74707
2017-05-30 22:01:13 +00:00
Mark Jansen c588ecb84f Fix the build for MSVC.
svn path=/trunk/; revision=74706
2017-05-30 21:48:04 +00:00
Pierre Schweitzer 038c2e6ca0 [KERNEL32_VISTA]
Add Kernel32 implementation for SRW locks and condition variables.
This is based on Wine implementation.

CORE-7546
CORE-8204

svn path=/trunk/; revision=74705
2017-05-30 21:39:50 +00:00
Pierre Schweitzer 379c7825ec [RTL]
Delete leftover

CORE-7546
CORE-8204

svn path=/trunk/; revision=74704
2017-05-30 21:36:43 +00:00
Pierre Schweitzer 296d09b486 [NTDLL_VISTA]
Create a new NTDLL library that exports some of the NTDLL Vista+ functions.
This new NTDLL includes at the time of commit:
- SRW locks implementation that was originally built in RTL but never used ;
- Condition variables implementation which is a new code in ReactOS trunk.

Condition variables is an implementation of Stephan Röger, with minor formatting
changes by Timo Kreuzer and various changes by myself.

CORE-7546
CORE-8204

svn path=/trunk/; revision=74703
2017-05-30 21:35:05 +00:00
Mark Jansen 29177f71b6 [KERNEL32] Do not use TEB->StaticUnicodeString in CreateProcessInternalA. CORE-10368
svn path=/trunk/; revision=74702
2017-05-30 20:57:45 +00:00
Mark Jansen 9a54d4a3a0 [KERNEL32_APITEST] Add test to show that we should not spoil TEB->StaticUnicodeString in CreateProcessA. CORE-10368
svn path=/trunk/; revision=74701
2017-05-30 20:55:15 +00:00
Thomas Faber 47ef0a440a [NTOS:IO]
- Fix key handle leak in PipCallDriverAddDevice
- Avoid double-close in failure case of IopAttachFilterDrivers
- Simplify closing handles, and use sensible variables names in IopAttachFilterDrivers
CORE-13336

svn path=/trunk/; revision=74700
2017-05-30 18:14:31 +00:00
Thomas Faber 23da2b0594 [NTOS:IO]
- Save an indentation level in IopAttachFilterDrivers
CORE-13336

svn path=/trunk/; revision=74699
2017-05-30 17:22:13 +00:00
Mark Jansen 9e82e9f1d6 [KERNEL32] Actually disable the shim engine while it is not ready yet.... CORE-10368
svn path=/trunk/; revision=74697
2017-05-29 21:14:15 +00:00
Thomas Faber c4393987a1 [ACPI]
- Remove some dead code in acpi_system_add. CID 502179
- Define deviceName only in debug builds in Bus_AddDevice. CID 502180

svn path=/trunk/; revision=74696
2017-05-29 09:23:33 +00:00
Mark Jansen 8f2963ab01 [KERNEL32] Initial implementation for BaseCheckRunApp, calling into apphelp to check for compatibility fixes CORE-10368
svn path=/trunk/; revision=74693
2017-05-28 19:27:51 +00:00
Giannis Adamopoulos 2fa8800e5e [EXPLORER] -Implement the trick that makes the start button to get clicked when the user clicks on the corner of the screen.
svn path=/trunk/; revision=74692
2017-05-28 18:31:48 +00:00
Mark Jansen 440290e1cb [USER32_APITEST] Add more tests to validate messages sent during window creation / modifying of styles. CORE-12052
svn path=/trunk/; revision=74691
2017-05-28 17:40:48 +00:00
Benedikt Freisen 846f8450db [MSPAINT]
- When setting a file as tiled wallpaper, it will now indeed show up tiled instead of centered.
- All three options (tiled, centered, stretched) are working.  (non-bitmaps only in Vista and above)

CORE-12164 #resolve

svn path=/trunk/; revision=74690
2017-05-28 17:33:15 +00:00
Mark Jansen 9386daa570 [USER32_APITEST] Add tests to validate messages sent during window creation / modifying of styles. CORE-12052
svn path=/trunk/; revision=74689
2017-05-28 13:55:05 +00:00
Pierre Schweitzer f61c6e1fbd [NTOSKRNL:MM]
Only warn for unimplemented in ExAllocatePoolWithTagPriority() when memory allocation fails. For the rest, the caller has the memory it asked for.
Side note: we could also warn when caller wants to use special pool.

CORE-13334
CORE-11327

svn path=/trunk/; revision=74688
2017-05-28 10:22:30 +00:00
Daniel Reimer 7bb4b752e1 [RAPPS]
Update 7-Zip to 16.04

svn path=/trunk/; revision=74687
2017-05-27 21:08:25 +00:00
Pierre Schweitzer a6849e9613 [RDBSS]
Properly initialize pRdbssScavenger in RxDeviceObject to avoid NULL-ptr deref

CORE-11327

svn path=/trunk/; revision=74686
2017-05-27 20:20:27 +00:00
Pierre Schweitzer 683eaf0e00 [RXCE]
Make RxpTrackDereference()/RxpTrackReference() when they're noop.

CORE-11327

svn path=/trunk/; revision=74684
2017-05-27 17:41:58 +00:00
Pierre Schweitzer 5d1661ec2d [RDBSS]
[RXCE]
Try to make use of wrapper more 'properly'. Now, we use wrappers for ASSERT and memory management.
This allows us to allocate memory with low priority (which isn't supported by ReactOS yet :-().

Note that we go a bit farther than MS: we also define RxFreePoolWithTag() and make use of it.
This should make Thomas happy :-)

CORE-11327

svn path=/trunk/; revision=74683
2017-05-27 17:29:11 +00:00
Pierre Schweitzer 40f5fb3a68 [RXCE]
Implement FCB refcounting

CORE-11327

svn path=/trunk/; revision=74682
2017-05-27 16:50:29 +00:00
Pierre Schweitzer e89be79709 [RXCE]
Implement operation verification, this is notably based on FatVerifyOperationIsLegal.

CORE-11327

svn path=/trunk/; revision=74681
2017-05-27 12:34:38 +00:00
Giannis Adamopoulos d2dcb75417 [EXPLORER] -Make the taskbar grip get its size from the theme. This fixes one of the last theme related problems in explorer itself. Also simplify some theme drawing code.
svn path=/trunk/; revision=74680
2017-05-27 10:44:44 +00:00
Mark Jansen 31391c60b1 [SYSSETUP][UNATTENDED] Allow changing the resolution automatically. CORE-13315
svn path=/trunk/; revision=74679
2017-05-27 09:37:16 +00:00
Pierre Schweitzer acc9f33775 [RXCE]
- Make RxpUndoScavengerFinalizationMarking() more smart: only warn about unimplemented if there's scavenger mark
- Implement FCB operations (release/acquire) tracker

CORE-11327

svn path=/trunk/; revision=74678
2017-05-27 09:36:42 +00:00
Giannis Adamopoulos 3972478a69 [EXPLORER] -Reload the theme data only when the orientation changes (we ended up reloading it every few seconds).
svn path=/trunk/; revision=74677
2017-05-27 09:09:01 +00:00
Pierre Schweitzer 7e486e2119 [RXCE]
Implement reference tracing

CORE-11327

svn path=/trunk/; revision=74676
2017-05-27 08:39:42 +00:00
Pierre Schweitzer a89c82316c [RDBSS]
[RXCE]
[DDK]
Add an initial implementation of the RXCE and RDBSS libraries that are used to implement mini-redirectors
The associated headers are also added to DDK

The implementation is partial (really!) and is only working for read-only operations.

It leaks memory as hell (no refcounting implemented) and thus, objects freeing is not implemented.

It was tested with NFS41 driver. With such RDBSS, it's possible for the driver to mount a remote share, to list
files, to query their properties, to query volume properties, and finally to read files (with some corruption under
specific conditions).

Please refrain from committing in this (especially for modifying whitespaces or fixing comments...), this is still WIP
and under development, it would mess with my local changes!

In itself, it doesn't bring anything to ReactOS yet, as no mini redirector is available in ReactOS source tree.
This may come later on with NFS41.

More to follow...

CORE-11327

svn path=/trunk/; revision=74674
2017-05-26 20:52:18 +00:00
Peter Hater fb1a1ab85e [MSAFD] Don't update shared state on close if we still have active references to the socket. Checked also by ws2_32:close API test CORE-12029
svn path=/trunk/; revision=74673
2017-05-26 15:27:45 +00:00